cellpycore 0.1.2__tar.gz → 0.1.3__tar.gz

cellpycore-0.1.3/.cursor/rules/graphify.mdc

@@ -0,0 +1,11 @@
+---
+description: graphify knowledge graph context
+alwaysApply: true
+---
+
+This project has a graphify knowledge graph at graphify-out/.
+
+- For codebase or architecture questions, when `graphify-out/graph.json` exists, first run `graphify query "<question>"` (or `graphify path "<A>" "<B>"` / `graphify explain "<concept>"`). These return a scoped subgraph, usually much smaller than `GRAPH_REPORT.md` or raw grep output.
+- If graphify-out/wiki/index.md exists, navigate it instead of reading raw files
+- Read graphify-out/GRAPH_REPORT.md only for broad architecture review or when query/path/explain do not surface enough context
+- After modifying code files in this session, run `graphify update .` to keep the graph current (AST-only, no API cost)

{cellpycore-0.1.2 → cellpycore-0.1.3}/.cursor/rules/issueflow-rules.mdc

@@ -118,7 +118,11 @@ The full slash-command lifecycle is:
 5. **`/iflow-close`** — tests, optional `uv version --bump`, status update, commit, push, PR. Does not delete branches.
 6. **`/iflow-cleanup`** — post-merge: switch to default, `git pull --ff-only`, `git fetch --prune`, `git branch -d` on merged local branches under a single consolidated confirm. Never `-D`.
 
-`/iflow-yolo` chains `init → plan → start → close` for small, low-risk issues with up-front safeguards (clean tree, passing tests, single consolidated confirm).
+`/iflow-yolo` chains `init → plan → start → close yolo` for small, low-risk issues with up-front safeguards (clean tree, passing tests, single consolidated confirm). Its close step is hands-off: changelog decided without a prompt, PR merged (`gh pr merge --squash`, `--auto` fallback), then default-branch switch + pull.
+
+
+Issue labels can select the flow: when an issue picked via `/iflow-pick` carries the **`yolo`** label, it is routed through `/iflow-yolo` (one combined confirmation). Controlled by `label_flows` (default `true`) and `yolo_label` (default `"yolo"`) under `[issueflow]` in `.issueflows/config.toml`; re-run `issue-flow update` after changing them.
+
 
 `/iflow-fix` opens an interactive iterative-fixes session: it creates one GitHub issue + long-lived branch, then loops over many small fixes (each gets a short plan and is implemented only on confirmation, recorded as a dated bullet in `issue<N>_status.md`), and ends with `/iflow-close`. It is off-path (never auto-dispatched); while a session is active, drive it with `/iflow-fix` + `/iflow-close`, not `/iflow`.
 

{cellpycore-0.1.2 → cellpycore-0.1.3}/.cursor/skills/iflow-close/SKILL.md

@@ -38,13 +38,17 @@ When a bump applies: read `.cursor/skills/iflow-version-bump/SKILL.md`, run the
 
 - **`stay`**, **`stay on branch`**, **`don't switch`**, or **`dont switch to main`** → after the PR step, stay on the issue branch instead of switching back to the default branch.
 
+## Hands-off token (command input)
+
+- **`yolo`** (used by `/iflow-yolo`) → close the loop without user input: write the `HISTORY.md` bullet without a confirm prompt (step 3), **merge the PR** right after opening it (step 8a), then switch back to the default branch and `git pull --ff-only` (step 9, unless `stay` was also passed).
+
 ## Instructions
 
 1. **Sanity check** — Run the project test suite (e.g. `uv run pytest`) and any checks the repo relies on. Skim the diff; avoid bundling unrelated changes. Confirm that any design decisions or good practices that emerged from this issue are captured under `.issueflows/04-designs-and-guides/` before committing.
 
 2. **Optional version bump** — If the user asked for a bump (see above), follow `.cursor/skills/iflow-version-bump/SKILL.md` and run `uv version --bump <patch|minor|major>`. If there is no bumpable `pyproject.toml`, skip and continue.
 
-3. **Update `HISTORY.md`** — Unless the user passed `nohistory`, follow `.cursor/skills/iflow-history-update/SKILL.md`. If step 2 did not bump the version, append a bullet to the `## [Unreleased]` section. If step 2 bumped the version, promote `## [Unreleased]` to `## [<new_version>] - <YYYY-MM-DD>` and open a fresh empty `## [Unreleased]` above it. Show the diff and confirm once before writing. Skip with a note if `HISTORY.md` does not exist at the project root.
+3. **Update `HISTORY.md`** — Unless the user passed `nohistory`, follow `.cursor/skills/iflow-history-update/SKILL.md`. If step 2 did not bump the version, append a bullet to the `## [Unreleased]` section. If step 2 bumped the version, promote `## [Unreleased]` to `## [<new_version>] - <YYYY-MM-DD>` and open a fresh empty `## [Unreleased]` above it. Show the diff and confirm once before writing. Skip with a note if `HISTORY.md` does not exist at the project root. With the `yolo` token, do not ask — decide yourself and write the bullet (issue title, or `log "..."` text) directly.
 
 4. **Issue tracking** — Under `.issueflows/01-current-issues/`, update the status file: remaining work, checklists, and **`- [x] Done`** only when the issue is fully resolved. If fully resolved, move that issue's markdown files (`issue<n>_*`) to `.issueflows/03-solved-issues/`. If partially resolved, move to `.issueflows/02-partly-solved-issues/`. Follow any stricter rules in `.cursor/rules/issueflow-rules.mdc` if present.
 
@@ -56,11 +60,13 @@ When a bump applies: read `.cursor/skills/iflow-version-bump/SKILL.md`, run the
 
 8. **Pull request** — Open (or update) a PR against the default branch. Body should explain the change, how to test, and link the GitHub issue (`Closes #n` / `Refs #n`).
 
-9. **Switch back when safe** — Detect the default branch (prefer `gh repo view --json defaultBranchRef -q .defaultBranchRef.name`, else `git symbolic-ref --quiet --short refs/remotes/origin/HEAD`, else `main`). If the input included `stay`, `stay on branch`, `don't switch`, or `dont switch to main`, stay on the issue branch and report that opt-out. Otherwise run `git status --porcelain` after the PR is open or updated. If it is clean, run `git switch <default>` and then `git pull --ff-only`; a clean tree here means the branch work has been committed and pushed to the PR branch. If dirty, stay on the current branch, list the uncommitted paths, and explain that switching is unsafe until those changes are committed, stashed, or discarded by the user. Never delete the issue branch here.
+8a. **Merge the PR (`yolo` token only)** — Merge immediately with `gh pr merge <number> --squash` (never `--delete-branch`; branch deletion stays in `/iflow-cleanup`). If GitHub refuses (branch protection, pending checks), fall back to `gh pr merge <number> --squash --auto` and report the merge as queued. If even `--auto` fails, stop the hands-off behaviour, report the error, and leave the PR open. Without the `yolo` token, skip this step — merging stays a user decision (step 10).
+
+9. **Switch back when safe** — Detect the default branch (prefer `gh repo view --json defaultBranchRef -q .defaultBranchRef.name`, else `git symbolic-ref --quiet --short refs/remotes/origin/HEAD`, else `main`). If the input included `stay`, `stay on branch`, `don't switch`, or `dont switch to main`, stay on the issue branch and report that opt-out. Otherwise run `git status --porcelain` after the PR is open or updated. If it is clean, run `git switch <default>` and then `git pull --ff-only`; a clean tree here means the branch work has been committed and pushed to the PR branch. If dirty, stay on the current branch, list the uncommitted paths, and explain that switching is unsafe until those changes are committed, stashed, or discarded by the user. Never delete the issue branch here. With the `yolo` token this step runs **after** the merge from step 8a so the pull brings the squash commit into the local default branch (a queued auto-merge arrives later; note that).
 
-10. **After review** — Address feedback, push updates, and merge when approved and CI is green. If step 9 switched back to the default branch, switch to the PR branch again before making review fixes. Tell the user to run **`/iflow-cleanup`** once the PR is merged so the standard post-merge cleanup runs (`git fetch --prune`, `git branch -d` on merged local branches under a single consolidated confirm).
+10. **After review** — With the `yolo` token the PR was already merged in step 8a; skip to the `/iflow-cleanup` reminder. Otherwise address feedback, push updates, and merge when approved and CI is green. If step 9 switched back to the default branch, switch to the PR branch again before making review fixes. Tell the user to run **`/iflow-cleanup`** once the PR is merged so the standard post-merge cleanup runs (`git fetch --prune`, `git branch -d` on merged local branches under a single consolidated confirm).
 
-11. **Output** — Summarize commit, push result, PR URL, whether the working copy switched back to the default branch or stayed on the issue branch, and next step (`/iflow-cleanup` after merge, or "blocked on …" if stuck).
+11. **Output** — Summarize commit, push result, PR URL, whether the working copy switched back to the default branch or stayed on the issue branch, the merge result when `yolo` applied (merged, or queued via `--auto`), and next step (`/iflow-cleanup` after merge, or "blocked on …" if stuck).
 
 ## Constraints
 

{cellpycore-0.1.2 → cellpycore-0.1.3}/.cursor/skills/iflow-pick/SKILL.md

@@ -40,7 +40,8 @@ Do **not** use this skill from `/iflow`, `/iflow-start`, or `/iflow-close`. `/if
 5. **Create a `fix` issue (only when requested).** Use `gh issue create` (e.g. `chore: general fixes`), confirm title/body first, capture the new number. A fresh issue is created each time — never reuse an existing open general-fixes issue.
 6. **Over-large issue (note only).** If the chosen issue is too big for one PR, **mention** that breaking it into sub-issues is possible and tracked as a follow-up (Phase B of issue #63). Do **not** auto-create sub-issues here.
 
-### Phase 2 — create the branch
+7. **Label-driven yolo flow.** If the chosen issue carries the **`yolo`** label (case-insensitive), announce it and fold `/iflow-yolo`'s consolidated confirm into the pick confirmation (one prompt: branch + full `init → plan → start → close yolo` chain). On yes, run Phase 2 then follow the `iflow-yolo` skill **instead of** the Phase 3 handoff — its preflight still applies, but do not re-ask its confirm. Configurable via `label_flows` / `yolo_label` under `[issueflow]` in `.issueflows/config.toml` (re-run `issue-flow update` after changing).
+
 
 1. **Require a clean tree** (`git status --porcelain`). If dirty, **stop** and ask the user to commit/stash.
 2. **Branch off the default** — switch to default, fast-forward, then `git switch -c <N>-<short-slug>` (GitHub numeric convention). Confirm a non-obvious slug.
@@ -50,6 +51,9 @@ Do **not** use this skill from `/iflow`, `/iflow-start`, or `/iflow-close`. `/if
 
 1. **Ask** whether to continue with `/iflow-plan`. Do not auto-run it.
 
+2. **Exception:** when the `yolo`-label routing was confirmed in Phase 1, skip this handoff — the `iflow-yolo` chain (which includes `/iflow-init`) takes over after the branch is created.
+
+
 ## Constraints
 
 - Off-path: never auto-dispatch from `/iflow`, `/iflow-start`, or `/iflow-close`.

{cellpycore-0.1.2 → cellpycore-0.1.3}/.cursor/skills/iflow-yolo/SKILL.md

@@ -3,7 +3,8 @@ name: iflow-yolo
 description: >-
   Run the /iflow-yolo workflow: preflight (no default branch, clean tree,
   passing tests), single consolidated confirm, then chain init → plan → start
-  → close for small, low-risk issues. Stops on any ambiguity.
+  → close yolo (hands-off close: auto changelog, PR merge, default-branch
+  pull) for small, low-risk issues. Stops on any ambiguity.
 disable-model-invocation: true
 ---
 
@@ -26,7 +27,7 @@ Use only for minor fixes, doc tweaks, and similar low-risk changes. Anything non
 
 3. **Tests must pass up front.** Run `uv run pytest` (or the repo's documented test command). On any failure, **stop** before the chain starts.
 
-4. **Single consolidated confirm.** Present the full planned chain explicitly (issue reference, target branch, repo, downstream commands including any `bump` / `patch` / `draft` / `stay` flags). Require an explicit yes; any other input aborts.
+4. **Single consolidated confirm.** Present the full planned chain explicitly (issue reference, target branch, repo, downstream commands including any `bump` / `patch` / `draft` / `stay` flags). Require an explicit yes; any other input aborts. (When `/iflow-pick` routed here via the yolo issue label, its combined confirmation already covered this — do not ask twice.)
 
 ## Chain
 
@@ -36,11 +37,11 @@ Once preflight has passed and the user confirmed:
 2. **`/iflow-plan`** — write a **short** `issue<N>_plan.md` (Goal + Approach + Files to touch + Test strategy). Auto-confirm — the consolidated confirm above covered it. If the scope check reveals the change is not actually small, **abort the yolo chain** and tell the user to run the commands individually.
 3. **`/iflow-start`** — implement the plan without an additional plan-mode prompt.
 4. **Re-run tests.** `uv run pytest` again. On failure, **stop** before commit / push / PR.
-5. **`/iflow-close`** — run the full close flow (optional version bump if the user passed `bump` / `patch` / `minor` / `major`, issue-folder update, commit, push, PR, and the default-branch switch unless `stay` / `don't switch` text was passed). Do **not** chain `/iflow-cleanup` automatically — the PR has not merged yet.
+5. **`/iflow-close yolo`** — run the close flow with the `yolo` token (plus forwarded `bump` / `log` / `nohistory` / `draft` / `stay` tokens). The `yolo` token makes close hands-off: changelog bullet written without a confirm prompt, PR **merged** via `gh pr merge --squash` (fall back to `--squash --auto` when branch protection or pending checks block it), then default-branch switch + `git pull --ff-only`. `draft` conflicts with auto-merge — when passed, skip the merge and say so. Do **not** chain `/iflow-cleanup` automatically — local branch deletion stays a user decision.
 
 ## Post-run
 
-Report the PR URL and final branch. By default `/iflow-close` switches back to the default branch when the tree is clean; forwarded `stay` text leaves the user on the issue branch instead. Remind them to re-run `/iflow-cleanup` once the PR merges.
+Report the PR URL, the merge result (merged, or queued via `--auto`), and the final branch. By default `/iflow-close yolo` merges the PR and switches back to the default branch with a pull; forwarded `stay` text leaves the user on the issue branch instead. Remind them that `/iflow-cleanup` will delete the now-merged local branch when they are ready.
 
 ## Constraints
 

{cellpycore-0.1.2 → cellpycore-0.1.3}/.gitignore

@@ -179,4 +179,8 @@ local/
 __marimo__/
 
 # graphify
-graphify-out/cache/
+graphify-out/cache/
+
+# scratch / throwaway artifacts
+scratch.db
+tmp/

cellpycore-0.1.3/.issueflows/03-solved-issues/issue62_original.md

@@ -0,0 +1,13 @@
+# Issue #62 — readme links not working on pypi
+
+- **URL:** https://github.com/cellpy/cellpy-core/issues/62
+- **State:** open
+- **Labels:** yolo
+- **Captured:** 2026-07-02
+
+## Original description
+
+The links in the readme do not work on pypi. I guess the docs folder is not a
+part of the package. If so, consider either linking to the locations in the
+github repo or include those three files that have links on readme into the
+package.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue62_plan.md

@@ -0,0 +1,22 @@
+# Issue #62 — plan
+
+## Goal
+
+Make the documentation links in `README.md` work when rendered on PyPI.
+
+## Approach
+
+Relative links (`docs/...`) break on PyPI because the docs folder is not part
+of the rendered page context. Replace the three relative doc links in the
+README with absolute GitHub URLs pointing at `main`
+(`https://github.com/cellpy/cellpy-core/blob/main/docs/...`). No packaging
+changes — simplest fix, keeps the sdist/wheel lean.
+
+## Files to touch
+
+- `README.md`
+
+## Test strategy
+
+- `uv run pytest` (no code changes, suite must stay green).
+- Visual check that the rewritten URLs resolve on GitHub.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue62_status.md

@@ -0,0 +1,14 @@
+# Issue #62 — status
+
+- [x] Done
+
+## What was done
+
+- 2026-07-02: Replaced the three relative doc links in `README.md` with
+  absolute GitHub URLs (`https://github.com/cellpy/cellpy-core/blob/main/docs/...`)
+  so they render correctly on PyPI. Verified all three target files exist.
+  Full test suite green (107 passed). No packaging changes needed.
+
+## Remaining work
+
+None.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue64_original.md

@@ -0,0 +1,7 @@
+# Issue #64: small update in readme
+
+Source: https://github.com/cellpy/cellpy-core/issues/64
+
+## Original issue text
+
+The developer section in readme mentions running "uv venv". We should instead use the built in project manager in uv (so, developers should run "uv sync" after cloning the repo, and "uv add some-package" when adding new dependencies).

cellpycore-0.1.3/.issueflows/03-solved-issues/issue64_plan.md

@@ -0,0 +1,28 @@
+# Issue #64 plan: small update in readme
+
+## Goal
+
+The Developing section in `README.md` tells developers to run `uv venv` +
+`uv pip install -e ".[dev]"`. Switch to uv's built-in project workflow:
+`uv sync` after cloning, `uv add` for new dependencies.
+
+## Approach
+
+Rewrite the "Development Workflow" and "Common Commands" parts of the
+Developing section:
+
+- Drop `uv venv` + activate + `uv pip install -e ".[dev]"`; replace with a
+  single `uv sync` step (creates `.venv` and installs all locked deps).
+- Keep `uv add` / `uv add --dev` for adding dependencies.
+- Run tests via `uv run pytest`.
+- Update "Common Commands" to project-manager equivalents (`uv remove`,
+  `uv sync --upgrade`, `uv tree`).
+
+## Files to touch
+
+- `README.md` (only)
+
+## Test strategy
+
+Docs-only change; run `uv run pytest` before commit to confirm the suite is
+still green (yolo chain requirement).

cellpycore-0.1.3/.issueflows/03-solved-issues/issue64_status.md

@@ -0,0 +1,17 @@
+# Issue #64 status: small update in readme
+
+- [x] Done
+
+## What was done
+
+- Rewrote the "Development Workflow" part of `README.md` Developing section:
+  replaced `uv venv` + activate + `uv pip install -e ".[dev]"` with a single
+  `uv sync` step; kept `uv add` / `uv add --dev`; tests now via `uv run pytest`.
+- Updated "Common Commands" to project-manager equivalents (`uv sync`,
+  `uv remove`, `uv sync --upgrade`, `uv tree`), dropping the `uv pip ...`
+  commands.
+- Added a `HISTORY.md` bullet under `[Unreleased]`.
+
+## Remaining work
+
+None. Docs-only change; test suite green (107 passed).

cellpycore-0.1.3/.issueflows/03-solved-issues/issue66_original.md

@@ -0,0 +1,9 @@
+# Issue #66: code cleaning and test completion
+
+Source: https://github.com/cellpy/cellpy-core/issues/66
+
+## Original issue text
+
+Do some refactoring and cleaning up in the codebase. Check .issueflows\04-designs-and-guides\code-review-2026-07.md
+Create appropriate e2e tests.
+Create appropriate profiling tests.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue66_plan.md

@@ -0,0 +1,140 @@
+# Issue #66 plan: code cleaning and test completion
+
+Source issue: [issue66_original.md](issue66_original.md)
+Driving doc: [code-review-2026-07.md](../04-designs-and-guides/code-review-2026-07.md)
+Branch: `66-code-cleaning-and-test-completion`
+
+## Goal
+
+Land the mechanical cleanup from the 2026-07 code review (hygiene, API truthing,
+engine guards) and close the test gaps with native-path e2e tests and opt-in
+profiling benchmarks.
+
+## Constraints
+
+- **In scope (grilled + confirmed):** review-doc items D1 (hygiene), D2 (API
+  truthing), D5 (engine guards), D7 (test gaps) + e2e + profiling tests.
+- **Out of scope (deferred, filed):** D3 selectors decision (#67, see
+  `selector-dead-code-deferral.md`), D4 units fallback (A2, #68), CI coverage
+  reporting (#69), B1/B2 design pass (#70), structural refactors (no module
+  splits/moves — review verdict: engine is healthy; avoid churn before cellpy
+  pins a tag).
+- Parity is enforced by tests (migration doc): golden tests must stay green
+  byte-for-byte; no changes to computed values.
+- Legacy bridge (`OldCellpyCellCore`) behavior unchanged — cellpy imports only
+  this (verified: `cellpy/readers/cellreader.py:72` is the sole entry).
+- Google-style docstrings; project loggers, not root `logging` calls.
+
+### Prior art
+
+- `tests/test_golden.py` — legacy-bridge e2e on vendored Arbin parquet with
+  golden numbers (`ARBIN_N_STEPS=103`, `ARBIN_N_CYCLES=18`); new native e2e
+  mirrors this oracle, does not duplicate the legacy path.
+- `tests/test_harmonized_fixture.py` + `tests/data/arbin_cc_harmonized_raw.parquet`
+  — harmonized (native-naming) fixture already vendored; reuse for native e2e.
+- `Data.from_raw_frame` (issue #55) — existing validating front door; native
+  e2e drives through it, engine guards (B3) extend the same validation spirit
+  into `make_step_table` / `make_summary`.
+- Exclude-types support (issue #54) — covered by `tests/test_exclude_types.py`;
+  e2e exercises it as a pipeline variant only.
+- `.issueflows/00-tools/` — only README, no reusable helper applies.
+- graphify: not installed for this repo state (no `graphify-out/` consulted
+  beyond rules; grep-based discovery used).
+
+## Approach
+
+Phased commits on the issue branch, one concern per commit (Conventional
+Commits), tests green after each phase.
+
+### Phase 1 — hygiene (D1)
+
+1. `pyproject.toml`: remove `duckdb`, `duckdb-engine`, `sqlalchemy`, `narwhals`
+   (keep `pyarrow`); drop `uv-dynamic-versioning` from `[build-system]`; real
+   description; fix wrong classifier; `uv sync` to refresh lock.
+2. Delete tracked junk: `scratch.db`, `tmp/simple.csv`, `tmp/simple.parquet`
+   (+ `.gitignore` entries for `scratch.db`, `tmp/`).
+3. Replace root-logger calls with module loggers (`logger = logging.getLogger(__name__)`)
+   in `summarizers.py`, `settings_base.py`, `units.py`.
+4. **A3 falsy-override fix** in `summarizers._classify_steps`: membership test
+   (`key in orl`) instead of `or`-fallback for all four override keys +
+   regression test with `0.0` override.
+5. **A5**: `make_step_table(raw_limits=None)` → build fresh
+   `asdict(CellpyLimits())` per call; keep `DEFAULT_RAW_LIMITS` as a frozen
+   `MappingProxyType` for introspection/back-compat (`test_limits.py` uses it).
+6. **A6**: delete `Data.cycle` / `Data.step` dead fields (verified unused in
+   cellpy).
+7. CI: add ruff step (`ruff check` + `ruff format --check`) to
+   `.github/workflows/simpletest.yml`; minimal `[tool.ruff]` config.
+
+### Phase 2 — API truthing (D2)
+
+1. `src/cellpycore/__init__.py`: minimal curated exports —
+   `CellpyCellCore`, `OldCellpyCellCore`, `Data`, `make_step_table`,
+   `make_summary`, `default_schema` + schema types, `NoDataFound`;
+   `__version__` via `importlib.metadata.version("cellpy-core")` with
+   `PackageNotFoundError` fallback. `metadata` stays a submodule import.
+2. **A4**: delete unused `selector` / `select_columns` / `find_end_voltage`
+   params from native `make_core_summary` (legacy bridge keeps its
+   `find_end_voltage`).
+3. Add `py.typed` marker (+ ensure hatch includes it).
+4. Docs: fill `this-project.md` stubs; README project description.
+
+### Phase 3 — engine guards (D5/B3)
+
+- `make_step_table` / `make_summary`: raise `NoDataFound` when `data.raw`
+  (resp. `data.steps`) is `None`/missing; raise `ValueError` naming the missing
+  required columns. Tests for both.
+
+### Phase 4 — tests (D7 + e2e + profiling)
+
+1. `tests/test_e2e.py` — native pipeline via public API only
+   (`from cellpycore import ...`): harmonized raw parquet →
+   `Data.from_raw_frame` → `make_step_table` → `make_summary` →
+   exclude-types and scaled-columns variants; assert golden cycle/step counts
+   and spot values. Edge cases: empty raw frame, cycle without charge step,
+   `override_raw_limits={"current_hard": 0.0}`; thread-safety smoke (two
+   schemas, parallel `make_step_table` via `ThreadPoolExecutor`).
+2. `tests/test_benchmarks.py` — `pytest-benchmark` (new dev dep):
+   `make_step_table` + `make_summary` on Arbin fixture + small fixture;
+   `@pytest.mark.benchmark`, excluded from default run via addopts
+   (`-m "not benchmark"`); run manually: `uv run pytest -m benchmark`.
+
+## Files to touch
+
+- `pyproject.toml` — deps, build-system, metadata, ruff config, addopts, dev dep
+- `uv.lock` — regenerated
+- `scratch.db`, `tmp/` — deleted; `.gitignore` — updated
+- `.github/workflows/simpletest.yml` — ruff step
+- `src/cellpycore/__init__.py` — public API + `__version__`
+- `src/cellpycore/py.typed` — new marker
+- `src/cellpycore/summarizers.py` — A3, A5, logger, guards
+- `src/cellpycore/cell_core.py` — A6, A4
+- `src/cellpycore/settings_base.py`, `src/cellpycore/units.py` — logger only
+- `tests/test_e2e.py`, `tests/test_benchmarks.py` — new
+- `tests/test_limits.py` — adjust for frozen `DEFAULT_RAW_LIMITS`
+- `README.md`, `.issueflows/04-designs-and-guides/this-project.md` — docs
+
+## Test strategy
+
+- Full suite: `uv run pytest` (must stay green after every phase; golden tests
+  are the parity gate).
+- New: A3 regression (`0.0` override), guard tests (`NoDataFound`,
+  missing-column `ValueError`), native e2e, thread-safety smoke.
+- Benchmarks opt-in: `uv run pytest -m benchmark` (not in CI).
+- Lint locally before push: `uv run ruff check` + `uv run ruff format --check`.
+
+## Open questions
+
+- None — resolved via grilling 2026-07-03 (scope split, minimal public API,
+  native-path e2e, pytest-benchmark opt-in, no structural refactor).
+
+## Follow-ups (filed as GitHub issues, not this issue)
+
+- [#67](https://github.com/cellpy/cellpy-core/issues/67) — D3: selectors module
+  decision (port vs bridge-only).
+- [#68](https://github.com/cellpy/cellpy-core/issues/68) — D4/A2: units
+  fallback → explicit values or `metadata.CellMeta`.
+- [#69](https://github.com/cellpy/cellpy-core/issues/69) — CI coverage
+  reporting.
+- [#70](https://github.com/cellpy/cellpy-core/issues/70) — B1/B2 design pass
+  (schema-agnostic stat columns; cycle_mode polarity default).

cellpycore-0.1.3/.issueflows/03-solved-issues/issue66_status.md

@@ -0,0 +1,42 @@
+# Issue #66 status: code cleaning and test completion
+
+- [x] Done
+
+Plan: [issue66_plan.md](issue66_plan.md) (confirmed 2026-07-03, deferred items filed as #67–#70)
+
+## What's done
+
+All four plan phases implemented on branch `66-code-cleaning-and-test-completion`
+(one commit per phase, suite green after each; 120 passed + 3 opt-in benchmarks):
+
+- **Phase 1 — hygiene** (`chore:` commit): removed unused deps (duckdb,
+  duckdb-engine, sqlalchemy, narwhals) + uv-dynamic-versioning; real pyproject
+  description/classifier; deleted tracked `scratch.db` / `tmp/*` (+ gitignore);
+  module loggers replace root `logging.*` calls; **A3** falsy-override fix
+  (explicit `0.0` wins) + regression test; **A5** `DEFAULT_RAW_LIMITS` frozen
+  (`MappingProxyType`), `make_step_table` builds fresh limits per call;
+  **A6** dead `Data.cycle` / `Data.step` removed; ruff config + CI lint step;
+  ruff check --fix + format applied repo-wide.
+- **Phase 2 — API truthing** (`feat:` commit): curated public API in
+  `cellpycore/__init__.py` + `__version__` (importlib.metadata); `py.typed`;
+  **A4** dead `find_end_voltage`/`select_columns` removed from *native*
+  `make_core_summary` (legacy bridge keeps them — cellpy passes
+  `select_columns`); README description + example; `this-project.md` filled.
+- **Phase 3 — engine guards** (`feat:` commit): `NoDataFound` for missing
+  `raw`/`steps`, `ValueError` naming every missing required column at
+  `make_step_table` / `make_summary`; guard tests.
+- **Phase 4 — tests** (`test:` commit): `tests/test_e2e.py` native pipeline
+  via public API on the harmonized Arbin fixture (golden counts 103/18/1457,
+  exclude-types + scaled-columns variants, empty-frame and discharge-only
+  edge cases, thread-safety smoke with parallel schemas);
+  `tests/test_benchmarks.py` (pytest-benchmark, opt-in via
+  `uv run pytest -m benchmark`). Engine fix: Null-dtype raw signal columns
+  skipped in `make_step_table` (all-null placeholders crashed polars).
+- Deferred issues filed: #67 (selectors), #68 (units fallback), #69 (CI
+  coverage), #70 (B1/B2 design pass).
+- graphify graph refreshed.
+
+## Remaining work
+
+- None. Closed via `/iflow-close` 2026-07-03 (HISTORY.md bullet added, no
+  version bump requested). Deferred follow-ups live in issues #67–#70.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue67_original.md

@@ -0,0 +1,15 @@
+# Issue #67: Selectors: port remaining functions to native schema or make bridge-only
+
+Source: https://github.com/cellpy/cellpy-core/issues/67
+
+## Original issue text
+
+Deferred from #66 (code review 2026-07, item D3/A1).
+
+`selectors.py` is broken with its own default schema: `get_step_numbers`, `get_cycle_numbers`, `get_rates` default to `default_schema()` but dereference legacy-only attribute names (`data_point_txt`, `voltage_txt`, `cycle_index_txt`, ...), so they raise `AttributeError` unless legacy headers are injected. Module is also pandas-only and has zero test coverage.
+
+Decide and implement one of:
+- port the functions to the native schema + polars, with tests, or
+- move the module next to `legacy.py` and document it as bridge-only until removal.
+
+See `.issueflows/04-designs-and-guides/code-review-2026-07.md` (A1, D3) and `selector-dead-code-deferral.md`.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue67_plan.md

@@ -0,0 +1,114 @@
+# Issue #67 plan: selectors → bridge-only `legacy_selectors`
+
+Confirmed via grill-me (2026-07-03).
+
+## Goal
+
+Relocate the three remaining pandas selector helpers (`get_step_numbers`,
+`get_cycle_numbers`, `get_rates`) to a clearly bridge-only module, fix the
+`default_schema()` trap by defaulting to `legacy_schema()`, and add unit +
+golden tests. No native polars port.
+
+## Grill decisions (locked)
+
+| # | Decision |
+|---|----------|
+| 1 | **Bridge-only** — not a native polars port |
+| 2 | **`legacy_selectors.py`** — delete `selectors.py`; no shim |
+| 3 | **`legacy_schema()` default** — new helper in `config.py`, used when `schema is None` |
+| 4 | **Tests: unit + golden** — handcrafted legacy frames always run; one golden smoke with parquet `skipif` |
+| 5 | **Relocation + schema fix only** — preserve cellpy-parity behavior; do not fix dead code (e.g. unreachable `rate = 0.05` block) |
+
+## Constraints
+
+- Read-only on cellpy repo; no cellpy changes required (cellpy owns its own
+  `cellreader.py` copies; #45 removed the last `cellpycore.selectors` import).
+- Functions stay **pandas-only** (dict / `pandas.DataFrame` returns unchanged).
+- Not part of the public API (`__init__.py` exports unchanged).
+- Google-style docstrings on new/changed public helpers.
+
+### Prior art
+
+- `src/cellpycore/selectors.py` — current broken module (legacy attr names +
+  `default_schema()`).
+- `src/cellpycore/legacy.py` — `HeadersNormal`, `HeadersStepTable`,
+  `HeadersSummary` (target neighbourhood).
+- `config.default_schema()` — native `RawCols`/`StepCols`/`CycleCols` bundle.
+- `tests/test_golden._legacy_schema()` — private duplicate; replace with shared
+  `config.legacy_schema()`.
+- `tests/test_schema.py` — imports `selectors`, asserts removed #45 functions
+  absent; update import path.
+- `cellpy/readers/cellreader.py` — verbatim upstream copies of the three
+  functions (parity reference, not imported).
+- `.issueflows/04-designs-and-guides/this-project.md` — already notes selectors
+  as bridge-only/broken; update wording post-fix.
+- Graph community (selectors): `get_step_numbers`, `get_cycle_numbers`,
+  `get_rates` — isolated, no engine callers.
+
+## Approach
+
+1. **Add `legacy_schema()` to `config.py`**
+   - `Schema(raw=HeadersNormal(), cycle=HeadersSummary(), step=HeadersStepTable())`.
+   - Docstring: bridge/legacy callers only; engine uses `default_schema()`.
+   - Import header classes from `cellpycore.legacy` (lazy or top-level — match
+     existing `config.py` style).
+
+2. **Move `selectors.py` → `legacy_selectors.py`**
+   - Move the three functions verbatim (only change: `default_schema()` →
+     `legacy_schema()` in each `if schema is None` block).
+   - Module-level docstring: bridge-only, pandas + legacy column names required,
+     not for native `CellpyCellCore` / `default_schema()` consumers.
+   - Delete `src/cellpycore/selectors.py`.
+
+3. **Deduplicate test helper**
+   - `tests/test_golden.py`: replace `_legacy_schema()` with
+     `config.legacy_schema()`.
+
+4. **Update `tests/test_schema.py`**
+   - Drop `selectors` import.
+   - Move `test_no_legacy_selector_functions` to new test file (or delete if
+     module gone — function removal is already covered by #45; optional thin
+     assert that `legacy_selectors` has no `create_selector`).
+
+5. **Add `tests/test_legacy_selectors.py`**
+   - **Unit (always run):** minimal legacy-named pandas raw + step tables;
+     assert `get_step_numbers` dict keys/values, `get_cycle_numbers` without
+     rate filter, `get_rates` columns; confirm `schema=None` uses
+     `legacy_schema()` (no `AttributeError`).
+   - **Golden (skipif parquet missing):** reuse `test_golden._step_table()` +
+     `CYCLER_CC_*` constants; call `get_step_numbers("charge")`,
+     `get_cycle_numbers()`, `get_rates()` on real legacy-shaped step table;
+     assert cycle count matches `CYCLER_CC_N_CYCLES` and charge steps exist
+     for cycle 1.
+
+6. **Docs touch-up**
+   - `this-project.md`: selectors line → "bridge-only in `legacy_selectors.py`,
+     requires `legacy_schema()`".
+   - Optional one-liner in `code-review-2026-07.md` A1 noting resolution via #67
+     (no rewrite of the report).
+
+## Files to touch
+
+| File | Change |
+|------|--------|
+| `src/cellpycore/config.py` | Add `legacy_schema()` |
+| `src/cellpycore/legacy_selectors.py` | New — moved functions + module docstring |
+| `src/cellpycore/selectors.py` | Delete |
+| `tests/test_legacy_selectors.py` | New — unit + golden tests |
+| `tests/test_golden.py` | Use `legacy_schema()` |
+| `tests/test_schema.py` | Remove `selectors` import; adjust/remove selector asserts |
+| `.issueflows/04-designs-and-guides/this-project.md` | Update non-goals line |
+
+## Test strategy
+
+```bash
+uv run pytest tests/test_legacy_selectors.py -v
+uv run pytest   # full suite green
+```
+
+Golden test uses same `pytest.mark.skipif` + `CYCLER_CC_RAW` pattern as
+`test_golden.py`.
+
+## Open questions
+
+None — all branches resolved in grill-me.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue67_status.md

@@ -0,0 +1,19 @@
+# Issue #67 status: selectors → bridge-only `legacy_selectors`
+
+- [x] Done
+
+Plan: [issue67_plan.md](issue67_plan.md) (confirmed 2026-07-03, grill-me)
+
+## What's done
+
+- Added `config.legacy_schema()` (lazy import of legacy header classes).
+- Moved three functions to `src/cellpycore/legacy_selectors.py`; deleted `selectors.py`.
+- `tests/test_legacy_selectors.py` — unit tests (always run) + golden smoke (`skipif`).
+- `tests/test_golden.py` — uses shared `legacy_schema()`; dropped private `_legacy_schema()`.
+- `tests/test_schema.py` — removed `selectors` import and selector asserts.
+- Docs: `this-project.md`, `code-review-2026-07.md` A1 resolution note.
+- Suite green: 123 passed (+ 3 deselected benchmarks).
+
+## Remaining work
+
+None.

cellpycore-0.1.3/.issueflows/03-solved-issues/issue68_original.md

@@ -0,0 +1,13 @@
+# Issue #68: Units fallback: replace crashing data.<attr> fallback with explicit values or CellMeta
+
+Source: https://github.com/cellpy/cellpy-core/issues/68
+
+## Original issue text
+
+Deferred from #66 (code review 2026-07, item D4/A2).
+
+`units.get_converter_to_specific` reads `data.raw_units`, `data.mass`, `data.active_electrode_area`, `data.volume`; `nominal_capacity_as_absolute` reads `data.nom_cap_specifics`, `data.nom_cap`. The core `Data` class has none of these attributes, so the fallback path (taken whenever a caller omits `specific_converters` in `add_scaled_summary_columns`) raises `AttributeError` for standalone cellpy-core users.
+
+Make these functions take explicit values or a `metadata.CellMeta` (which already has `mass`, `active_electrode_area`, `nom_cap`, `nom_cap_specifics`) — a natural fit with the metadata-boundary decision. Also remove the pointless `try/except Exception: raise` block in `nominal_capacity_as_absolute`.
+
+See `.issueflows/04-designs-and-guides/code-review-2026-07.md` (A2, D4).