carconnectivity-connector-skoda 0.1a14__tar.gz → 0.1a16__tar.gz

{carconnectivity_connector_skoda-0.1a14 → carconnectivity_connector_skoda-0.1a16}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: carconnectivity-connector-skoda
-Version: 0.1a14
+Version: 0.1a16
 Summary: CarConnectivity connector for Skoda services
 Author: Till Steinbach
 License: MIT License

{carconnectivity_connector_skoda-0.1a14 → carconnectivity_connector_skoda-0.1a16}/src/carconnectivity_connector_skoda.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.2
 Name: carconnectivity-connector-skoda
-Version: 0.1a14
+Version: 0.1a16
 Summary: CarConnectivity connector for Skoda services
 Author: Till Steinbach
 License: MIT License

{carconnectivity_connector_skoda-0.1a14 → carconnectivity_connector_skoda-0.1a16}/src/carconnectivity_connectors/skoda/_version.py

@@ -12,5 +12,5 @@ __version__: str
 __version_tuple__: VERSION_TUPLE
 version_tuple: VERSION_TUPLE
 
-__version__ = version = '0.1a14'
+__version__ = version = '0.1a16'
 __version_tuple__ = version_tuple = (0, 1)

{carconnectivity_connector_skoda-0.1a14 → carconnectivity_connector_skoda-0.1a16}/src/carconnectivity_connectors/skoda/mqtt_client.py

@@ -21,18 +21,26 @@ from carconnectivity.drive import ElectricDrive
 from carconnectivity.util import robust_time_parse, log_extra_keys
 from carconnectivity.charging import Charging
 from carconnectivity.climatization import Climatization
+from carconnectivity.units import Speed, Power
 
 from carconnectivity_connectors.skoda.vehicle import SkodaVehicle, SkodaElectricVehicle
 from carconnectivity_connectors.skoda.charging import SkodaCharging, mapping_skoda_charging_state
 
 
 if TYPE_CHECKING:
-    from typing import Set, Dict, Any, Optional
+    from typing import Set, Dict, Any, Optional, List
     from datetime import datetime
 
+    from paho.mqtt.client import MQTTMessage, DisconnectFlags, ConnectFlags
+    from paho.mqtt.reasoncodes import ReasonCode
+    from paho.mqtt.properties import Properties
+
+    from carconnectivity.attributes import GenericAttribute
+
     from carconnectivity_connectors.skoda.connector import Connector
 
 
+
 LOG: logging.Logger = logging.getLogger("carconnectivity.connectors.skoda.mqtt")
 LOG_API: logging.Logger = logging.getLogger("carconnectivity.connectors.skoda-api-debug")
 
@@ -72,7 +80,7 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
         """
         return super().connect(*args, host='mqtt.messagehub.de', port=8883, keepalive=60, **kwargs)
 
-    def _on_pre_connect_callback(self, client, userdata) -> None:
+    def _on_pre_connect_callback(self, client: Client, userdata: Any) -> None:
         """
         Callback function that is called before the MQTT client connects to the broker.
 
@@ -94,7 +102,7 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
             # pylint: disable-next=attribute-defined-outside-init # this is a false positive, password has a setter in super class
             self._password = self._skoda_connector.session.access_token  # This is a bit hacky but if password attribute is used here there is an Exception
 
-    def _on_carconnectivity_vehicle_enabled(self, element, flags):
+    def _on_carconnectivity_vehicle_enabled(self, element: GenericAttribute, flags: Observable.ObserverEvent) -> None:
         """
         Handles the event when a vehicle is enabled or disabled in the car connectivity system.
 
@@ -252,7 +260,7 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
                 self.subscribed_topics.remove(topic)
                 LOG.debug('Unsubscribed from topic %s', topic)
 
-    def _on_connect_callback(self, mqttc, obj, flags, reason_code, properties) -> None:
+    def _on_connect_callback(self, client: Client, obj: Any, flags: ConnectFlags, reason_code: ReasonCode, properties: Optional[Properties]) -> None:
         """
         Callback function that is called when the MQTT client connects to the broker.
 
@@ -293,7 +301,7 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
             - 159: Connection rate exceeded.
             - Other: Generic connection error.
         """
-        del mqttc  # unused
+        del client  # unused
         del obj  # unused
         del flags  # unused
         del properties
@@ -351,8 +359,8 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
         else:
             LOG.error('Could not connect (%s)', reason_code)
 
-    def _on_disconnect_callback(self, client, userdata, flags, reason_code, properties) -> None:
-        """
+    def _on_disconnect_callback(self, client: Client, userdata, flags: DisconnectFlags, reason_code: ReasonCode, properties: Optional[Properties]) -> None:
+        """["Client", Any, DisconnectFlags, ReasonCode, Union[Properties, None]
         Callback function that is called when the MQTT client disconnects.
 
         This function handles the disconnection of the MQTT client and logs the appropriate
@@ -391,9 +399,9 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
         elif reason_code == 160:
             LOG.error('Client disconnected: Maximum connect time')
         else:
-            LOG.error('Client unexpectedly disconnected (%d: %s), trying to reconnect', reason_code, reason_code)
+            LOG.error('Client unexpectedly disconnected (%d: %s), trying to reconnect', reason_code.value, reason_code.getName())
 
-    def _on_subscribe_callback(self, mqttc, obj, mid, reason_codes, properties) -> None:
+    def _on_subscribe_callback(self, client: Client, obj: Any, mid: int, reason_codes: List[ReasonCode], properties: Optional[Properties]) -> None:
         """
         Callback function for MQTT subscription.
 
@@ -410,15 +418,15 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
         Returns:
             None
         """
-        del mqttc  # unused
+        del client  # unused
         del obj  # unused
         del properties  # unused
         if any(x in [0, 1, 2] for x in reason_codes):
             LOG.debug('sucessfully subscribed to topic of mid %d', mid)
         else:
-            LOG.error('Subscribe was not successfull (%s)', ', '.join(reason_codes))
+            LOG.error('Subscribe was not successfull (%s)', ', '.join([reason_code.getName() for reason_code in reason_codes]))
 
-    def _on_message_callback(self, mqttc, obj, msg) -> None:  # noqa: C901
+    def _on_message_callback(self, client: Client, obj: Any, msg: MQTTMessage) -> None:  # noqa: C901
         """
         Callback function for handling incoming MQTT messages.
 
@@ -434,7 +442,7 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
         Returns:
             None
         """
-        del mqttc  # unused
+        del client  # unused
         del obj  # unused
         if len(msg.payload) == 0:
             LOG_API.debug('MQTT topic %s: ignoring empty message', msg.topic)
@@ -474,9 +482,9 @@ class SkodaMQTTClient(Client):  # pylint: disable=too-many-instance-attributes
                                             # pylint: disable-next=protected-access
                                             vehicle.charging.type._set_value(value=Charging.ChargingType.OFF, measured=measured_at)
                                             # pylint: disable-next=protected-access
-                                            vehicle.charging.rate._set_value(value=0, measured=measured_at)
+                                            vehicle.charging.rate._set_value(value=0, measured=measured_at, unit=Speed.KMH)
                                             # pylint: disable-next=protected-access
-                                            vehicle.charging.power._set_value(value=0, measured=measured_at)
+                                            vehicle.charging.power._set_value(value=0, measured=measured_at, unit=Power.KW)
                                     if 'soc' in data['data'] and data['data']['soc'] is not None:
                                         electric_drive.level._set_value(measured=measured_at, value=data['data']['soc'])  # pylint: disable=protected-access
                                     if 'chargedRange' in data['data'] and data['data']['chargedRange'] is not None: