cad-to-dagmc 0.9.4__tar.gz → 0.9.6__tar.gz

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cad_to_dagmc
-Version: 0.9.4
+Version: 0.9.6
 Summary: Converts CAD files to a DAGMC h5m file
 Author-email: Jonathan Shimwell <mail@jshimwell.com>
 Project-URL: Homepage, https://github.com/fusion-energy/cad_to_dagmc
@@ -50,7 +50,7 @@ cad-to-dagmc can convert the following in to DAGMC compatible meshes:
 
 Cad-to-dagmc offers a wide range of features including.
 - Geometry scaling with ```scale_factor``` argument
-- Ddirect surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
+- Direct surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
 - Model wide mesh Gmsh size parameters with ```min_mesh_size``` and ```max_mesh_size``` arguments
 - Volume specific mesh sizing parameters with the ```set_size``` argument
 - Unstructured mesh that share the same coordinates as the surface mesh.

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/README.md

@@ -25,7 +25,7 @@ cad-to-dagmc can convert the following in to DAGMC compatible meshes:
 
 Cad-to-dagmc offers a wide range of features including.
 - Geometry scaling with ```scale_factor``` argument
-- Ddirect surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
+- Direct surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
 - Model wide mesh Gmsh size parameters with ```min_mesh_size``` and ```max_mesh_size``` arguments
 - Volume specific mesh sizing parameters with the ```set_size``` argument
 - Unstructured mesh that share the same coordinates as the surface mesh.

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/src/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '0.9.4'
-__version_tuple__ = version_tuple = (0, 9, 4)
+__version__ = version = '0.9.6'
+__version_tuple__ = version_tuple = (0, 9, 6)
 
-__commit_id__ = commit_id = 'g725750322'
+__commit_id__ = commit_id = 'gc9bf24ac7'

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/src/cad_to_dagmc/core.py

@@ -812,7 +812,6 @@ class CadToDagmc:
     def export_dagmc_h5m_file(
         self,
         filename: str = "dagmc.h5m",
-        meshing_backend: str = "cadquery",
         implicit_complement_material_tag: str | None = None,
         scale_factor: float = 1.0,
         imprint: bool = True,
@@ -822,8 +821,6 @@ class CadToDagmc:
 
         Args:
             filename: the filename to use for the saved DAGMC file.
-            meshing_backend: determines whether gmsh or cadquery's direct mesh method
-                is used for meshing. Options are 'gmsh' or 'cadquery'.
             implicit_complement_material_tag: the name of the material tag to use
                 for the implicit complement (void space).
             scale_factor: a scaling factor to apply to the geometry.
@@ -831,6 +828,11 @@ class CadToDagmc:
 
             **kwargs: Backend-specific parameters:
 
+                Backend selection:
+                - meshing_backend (str, optional): explicitly specify 'gmsh' or 'cadquery'.
+                  If not provided, backend is auto-selected based on other arguments.
+                  Defaults to 'cadquery' if no backend-specific arguments are given.
+
                 For GMSH backend:
                 - min_mesh_size (float): minimum mesh element size
                 - max_mesh_size (float): maximum mesh element size
@@ -851,6 +853,52 @@ class CadToDagmc:
             ValueError: If invalid parameter combinations are used.
         """
 
+        # Define all acceptable kwargs
+        cadquery_keys = {"tolerance", "angular_tolerance"}
+        gmsh_keys = {
+            "min_mesh_size",
+            "max_mesh_size",
+            "mesh_algorithm",
+            "set_size",
+            "umesh_filename",
+            "method",
+            "unstructured_volumes",
+        }
+        all_acceptable_keys = cadquery_keys | gmsh_keys | {"meshing_backend"}
+
+        # Check for invalid kwargs
+        invalid_keys = set(kwargs.keys()) - all_acceptable_keys
+        if invalid_keys:
+            raise ValueError(
+                f"Invalid keyword arguments: {sorted(invalid_keys)}\n"
+                f"Acceptable arguments are: {sorted(all_acceptable_keys)}"
+            )
+
+        # Handle meshing_backend - either from kwargs or auto-detect
+        meshing_backend = kwargs.pop("meshing_backend", None)
+
+        if meshing_backend is None:
+            # Auto-select meshing_backend based on kwargs
+            has_cadquery = any(key in kwargs for key in cadquery_keys)
+            has_gmsh = any(key in kwargs for key in gmsh_keys)
+            if has_cadquery and not has_gmsh:
+                meshing_backend = "cadquery"
+            elif has_gmsh and not has_cadquery:
+                meshing_backend = "gmsh"
+            elif has_cadquery and has_gmsh:
+                provided_cadquery = [key for key in cadquery_keys if key in kwargs]
+                provided_gmsh = [key for key in gmsh_keys if key in kwargs]
+                raise ValueError(
+                    "Ambiguous backend: both CadQuery and GMSH-specific arguments provided.\n"
+                    f"CadQuery-specific arguments: {sorted(cadquery_keys)}\n"
+                    f"GMSH-specific arguments: {sorted(gmsh_keys)}\n"
+                    f"Provided CadQuery arguments: {provided_cadquery}\n"
+                    f"Provided GMSH arguments: {provided_gmsh}\n"
+                    "Please provide only one backend's arguments."
+                )
+            else:
+                meshing_backend = "cadquery"  # default
+
         # Validate meshing backend
         if meshing_backend not in ["gmsh", "cadquery"]:
             raise ValueError(
@@ -858,6 +906,8 @@ class CadToDagmc:
                 'Available options are "gmsh" or "cadquery"'
             )
 
+        print(f"Using meshing backend: {meshing_backend}")
+
         # Initialize variables to avoid unbound errors
         tolerance = 0.1
         angular_tolerance = 0.1

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/src/cad_to_dagmc.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: cad_to_dagmc
-Version: 0.9.4
+Version: 0.9.6
 Summary: Converts CAD files to a DAGMC h5m file
 Author-email: Jonathan Shimwell <mail@jshimwell.com>
 Project-URL: Homepage, https://github.com/fusion-energy/cad_to_dagmc
@@ -50,7 +50,7 @@ cad-to-dagmc can convert the following in to DAGMC compatible meshes:
 
 Cad-to-dagmc offers a wide range of features including.
 - Geometry scaling with ```scale_factor``` argument
-- Ddirect surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
+- Direct surface meshing of CadQuery geometry with ```tolerance``` and ```angular_tolerance``` arguments (avoids using Gmsh)
 - Model wide mesh Gmsh size parameters with ```min_mesh_size``` and ```max_mesh_size``` arguments
 - Volume specific mesh sizing parameters with the ```set_size``` argument
 - Unstructured mesh that share the same coordinates as the surface mesh.

{cad_to_dagmc-0.9.4 → cad_to_dagmc-0.9.6}/tests/test_kwarg_args.py

@@ -187,6 +187,121 @@ class TestKwargsExportDagmcH5mFile:
         assert output_file_gmsh.exists()
 
 
+class TestKwargsValidation:
+    """Test kwargs validation for export_dagmc_h5m_file method"""
+
+    def setup_method(self):
+        """Setup method to create a simple geometry for testing"""
+        self.my_model = CadToDagmc()
+
+        # Create a simple box
+        box = cq.Workplane("XY").box(10, 10, 10)
+        self.my_model.add_cadquery_object(box, material_tags=["steel"])
+
+    def test_invalid_kwargs_raises_error(self, tmp_path):
+        """Test that invalid kwargs raise ValueError with helpful message"""
+        output_file = tmp_path / "test_invalid_kwargs.h5m"
+
+        with pytest.raises(ValueError) as excinfo:
+            self.my_model.export_dagmc_h5m_file(
+                filename=str(output_file),
+                invalid_param=123,
+                another_invalid=True,
+            )
+
+        error_message = str(excinfo.value)
+        assert "Invalid keyword arguments:" in error_message
+        assert "another_invalid" in error_message
+        assert "invalid_param" in error_message
+        assert "Acceptable arguments are:" in error_message
+
+    def test_mixed_valid_invalid_kwargs_raises_error(self, tmp_path):
+        """Test that mix of valid and invalid kwargs raises error"""
+        output_file = tmp_path / "test_mixed_kwargs.h5m"
+
+        with pytest.raises(ValueError) as excinfo:
+            self.my_model.export_dagmc_h5m_file(
+                filename=str(output_file),
+                tolerance=0.1,  # valid
+                bad_param=456,  # invalid
+                min_mesh_size=0.5,  # valid
+            )
+
+        error_message = str(excinfo.value)
+        assert "Invalid keyword arguments:" in error_message
+        assert "bad_param" in error_message
+        assert "tolerance" in error_message  # valid param should be in error
+        assert "min_mesh_size" in error_message  # valid param should be in error
+
+    def test_all_valid_cadquery_kwargs_accepted(self, tmp_path):
+        """Test that all valid CadQuery kwargs are accepted"""
+        output_file = tmp_path / "test_valid_cq_kwargs.h5m"
+
+        # Should not raise any error
+        result = self.my_model.export_dagmc_h5m_file(
+            filename=str(output_file),
+            meshing_backend="cadquery",
+            tolerance=0.1,
+            angular_tolerance=0.2,
+        )
+
+        assert result == str(output_file)
+        assert output_file.exists()
+
+    def test_all_valid_gmsh_kwargs_accepted(self, tmp_path):
+        """Test that all valid GMSH kwargs are accepted"""
+        output_file = tmp_path / "test_valid_gmsh_kwargs.h5m"
+
+        # Should not raise any error
+        result = self.my_model.export_dagmc_h5m_file(
+            filename=str(output_file),
+            meshing_backend="gmsh",
+            min_mesh_size=0.1,
+            max_mesh_size=1.0,
+            mesh_algorithm=1,
+            set_size={1: 0.5},
+            umesh_filename="test.vtk",
+            method="file",
+            # unstructured_volumes would be tested separately
+        )
+
+        assert result == str(output_file)
+        assert output_file.exists()
+
+    def test_typo_in_kwarg_name_raises_helpful_error(self, tmp_path):
+        """Test that typos in parameter names give helpful error messages"""
+        output_file = tmp_path / "test_typo.h5m"
+
+        # Common typo: "tolerance" -> "tollerance"
+        with pytest.raises(ValueError) as excinfo:
+            self.my_model.export_dagmc_h5m_file(
+                filename=str(output_file),
+                tollerance=0.1,  # typo
+            )
+
+        error_message = str(excinfo.value)
+        assert "Invalid keyword arguments:" in error_message
+        assert "tollerance" in error_message
+        assert "tolerance" in error_message  # should show the correct options
+
+    def test_case_sensitivity_in_kwargs(self, tmp_path):
+        """Test that kwargs are case sensitive"""
+        output_file = tmp_path / "test_case_sensitive.h5m"
+
+        # Wrong case should raise error
+        with pytest.raises(ValueError) as excinfo:
+            self.my_model.export_dagmc_h5m_file(
+                filename=str(output_file),
+                Tolerance=0.1,  # wrong case
+                MESHING_BACKEND="cadquery",  # wrong case
+            )
+
+        error_message = str(excinfo.value)
+        assert "Invalid keyword arguments:" in error_message
+        assert "Tolerance" in error_message
+        assert "MESHING_BACKEND" in error_message
+
+
 class TestKwargsWithMultipleVolumes:
     """Test kwargs functionality with multiple volumes"""