boost-skill-cli 1.0.95__tar.gz → 1.0.96__tar.gz

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.95
+Version: 1.0.96
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/boost_cli/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.0.95'
-__version_tuple__ = version_tuple = (1, 0, 95)
+__version__ = version = '1.0.96'
+__version_tuple__ = version_tuple = (1, 0, 96)
 
 __commit_id__ = commit_id = None

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/boost_cli/core/rag.py

@@ -27,7 +27,7 @@ try:  # TypedDict lives in typing on 3.9+, kept optional for safety
 except ImportError:  # pragma: no cover - 3.9+ always has it
     TypedDict = None  # type: ignore
 
-from . import ai, catalog, frontmatter, gitutil, paths, registry
+from . import ai, catalog, frontmatter, gitutil, paths, registry, util
 
 INDEX_VERSION = 1
 ENGINE = "bm25"
@@ -249,14 +249,15 @@ def _save(docs: List[dict], commits: Dict[str, str]) -> None:
     }
     paths.ensure_dirs()
     p = index_path()
-    p.write_text(json.dumps(payload))
+    # Atomic swap: a bare write_text here can leave a truncated/corrupt index
+    # on disk if the process dies mid-write or a query reads concurrently.
+    util.atomic_write_text(p, json.dumps(payload))
     # Drop the mtime-keyed cache so a reindex is visible to an immediately
     # following query even when the filesystem mtime granularity is coarse.
     _CACHE.pop(str(p), None)
 
 
 def _now() -> str:
-    from . import util
     return util.now_iso()
 
 

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/boost_skill_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.95
+Version: 1.0.96
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

boost_skill_cli-1.0.96/docs/roadmap/items/atomic-corruption-safe-lock-file-writes.md

@@ -0,0 +1,21 @@
+---
+id: atomic-corruption-safe-lock-file-writes
+board: code
+section: shipped
+status: shipped
+category: Correctness · Robustness
+complexity: M
+impact: High
+wow: 4
+note: already fixed in #65
+order: 1
+owner: loop/roadmap-hygiene-stale-cards
+pr: 65
+title: Atomic, corruption-safe lock-file writes
+---
+Shipped in <b>#65</b> (this card lingered as "next" after the fact).
+<code>core/lockfile.py</code> now writes through <code>util.atomic_write_text</code>
+(temp file + <code>os.replace()</code>) and <code>read()</code> tells "empty"
+apart from "corrupt": an unparseable lock is preserved as <code>&lt;lock&gt;.corrupt</code>
+and surfaced loudly rather than silently overwritten, so an interrupted or
+concurrent write can no longer drop every prior install record.

boost_skill_cli-1.0.96/docs/roadmap/items/github-pages-deploy-is-broken-every-push.md

@@ -0,0 +1,22 @@
+---
+id: github-pages-deploy-is-broken-every-push
+board: code
+section: shipped
+status: shipped
+category: Bug · Infra
+complexity: S
+impact: High
+wow: 2
+note: root cause removed in #60
+order: 1
+owner: loop/roadmap-hygiene-stale-cards
+pr: 60
+title: GitHub Pages deploy is broken every push
+---
+Fixed by <b>#60</b>: the bogus <code>mutants/None</code> gitlink (a stray mutmut
+artifact with no <code>.gitmodules</code> entry) that made Pages' submodule
+checkout abort with <code>fatal: No url found for submodule path 'mutants/None'</code>
+is gone. Verified: the Pages "build and deployment" now completes successfully and
+the site serves — the boards live at
+<code>jonnyeclectic.github.io/boost/docs/roadmap.html</code> (200), since Pages
+publishes from the repo root.

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/docs/roadmap/items/one-shared-atomic-write-helper.md

@@ -2,15 +2,15 @@
 id: one-shared-atomic-write-helper
 board: code
 section: internals
-status: planned
+status: shipped
 category: Robustness
 complexity: S
 impact: Med
 wow: 2
 note: 
 order: 8
-owner:
-pr:
+owner: loop/atomic-rag-save
+pr: 108
 title: One shared atomic-write helper
 ---
 <code>journal._maybe_rotate</code> is a racy read-modify-write that concurrent appends can truncate mid-line; <code>rag._save</code> and <code>config.save</code> repeat the non-atomic pattern (<code>journal.py:63 · rag.py:252 · config.py:93</code>). Factor a single <code>atomic_write</code> into <code>core</code> and route all four through it.

boost_skill_cli-1.0.96/docs/roadmap/items/untrack-generated-build-noise.md

@@ -0,0 +1,19 @@
+---
+id: untrack-generated-build-noise
+board: code
+section: shipped
+status: shipped
+category: Hygiene · DX
+complexity: S
+impact: Med
+wow: 1
+note: already fixed in #60
+order: 2
+owner: loop/roadmap-hygiene-stale-cards
+pr: 60
+title: Untrack generated build noise
+---
+Shipped in <b>#60</b>. The generated <code>mutants/**</code>,
+<code>__pycache__/*.pyc</code> and <code>.coverage</code> files were removed from
+the index (verified: <code>git ls-files</code> now tracks zero of them), so they
+no longer churn every diff or force path-scoped <code>git add</code>s.

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/docs/roadmap.html

@@ -115,8 +115,8 @@
   <section class="block reveal">
     <div class="stats">
       <!-- ROADMAP:stats -->
-      <div class="stat"><b>11</b><span>Shipped</span></div>
-      <div class="stat"><b>3</b><span>Next up</span></div>
+      <div class="stat"><b>14</b><span>Shipped</span></div>
+      <div class="stat"><b>1</b><span>Next up</span></div>
       <div class="stat"><b>4</b><span>Planned</span></div>
       <div class="stat"><b>89</b><span>Loop finds</span></div>
       <!-- /ROADMAP:stats -->
@@ -132,6 +132,41 @@
     <div class="rgrid">
 
       <!-- ROADMAP:cards section=shipped -->
+      <article class="cap rcard">
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Correctness · Robustness</span></div>
+        <h3>Atomic, corruption-safe lock-file writes</h3>
+        <p>Shipped in <b>#65</b> (this card lingered as "next" after the fact).
+<code>core/lockfile.py</code> now writes through <code>util.atomic_write_text</code>
+(temp file + <code>os.replace()</code>) and <code>read()</code> tells "empty"
+apart from "corrupt": an unparseable lock is preserved as <code>&lt;lock&gt;.corrupt</code>
+and surfaced loudly rather than silently overwritten, so an interrupted or
+concurrent write can no longer drop every prior install record.</p>
+        <div class="meta">
+          <span class="m">Complexity <b>M</b></span>
+          <span class="m hi">Impact <b>High</b></span>
+          <span class="m">Wow <b class="wow">★★★★</b></span>
+          <span class="m">already fixed in</span>
+        </div>
+      </article>
+
+      <article class="cap rcard">
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Bug · Infra</span></div>
+        <h3>GitHub Pages deploy is broken every push</h3>
+        <p>Fixed by <b>#60</b>: the bogus <code>mutants/None</code> gitlink (a stray mutmut
+artifact with no <code>.gitmodules</code> entry) that made Pages' submodule
+checkout abort with <code>fatal: No url found for submodule path 'mutants/None'</code>
+is gone. Verified: the Pages "build and deployment" now completes successfully and
+the site serves — the boards live at
+<code>jonnyeclectic.github.io/boost/docs/roadmap.html</code> (200), since Pages
+publishes from the repo root.</p>
+        <div class="meta">
+          <span class="m">Complexity <b>S</b></span>
+          <span class="m hi">Impact <b>High</b></span>
+          <span class="m">Wow <b class="wow">★★</b></span>
+          <span class="m">root cause removed in</span>
+        </div>
+      </article>
+
       <article class="cap rcard">
         <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Testing · Bug</span></div>
         <h3>Mutation hardening — <code>core/store.py</code></h3>
@@ -162,6 +197,21 @@
         </div>
       </article>
 
+      <article class="cap rcard">
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Hygiene · DX</span></div>
+        <h3>Untrack generated build noise</h3>
+        <p>Shipped in <b>#60</b>. The generated <code>mutants/**</code>,
+<code>__pycache__/*.pyc</code> and <code>.coverage</code> files were removed from
+the index (verified: <code>git ls-files</code> now tracks zero of them), so they
+no longer churn every diff or force path-scoped <code>git add</code>s.</p>
+        <div class="meta">
+          <span class="m">Complexity <b>S</b></span>
+          <span class="m">Impact <b>Med</b></span>
+          <span class="m">Wow <b class="wow">★</b></span>
+          <span class="m">already fixed in</span>
+        </div>
+      </article>
+
       <article class="cap rcard">
         <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Correctness</span></div>
         <h3>Consolidate skill-staleness / drift logic into core</h3>
@@ -337,37 +387,6 @@ by new unit tests covering every branch.</p>
     <div class="rgrid">
 
       <!-- ROADMAP:cards section=next -->
-      <article class="cap rcard">
-        <div class="head"><span class="pill next">Next</span><span class="cat">Bug · Infra</span></div>
-        <h3>GitHub Pages deploy is broken every push</h3>
-        <p>Root cause found: a bogus <code>mutants/None</code> gitlink (a stray
-           mutmut artifact) was committed with no <code>.gitmodules</code> entry,
-           so Pages' submodule checkout aborts with
-           <code>fatal: No url found for submodule path 'mutants/None'</code>.
-           Fix: stop tracking <code>mutants/</code>.</p>
-        <div class="meta">
-          <span class="m">Complexity <b>S</b></span>
-          <span class="m hi">Impact <b>High</b></span>
-          <span class="m">Wow <b class="wow">★★</b></span>
-          <span class="m">docs site down</span>
-        </div>
-      </article>
-
-      <article class="cap rcard">
-        <div class="head"><span class="pill next">Next</span><span class="cat">Hygiene · DX</span></div>
-        <h3>Untrack generated build noise</h3>
-        <p>Over a hundred <code>mutants/**</code>, <code>__pycache__/*.pyc</code>
-           and <code>.coverage</code> files are tracked despite being in
-           <code>.gitignore</code> — they churn every diff and forced careful
-           path-scoped <code>git add</code>s. Remove from the index.</p>
-        <div class="meta">
-          <span class="m">Complexity <b>S</b></span>
-          <span class="m">Impact <b>Med</b></span>
-          <span class="m">Wow <b class="wow">★</b></span>
-          <span class="m">unblocks Pages</span>
-        </div>
-      </article>
-
       <article class="cap rcard">
         <div class="head"><span class="pill next">Next</span><span class="cat">Design</span></div>
         <h3>Reconcile the theme drift</h3>
@@ -462,17 +481,6 @@ by new unit tests covering every branch.</p>
     <div class="rgrid">
 
       <!-- ROADMAP:cards section=internals -->
-      <article class="cap rcard">
-        <div class="head"><span class="pill next">Next</span><span class="cat">Correctness · Robustness</span></div>
-        <h3>Atomic, corruption-safe lock-file writes</h3>
-        <p><code>read()</code> returns an empty skeleton on <b>any</b> JSON error and <code>write()</code> is a bare <code>write_text</code> at <code>core/lockfile.py:55</code>. An interrupted or concurrent write truncates the lock — the next <code>set_skill()</code> then <b>permanently drops every prior install record</b> while store dirs linger as orphans. Write to a temp file + <code>os.replace()</code>, and tell "empty" apart from "corrupt".</p>
-        <div class="meta">
-          <span class="m">Complexity <b>M</b></span>
-          <span class="m hi">Impact <b>High</b></span>
-          <span class="m">Wow <b class="wow">★★★★</b></span>
-        </div>
-      </article>
-
       <article class="cap rcard">
         <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Performance</span></div>
         <h3>Memoize <code>config.load()</code> in-process</h3>
@@ -496,7 +504,7 @@ by new unit tests covering every branch.</p>
       </article>
 
       <article class="cap rcard">
-        <div class="head"><span class="pill planned">Planned</span><span class="cat">Robustness</span></div>
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Robustness</span></div>
         <h3>One shared atomic-write helper</h3>
         <p><code>journal._maybe_rotate</code> is a racy read-modify-write that concurrent appends can truncate mid-line; <code>rag._save</code> and <code>config.save</code> repeat the non-atomic pattern (<code>journal.py:63 · rag.py:252 · config.py:93</code>). Factor a single <code>atomic_write</code> into <code>core</code> and route all four through it.</p>
         <div class="meta">

{boost_skill_cli-1.0.95 → boost_skill_cli-1.0.96}/tests/unit/test_rag.py

@@ -9,6 +9,7 @@ from __future__ import annotations
 
 import json
 import math
+from pathlib import Path
 
 import pytest
 
@@ -861,3 +862,39 @@ class TestEngineRouting:
     def test_none_when_no_index_at_all(self, sandbox, monkeypatch):
         monkeypatch.setattr(dense_mod, "ready", lambda: False)
         assert rag.search("react", smart=False) is None
+
+
+class TestAtomicIndexSave:
+    """`_save` must route the index through util.atomic_write_text so a crash
+    or concurrent reader never sees a truncated/corrupt BM25 index."""
+
+    def test_save_routes_through_atomic_write_text(self, corpus, monkeypatch):
+        _root, entries = corpus
+        calls = []
+        real = rag.util.atomic_write_text
+
+        def spy(path, text, *a, **k):
+            calls.append(Path(path))
+            return real(path, text, *a, **k)
+
+        monkeypatch.setattr(rag.util, "atomic_write_text", spy)
+        rag.build(entries=entries, force=True)
+        # The index write went through the atomic helper, not a bare write_text.
+        assert rag.index_path() in calls
+
+    def test_index_is_complete_json_and_leaves_no_temp_turd(self, corpus):
+        _root, entries = corpus
+        rag.build(entries=entries, force=True)
+        p = rag.index_path()
+        payload = json.loads(p.read_text())  # parseable ⇒ not truncated
+        assert payload["docs"] and "postings" in payload
+        # atomic_write_text writes to ".<name>.*.tmp" then os.replace — the
+        # temp file must not survive a successful save.
+        assert list(p.parent.glob("." + p.name + ".*")) == []
+
+    def test_rebuild_replaces_index_atomically(self, corpus):
+        _root, entries = corpus
+        rag.build(entries=entries, force=True)
+        rag.build(entries=entries, force=True)  # second save swaps in place
+        payload = json.loads(rag.index_path().read_text())
+        assert payload["stats"]["docs"] >= 2

boost_skill_cli-1.0.95/docs/roadmap/items/atomic-corruption-safe-lock-file-writes.md

@@ -1,16 +0,0 @@
----
-id: atomic-corruption-safe-lock-file-writes
-board: code
-section: internals
-status: next
-category: Correctness · Robustness
-complexity: M
-impact: High
-wow: 4
-note: 
-order: 1
-owner:
-pr:
-title: Atomic, corruption-safe lock-file writes
----
-<code>read()</code> returns an empty skeleton on <b>any</b> JSON error and <code>write()</code> is a bare <code>write_text</code> at <code>core/lockfile.py:55</code>. An interrupted or concurrent write truncates the lock — the next <code>set_skill()</code> then <b>permanently drops every prior install record</b> while store dirs linger as orphans. Write to a temp file + <code>os.replace()</code>, and tell "empty" apart from "corrupt".

boost_skill_cli-1.0.95/docs/roadmap/items/github-pages-deploy-is-broken-every-push.md

@@ -1,20 +0,0 @@
----
-id: github-pages-deploy-is-broken-every-push
-board: code
-section: next
-status: next
-category: Bug · Infra
-complexity: S
-impact: High
-wow: 2
-note: docs site down
-order: 1
-owner:
-pr:
-title: GitHub Pages deploy is broken every push
----
-Root cause found: a bogus <code>mutants/None</code> gitlink (a stray
-           mutmut artifact) was committed with no <code>.gitmodules</code> entry,
-           so Pages' submodule checkout aborts with
-           <code>fatal: No url found for submodule path 'mutants/None'</code>.
-           Fix: stop tracking <code>mutants/</code>.

boost_skill_cli-1.0.95/docs/roadmap/items/untrack-generated-build-noise.md

@@ -1,19 +0,0 @@
----
-id: untrack-generated-build-noise
-board: code
-section: next
-status: next
-category: Hygiene · DX
-complexity: S
-impact: Med
-wow: 1
-note: unblocks Pages
-order: 2
-owner:
-pr:
-title: Untrack generated build noise
----
-Over a hundred <code>mutants/**</code>, <code>__pycache__/*.pyc</code>
-           and <code>.coverage</code> files are tracked despite being in
-           <code>.gitignore</code> — they churn every diff and forced careful
-           path-scoped <code>git add</code>s. Remove from the index.