boost-skill-cli 1.0.76__tar.gz → 1.0.78__tar.gz

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.76
+Version: 1.0.78
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/boost_cli/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.0.76'
-__version_tuple__ = version_tuple = (1, 0, 76)
+__version__ = version = '1.0.78'
+__version_tuple__ = version_tuple = (1, 0, 78)
 
 __commit_id__ = commit_id = None

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/boost_cli/commands/configuration.py

@@ -737,6 +737,8 @@ _PAGE_CSS = ("body{background:#111;color:#ddd;font-family:ui-monospace,SFMono-Re
              "th,td{text-align:left;padding:.3rem .8rem .3rem 0;"
              "border-bottom:1px solid #2a2a2a}.dim{color:#777}")
 
+_SKILL_NAME_RE = re.compile(r"^[A-Za-z0-9._-]+$")
+
 
 def _serve_page() -> str:
     installed = lockfile.installed()
@@ -761,7 +763,7 @@ def _serve_page() -> str:
 
 def _skill_text(name: str):
     """SKILL.md text for an installed skill, else from a tap. None if unknown."""
-    if not re.match(r"^[A-Za-z0-9._-]+$", name):
+    if not _SKILL_NAME_RE.fullmatch(name):
         return None
     fp = store.skill_store_dir(name) / "SKILL.md"
     if fp.is_file():
@@ -803,6 +805,10 @@ class _CatalogHandler(BaseHTTPRequestHandler):
                            json.dumps(lockfile.read(), indent=2).encode())
             elif path.startswith("/skill/"):
                 name = path[len("/skill/"):].strip("/")
+                if not _SKILL_NAME_RE.fullmatch(name):
+                    self._send(404, "application/json",
+                               json.dumps({"error": "no skill named %r" % name}).encode())
+                    return
                 text = _skill_text(name)
                 if text is None:
                     self._send(404, "application/json",

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/boost_cli/core/config.py

@@ -77,7 +77,30 @@ def _merge(base: dict, override: dict) -> dict:
     return out
 
 
-def load() -> dict:
+# In-process cache of the merged config. get() is on many hot paths
+# (ai.enabled, per-skill enabled_agents, log level, policy) and every call
+# used to re-read config.json and re-merge/deep-copy DEFAULTS. We cache the
+# merged result keyed on the config path + its stat stamp, so any write —
+# save(), an external edit, or a HOME/BOOST_HOME switch between tests — is
+# picked up automatically without an explicit invalidation call.
+_cache: dict | None = None
+_cache_key: tuple | None = None
+
+
+def _stat_stamp(p: Any) -> tuple:
+    """Identity of the config file: (path, mtime_ns, size).
+
+    A missing file stamps as (path, None, None); any create/modify/delete
+    changes the stamp, which is what invalidates the cache.
+    """
+    try:
+        st = p.stat()
+    except OSError:
+        return (str(p), None, None)
+    return (str(p), st.st_mtime_ns, st.st_size)
+
+
+def _read() -> dict:
     p = paths.config_path()
     if not p.exists():
         return deepcopy(DEFAULTS)
@@ -88,6 +111,24 @@ def load() -> dict:
     return _merge(DEFAULTS, user)
 
 
+def _cached() -> dict:
+    """The merged config, re-read from disk only when the file changes."""
+    global _cache, _cache_key
+    key = _stat_stamp(paths.config_path())
+    cache = _cache
+    if cache is None or _cache_key != key:
+        cache = _read()
+        _cache = cache
+        _cache_key = key
+    return cache
+
+
+def load() -> dict:
+    # A defensive copy so callers can mutate the result (set_value/unset do)
+    # without corrupting the shared cache.
+    return deepcopy(_cached())
+
+
 def save(cfg: dict) -> None:
     paths.ensure_dirs()
     util.atomic_write_text(
@@ -95,12 +136,12 @@ def save(cfg: dict) -> None:
 
 
 def get(dotted: str, default=None):
-    node = load()
+    node = _cached()
     for part in dotted.split("."):
         if not isinstance(node, dict) or part not in node:
             return default
         node = node[part]
-    return node
+    return deepcopy(node)
 
 
 def set_value(dotted: str, raw: str) -> None:

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/boost_skill_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.76
+Version: 1.0.78
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/docs/roadmap/items/memoize-config-load-in-process.md

@@ -2,15 +2,15 @@
 id: memoize-config-load-in-process
 board: code
 section: internals
-status: next
+status: shipped
 category: Performance
 complexity: S
 impact: Med-High
 wow: 3
 note: 
 order: 4
-owner:
-pr:
+owner: loop/memoize-config
+pr: 88
 title: Memoize <code>config.load()</code> in-process
 ---
 Every <code>config.get()</code> re-reads <code>config.json</code> and runs a recursive <code>deepcopy</code> of <code>DEFAULTS</code> (<code>core/config.py:80–102</code>). It's called all over hot paths — <code>ai.enabled</code>, per-skill <code>enabled_agents</code> in sync loops, log-level and policy checks — so one command triggers <b>dozens of full reads + deep-copies</b>. Cache the load, invalidate on <code>save</code>.

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/docs/roadmap.html

@@ -432,7 +432,7 @@
       </article>
 
       <article class="cap rcard">
-        <div class="head"><span class="pill next">Next</span><span class="cat">Performance</span></div>
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Performance</span></div>
         <h3>Memoize <code>config.load()</code> in-process</h3>
         <p>Every <code>config.get()</code> re-reads <code>config.json</code> and runs a recursive <code>deepcopy</code> of <code>DEFAULTS</code> (<code>core/config.py:80–102</code>). It's called all over hot paths — <code>ai.enabled</code>, per-skill <code>enabled_agents</code> in sync loops, log-level and policy checks — so one command triggers <b>dozens of full reads + deep-copies</b>. Cache the load, invalidate on <code>save</code>.</p>
         <div class="meta">

{boost_skill_cli-1.0.76 → boost_skill_cli-1.0.78}/tests/unit/test_config.py

@@ -81,6 +81,53 @@ class TestSaveRoundtrip:
         assert raw.endswith("\n")
 
 
+class TestCaching:
+    def test_reads_only_once_when_file_unchanged(self, sandbox, monkeypatch):
+        calls = {"n": 0}
+        real = config._read
+
+        def counting():
+            calls["n"] += 1
+            return real()
+
+        monkeypatch.setattr(config, "_cache", None)
+        monkeypatch.setattr(config, "_cache_key", None)
+        monkeypatch.setattr(config, "_read", counting)
+        config.get("ai.model")
+        config.get("serve.port")
+        config.load()
+        assert calls["n"] == 1  # cached: file never re-read
+
+    def test_external_write_invalidates_cache(self, sandbox):
+        paths.ensure_dirs()
+        paths.config_path().write_text(json.dumps({"serve": {"port": 1}}))
+        assert config.get("serve.port") == 1
+        # A different size on disk changes the stat stamp -> reload.
+        paths.config_path().write_text(json.dumps({"serve": {"port": 22222}}))
+        assert config.get("serve.port") == 22222
+
+    def test_save_visible_to_get(self, sandbox):
+        assert config.get("telemetry") is False  # warm the cache
+        config.save({"telemetry": True})
+        assert config.get("telemetry") is True
+
+    def test_get_returns_isolated_container(self, sandbox):
+        agents = config.get("agents")
+        agents["claude-code"]["enabled"] = False
+        assert config.get("agents")["claude-code"]["enabled"] is True
+
+    def test_load_returns_isolated_copy(self, sandbox):
+        first = config.load()
+        first["serve"]["port"] = 424242
+        assert config.get("serve.port") == 8787
+        assert config.load()["serve"]["port"] == 8787
+
+    def test_missing_file_stamps_then_reloads_on_create(self, sandbox):
+        assert config.get("serve.port") == 8787  # no file yet -> defaults
+        config.save({"serve": {"port": 7000}})
+        assert config.get("serve.port") == 7000
+
+
 class TestGet:
     def test_dotted_hit(self, sandbox):
         assert config.get("ai.model") == "claude-haiku-4-5-20251001"