boost-skill-cli 1.0.67__tar.gz → 1.0.68__tar.gz

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.67
+Version: 1.0.68
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/boost_cli/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.0.67'
-__version_tuple__ = version_tuple = (1, 0, 67)
+__version__ = version = '1.0.68'
+__version_tuple__ = version_tuple = (1, 0, 68)
 
 __commit_id__ = commit_id = None

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/boost_cli/commands/configuration.py

@@ -1147,14 +1147,21 @@ def cmd_self_update(argv) -> int:
         raise BoostError("boost is not running from a git checkout",
                         hint="git clone the boost repo and symlink bin")
     old = __version__
+    before = gitutil.head_commit(root)
     gitutil.run(["-C", str(root), "pull", "--ff-only"], timeout=120)
-    new = old
-    m = re.search(r"__version__\s*=\s*[\"']([^\"']+)[\"']",
-                  (root / "boost_cli" / "__init__.py").read_text())
-    if m:
-        new = m.group(1)
-    journal.log("self-update", new, previous=old)
-    if new != old:
+    after = gitutil.head_commit(root)
+    # The version is setuptools-scm derived — there is no `__version__ = "…"`
+    # literal to grep, and the build-time _version.py / installed metadata are
+    # stale until a reinstall. Ask git for the freshly-pulled version directly
+    # (mirrors boost_cli._detect_version()'s git-checkout fallback), and treat a
+    # moved HEAD as the unambiguous "an update landed" signal — independent of
+    # how the two version strings happen to be formatted.
+    new = gitutil.run(
+        ["-C", str(root), "describe", "--tags", "--always", "--dirty"],
+        check=False, timeout=10).stdout.strip().lstrip("v") or old
+    updated = bool(after) and after != before
+    journal.log("self-update", new if updated else old, previous=old)
+    if updated:
         out.ok("boost v%s → v%s" % (old, new))
     else:
         out.ok("already up to date (v%s)" % old)

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/boost_skill_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.67
+Version: 1.0.68
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

boost_skill_cli-1.0.68/docs/roadmap/items/fix-self-update-version-detection-dead-branch.md

@@ -0,0 +1,25 @@
+---
+id: fix-self-update-version-detection-dead-branch
+board: code
+section: shipped
+status: shipped
+category: Correctness
+complexity: S
+impact: High
+wow: 3
+note: broken headline command, now works
+order: 7
+owner: loop/self-update-fix
+pr:
+title: Fix <code>self-update</code> version detection (dead branch)
+---
+<code>boost self-update</code> greped <code>__init__.py</code> for a
+           <code>__version__ = "…"</code> literal that setuptools-scm never
+           writes, so the regex never matched and it always reported
+           <b>"already up to date"</b> — even after a pull brought a newer tag.
+           The success path was <em>unreachable</em>. It now derives the pulled
+           version straight from git (<code>describe --tags</code>, mirroring
+           <code>_detect_version()</code>) and treats a moved <code>HEAD</code>
+           as the "an update landed" signal, so the version-bump path finally
+           fires. Regression tests cover both the up-to-date and update-landed
+           branches.

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/docs/roadmap.html

@@ -115,7 +115,7 @@
   <section class="block reveal">
     <div class="stats">
       <!-- ROADMAP:stats -->
-      <div class="stat"><b>6</b><span>Shipped</span></div>
+      <div class="stat"><b>7</b><span>Shipped</span></div>
       <div class="stat"><b>3</b><span>Next up</span></div>
       <div class="stat"><b>4</b><span>Planned</span></div>
       <div class="stat"><b>84</b><span>Loop finds</span></div>
@@ -227,6 +227,27 @@
           <span class="m">Wow <b class="wow">★★★★</b></span>
         </div>
       </article>
+
+      <article class="cap rcard">
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Correctness</span></div>
+        <h3>Fix <code>self-update</code> version detection (dead branch)</h3>
+        <p><code>boost self-update</code> greped <code>__init__.py</code> for a
+           <code>__version__ = "…"</code> literal that setuptools-scm never
+           writes, so the regex never matched and it always reported
+           <b>"already up to date"</b> — even after a pull brought a newer tag.
+           The success path was <em>unreachable</em>. It now derives the pulled
+           version straight from git (<code>describe --tags</code>, mirroring
+           <code>_detect_version()</code>) and treats a moved <code>HEAD</code>
+           as the "an update landed" signal, so the version-bump path finally
+           fires. Regression tests cover both the up-to-date and update-landed
+           branches.</p>
+        <div class="meta">
+          <span class="m">Complexity <b>S</b></span>
+          <span class="m hi">Impact <b>High</b></span>
+          <span class="m">Wow <b class="wow">★★★</b></span>
+          <span class="m">broken headline command, now works</span>
+        </div>
+      </article>
       <!-- /ROADMAP:cards -->
 
     </div>
@@ -377,17 +398,6 @@
         </div>
       </article>
 
-      <article class="cap rcard">
-        <div class="head"><span class="pill next">Next</span><span class="cat">Correctness</span></div>
-        <h3>Fix <code>self-update</code> version detection (dead branch)</h3>
-        <p><code>cmd_self_update</code> greps <code>__init__.py</code> for a <code>__version__ = "…"</code> literal (<code>commands/configuration.py:1090</code>), but the constant is <code>_detect_version()</code> (setuptools-scm — no literal). The regex never matches, so it reports <b>"already up to date"</b> even after a pull brings a newer tag. The success path is unreachable.</p>
-        <div class="meta">
-          <span class="m">Complexity <b>S</b></span>
-          <span class="m hi">Impact <b>High</b></span>
-          <span class="m">Wow <b class="wow">★★★</b></span>
-        </div>
-      </article>
-
       <article class="cap rcard">
         <div class="head"><span class="pill next">Next</span><span class="cat">Correctness</span></div>
         <h3>Consolidate skill-staleness / drift logic into core</h3>

{boost_skill_cli-1.0.67 → boost_skill_cli-1.0.68}/tests/functional/test_cli_configuration.py

@@ -809,20 +809,54 @@ class TestSelfUpdate:
         assert "boost is not running from a git checkout" in r.err
         assert "git clone the boost repo" in r.err
 
-    def test_git_path_pulls_and_reports(self, boost, sandbox, monkeypatch):
+    def _fake_git(self, monkeypatch, *, before, after, described):
+        """Stub gitutil so self-update sees a controlled HEAD move + describe.
+
+        ``rev-parse HEAD`` returns ``before`` until the pull runs, ``after``
+        afterwards; ``describe`` returns ``described``; ``pull`` is a no-op.
+        """
         calls = []
+        pulled = {"done": False}
         monkeypatch.setattr("boost_cli.core.gitutil.is_repo", lambda p: True)
 
         def fake_run(args, **kw):
             calls.append(list(args))
+            if "pull" in args:
+                pulled["done"] = True
+                return _proc(args, 0)
+            if "rev-parse" in args:
+                return _proc(args, 0, out=(after if pulled["done"] else before))
+            if "describe" in args:
+                return _proc(args, 0, out=described)
             return _proc(args, 0)
 
         monkeypatch.setattr("boost_cli.core.gitutil.run", fake_run)
+        return calls
+
+    def test_reports_already_up_to_date_when_head_unchanged(
+            self, boost, sandbox, monkeypatch):
+        # HEAD is identical before and after the pull -> nothing landed
+        calls = self._fake_git(monkeypatch, before="sha1\n", after="sha1\n",
+                               described="v2.3.3\n")
         r = boost("self-update")
         root = paths.repo_root()
-        assert calls == [["-C", str(root), "pull", "--ff-only"]]
         from boost_cli import __version__
+        assert ["-C", str(root), "pull", "--ff-only"] in calls
         assert ("already up to date (v%s)" % __version__) in r.out
+        assert "→" not in r.out
+        ev = journal.events(action="self-update")[0]
+        assert ev["subject"] == __version__ and ev["previous"] == __version__
+
+    def test_reports_new_version_when_pull_advances_head(
+            self, boost, sandbox, monkeypatch):
+        # the pull fast-forwards HEAD -> report the git-described new version.
+        # This path was unreachable before the fix (the old code grepped
+        # __init__.py for a __version__ literal setuptools-scm never writes).
+        self._fake_git(monkeypatch, before="oldsha\n", after="newsha\n",
+                       described="v9.9.9\n")
+        r = boost("self-update")
+        from boost_cli import __version__
+        assert ("boost v%s → v9.9.9" % __version__) in r.out
         ev = journal.events(action="self-update")[0]
-        assert ev["subject"] == __version__
+        assert ev["subject"] == "9.9.9"          # git-derived, not the stale const
         assert ev["previous"] == __version__

boost_skill_cli-1.0.67/docs/roadmap/items/fix-self-update-version-detection-dead-branch.md

@@ -1,16 +0,0 @@
----
-id: fix-self-update-version-detection-dead-branch
-board: code
-section: internals
-status: next
-category: Correctness
-complexity: S
-impact: High
-wow: 3
-note: 
-order: 2
-owner:
-pr:
-title: Fix <code>self-update</code> version detection (dead branch)
----
-<code>cmd_self_update</code> greps <code>__init__.py</code> for a <code>__version__ = "…"</code> literal (<code>commands/configuration.py:1090</code>), but the constant is <code>_detect_version()</code> (setuptools-scm — no literal). The regex never matches, so it reports <b>"already up to date"</b> even after a pull brings a newer tag. The success path is unreachable.