boost-skill-cli 1.0.403__tar.gz → 1.0.404__tar.gz

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.403
+Version: 1.0.404
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/boost_cli/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.0.403'
-__version_tuple__ = version_tuple = (1, 0, 403)
+__version__ = version = '1.0.404'
+__version_tuple__ = version_tuple = (1, 0, 404)
 
 __commit_id__ = commit_id = None

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/boost_cli/commands/pkg.py

@@ -388,7 +388,18 @@ def cmd_install(argv: List[str]) -> int:
         multi = multi or len(entries) > 1
 
     if args.dry_run:
+        # TWO lists, because the three kinds do not reach the same agents.
+        # Rules and workflows materialize into every enabled agent's dotdir,
+        # Gemini included. A skill is symlinked only into the agents that take
+        # links — Gemini reads the canonical store directly and is deliberately
+        # never linked (see agents.linking_agents). One list for both is how
+        # `--dry-run` came to promise a `~/.gemini/skills` symlink that the real
+        # install has never created.
         targets = [a for a in agents.enabled_agents() if not only or a in only]
+        link_targets = [a for a in agents.linking_agents()
+                        if not only or a in only]
+        native_targets = [a for a in agents.native_store_agents()
+                          if not only or a in only]
         pbase = scopes.resolve_base(args.scope)
         if args.scope == scopes.SCOPE_PROJECT and pbase is None:
             raise BoostError(
@@ -423,7 +434,14 @@ def cmd_install(argv: List[str]) -> int:
                                                   e["version"], e["tap"]))
             out.info("  copy  %s → %s" % (_tilde(store.source_dir_for(e)),
                                           _tilde(store.skill_store_dir(e["name"]))))
-            out.info("  link  → %s" % (" · ".join(targets) or "(no enabled agents)"))
+            out.info("  link  → %s" % (" · ".join(link_targets)
+                                        or "(no linking agents)"))
+            # Mirrors what the real install reports, so a Gemini-only install
+            # does not read as reaching no agent at all.
+            if native_targets:
+                out.info("  available to %s (reads the store directly)"
+                         % " · ".join(agents.display_name(a)
+                                      for a in native_targets))
         out.info("dry run — nothing was changed")
         return 1 if failed else 0
 

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/boost_skill_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.403
+Version: 1.0.404
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/boost_skill_cli.egg-info/SOURCES.txt

@@ -213,6 +213,7 @@ docs/roadmap/items/dependency-cve-gate-pip-audit.md
 docs/roadmap/items/docsite-chrome-and-content-audit.md
 docs/roadmap/items/docstring-coverage-interrogate.md
 docs/roadmap/items/doctor-checks-rules-and-workflows.md
+docs/roadmap/items/dry-run-promised-a-link-nobody-makes.md
 docs/roadmap/items/end-of-options-guard-on-git-commands.md
 docs/roadmap/items/eval-corpus-cannot-see-real-retrieval.md
 docs/roadmap/items/eval-corpus-is-96x-smaller-than-a-real-install.md

boost_skill_cli-1.0.404/docs/roadmap/items/dry-run-promised-a-link-nobody-makes.md

@@ -0,0 +1,43 @@
+---
+id: dry-run-promised-a-link-nobody-makes
+board: code
+section: internals
+status: shipped
+category: Correctness
+complexity: S
+impact: Medium
+wow: 3
+note: the bug was written down in a test comment and pinned as "behaves today"
+order: 100
+owner: fix/dry-run-matches-the-real-install
+pr: 460
+title: install --dry-run predicted an install that never happens
+---
+<b>A preview has exactly one job, and this one got it wrong by an agent and a verb.</b>
+<code>boost install brainstorming --dry-run</code> reported
+<code>link&nbsp;&rarr;&nbsp;claude-code&nbsp;&middot;&nbsp;windsurf&nbsp;&middot;&nbsp;cursor&nbsp;&middot;&nbsp;gemini</code>.
+The real install reports three agents, plus a separate line saying Gemini reads the store directly
+&mdash; and <code>~/.gemini/skills</code> does not exist afterwards, because boost has never created
+it.
+
+<b>One list was doing two jobs.</b> The dry-run block computed a single set of targets from
+<code>agents.enabled_agents()</code> and printed it for both the skill <code>link</code> line and the
+rule/workflow <code>materialize</code> line. For rules and workflows that is right: they really are
+materialised into every enabled agent's dotdir, Gemini included. For a <i>skill</i> it is wrong,
+because Gemini implements the Agent Skills standard and discovers the canonical store itself, so it
+is configured <code>links_skills: false</code> and is deliberately never symlinked. CLAUDE.md is
+explicit &mdash; iterate <code>linking_agents()</code> for anything symlink-shaped.
+
+<b>The bug was already written down.</b> The functional test carried a comment saying so:
+"<i>the preview lists every enabled agent, so it still promises a gemini link the real install does
+not make &hellip; Pinned as it behaves today.</i>" Someone found it, understood it, described it
+accurately, and pinned the wrong behaviour rather than fixing it &mdash; which is how a known defect
+acquires a test that defends it.
+
+<b>Fixed as a distinction, not a deletion.</b> A skill's preview names the agents that take links and
+adds the same "available to Gemini CLI (reads the store directly)" line the real install prints; a
+rule's preview still names all four, because a rule genuinely reaches all four. A test now compares
+the two runs field by field &mdash; the preview's link list against the real install's &mdash;
+because <code>"a&nbsp;&middot;&nbsp;b&nbsp;&middot;&nbsp;c"</code> contains
+<code>"a&nbsp;&middot;&nbsp;b"</code>, so a substring assertion passes on exactly this bug. It was
+written as a substring first and caught nothing until it was tightened.

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/docs/roadmap.html

@@ -125,7 +125,7 @@
       <div class="stat"><b>16</b><span>Shipped</span></div>
       <div class="stat"><b>1</b><span>Next up</span></div>
       <div class="stat"><b>8</b><span>Planned</span></div>
-      <div class="stat"><b>216</b><span>Loop finds</span></div>
+      <div class="stat"><b>217</b><span>Loop finds</span></div>
       <!-- /ROADMAP:stats -->
     </div>
   </section>
@@ -3521,6 +3521,46 @@ ownership check reverted.</p></details>
           <span class="m">a dangling link is not garbage — an unmounted volume comes back, and heal deleted it anyway</span>
         </div>
       </article>
+
+      <article class="cap rcard" id="dry-run-promised-a-link-nobody-makes">
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Correctness</span></div>
+        <h3>install --dry-run predicted an install that never happens</h3>
+        <details class="cardbody"><summary>Write-up</summary>
+        <p><b>A preview has exactly one job, and this one got it wrong by an agent and a verb.</b>
+<code>boost install brainstorming --dry-run</code> reported
+<code>link&nbsp;&rarr;&nbsp;claude-code&nbsp;&middot;&nbsp;windsurf&nbsp;&middot;&nbsp;cursor&nbsp;&middot;&nbsp;gemini</code>.
+The real install reports three agents, plus a separate line saying Gemini reads the store directly
+&mdash; and <code>~/.gemini/skills</code> does not exist afterwards, because boost has never created
+it.
+
+<b>One list was doing two jobs.</b> The dry-run block computed a single set of targets from
+<code>agents.enabled_agents()</code> and printed it for both the skill <code>link</code> line and the
+rule/workflow <code>materialize</code> line. For rules and workflows that is right: they really are
+materialised into every enabled agent's dotdir, Gemini included. For a <i>skill</i> it is wrong,
+because Gemini implements the Agent Skills standard and discovers the canonical store itself, so it
+is configured <code>links_skills: false</code> and is deliberately never symlinked. CLAUDE.md is
+explicit &mdash; iterate <code>linking_agents()</code> for anything symlink-shaped.
+
+<b>The bug was already written down.</b> The functional test carried a comment saying so:
+"<i>the preview lists every enabled agent, so it still promises a gemini link the real install does
+not make &hellip; Pinned as it behaves today.</i>" Someone found it, understood it, described it
+accurately, and pinned the wrong behaviour rather than fixing it &mdash; which is how a known defect
+acquires a test that defends it.
+
+<b>Fixed as a distinction, not a deletion.</b> A skill's preview names the agents that take links and
+adds the same "available to Gemini CLI (reads the store directly)" line the real install prints; a
+rule's preview still names all four, because a rule genuinely reaches all four. A test now compares
+the two runs field by field &mdash; the preview's link list against the real install's &mdash;
+because <code>"a&nbsp;&middot;&nbsp;b&nbsp;&middot;&nbsp;c"</code> contains
+<code>"a&nbsp;&middot;&nbsp;b"</code>, so a substring assertion passes on exactly this bug. It was
+written as a substring first and caught nothing until it was tightened.</p></details>
+        <div class="meta">
+          <span class="m">Complexity <b>S</b></span>
+          <span class="m">Impact <b>Medium</b></span>
+          <span class="m">Wow <b class="wow">★★★</b></span>
+          <span class="m">the bug was written down in a test comment and pinned as "behaves today"</span>
+        </div>
+      </article>
       <!-- /ROADMAP:cards -->
 
     </div>

{boost_skill_cli-1.0.403 → boost_skill_cli-1.0.404}/tests/functional/test_cli_pkg.py

@@ -123,14 +123,47 @@ class TestInstall:
         r = boost("install", "--dry-run", "brainstorming")
         assert "would install brainstorming v1.4.0 from fixture-tap" in r.out
         assert "~/.boost/repos/fixture-tap/skills/brainstorming" in r.out
-        # NOTE: the preview lists every *enabled* agent, so it still promises a
-        # gemini link the real install does not make (gemini reads the store
-        # directly — see test_exact_report_lines). Pinned as it behaves today.
-        assert "link  → claude-code · windsurf · cursor · gemini" in r.out
+        # The preview names the agents that actually take a link. Gemini reads
+        # the canonical store directly and is never symlinked, so promising one
+        # here made the dry run wrong about the one thing it exists to predict.
+        assert "link  → claude-code · windsurf · cursor" in r.out
+        assert "· gemini" not in r.out
+        assert "available to Gemini CLI (reads the store directly)" in r.out
         assert "dry run — nothing was changed" in r.out
         assert not (paths.store_dir() / "brainstorming").exists()
         assert not paths.lockfile_path().exists()
 
+    def test_dry_run_predicts_the_real_install(self, boost, tapped):
+        """The whole job of a preview: say what the real run will do.
+
+        These two disagreed by one agent and one verb — `--dry-run` promised a
+        `~/.gemini/skills` symlink that no install has ever created.
+        """
+        def agents_on(text, marker):
+            line = next(x for x in text.splitlines() if marker in x)
+            return line.split("→", 1)[1].strip()
+
+        preview = boost("install", "--dry-run", "brainstorming").out
+        real = boost("install", "brainstorming").out
+        # Compared as whole fields, not substrings: "a · b · c" contains
+        # "a · b", so a substring check would have passed on the bug.
+        assert agents_on(preview, "link  →") == agents_on(real, "linked →")
+        for text in (preview, real):
+            assert "available to Gemini CLI (reads the store directly)" in text
+        assert not (paths.home() / ".gemini" / "skills").exists()
+
+    def test_dry_run_still_names_gemini_for_a_rule(self, boost, fixture_tap_src,
+                                                   tmp_path):
+        # The distinction is the point, not a blanket removal: a RULE really is
+        # materialized into ~/.gemini/, so the preview must keep saying so.
+        tap_dir = _copy_tap(fixture_tap_src, tmp_path / "rule-dry-tap")
+        _add_and_commit(tap_dir, "rules/house.mdc",
+                        "---\nname: house-style\nversion: 1.0.0\n---\n\nUse tabs.\n",
+                        "add rule")
+        boost("tap", tap_dir)
+        r = boost("install", "house-style", "--dry-run")
+        assert "materialize → claude-code · windsurf · cursor · gemini" in r.out
+
     def test_installs_declared_requires_closure(self, boost, tapped):
         # jira-integration declares `requires: [commit-messages]` in the fixture;
         # installing it must pull in the dependency, dependency-first.