boost-skill-cli 1.0.171__tar.gz → 1.0.173__tar.gz

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/CONTRIBUTING.md

@@ -54,6 +54,7 @@ auto-fixes straight back onto the branch.
 | `make mutation` | mutmut over `boost_cli/core`, **≥80% mutants killed** |
 | `ruff check boost_cli tests` | lint, zero findings |
 | `mypy` | type check, zero errors |
+| `pyright` | second type checker over `core/` — None-flow & narrowing, zero errors |
 | `lint-imports` | layering: `core/` imports no `commands/`/`cli`; CLI depends inward |
 | `vulture` | dead-code radar: no unused imports / unreachable code (confidence ≥80) |
 | `xenon` | complexity ratchet: aggregate cyclomatic complexity can't regress (avg ≤B) |

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/Makefile

@@ -14,7 +14,7 @@ EVAL_HOME := $(CURDIR)/.eval-home
 
 venv:
 	python3 -m venv $(VENV)
-	$(VENV)/bin/pip -q install pytest pytest-cov coverage mutmut ruff mypy codespell hypothesis import-linter diff-cover vulture xenon
+	$(VENV)/bin/pip -q install pytest pytest-cov coverage mutmut ruff mypy codespell hypothesis import-linter diff-cover vulture xenon pyright
 
 unit:
 	$(PYTEST) tests/unit -q
@@ -45,6 +45,7 @@ mutation:
 lint:
 	$(VENV)/bin/ruff check boost_cli tests
 	$(VENV)/bin/mypy
+	$(VENV)/bin/pyright
 	$(VENV)/bin/lint-imports
 	$(VENV)/bin/vulture boost_cli --min-confidence 80
 	$(VENV)/bin/xenon --max-absolute F --max-modules E --max-average B boost_cli

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.171
+Version: 1.0.173
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '1.0.171'
-__version_tuple__ = version_tuple = (1, 0, 171)
+__version__ = version = '1.0.173'
+__version_tuple__ = version_tuple = (1, 0, 173)
 
 __commit_id__ = commit_id = None

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/core/dense.py

@@ -194,6 +194,8 @@ def _delete_taps(con: sqlite3.Connection, taps: List[str]) -> None:
 def _embed_and_store(con: sqlite3.Connection, entries: List[dict],
                      tap_paths: Optional[Dict[str, Path]]) -> int:
     mod = _load()
+    if mod is None:          # [rag] extra absent — nothing to serialize into
+        return 0             # (callers fall back to BM25; see module docstring)
     rows: List[Tuple[dict, int, str]] = []   # (entry, chunk_ix, text)
     for e in entries:
         for ci, text in enumerate(_chunk_texts(e, tap_paths)):
@@ -226,7 +228,7 @@ def retrieve(query: str, k: int = 60, kind: Optional[str] = None,
         return None
     mod = _load()
     con = _connect()
-    if con is None:
+    if con is None or mod is None:
         return None
     try:
         pool = max(k * _POOL, 200)

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/core/mcp.py

@@ -115,9 +115,12 @@ def handle_request(req: dict, *, version: str,
         if text is None:
             resp["error"] = {"code": -32602, "message": "unknown tool %r" % tool}
         else:
-            resp["result"] = {"content": [{"type": "text", "text": text}]}
+            # Annotated: the literal alone infers a list-only value type, so
+            # adding the `isError` bool below would be a type error.
+            result: dict = {"content": [{"type": "text", "text": text}]}
             if is_err:
-                resp["result"]["isError"] = True
+                result["isError"] = True
+            resp["result"] = result
     else:
         resp["error"] = {"code": -32601, "message": "method not found: %s" % method}
     return resp

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/core/output.py

@@ -36,9 +36,12 @@ def harden_console_encoding() -> None:
     so skip a stream that doesn't have it rather than fail startup over it.
     """
     for stream in (sys.stdout, sys.stderr):
-        if hasattr(stream, "reconfigure"):
+        # getattr, not hasattr+call: same guard, but it also gives the type
+        # checkers a concrete optional to narrow (TextIO has no `reconfigure`).
+        reconfigure = getattr(stream, "reconfigure", None)
+        if callable(reconfigure):
             with contextlib.suppress(OSError, ValueError):
-                stream.reconfigure(encoding="utf-8", errors="replace")
+                reconfigure(encoding="utf-8", errors="replace")
 
 
 def use_color(stream=None) -> bool:

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/core/registry.py

@@ -56,8 +56,16 @@ def parse_spec(spec: str):
 
 
 def list_taps() -> List[Tap]:
+    # `or []`, not just the get() default: config.get returns the default only
+    # when the key is ABSENT, so a config.json carrying `"taps": null` (or any
+    # non-list scalar) would otherwise reach the comprehension and raise
+    # TypeError. A malformed config should read as "no taps", never crash every
+    # command that lists them.
+    taps = config.get("taps", []) or []
+    if not isinstance(taps, list):
+        return []
     return [Tap(name=t["name"], url=t.get("url", ""), curated=bool(t.get("curated")))
-            for t in config.get("taps", [])]
+            for t in taps if isinstance(t, dict) and t.get("name")]
 
 
 def get(name: str) -> Tap:

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_cli/core/serve.py

@@ -151,8 +151,12 @@ def route(path: str) -> Tuple[int, str, bytes]:
 class _CatalogHandler(BaseHTTPRequestHandler):
     server_version = "boost/" + __version__
 
-    def log_message(self, fmt, *args):  # logged in _send instead
-        pass
+    # `fmt`, not the base class's `format`: the stdlib only ever calls this
+    # positionally, and `format` would shadow the builtin (and read as an
+    # unused variable to vulture). The name-mismatch override warning is
+    # cosmetic here, so it's suppressed at the line rather than repo-wide.
+    def log_message(self, fmt, *args):  # pyright: ignore[reportIncompatibleMethodOverride]
+        pass  # request logging happens in _send instead
 
     def _send(self, status: int, ctype: str, body: bytes) -> None:
         self.send_response(status)

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/boost_skill_cli.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: boost-skill-cli
-Version: 1.0.171
+Version: 1.0.173
 Summary: boost — Homebrew for AI coding skills
 Author: Jonathan Reyes
 License: GNU GENERAL PUBLIC LICENSE

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/docs/roadmap/items/second-type-checker-pyright.md

@@ -2,15 +2,15 @@
 id: second-type-checker-pyright
 board: code
 section: pipeline
-status: planned
+status: shipped
 category: Testing · Type
 complexity: M
 impact: Med
 wow: 3
 note: editor-parity
 order: 6
-owner:
-pr:
+owner: loop/pyright
+pr: 196
 title: Second type checker — <code>pyright</code>
 ---
 Run Microsoft's <code>pyright</code> alongside mypy. Its independent

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/docs/roadmap.html

@@ -1246,7 +1246,7 @@ improvement is real (or isn't)."</p>
       </article>
 
       <article class="cap rcard">
-        <div class="head"><span class="pill planned">Planned</span><span class="cat">Testing · Type</span></div>
+        <div class="head"><span class="pill shipped">Shipped</span><span class="cat">Testing · Type</span></div>
         <h3>Second type checker — <code>pyright</code></h3>
         <p>Run Microsoft's <code>pyright</code> alongside mypy. Its independent
            inference catches <code>None</code>-flow and narrowing bugs the current

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/pyproject.toml

@@ -156,6 +156,21 @@ exclude_lines = [
     "raise NotImplementedError",
 ]
 
+# pyright: a SECOND type checker alongside mypy. Its independent inference
+# catches None-flow and narrowing bugs mypy's config lets slide — it found the
+# `"taps": null` crash in registry.list_taps() that mypy passed clean.
+# Scoped to boost_cli/core (the mutation-tested engine) so the gate is green and
+# meaningful today; widening to commands/ is tracked on the roadmap.
+# Dev/CI-only — never imported at runtime.
+[tool.pyright]
+include = ["boost_cli/core"]
+pythonVersion = "3.9"
+typeCheckingMode = "standard"
+# _version.py is generated by setuptools-scm at build time and absent from a
+# plain checkout (same carve-out as [tool.mypy]).
+ignore = ["boost_cli/_version.py"]
+reportMissingImports = false   # optional extras ([rag] sqlite_vec) resolve at runtime
+
 # import-linter: turn boost's assumed layering into an enforced contract, so a
 # cross-layer import can't silently erode the engine. Run by `make lint`
 # (lint-imports) and the CI lint job. Dev/CI-only — never imported at runtime.

{boost_skill_cli-1.0.171 → boost_skill_cli-1.0.173}/tests/unit/test_registry.py

@@ -115,6 +115,32 @@ class TestListAndGet:
     def test_list_taps_empty_by_default(self, sandbox):
         assert registry.list_taps() == []
 
+    def test_list_taps_survives_null_taps_key(self, sandbox):
+        """`"taps": null` must read as "no taps", not crash every command.
+
+        config.get returns its default only when the key is ABSENT, so an
+        explicit null reached the comprehension and raised TypeError
+        ('NoneType' object is not iterable) — found by pyright, not mypy.
+        """
+        cfg = config.load()
+        cfg["taps"] = None
+        config.save(cfg)
+        assert registry.list_taps() == []
+
+    @pytest.mark.parametrize("bogus", ["not-a-list", 42, {"name": "x"}])
+    def test_list_taps_ignores_non_list_taps(self, sandbox, bogus):
+        cfg = config.load()
+        cfg["taps"] = bogus
+        config.save(cfg)
+        assert registry.list_taps() == []
+
+    def test_list_taps_skips_malformed_entries(self, sandbox):
+        """A junk element must not take down the whole listing."""
+        cfg = config.load()
+        cfg["taps"] = [{"name": "good", "url": "https://x"}, "junk", {}, None]
+        config.save(cfg)
+        assert [t.name for t in registry.list_taps()] == ["good"]
+
     def test_get_exact_name(self, sandbox):
         self._seed()
         assert registry.get("owner/repo").name == "owner/repo"