blot-git 0.5.0__tar.gz → 0.6.0__tar.gz
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- {blot_git-0.5.0 → blot_git-0.6.0}/.pre-commit-hooks.yaml +1 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/CLAUDE.md +16 -8
- {blot_git-0.5.0 → blot_git-0.6.0}/PKG-INFO +6 -2
- {blot_git-0.5.0 → blot_git-0.6.0}/README.md +37 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/action.yml +1 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/README.md +3 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/RESULTS.md +33 -2
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/cases.json +31 -0
- blot_git-0.6.0/bench/labels/expressjs-express.json +246 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/labels/facebook-react.json +300 -0
- blot_git-0.6.0/bench/labels/psf-requests.json +216 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/docs/PRD.md +17 -4
- {blot_git-0.5.0 → blot_git-0.6.0}/docs/PYPI.md +5 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/pyproject.toml +1 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/__init__.py +1 -1
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/bench.py +14 -2
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/cli.py +42 -1
- blot_git-0.6.0/src/blot/guard.py +177 -0
- blot_git-0.6.0/src/blot/hooks.py +178 -0
- blot_git-0.6.0/tests/test_guard.py +160 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_why_github.py +18 -0
- blot_git-0.5.0/bench/labels/expressjs-express.json +0 -96
- blot_git-0.5.0/bench/labels/psf-requests.json +0 -86
- blot_git-0.5.0/src/blot/hooks.py +0 -77
- {blot_git-0.5.0 → blot_git-0.6.0}/.gitattributes +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/ISSUE_TEMPLATE/bench_case.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/ISSUE_TEMPLATE/bug_report.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/ISSUE_TEMPLATE/check_idea.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/pull_request_template.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/workflows/blot.yml +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/workflows/ci.yml +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.github/workflows/release.yml +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/.gitignore +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/CONTRIBUTING.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/LICENSE +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/demo/demo.gif +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/demo/make_demo.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/alert.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/faces.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/happy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/idle.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/sad.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/sleepy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/walk.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/blue/worried.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/build_sprites.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/alert.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/faces.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/happy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/idle.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/sad.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/sleepy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/walk.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/mustard/worried.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/alert.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/faces.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/happy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/idle.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/sad.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/sleepy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/walk.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/orange/worried.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/alert.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/faces.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/happy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/idle.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/sad.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/sleepy.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/walk.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/assets/sora/sage/worried.svg +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/labels/django-django.json +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/bench/labels/pallets-flask.json +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/docs/EXPLAINER.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/docs/competitors.md +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/__main__.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/checks/__init__.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/checks/base.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/checks/cochange.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/checks/readded_bug.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/checks/removed_fix.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/classify.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/config.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/diff.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/git.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/github.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/index.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/report.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/store.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/trace.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/src/blot/why.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/conftest.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_action.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_bench.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_checks.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_classify.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_cli.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_config.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_diff.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_git.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_hooks.py +0 -0
- {blot_git-0.5.0 → blot_git-0.6.0}/tests/test_index.py +0 -0
|
@@ -7,12 +7,12 @@ always changes with another (`forgot-related-file`). Mascot: Sora the slime. Own
|
|
|
7
7
|
|
|
8
8
|
## Layout
|
|
9
9
|
- `src/blot/`: stdlib-only on Python 3.11+ (3.10 also needs `tomli`; keep it that way)
|
|
10
|
-
- `cli.py` commands: index, check, why, install-hook, bench. `check`/`why` build/refresh the index themselves.
|
|
10
|
+
- `cli.py` commands: index, check, why, install-hook, guard, install-agent-hook, bench. `check`/`why` build/refresh the index themselves.
|
|
11
11
|
- `index.py` builds `.git/blot.db` (parallel `git log` slices for 2000+ commits); `store.py` SQLite schema v2
|
|
12
12
|
- `classify.py` fix severity 0/1/2 + refactor detection: most precision lives here
|
|
13
13
|
- `checks/` one file per check; `trace.py` blame that follows lines past refactor commits
|
|
14
|
-
- `why.py`, `github.py` (`index --github` via `gh api graphql`), `bench.py` (cases + `--replay N`)
|
|
15
|
-
- `bench/cases.json` scripted real-world cases (
|
|
14
|
+
- `guard.py` (Claude Code hook; installer in `hooks.py`), `why.py`, `github.py` (`index --github` via `gh api graphql`), `bench.py` (cases + `--replay N`)
|
|
15
|
+
- `bench/cases.json` scripted real-world cases (32/32); `bench/labels/` hand verdicts for every replay
|
|
16
16
|
warning on the 5 reference repos; `bench/RESULTS.md` replay numbers and precision
|
|
17
17
|
- `action.yml` GitHub Action; `.github/workflows/blot.yml` runs it on Blot's own PRs
|
|
18
18
|
- `assets/sora/build_sprites.py` and `assets/demo/make_demo.py` regenerate the mascot and demo GIF
|
|
@@ -22,7 +22,7 @@ always changes with another (`forgot-related-file`). Mascot: Sora the slime. Own
|
|
|
22
22
|
```bash
|
|
23
23
|
python -m venv .venv && .venv/Scripts/python -m pip install -e ".[dev]"
|
|
24
24
|
.venv/Scripts/python -m pytest -q
|
|
25
|
-
.venv/Scripts/blot bench --workdir <short path> # must stay
|
|
25
|
+
.venv/Scripts/blot bench --workdir <short path> # must stay 32/32
|
|
26
26
|
```
|
|
27
27
|
- Any change to `classify.py` or a check: on each of the 5 clones, checked out at the `head` in its
|
|
28
28
|
labels file, run `blot bench --replay 500 --labels bench/labels/<repo>.json --update-labels`. Keep a
|
|
@@ -50,11 +50,19 @@ python -m venv .venv && .venv/Scripts/python -m pip install -e ".[dev]"
|
|
|
50
50
|
- Writing code through bash heredocs mangles `\b`, `\n`, `\s`: use the Edit tool for regexes/strings.
|
|
51
51
|
- `gh api` paths: no leading slash (Git Bash rewrites it).
|
|
52
52
|
|
|
53
|
-
## State (2026-
|
|
54
|
-
- Released 0.
|
|
55
|
-
|
|
53
|
+
## State (2026-11-06)
|
|
54
|
+
- Released 0.6.0: checks, `why`, `--github`, agent guard (`blot guard` / `install-agent-hook`, tested
|
|
55
|
+
live in Claude Code 2026-11-06), bench/replay with labels, parallel indexing, pre-commit framework
|
|
56
|
+
support (`rev: v0.6.0`), GitHub Action (`uses: Sym-jay/Blot@v0.6.0`).
|
|
56
57
|
- Launch: dev.to post published 2026-10-24; the CVE sentence there should mention the withdrawn advisory.
|
|
57
|
-
- Open issues: #2–#6 (bench cases
|
|
58
|
+
- Open issues: #2–#4, #6 (bench cases); #33 (live guard report), #34 (quiet readded-bug case), #35–#36 (noise).
|
|
58
59
|
- Precision (0.5.0, measured 2026-10-30): 57/109 useful (52%); Django 1.19 / 10 commits, others ≤ 0.6.
|
|
59
60
|
`forgot-related-file` has 0 useful warnings in 45 labelled; candidate to become opt-in.
|
|
61
|
+
- `--github` measured (2026-11-01): precision unchanged (52.5%), +7 useful warnings, almost no demotions.
|
|
62
|
+
- Tried and dropped (2026-11-01): "fix word + PR number" as an offline fix rule: +85 warnings at 22%
|
|
63
|
+
useful. Don't retry it without a narrower signal (see bench/RESULTS.md).
|
|
64
|
+
- Agent guard (2026-11-04, branch `agent-guard`, unreleased): `blot guard` is a Claude Code PreToolUse
|
|
65
|
+
hook (`src/blot/guard.py`) running removed-fix + readded-bug on a proposed Edit/Write/MultiEdit;
|
|
66
|
+
`blot install-agent-hook` edits `.claude/settings.json`. Flask edit of `self_ref` warns in ~450 ms.
|
|
67
|
+
Not yet tried in a live Claude Code session.
|
|
60
68
|
- Next: remaining noise (renames, API swaps, added arguments, docstrings) in bench/RESULTS.md.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
Metadata-Version: 2.5
|
|
2
2
|
Name: blot-git
|
|
3
|
-
Version: 0.
|
|
3
|
+
Version: 0.6.0
|
|
4
4
|
Summary: A pre-commit check that has read your project's history: warns when a change removes a fix, re-adds a fixed bug, or forgets a file that always changes too.
|
|
5
5
|
Project-URL: Homepage, https://github.com/Sym-jay/Blot
|
|
6
6
|
Project-URL: Issues, https://github.com/Sym-jay/Blot/issues
|
|
@@ -46,6 +46,10 @@ blot why src/app.py:42 # which commit explains this line, skipping refactors
|
|
|
46
46
|
blot index --github # optional: issue/PR titles and labels via the gh CLI
|
|
47
47
|
```
|
|
48
48
|
|
|
49
|
-
|
|
49
|
+
**Guard coding agents.** `blot install-agent-hook` adds a Claude Code hook that runs the same checks on
|
|
50
|
+
an edit an agent is about to make, so the agent sees "this line exists because of fix 8efea0c" before
|
|
51
|
+
it "simplifies" it away. It warns by default; `--ask` makes Claude Code ask you first.
|
|
52
|
+
|
|
53
|
+
> **Status:** pre-alpha. All three checks work. Replayed on 500 recent commits each of Flask, requests, Express, Django and React, Blot warns on 0.6–9.5% of commits, and about half of its warnings (labelled by hand) are worth a reviewer's time; see the bench results on GitHub. Please report false alarms.
|
|
50
54
|
|
|
51
55
|
Meet Sora the slime, read the docs, or contribute on GitHub: https://github.com/Sym-jay/Blot
|
|
@@ -71,6 +71,42 @@ src/flask/app.py:355
|
|
|
71
71
|
|
|
72
72
|
`blot why FILE:LINE` (or `FILE:START-END`) finds the commit that explains a line, skipping commits that only moved it. Plain `git blame` stops at the refactor.
|
|
73
73
|
|
|
74
|
+
## Guard coding agents
|
|
75
|
+
|
|
76
|
+
Coding agents are the most likely to "clean up" a line they don't understand. `blot guard` is a
|
|
77
|
+
[Claude Code](https://code.claude.com/docs/en/hooks) `PreToolUse` hook on `Edit`, `Write` and `MultiEdit`:
|
|
78
|
+
it runs the `removed-fix` and `readded-bug` checks on the edit the agent is about to make, and hands any
|
|
79
|
+
finding to the agent as context:
|
|
80
|
+
|
|
81
|
+
```
|
|
82
|
+
blot: 1 warning
|
|
83
|
+
|
|
84
|
+
! removed-fix src/flask/app.py:355
|
|
85
|
+
You're removing or changing a line that a bug fix added.
|
|
86
|
+
Check that the bug it fixed can't come back.
|
|
87
|
+
8efea0c "Break reference cycle created by default in Flask instances." (2020-10-03)
|
|
88
|
+
traced past refactor 0ec7f71 "Split the App and Blueprint into Sansio and IO parts"
|
|
89
|
+
Run `blot why FILE:LINE` for the full history before you change it.
|
|
90
|
+
```
|
|
91
|
+
|
|
92
|
+
```bash
|
|
93
|
+
blot install-agent-hook # adds the hook to .claude/settings.json and builds the index
|
|
94
|
+
blot install-agent-hook --local # or .claude/settings.local.json, which isn't committed
|
|
95
|
+
blot install-agent-hook --ask # also ask you to approve edits that touch a fix
|
|
96
|
+
```
|
|
97
|
+
|
|
98
|
+
The hook command names this machine's Python by absolute path (like `install-hook`), so prefer `--local`
|
|
99
|
+
if your team commits `.claude/settings.json`. Remove it with `blot install-agent-hook --uninstall`
|
|
100
|
+
(add `--local` if you installed it there); other hooks in the file are left alone.
|
|
101
|
+
|
|
102
|
+
By default the guard only warns: Claude Code adds the warning to the agent's context with the edit's
|
|
103
|
+
result, and the normal permission flow is unchanged. With `--ask`, Claude Code stops before the edit and
|
|
104
|
+
asks you, showing the warning. The guard prints nothing when it has nothing to say, stays quiet for
|
|
105
|
+
files outside a git repo or not tracked at HEAD, and never blocks an edit because of its own errors. It
|
|
106
|
+
doesn't build a first index (that can take a minute): `install-agent-hook` does, or run `blot index`.
|
|
107
|
+
After that it refreshes the index incrementally. On Flask a guarded edit takes about 450 ms.
|
|
108
|
+
`forgot-related-file` is left out: it had no useful warnings among the 45 labelled in replays.
|
|
109
|
+
|
|
74
110
|
## Issue and PR titles (optional)
|
|
75
111
|
|
|
76
112
|
```bash
|
|
@@ -91,7 +127,7 @@ jobs:
|
|
|
91
127
|
blot:
|
|
92
128
|
runs-on: ubuntu-latest
|
|
93
129
|
steps:
|
|
94
|
-
- uses: Sym-jay/Blot@v0.
|
|
130
|
+
- uses: Sym-jay/Blot@v0.6.0
|
|
95
131
|
```
|
|
96
132
|
|
|
97
133
|
The action checks out the pull request with its full history, installs Blot, runs `blot index` and
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Run Blot on a pull request and show its findings as warning annotations.
|
|
2
2
|
# Usage (in a workflow triggered by pull_request):
|
|
3
|
-
# - uses: Sym-jay/Blot@v0.
|
|
3
|
+
# - uses: Sym-jay/Blot@v0.6.0
|
|
4
4
|
# See "Use in CI" in README.md.
|
|
5
5
|
name: Blot
|
|
6
6
|
description: History-aware checks on the commits of a pull request, shown as warning annotations
|
|
@@ -62,5 +62,8 @@ How to label:
|
|
|
62
62
|
|
|
63
63
|
Write a short `reason` either way; grouping noise by reason shows which rule to fix next.
|
|
64
64
|
|
|
65
|
+
Add `--github` to replay with issue and PR labels too, as after `blot index --github` (needs the
|
|
66
|
+
GitHub CLI logged in and a GitHub `origin` or `upstream` remote).
|
|
67
|
+
|
|
65
68
|
Target: **at most 1 warning per 10 commits**, and most of those should be worth reading.
|
|
66
69
|
See [RESULTS.md](RESULTS.md) for the latest numbers.
|
|
@@ -2,12 +2,12 @@
|
|
|
2
2
|
|
|
3
3
|
Measured 2026-10-30 with `blot bench`, on Windows 11, Python 3.12.
|
|
4
4
|
|
|
5
|
-
## Cases:
|
|
5
|
+
## Cases: 32/32 correct
|
|
6
6
|
|
|
7
7
|
| Check | Cases | Precision | Recall |
|
|
8
8
|
|---|---|---|---|
|
|
9
9
|
| removed-fix | 24 (16 warn, 8 quiet) | 100% | 100% |
|
|
10
|
-
| readded-bug |
|
|
10
|
+
| readded-bug | 5 (4 warn, 1 quiet) | 100% | 100% |
|
|
11
11
|
| forgot-related-file | 3 (3 quiet) | n/a | n/a |
|
|
12
12
|
|
|
13
13
|
A quiet case now fails if its scripted edit can't be applied (it used to pass without running).
|
|
@@ -74,6 +74,37 @@ code from earlier fixes and CVEs.
|
|
|
74
74
|
stays on, because the remaining warnings are rare (React only), but it is the first candidate to
|
|
75
75
|
become opt-in if real-world reports agree.
|
|
76
76
|
|
|
77
|
+
## Does `--github` help? (measured 2026-11-01)
|
|
78
|
+
|
|
79
|
+
`blot bench --replay 500 --github` reads issue and PR labels the way `blot index --github` does.
|
|
80
|
+
Flask, requests, Express and React track bugs on GitHub; Django's GitHub Issues are off (it uses
|
|
81
|
+
Trac), so it is unchanged. New warnings were labelled with the same rules.
|
|
82
|
+
|
|
83
|
+
| Repo | Without `--github` | With `--github` | Commits re-judged by labels |
|
|
84
|
+
|---|---|---|---|
|
|
85
|
+
| pallets/flask | 3/4 (75%) | 3/4 (75%) | 0 |
|
|
86
|
+
| psf/requests | 2/8 (25%) | **4/10 (40%)** | 15 upgraded |
|
|
87
|
+
| expressjs/express | 5/9 (56%) | 5/9 (56%) | 25 upgraded |
|
|
88
|
+
| facebook/react | 7/29 (24%) | **12/40 (30%)** | 154 upgraded, 4 demoted |
|
|
89
|
+
| **All five, with Django** | 57/109 (52.3%) | **64/122 (52.5%)** | |
|
|
90
|
+
|
|
91
|
+
**`--github` doesn't raise precision; it finds more useful warnings** (7 more, with 5 more noise).
|
|
92
|
+
Labels almost never demote a commit (4 of ~3,200 issues and PRs looked up). What they do is
|
|
93
|
+
upgrade commits like `ReactDOM: Fix missing form data ... (#28056)`, which Blot rates as unclear
|
|
94
|
+
without labels: "Fix" isn't at the start, and there's no "fixes #N" or strong defect word.
|
|
95
|
+
|
|
96
|
+
Caveat: labels are read as they are today, so a label added after a commit was made counts too.
|
|
97
|
+
|
|
98
|
+
### Tried and dropped: "a fix word plus a PR number" (2026-11-01)
|
|
99
|
+
|
|
100
|
+
Could a rule do offline what the `bug` label does? Rule tried: a fix word anywhere in the subject
|
|
101
|
+
plus an issue or PR number makes a commit a fix. It added **85 warnings** (React went from 0.60 to
|
|
102
|
+
1.95 per 10 commits), because almost every React and Express subject ends in its PR number. Of 46
|
|
103
|
+
labelled (all of requests' and Express's, 20 of React's), **10 were useful (22%)**. Most were
|
|
104
|
+
`fix(deps): …@^2.0.0` bumps, "Fix Flow type" commits and import lines. Overall precision would fall
|
|
105
|
+
from 52% to about 39%, so the rule was not kept. Its 46 labels stay in `labels/` for any narrower
|
|
106
|
+
attempt. A label written by a maintainer says more than a keyword can.
|
|
107
|
+
|
|
77
108
|
## Reproduce
|
|
78
109
|
|
|
79
110
|
```bash
|
|
@@ -408,5 +408,36 @@
|
|
|
408
408
|
"commit": "db8cb31"
|
|
409
409
|
},
|
|
410
410
|
"notes": "Changes load_dotenv's return behaviour that fix #2937 made consistent."
|
|
411
|
+
},
|
|
412
|
+
{
|
|
413
|
+
"id": "requests-readd-verify-https-condition",
|
|
414
|
+
"repo": "https://github.com/psf/requests",
|
|
415
|
+
"at": "af66521381d9e6806ca80b7e297b704e6a4966c9",
|
|
416
|
+
"file": "requests/adapters.py",
|
|
417
|
+
"replace": [
|
|
418
|
+
" if url.lower().startswith('https'):",
|
|
419
|
+
" if url.lower().startswith('https') and verify:"
|
|
420
|
+
],
|
|
421
|
+
"expect": {
|
|
422
|
+
"check": "readded-bug",
|
|
423
|
+
"warn": true,
|
|
424
|
+
"commit": "af66521"
|
|
425
|
+
},
|
|
426
|
+
"notes": "Re-adds the condition removed by fix #4025; this mirrors the later 00c6ad58 simplification. See https://github.com/psf/requests/issues/4025."
|
|
427
|
+
},
|
|
428
|
+
{
|
|
429
|
+
"id": "requests-quiet-black-auth-strip-formatting",
|
|
430
|
+
"repo": "https://github.com/psf/requests",
|
|
431
|
+
"at": "2d5517682b3b38547634d153cea43d48fbc8cdb5",
|
|
432
|
+
"file": "requests/sessions.py",
|
|
433
|
+
"replace": [
|
|
434
|
+
" if (not changed_scheme and old_parsed.port in default_port\n and new_parsed.port in default_port):",
|
|
435
|
+
" if (\n not changed_scheme\n and old_parsed.port in default_port\n and new_parsed.port in default_port\n ):"
|
|
436
|
+
],
|
|
437
|
+
"expect": {
|
|
438
|
+
"check": "readded-bug",
|
|
439
|
+
"warn": false
|
|
440
|
+
},
|
|
441
|
+
"notes": "Black's formatting change from 2a6f290b in should_strip_auth. Formatting only: must stay quiet."
|
|
411
442
|
}
|
|
412
443
|
]
|
|
@@ -0,0 +1,246 @@
|
|
|
1
|
+
{
|
|
2
|
+
"repo": "C:\\Users\\N Jayasankar\\AppData\\Local/Temp/wl/replay/express",
|
|
3
|
+
"head": "0dee2c52c7c873498f8ed7d8ee4ddd0a04d3ada8",
|
|
4
|
+
"labels": [
|
|
5
|
+
{
|
|
6
|
+
"sha": "a0276c6c9",
|
|
7
|
+
"subject": "Use mime-types for file to content type mapping",
|
|
8
|
+
"check": "removed-fix",
|
|
9
|
+
"path": "lib/response.js",
|
|
10
|
+
"line": 642,
|
|
11
|
+
"cited": "ae0b630",
|
|
12
|
+
"verdict": "useful",
|
|
13
|
+
"reason": "replaces the charset logic from fix #3303 with mime.contentType"
|
|
14
|
+
},
|
|
15
|
+
{
|
|
16
|
+
"sha": "490f1a173",
|
|
17
|
+
"subject": "lint: remove deprecated String.prototype.substr",
|
|
18
|
+
"check": "removed-fix",
|
|
19
|
+
"path": "lib/router/index.js",
|
|
20
|
+
"line": 291,
|
|
21
|
+
"cited": "99a369f",
|
|
22
|
+
"verdict": "noise",
|
|
23
|
+
"reason": "equivalent API swap (substr -> slice)"
|
|
24
|
+
},
|
|
25
|
+
{
|
|
26
|
+
"sha": "0def9bb65",
|
|
27
|
+
"subject": "Add \"root\" option to res.download",
|
|
28
|
+
"check": "removed-fix",
|
|
29
|
+
"path": "lib/response.js",
|
|
30
|
+
"line": 585,
|
|
31
|
+
"cited": "1150ca7",
|
|
32
|
+
"verdict": "useful",
|
|
33
|
+
"reason": "changes the path resolution that fix #2284 relied on"
|
|
34
|
+
},
|
|
35
|
+
{
|
|
36
|
+
"sha": "0867302dd",
|
|
37
|
+
"subject": "Prevent open redirect allow list bypass due to encodeurl",
|
|
38
|
+
"check": "removed-fix",
|
|
39
|
+
"path": "lib/response.js",
|
|
40
|
+
"line": 915,
|
|
41
|
+
"cited": "76eaa32",
|
|
42
|
+
"verdict": "useful",
|
|
43
|
+
"reason": "changes the URL encoding from fix #2897 (security follow-up)"
|
|
44
|
+
},
|
|
45
|
+
{
|
|
46
|
+
"sha": "89f198c6a",
|
|
47
|
+
"subject": "lib: use req.socket over deprecated req.connection (#6705)",
|
|
48
|
+
"check": "removed-fix",
|
|
49
|
+
"path": "lib/request.js",
|
|
50
|
+
"line": 285,
|
|
51
|
+
"cited": "11c74d7",
|
|
52
|
+
"verdict": "noise",
|
|
53
|
+
"reason": "equivalent API swap (req.connection -> req.socket)"
|
|
54
|
+
},
|
|
55
|
+
{
|
|
56
|
+
"sha": "89f198c6a",
|
|
57
|
+
"subject": "lib: use req.socket over deprecated req.connection (#6705)",
|
|
58
|
+
"check": "removed-fix",
|
|
59
|
+
"path": "lib/request.js",
|
|
60
|
+
"line": 290,
|
|
61
|
+
"cited": "20aa126",
|
|
62
|
+
"verdict": "noise",
|
|
63
|
+
"reason": "equivalent API swap (req.connection -> req.socket)"
|
|
64
|
+
},
|
|
65
|
+
{
|
|
66
|
+
"sha": "697547cde",
|
|
67
|
+
"subject": "Revert \"sec: security patch for CVE-2024-51999\"",
|
|
68
|
+
"check": "removed-fix",
|
|
69
|
+
"path": "lib/utils.js",
|
|
70
|
+
"line": 269,
|
|
71
|
+
"cited": "2f64f68",
|
|
72
|
+
"verdict": "useful",
|
|
73
|
+
"reason": "reverts the CVE-2024-51999 patch (deliberate; advisory later withdrawn)"
|
|
74
|
+
},
|
|
75
|
+
{
|
|
76
|
+
"sha": "697547cde",
|
|
77
|
+
"subject": "Revert \"sec: security patch for CVE-2024-51999\"",
|
|
78
|
+
"check": "readded-bug",
|
|
79
|
+
"path": "lib/utils.js",
|
|
80
|
+
"line": 269,
|
|
81
|
+
"cited": "2f64f68",
|
|
82
|
+
"verdict": "useful",
|
|
83
|
+
"reason": "reverts the CVE-2024-51999 patch (deliberate; advisory later withdrawn)"
|
|
84
|
+
},
|
|
85
|
+
{
|
|
86
|
+
"sha": "a08da78e6",
|
|
87
|
+
"subject": "deps: bump qs minimum to 6.15.2 (#7305)",
|
|
88
|
+
"check": "removed-fix",
|
|
89
|
+
"path": "package.json",
|
|
90
|
+
"line": 55,
|
|
91
|
+
"cited": "925a1df",
|
|
92
|
+
"verdict": "noise",
|
|
93
|
+
"reason": "raises the dependency floor past the fix's version, keeping the fix"
|
|
94
|
+
},
|
|
95
|
+
{
|
|
96
|
+
"sha": "9482b82d0",
|
|
97
|
+
"subject": "Invoke default with same arguments as types in res.format",
|
|
98
|
+
"check": "removed-fix",
|
|
99
|
+
"path": "lib/response.js",
|
|
100
|
+
"line": 700,
|
|
101
|
+
"cited": "1311f2a",
|
|
102
|
+
"verdict": "useful",
|
|
103
|
+
"reason": "changes how res.format calls the default handler from fix 1311f2a"
|
|
104
|
+
},
|
|
105
|
+
{
|
|
106
|
+
"sha": "b3906cbdd",
|
|
107
|
+
"subject": "fix(deps): serve-static@^2.1.0",
|
|
108
|
+
"check": "removed-fix",
|
|
109
|
+
"path": "package.json",
|
|
110
|
+
"line": 57,
|
|
111
|
+
"cited": "65b6206",
|
|
112
|
+
"verdict": "noise",
|
|
113
|
+
"reason": "dependency floor raised past the cited version"
|
|
114
|
+
},
|
|
115
|
+
{
|
|
116
|
+
"sha": "0c49926a9",
|
|
117
|
+
"subject": "fix(deps): send@^1.1.0",
|
|
118
|
+
"check": "removed-fix",
|
|
119
|
+
"path": "package.json",
|
|
120
|
+
"line": 56,
|
|
121
|
+
"cited": "ecf762f",
|
|
122
|
+
"verdict": "noise",
|
|
123
|
+
"reason": "dependency floor raised past the cited version"
|
|
124
|
+
},
|
|
125
|
+
{
|
|
126
|
+
"sha": "9f8589e31",
|
|
127
|
+
"subject": "cleanup: remove unnecessary require for global Buffer",
|
|
128
|
+
"check": "removed-fix",
|
|
129
|
+
"path": "lib/response.js",
|
|
130
|
+
"line": 15,
|
|
131
|
+
"cited": "c70197a",
|
|
132
|
+
"verdict": "noise",
|
|
133
|
+
"reason": "removes a require made unnecessary by Node's global Buffer"
|
|
134
|
+
},
|
|
135
|
+
{
|
|
136
|
+
"sha": "9f8589e31",
|
|
137
|
+
"subject": "cleanup: remove unnecessary require for global Buffer",
|
|
138
|
+
"check": "removed-fix",
|
|
139
|
+
"path": "lib/utils.js",
|
|
140
|
+
"line": 15,
|
|
141
|
+
"cited": "c70197a",
|
|
142
|
+
"verdict": "noise",
|
|
143
|
+
"reason": "removes a require made unnecessary by Node's global Buffer"
|
|
144
|
+
},
|
|
145
|
+
{
|
|
146
|
+
"sha": "d2de128a3",
|
|
147
|
+
"subject": "fix (deps): update deps (#6337)",
|
|
148
|
+
"check": "removed-fix",
|
|
149
|
+
"path": "package.json",
|
|
150
|
+
"line": 65,
|
|
151
|
+
"cited": "6a40af8",
|
|
152
|
+
"verdict": "noise",
|
|
153
|
+
"reason": "dependency range loosened, cited commit was a dev-deps bump"
|
|
154
|
+
},
|
|
155
|
+
{
|
|
156
|
+
"sha": "9e9714422",
|
|
157
|
+
"subject": "feat(deps): finalhandler@2.1.0 (#6373)",
|
|
158
|
+
"check": "removed-fix",
|
|
159
|
+
"path": "package.json",
|
|
160
|
+
"line": 45,
|
|
161
|
+
"cited": "accafc6",
|
|
162
|
+
"verdict": "noise",
|
|
163
|
+
"reason": "dependency floor raised past the cited version"
|
|
164
|
+
},
|
|
165
|
+
{
|
|
166
|
+
"sha": "f1a2dc884",
|
|
167
|
+
"subject": "deps: type-is@^2.0.1 (#6420)",
|
|
168
|
+
"check": "removed-fix",
|
|
169
|
+
"path": "package.json",
|
|
170
|
+
"line": 60,
|
|
171
|
+
"cited": "402e7f6",
|
|
172
|
+
"verdict": "noise",
|
|
173
|
+
"reason": "dependency floor raised past the cited version"
|
|
174
|
+
},
|
|
175
|
+
{
|
|
176
|
+
"sha": "00bb633ca",
|
|
177
|
+
"subject": "deps: qs@^6.14.1",
|
|
178
|
+
"check": "removed-fix",
|
|
179
|
+
"path": "package.json",
|
|
180
|
+
"line": 55,
|
|
181
|
+
"cited": "1e359f5",
|
|
182
|
+
"verdict": "noise",
|
|
183
|
+
"reason": "dependency floor raised past the cited version"
|
|
184
|
+
},
|
|
185
|
+
{
|
|
186
|
+
"sha": "f5c159b11",
|
|
187
|
+
"subject": "ci: build express with node.js v26 (#7218)",
|
|
188
|
+
"check": "removed-fix",
|
|
189
|
+
"path": "package.json",
|
|
190
|
+
"line": 75,
|
|
191
|
+
"cited": "d2de128",
|
|
192
|
+
"verdict": "noise",
|
|
193
|
+
"reason": "dev dependency bump; cited commit was a deps bump"
|
|
194
|
+
},
|
|
195
|
+
{
|
|
196
|
+
"sha": "cb19f0417",
|
|
197
|
+
"subject": "Upgrade `content-type` (#7234)",
|
|
198
|
+
"check": "removed-fix",
|
|
199
|
+
"path": "package.json",
|
|
200
|
+
"line": 38,
|
|
201
|
+
"cited": "d2de128",
|
|
202
|
+
"verdict": "noise",
|
|
203
|
+
"reason": "dependency bump; cited commit was a deps bump"
|
|
204
|
+
},
|
|
205
|
+
{
|
|
206
|
+
"sha": "59e205a57",
|
|
207
|
+
"subject": "Upgrade `content-disposition` (#7233)",
|
|
208
|
+
"check": "removed-fix",
|
|
209
|
+
"path": "package.json",
|
|
210
|
+
"line": 37,
|
|
211
|
+
"cited": "05f40f4",
|
|
212
|
+
"verdict": "noise",
|
|
213
|
+
"reason": "dependency bump past the cited version"
|
|
214
|
+
},
|
|
215
|
+
{
|
|
216
|
+
"sha": "9a34acf03",
|
|
217
|
+
"subject": "fix(res.send): preserve ETag generation with Transfer-Encoding (#7459)",
|
|
218
|
+
"check": "removed-fix",
|
|
219
|
+
"path": "lib/response.js",
|
|
220
|
+
"line": 168,
|
|
221
|
+
"cited": "18e5985",
|
|
222
|
+
"verdict": "useful",
|
|
223
|
+
"reason": "changes the Transfer-Encoding condition from fix #4893"
|
|
224
|
+
},
|
|
225
|
+
{
|
|
226
|
+
"sha": "9a34acf03",
|
|
227
|
+
"subject": "fix(res.send): preserve ETag generation with Transfer-Encoding (#7459)",
|
|
228
|
+
"check": "readded-bug",
|
|
229
|
+
"path": "lib/response.js",
|
|
230
|
+
"line": 166,
|
|
231
|
+
"cited": "18e5985",
|
|
232
|
+
"verdict": "useful",
|
|
233
|
+
"reason": "re-adds the condition that fix #4893 replaced"
|
|
234
|
+
},
|
|
235
|
+
{
|
|
236
|
+
"sha": "6d2df035a",
|
|
237
|
+
"subject": "build(deps-dev): bump supertest from 6.3.0 to 7.3.0 (#7494)",
|
|
238
|
+
"check": "removed-fix",
|
|
239
|
+
"path": "package.json",
|
|
240
|
+
"line": 79,
|
|
241
|
+
"cited": "d2de128",
|
|
242
|
+
"verdict": "noise",
|
|
243
|
+
"reason": "dev dependency bump; cited commit was a deps bump"
|
|
244
|
+
}
|
|
245
|
+
]
|
|
246
|
+
}
|