benchling-sdk 1.21.1__tar.gz → 1.21.2__tar.gz

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: benchling-sdk
-Version: 1.21.1
+Version: 1.21.2
 Summary: SDK for interacting with the Benchling Platform.
 License: Apache-2.0
 Author: Benchling Support

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/config/framework.py

@@ -228,7 +228,7 @@ class ConfigItemStore:
     _configuration_provider: ConfigProvider
     _configuration: Optional[List[ConfigurationReference]] = None
     _configuration_dict: Optional[Dict[ConfigItemPath, ConfigItemWrapper]] = None
-    _array_path_row_names: Dict[Tuple[str, ...], OrderedSet[str]] = dict()
+    _array_path_row_names: Dict[Tuple[str, ...], OrderedSet[str]]
 
     def __init__(self, configuration_provider: ConfigProvider):
         """
@@ -302,7 +302,7 @@ class ConfigItemStore:
                     # The +1 is the name of the array row
                     if len(config_item.path) >= len(path) + 1
                     # Ignoring flake8 error E203 because black keeps putting in whitespace padding :
-                    and config_item.path[0 : len(path_tuple)] == path  # noqa: E203
+                    and config_item.path[0 : len(path_tuple)] == path
                     and config_item.value is not None
                 ]
             )

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/config/helpers.py

@@ -1,6 +1,6 @@
 from datetime import datetime
 from enum import Enum
-from functools import lru_cache
+from functools import cache
 from typing import cast, List, Optional, Union
 
 from benchling_api_client.v2.beta.extensions import Enums
@@ -47,7 +47,8 @@ class _UnsupportedSubTypeError(Exception):
 
 
 class _ScalarConfigTypes(Enums.KnownString):
-    """Enum type copied from an earlier version of benchling-api-client, for internal use only.
+    """
+    Enum type copied from an earlier version of benchling-api-client, for internal use only.
 
     See BNCH-108704.
     """
@@ -65,12 +66,12 @@ class _ScalarConfigTypes(Enums.KnownString):
         return str(self.value)
 
     @staticmethod
-    @lru_cache(maxsize=None)
+    @cache
     def of_unknown(val: str) -> "_ScalarConfigTypes":
         if not isinstance(val, str):
             raise ValueError(f"Value of _ScalarConfigTypes must be a string (encountered: {val})")
         newcls = Enum("_ScalarConfigTypes", {"_UNKNOWN": val}, type=Enums.UnknownString)  # type: ignore
-        return cast(_ScalarConfigTypes, getattr(newcls, "_UNKNOWN"))
+        return cast(_ScalarConfigTypes, newcls._UNKNOWN)
 
 
 def _field_definitions_from_dependency(
@@ -122,7 +123,7 @@ def _enum_from_dependency(
 
 
 # TODO BNCH-57036 All element definitions currently deserialize to UnknownType. Hack around this temporarily
-def _fix_element_definition_deserialization(
+def _fix_element_definition_deserialization(  # noqa:PLR0911
     element: Union[UnknownType, _ArrayElementDependency]
 ) -> _ArrayElementDependency:
     if isinstance(element, UnknownType):

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/config/mock_config.py

@@ -345,7 +345,7 @@ def mock_text_app_config_item(path: List[str], value: Optional[str]) -> TextAppC
     )
 
 
-def _mock_dependency(
+def _mock_dependency(  # noqa:PLR0911
     dependency: ManifestDependencies,
     parent_path: Optional[List[str]] = None,
 ) -> List[AppConfigItem]:
@@ -451,7 +451,7 @@ def _convert_entity_subtype(manifest_subtype: SchemaDependencySubtypesBeta) -> S
     return SchemaDependencySubtypes(source_value)
 
 
-def _mock_scalar_dependency(
+def _mock_scalar_dependency(  # noqa:PLR0911
     dependency: ManifestScalarConfig, parent_path: Optional[List[str]] = None
 ) -> AppConfigItem:
     parent_path = parent_path if parent_path else []
@@ -502,7 +502,7 @@ def _mock_array_dependency(
 ) -> List[AppConfigItem]:
     config_rows = []
     parent_path = parent_path if parent_path else []
-    for i in range(rows):
+    for _ in range(rows):
         row = _mock_array_row(dependency, parent_path=parent_path)
         elements = _element_definition_from_dependency(dependency)
         element_configs = [_mock_dependency(element, row.path) for element in elements]
@@ -594,7 +594,7 @@ def _mock_linked_resource(id: str, name: Optional[str] = None) -> LinkedAppConfi
     return LinkedAppConfigResourceSummary(id=id, name=name if name else _random_string("Resource Name"))
 
 
-def _mock_scalar_value(
+def _mock_scalar_value(  # noqa:PLR0911
     dependency: ManifestScalarConfig,
 ) -> Union[bool, date, datetime, int, float, str, Dict[str, Union[str, float]]]:
     """Mock a scalar config value from its manifest definition."""

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/helpers/webhook_helpers.py

@@ -276,8 +276,8 @@ def _verify_timestamp(timestamp_header: str) -> None:
     now = datetime.now(tz=timezone.utc)
     try:
         timestamp = datetime.fromtimestamp(float(timestamp_header), tz=timezone.utc)
-    except Exception:
-        raise WebhookVerificationError("Invalid Signature Headers")
+    except Exception as exc:
+        raise WebhookVerificationError("Invalid Signature Headers") from exc
     if timestamp < (now - webhook_tolerance):
         raise WebhookVerificationError("Message timestamp too old")
     if timestamp > (now + webhook_tolerance):

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/status/framework.py

@@ -286,10 +286,7 @@ class SessionClosingContextExitHandler(SessionContextExitHandler):
         error_messages: Optional[Iterable[AppSessionMessageCreate]] = [
             AppSessionMessageCreate(_DEFAULT_APP_ERROR_MESSAGE, style=AppSessionMessageStyle.ERROR)
         ],
-        error_processors: List[Type[SessionContextErrorProcessor]] = [
-            AppUserFacingErrorProcessor,
-            BenchlingBadRequestErrorProcessor,
-        ],
+        error_processors: Optional[List[Type[SessionContextErrorProcessor]]] = None,
         enable_attached_canvas_on_error: bool = True,
     ):
         """
@@ -300,7 +297,10 @@ class SessionClosingContextExitHandler(SessionContextExitHandler):
         """
         self._success_messages = success_messages
         self._error_messages = error_messages
-        self._error_processors = error_processors
+        self._error_processors = error_processors or [
+            AppUserFacingErrorProcessor,
+            BenchlingBadRequestErrorProcessor,
+        ]
         self._enable_attached_canvas_on_error = enable_attached_canvas_on_error
 
     def on_success(self, context: SessionContextManager) -> bool:

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/apps/status/helpers.py

@@ -13,6 +13,7 @@ def ref(reference: ReferencedSessionLinkType) -> str:
     Example:
         dna_sequence = benchling.dna_sequences.get_by_id("seq_1234")
         AppSessionMessageCreate(f"This is my DNA sequence {ref(dna_sequence)} for analysis")
+
     """
     return ref_by_id(reference.id)
 
@@ -28,6 +29,7 @@ def ref_by_id(reference_id: str) -> str:
     Example:
         dna_sequence_id: str = "seq_asQya4lk"
         AppSessionMessageCreate(f"This is my DNA sequence {ref_by_id(dna_sequence_id)} for analysis")
+
     """
     assert reference_id, "reference_id cannot be empty or None"
     return _encode_id(reference_id)

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/auth/client_credentials_oauth2.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
 import base64
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, timezone
 from json import JSONDecodeError
 import threading
+import typing
 from typing import NoReturn, Optional
 from urllib.parse import urljoin
 
@@ -31,7 +32,7 @@ class Token:
 
     def valid(self) -> bool:
         """Return whether token is still valid for use or should be regenerated."""
-        return datetime.now() < self.refresh_time
+        return datetime.now(timezone.utc) < self.refresh_time
 
     @classmethod
     def from_token_response(cls, token_response) -> Token:
@@ -50,7 +51,7 @@ class Token:
         # Add in a buffer to safeguard against race conditions with token expiration.
         # Buffer is 10% of expires_in time, clamped between [1, MINIMUM_TOKEN_EXPIRY_BUFFER] seconds.
         refresh_delta = expires_in - max(1, min(MINIMUM_TOKEN_EXPIRY_BUFFER, expires_in * 0.1))
-        refresh_time = datetime.now() + timedelta(seconds=refresh_delta)
+        refresh_time = datetime.now(timezone.utc) + timedelta(seconds=refresh_delta)
         return cls(access_token, refresh_time)
 
 
@@ -62,7 +63,7 @@ class ClientCredentialsOAuth2(AuthorizationMethod):
     type.
     """
 
-    _data_for_token_request = {
+    _data_for_token_request: typing.ClassVar[dict] = {
         "grant_type": "client_credentials",
     }
 

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/benchling.py

@@ -96,7 +96,7 @@ _DEFAULT_BASE_PATH = "/api/v2"
 _DEFAULT_RETRY_STRATEGY = RetryStrategy()
 
 
-class Benchling(object):
+class Benchling:
     """
     A facade for interactions with the Benchling platform.
 
@@ -213,7 +213,7 @@ class Benchling(object):
 
         See https://benchling.com/api/reference#/Apps
         and https://docs.benchling.com/docs/getting-started-benchling-apps
-        """
+        """  # noqa:RUF002  # Ruff gets confused by a trailing apostrophe with a plural noun
         return self.v2.stable.apps
 
     @property

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/errors.py

@@ -26,7 +26,8 @@ logger = default_logger()
 
 @dataclass
 class BenchlingError(Exception):
-    """An error resulting from communicating with the Benchling API.
+    """
+    An error resulting from communicating with the Benchling API.
 
     This could be an error returned from the API intentionally (e.g., 400 Bad Request) or an
     unexpected transport error (e.g., 502 Bad Gateway)
@@ -53,7 +54,7 @@ class BenchlingError(Exception):
     ]
 
     @classmethod
-    def from_response(cls, response: Response) -> "BenchlingError":
+    def from_response(cls, response: Response) -> BenchlingError:
         """Create a BenchlingError from a generated Response."""
         json_body = _parse_error_body(response.content)
         return cls(
@@ -95,7 +96,7 @@ class RegistrationError(Exception):
     task_status: Optional[AsyncTaskStatus] = None
 
     @classmethod
-    def from_task(cls, task: AsyncTask) -> "RegistrationError":
+    def from_task(cls, task: AsyncTask) -> RegistrationError:
         """Create a RegistrationError from a failed AsyncTask."""
         task_errors = unset_as_none(task.errors)
         errors_dict: Dict[Any, Any] = task_errors.to_dict() if task_errors else dict()  # type: ignore

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/helpers/retry_helpers.py

@@ -14,7 +14,7 @@ logging.getLogger("backoff").setLevel(logging.CRITICAL)
 
 
 @dataclass(frozen=True, eq=True)
-class RetryStrategy(object):
+class RetryStrategy:
     """Specify a strategy for automatically retrying failed HTTP calls."""
 
     # Passing in None results in unbounded retries

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/helpers/serialization_helpers.py

@@ -29,7 +29,8 @@ class SerializableModel(DataClassJsonMixin):
 
 @dataclass
 class DeserializableModel(DataClassJsonMixin):
-    """Provide an interface for deserialization to a custom model.
+    """
+    Provide an interface for deserialization to a custom model.
 
     For deserializing models when using raw API calls (e.g., Benchling.api)
     Override deserialize() for customized behavior.
@@ -50,7 +51,8 @@ class DeserializableModelNoContent(DeserializableModel):
 
 
 def optional_array_query_param(inputs: Optional[Iterable[str]]) -> Optional[str]:
-    """Collapse an Iterable to a comma-separated string if present.
+    """
+    Collapse an Iterable to a comma-separated string if present.
 
     Add leading and trailing quotes if the item contains "," and not quoted
     """
@@ -58,7 +60,8 @@ def optional_array_query_param(inputs: Optional[Iterable[str]]) -> Optional[str]
 
 
 def array_query_param(inputs: Iterable[str]) -> str:
-    """Collapse an Iterable to a comma-separated string.
+    """
+    Collapse an Iterable to a comma-separated string.
 
     Add leading and trailing quotes if the item contains "," and not quoted
     """

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/helpers/task_helpers.py

@@ -37,7 +37,8 @@ EMPTY_TASK_RESPONSE = EmptyTaskResponse()
 
 
 class TaskHelper(AsyncTaskLink, Generic[ResponseT]):
-    """Used by Benchling async task endpoints to provide the task response in an appropriate type.
+    """
+    Used by Benchling async task endpoints to provide the task response in an appropriate type.
 
     In the API spec, endpoints that create a long-running task are defined as returning an
     :py:class:`benchling_sdk.models.AsyncTaskLink`, which can be used with
@@ -70,12 +71,13 @@ class TaskHelper(AsyncTaskLink, Generic[ResponseT]):
 
         if response_class is not EmptyTaskResponse:
             assert hasattr(response_class, "from_dict")
-            self._response_decoder = getattr(response_class, "from_dict")
+            self._response_decoder = getattr(response_class, "from_dict")  # noqa: B009
 
     def wait_for_completion(
         self, interval_wait_seconds: int = 1, max_wait_seconds: int = 600
     ) -> TaskCompletion[ResponseT]:
-        """Wait for the task to succeed or fail.
+        """
+        Wait for the task to succeed or fail.
 
         This is equivalent to the :py:meth:`benchling_sdk.services.v2.stable.task_service.TaskService.wait_for_task`
         method in :py:class:`benchling_sdk.services.v2.stable.task_service.TaskService`, except that
@@ -116,7 +118,8 @@ class TaskHelper(AsyncTaskLink, Generic[ResponseT]):
         )
 
     def wait_for_response(self, interval_wait_seconds: int = 1, max_wait_seconds: int = 600) -> ResponseT:
-        """Wait for the task and return the response object on success, or raise an exception on failure.
+        """
+        Wait for the task and return the response object on success, or raise an exception on failure.
 
         This is a convenience method for calling :py:meth:`wait_for_completion` and then getting the
         `response` property of the returned object if the task succeeded, in cases where you're not

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/base_service.py

@@ -1,5 +1,5 @@
 from abc import ABC
-from typing import Type, TYPE_CHECKING
+from typing import Optional, Type, TYPE_CHECKING
 
 from benchling_api_client.v2.stable.client import Client
 from benchling_api_client.v2.types import Response
@@ -17,7 +17,7 @@ class BaseService(ABC):
     _client: Client
     _retry_strategy: RetryStrategy
 
-    def __init__(self, client: Client, retry_strategy: RetryStrategy = RetryStrategy()):
+    def __init__(self, client: Client, retry_strategy: Optional[RetryStrategy] = None):
         """
         Initialize a service.
 
@@ -25,7 +25,7 @@ class BaseService(ABC):
         :param retry_strategy: Retry strategy for failed HTTP calls
         """
         self._client = client
-        self._retry_strategy = retry_strategy
+        self._retry_strategy = retry_strategy or RetryStrategy()
 
     @property
     def client(self) -> Client:
@@ -38,7 +38,8 @@ class BaseService(ABC):
         return self._retry_strategy
 
     def _create_service(self, cls):
-        """Instantiate a service that derives from BaseService, with the same properties as this service.
+        """
+        Instantiate a service that derives from BaseService, with the same properties as this service.
 
         Override this in alpha and beta services that use a client other than self._client.
         """

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/beta/v2_beta_data_frame_service.py

@@ -72,7 +72,8 @@ class V2BetaDataFrameService(BaseService):
         input_bytes: Union[BytesIO, bytes],
         timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME,
     ) -> None:
-        """Upload bytes to an existing data frame.
+        """
+        Upload bytes to an existing data frame.
 
         :param url: The url provided by Benchling for uploading to the data frame
         :param input_bytes: Data to upload as bytes or BytesIO
@@ -90,7 +91,8 @@ class V2BetaDataFrameService(BaseService):
     def upload_file(
         self, url: str, file: Path, timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME
     ) -> None:
-        """Upload a file to an existing data frame.
+        """
+        Upload a file to an existing data frame.
 
         :param url: The url provided by Benchling for uploading to the data frame
         :param file: A valid Path to an existing file containing the data to upload
@@ -115,7 +117,8 @@ class V2BetaDataFrameService(BaseService):
         input_bytes: Union[BytesIO, bytes],
         timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME,
     ) -> TaskHelper[DataFrame]:
-        """Create a data frame from bytes or BytesIO data.
+        """
+        Create a data frame from bytes or BytesIO data.
 
         :param data_frame: The DataFrameCreate specification for the data. This must be provided, as it cannot be inferred from file names.
         :param input_bytes: Data to upload as bytes or BytesIO
@@ -151,7 +154,8 @@ class V2BetaDataFrameService(BaseService):
         data_frame: Optional[DataFrameCreate] = None,
         timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME,
     ) -> TaskHelper[DataFrame]:
-        """Create a data frame from file data.
+        """
+        Create a data frame from file data.
 
         :param file: A valid Path to an existing file containing the data to upload
         :param data_frame: The DataFrameCreate specification for the data. If not provided, it will be inferred from the file name
@@ -178,7 +182,8 @@ class V2BetaDataFrameService(BaseService):
     def download_data_frame_bytes(
         self, data_frame: DataFrame, timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME
     ) -> List[BytesIO]:
-        """Download data frame data to bytes.
+        """
+        Download data frame data to bytes.
 
         :param data_frame: The data frame to download
         :param timeout_seconds: Extends the normal HTTP timeout settings since DataFrame uploads can be large
@@ -211,7 +216,8 @@ class V2BetaDataFrameService(BaseService):
         destination_path: Optional[Path] = None,
         timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME,
     ) -> List[Path]:
-        """Download data frame data to files.
+        """
+        Download data frame data to files.
 
         :param data_frame: The data frame to download
         :param destination_path: A target directory to place the files. File names will be created based on the manifest item file names.
@@ -252,7 +258,8 @@ class V2BetaDataFrameService(BaseService):
     def download_data_frame_bytes_by_id(
         self, data_frame_id: str, timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME
     ) -> List[BytesIO]:
-        """Download data frame data to files by data_frame_id.
+        """
+        Download data frame data to files by data_frame_id.
 
         Fetches the data frame first, then downloads the files.
 
@@ -272,7 +279,8 @@ class V2BetaDataFrameService(BaseService):
         destination_path: Optional[Path] = None,
         timeout_seconds: float = _DEFAULT_HTTP_TIMEOUT_UPLOAD_DATA_FRAME,
     ) -> List[Path]:
-        """Download data frame data to files by data_frame_id.
+        """
+        Download data frame data to files by data_frame_id.
 
         Fetches the data frame first, then downloads the files.
 

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/stable/blob_service.py

@@ -46,7 +46,8 @@ DEFAULT_CHUNK_SIZE_BYTES: int = MINIMUM_CHUNK_SIZE_BYTES
 
 
 def _write_blob_file(file_contents: BytesIO, file_path: Optional[Path] = None) -> Path:
-    """Write bytes to a file. Will create a temp file if file_path isn't specified.
+    """
+    Write bytes to a file. Will create a temp file if file_path isn't specified.
 
     Returns the Path of the file written to, whether created or used.
     """
@@ -114,7 +115,8 @@ class BlobService(BaseService):
         timeout_seconds: float = DEFAULT_HTTP_TIMEOUT,
         chunk_size_bytes: int = DEFAULT_CHUNK_SIZE_BYTES,
     ) -> Blob:
-        """Create a Benchling Blob from bytes or a BytesIO stream.
+        """
+        Create a Benchling Blob from bytes or a BytesIO stream.
 
         Will automatically attempt a multi-part upload if the stream appears larger
         than the API's maximum size for single Blobs.
@@ -172,7 +174,8 @@ class BlobService(BaseService):
         timeout_seconds: float = DEFAULT_HTTP_TIMEOUT,
         chunk_size_bytes: int = DEFAULT_CHUNK_SIZE_BYTES,
     ) -> Blob:
-        """Create a Benchling Blob from a file.
+        """
+        Create a Benchling Blob from a file.
 
         Will automatically attempt a multi-part upload if the file appears larger
         than the API's maximum size for single Blobs.

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/stable/organization_service.py

@@ -157,7 +157,8 @@ class OrganizationService(BaseService):
         role: Optional[str] = None,
         page_size: Optional[int] = None,
     ) -> PageIterator[MembershipsPaginatedList]:
-        """Return all organization memberships in the given organization.
+        """
+        Return all organization memberships in the given organization.
 
         See https://benchling.com/api/reference#/Organizations/listOrganizationMemberships
         """
@@ -169,7 +170,8 @@ class OrganizationService(BaseService):
 
     @api_method
     def get_membership(self, organization_id: str, user_id: str) -> Membership:
-        """Get organization membership.
+        """
+        Get organization membership.
 
         See https://benchling.com/api/reference#/Organizations/getOrganizationMembership
         """
@@ -180,7 +182,8 @@ class OrganizationService(BaseService):
 
     @api_method
     def create_membership(self, organization_id: str, membership: MembershipCreate) -> Membership:
-        """Create organization membership.
+        """
+        Create organization membership.
 
         See https://benchling.com/api/reference#/Organizations/createOrganizationMembership
         """
@@ -195,7 +198,8 @@ class OrganizationService(BaseService):
     def update_membership(
         self, organization_id: str, user_id: str, membership: MembershipUpdate
     ) -> Membership:
-        """Update organization membership by user ID and organization ID.
+        """
+        Update organization membership by user ID and organization ID.
 
         See https://benchling.com/api/reference#/Organizations/updateOrganizationMembership
         """
@@ -209,7 +213,8 @@ class OrganizationService(BaseService):
 
     @api_method
     def delete_membership(self, organization_id: str, user_id: str) -> None:
-        """Delete a single team membership.
+        """
+        Delete a single team membership.
 
         See https://benchling.com/api/reference#/Organizations/deleteOrganizationMembership
         """

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/stable/team_service.py

@@ -139,7 +139,8 @@ class TeamService(BaseService):
 
     @api_method
     def create(self, team: TeamCreate) -> Team:
-        """Create team.
+        """
+        Create team.
 
         See https://benchling.com/api/reference#/Teams/createTeam
         """
@@ -148,7 +149,8 @@ class TeamService(BaseService):
 
     @api_method
     def update(self, team_id: str, team: TeamUpdate) -> Team:
-        """Update team.
+        """
+        Update team.
 
         See https://benchling.com/api/reference#/Teams/updateTeam
         """
@@ -179,7 +181,8 @@ class TeamService(BaseService):
         role: Optional[str] = None,
         page_size: Optional[int] = None,
     ) -> PageIterator[MembershipsPaginatedList]:
-        """Return all team memberships in the given team.
+        """
+        Return all team memberships in the given team.
 
         See https://benchling.com/api/reference#/Teams/listTeamMemberships
         """
@@ -191,7 +194,8 @@ class TeamService(BaseService):
 
     @api_method
     def get_membership(self, team_id: str, user_id: str) -> Membership:
-        """Get team membership.
+        """
+        Get team membership.
 
         See https://benchling.com/api/reference#/Teams/getTeamMembership
         """
@@ -200,7 +204,8 @@ class TeamService(BaseService):
 
     @api_method
     def create_membership(self, team_id: str, membership: MembershipCreate) -> Membership:
-        """Create team membership for the given user, role, and team.
+        """
+        Create team membership for the given user, role, and team.
 
         See https://benchling.com/api/reference#/Teams/createTeamMembership
         """
@@ -213,7 +218,8 @@ class TeamService(BaseService):
 
     @api_method
     def update_membership(self, team_id: str, user_id: str, membership: MembershipUpdate) -> Membership:
-        """Update a single team membership.
+        """
+        Update a single team membership.
 
         See https://benchling.com/api/reference#/Teams/updateTeamMembership
         """
@@ -227,7 +233,8 @@ class TeamService(BaseService):
 
     @api_method
     def delete_membership(self, team_id: str, user_id: str) -> None:
-        """Delete a single team membership.
+        """
+        Delete a single team membership.
 
         See https://benchling.com/api/reference#/Teams/deleteTeamMembership
         """

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/v2_alpha_service.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from functools import cached_property
-from typing import TYPE_CHECKING
+from typing import Optional, TYPE_CHECKING
 
 from benchling_api_client.v2.stable.client import Client
 
@@ -26,7 +26,7 @@ class V2AlphaService(BaseService):
 
     _alpha_client: Client
 
-    def __init__(self, client: Client, retry_strategy: RetryStrategy = RetryStrategy()):
+    def __init__(self, client: Client, retry_strategy: Optional[RetryStrategy] = None):
         """
         Initialize a v2-alpha service.
 

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/v2_beta_service.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from functools import cached_property
-from typing import TYPE_CHECKING
+from typing import Optional, TYPE_CHECKING
 
 from benchling_api_client.v2.stable.client import Client
 
@@ -33,7 +33,7 @@ class V2BetaService(BaseService):
 
     _beta_client: Client
 
-    def __init__(self, client: Client, retry_strategy: RetryStrategy = RetryStrategy()):
+    def __init__(self, client: Client, retry_strategy: Optional[RetryStrategy] = None):
         """
         Initialize a v2-beta service.
 

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2/v2_stable_service.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from functools import cached_property
-from typing import TYPE_CHECKING
+from typing import Optional, TYPE_CHECKING
 
 from benchling_api_client.v2.stable.client import Client
 
@@ -70,7 +70,7 @@ class V2StableService(BaseService):
     Namespace containing support for the V2 stable endpoints of the Benchling API.
     """
 
-    def __init__(self, client: Client, retry_strategy: RetryStrategy = RetryStrategy()):
+    def __init__(self, client: Client, retry_strategy: Optional[RetryStrategy] = None):
         """
         Initialize a service.
 
@@ -117,7 +117,7 @@ class V2StableService(BaseService):
 
         See https://benchling.com/api/reference#/Apps
         and https://docs.benchling.com/docs/getting-started-benchling-apps
-        """
+        """  # noqa:RUF002  # Ruff gets confused by a trailing apostrophe with a plural noun
         from .stable.app_service import AppService
 
         return self._create_service(AppService)

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/benchling_sdk/services/v2_service.py

@@ -25,7 +25,7 @@ class V2Service(BaseService):
     _v2_alpha_service: Optional[V2AlphaService]
     _v2_beta_service: Optional[V2BetaService]
 
-    def __init__(self, client: Client, retry_strategy: RetryStrategy = RetryStrategy()):
+    def __init__(self, client: Client, retry_strategy: Optional[RetryStrategy] = None):
         """
         Initialize a service.
 

{benchling_sdk-1.21.1 → benchling_sdk-1.21.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "benchling-sdk"
-version = "1.21.1"   # NOTE: This version number is ignored and does not correspond to releases (see README)
+version = "1.21.2"   # NOTE: This version number is ignored and does not correspond to releases (see README)
 description = "SDK for interacting with the Benchling Platform."
 authors = ["Benchling Support <support@benchling.com>"]
 packages = [{include = "benchling_sdk"}]
@@ -98,46 +98,23 @@ exclude = [
 [tool.ruff.lint]
 select = ["D", "E", "F", "I", "UP", "B", "PL", "RUF"]
 ignore = [
+    # rules we really don't care about
     "D100",  # don't require docstring for modules
     "D104",  # don't require docstring for public packages
     "D105",  # don't require docstring for magic methods
     "D203",  # don't require blank line before class docstring
-    "D211",  # no-blank-line-before-class
-    "D212",  # multi-line-summary-first-line
-    "D213",  # multi-line-summary-second-line
-    "D413",  # don't require blank line after docstring section
-
-    "E501",
-    "PLR0913",
-    "PLR2004",
+    "D212",  # don't move first line of multi-line docstring to be immediately after the quotes
+    "E731",  # don't need to rewrite lambdas as inner function defs
+    "PLR0913",  # don't complain about "too many arguments" for methods
+    "PLR2004",  # don't require numbers like 200 to be declared as constants
+    "UP015", # it's ok to pass "r" as the mode to open(), even though that's the default
 
     # rules that we can unignore once we've made some code updates:
-    "B006",
-    "B007",
-    "B008",
-    "B009",
-    "B010",
-    "B018",
-    "B028",
-    "B904",
-    "E721",
-    "E731",
-    "PLR0911",
-    "PLW2901",
-    "RUF002",
-    "RUF005",
-    "RUF012",
-    "RUF019",
-    "RUF100",
-    "UP004",
-    "UP006",
-    "UP007",
-    "UP012",
-    "UP015",
-    "UP018",
-    "UP033",
-    "UP037",
-    "UP035",
+    "E501",   # line too long - we could fix this in most code, just not generated code
+    "RUF005", # replace "list_expr + [new_value]" with "[*list_expr, new_value]"
+    "UP006",  # use list[], dict[], and type[] as types instead of typing.List etc.
+    "UP007",  # replace Optional & Union with pipe operator - requires __future__.annotations
+    "UP035",  # more unnecessary imports from typing module
 ]
 
 [tool.ruff.lint.isort]
@@ -149,6 +126,9 @@ known-third-party=["attr", "backoff", "benchling_api_client", "benchling_jira_ap
 order-by-type=false
 
 [tool.ruff.lint.per-file-ignores]
+"benchling_sdk/models/*" = [
+    "E501",  # line too long - we always want to disable this for generated models
+]
 "tests/*" = [
     "D100", "D101", "D102", "D104", "D106", "D107",  # missing docstrings
     "PLR2004",