belote-cli 3.3.3__tar.gz → 3.3.4__tar.gz

{belote_cli-3.3.3 → belote_cli-3.3.4}/CHANGELOG.md

@@ -5,6 +5,31 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.3.4] - 2026-05-10
+
+Portability release — removes all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode was unaffected on the same Alpine box (it never imported `play_sound`), and Kubuntu / Lubuntu 24.10 / 25.10 (glibc) were unaffected in either mode. Rather than guard the BEL writes behind a libc-detection flag, the entire sound subsystem is removed: classic Belote and BelAtro now share the same "no bells" baseline. 549 tests still passing, ruff and mypy strict still clean.
+
+### Removed
+
+- **`src/belote/ui/announce.py::play_sound`** — terminal-bell helper (writes `\a` bytes for `trick` / `belote` / `declaration` / `chute` / `capot` events). Was called from five sites in `gameflow.py` (post-trick, capot, first-trick declarations, Belote announcement, chute on failed contract); all five call sites are deleted along with the function. BelAtro's `engine/round_driver.py` never imported it, so no BelAtro behaviour changes.
+- **`src/belote/ui/announce.py::is_muted` / `toggle_mute`** — wrappers around `AUDIO.is_muted()` / `AUDIO.toggle_mute()`. Re-exports dropped from `src/belote/ui/__init__.py::__all__`.
+- **`src/belote/context.py::AudioManager` + the `AUDIO` singleton** — process-wide mute state holder. `TerminalContext` and the `TERMINAL` singleton are kept (they back the terminal-size cache used elsewhere).
+- **`src/belote/input.py::Key.MUTE` + the `m` / `b"m"` key bindings** — `M` no longer triggers a special key event in either `_UnixKeyReader` or `_WindowsKeyReader`; it now falls through to `Key.CHAR` like any other letter (Belote has no other meaning for `M`).
+- **Three `case Key.MUTE: toggle_mute()` branches in `src/belote/ui/prompts.py`** (card prompt, bid prompt, rules viewer) — deleted along with the `from .announce import is_muted, toggle_mute` import.
+- **Two `case Key.MUTE: toggle_mute()` branches in `src/belote/ui/menu.py`** (AI config submenu, main menu) — deleted along with the `from .announce import toggle_mute` import.
+- **`[M] Toggle Sound Effects` line from the in-game help screen** (`src/belote/ui/prompts.py::show_help`) — plus the live `(Currently: ON/OFF)` status line that reflected `is_muted()`.
+- **`tests/test_gameflow.py`** — the obsolete `unittest.mock.patch("belote.gameflow.play_sound")` mock inside `test_run_play_8_tricks`'s `ExitStack` is gone; the test still passes (the underlying `display` / `patch_trick_card` / `announce` / `prompt_card` mocks remain).
+
+### Internal
+
+- **Tests**: still 549 passing.
+- **Strict gates**: pytest 549/549, mypy 0 errors (75 files — `context.py` lost one class but kept the module), ruff 0 violations.
+- **Unused-import sweep**: `green_fg` dropped from `src/belote/ui/prompts.py` imports (only the deleted `sound_status` line used it).
+
+### Why drop the bell instead of guarding it on musl
+
+`play_sound` only writes BEL (`\a`) bytes to stdout; writing those bytes is just `write(2)` and doesn't itself trigger SIGSYS on any sane libc. Whatever the precise mechanism on Alpine 23 (terminal-driver quirk, blocked downstream ioctl, or musl-specific signal-frame interaction with the existing `signal.signal(SIGINT/SIGTERM)` registration in `main.py:132-133`), the simplest and most robust answer is to stop writing the bell at all. Modern terminal emulators on every tested distro either ignored or visually-flashed the bell — no user-meaningful audio was being produced. The mute toggle exists only to suppress those flashes; with the bell gone, the toggle is dead weight.
+
 ## [3.3.3] - 2026-05-10
 
 Audit-of-audit release — a fresh three-agent codebase pass (classic engine / BelAtro mode / tests + UI) produced ~50 candidate findings. Verification cut that to **3 real fixes** plus **3 net-new invariant test suites** for properties the prior 3.3.x cycles silently relied on. ~14 rejected claims are catalogued at the bottom of this entry so they aren't re-investigated next cycle. 549 tests passing (up from 537), ruff and mypy strict still clean. Plan file at `/home/mrrobot/.claude/plans/bug-hunt-code-performance-tingly-barto.md`.

{belote_cli-3.3.3 → belote_cli-3.3.4}/DEVELOPMENT.md

@@ -88,11 +88,11 @@ ruff check src/ tests/
 PYTHONPATH=src pytest
 ```
 
-Current baseline (3.3.3):
-- **mypy**: 0 errors (strict mode, 76 files)
+Current baseline (3.3.4):
+- **mypy**: 0 errors (strict mode, 75 files)
 - **ruff**: 0 violations
 - **pytest**: 549 tests, 0 failures
-- 3.3.3 covered: boss-RNG seeding, Tout Atout hand sort, Le Jugement Common-only filter, plus three new invariant suites (scoring conservation, replay round-trip, HUD synergy negative test).
+- 3.3.4 covered: removed all terminal-bell / sound code (`play_sound`, `AudioManager`, `[M]` mute key) to fix a SIGSYS crash on Alpine 23 / musl after the first classic-mode trick. BelAtro and glibc distros were unaffected; classic Belote and BelAtro now share the same "no bells" baseline.
 
 Run all gates before committing:
 

{belote_cli-3.3.3 → belote_cli-3.3.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: belote-cli
-Version: 3.3.3
+Version: 3.3.4
 Summary: A 4-player terminal card game
 Project-URL: Homepage, https://github.com/ElysiumDisc/belote
 Project-URL: Repository, https://github.com/ElysiumDisc/belote
@@ -45,6 +45,11 @@ Description-Content-Type: text/markdown
 
 Complete implementation of the French card game Belote for the terminal, with a full-screen green felt table and full card graphics at compass positions (N/W/E/S).
 
+## What's new in 3.3.4
+
+- **Portability fix** — Removed all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode and every glibc-based distro (Kubuntu / Lubuntu 24.10 / 25.10) were unaffected, but rather than guard the BEL writes behind a libc check, the entire sound subsystem is gone — `play_sound`, `AudioManager` / `AUDIO`, `is_muted` / `toggle_mute`, the `[M]` mute key, and the help-screen mute line. Classic Belote and BelAtro now share the same "no bells" baseline.
+- **Test coverage** — Still 549 tests. Strict gates clean: pytest 549/549, mypy 0 errors, ruff 0 violations.
+
 ## What's new in 3.3.3
 
 - **Determinism** — Boss assignment in BelAtro mode now draws from the run's seeded RNG instead of the module-level `random`. This was the last unseeded RNG site in the round flow (shop and tarots were converted in 3.2.0, AI in 3.3.1, replay analysis in 3.3.2). Same seed now reproduces the same boss on the boss blind.
@@ -243,7 +248,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 
 **General:**
 - `?`: Show keyboard shortcut help
-- `M`: Toggle sound effects on/off
 - `I` or `V`: Toggle BelAtro score overlay (per-trick breakdown popup)
 - `Q`: Quit to main menu or exit
 - `H`: View Game History (round-by-round, with contract / taker / tricks / declarations)
@@ -284,7 +288,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 - **Statistics:** unified global tracking of games played, win rates, best rounds, and BelAtro expansion milestones.
 - **Responsive Layout (3 tiers):** Three preset layouts — **compact** (80×32, fits 1366×768), **standard** (96×38), **spacious** (120×48+). The game picks the largest preset that fits your terminal on every render, so resizing mid-game adapts automatically; cards, side columns, and HUD verbosity all scale with the preset. Vertical centering pads tall terminals so the game never clings to the top.
 - **Alternate Screen Buffer:** Both classic Belote and BelAtro run in a dedicated terminal buffer for a clean, non-overlapping interface — your shell scrollback stays untouched after you quit.
-- **Sound Effects:** Enhanced auditory feedback for trick wins, Belote, and Capot, with a built-in mute toggle.
 - **Declarations:** Automatic detection and announcement of sequences (Tierce, Quarte, etc.) and Carrés after the first trick.
 - **Live HUD:** Real-time round scoring displays points won during the current round, with a smooth "rolling" numerical animation for total scores.
 - **High Fidelity:** Implementation of French Belote rules according to the [official rules of the Fédération Française de Belote](https://www.ffbelote.org/regles-officielle-belote/), including a two-round bidding system, "Dix de Der", "Capot" (252 pts), and "Litige" (tie-break). All six contracts are bidable in round 2: the four card suits, **Tout Atout** (every suit acts as trump within its own led-suit group; press `a`), and **Sans Atout** (no trump, lead-suit highest wins; press `s`).
@@ -316,7 +319,7 @@ belote/
 │   ├── scoring.py     # Declarations, round scoring, capot
 │   ├── ai.py          # Three-tier AI (easy/medium/hard)
 │   ├── config.py      # Global configuration and timings
-│   ├── context.py     # Global managers (Audio, Terminal)
+│   ├── context.py     # Global managers (Terminal)
 │   ├── themes.py      # Color theme management
 │   ├── ui/            # Modular UI package
 │   ├── ansi.py        # ANSI escape helpers (colors, cursor)

{belote_cli-3.3.3 → belote_cli-3.3.4}/README.md

@@ -2,6 +2,11 @@
 
 Complete implementation of the French card game Belote for the terminal, with a full-screen green felt table and full card graphics at compass positions (N/W/E/S).
 
+## What's new in 3.3.4
+
+- **Portability fix** — Removed all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode and every glibc-based distro (Kubuntu / Lubuntu 24.10 / 25.10) were unaffected, but rather than guard the BEL writes behind a libc check, the entire sound subsystem is gone — `play_sound`, `AudioManager` / `AUDIO`, `is_muted` / `toggle_mute`, the `[M]` mute key, and the help-screen mute line. Classic Belote and BelAtro now share the same "no bells" baseline.
+- **Test coverage** — Still 549 tests. Strict gates clean: pytest 549/549, mypy 0 errors, ruff 0 violations.
+
 ## What's new in 3.3.3
 
 - **Determinism** — Boss assignment in BelAtro mode now draws from the run's seeded RNG instead of the module-level `random`. This was the last unseeded RNG site in the round flow (shop and tarots were converted in 3.2.0, AI in 3.3.1, replay analysis in 3.3.2). Same seed now reproduces the same boss on the boss blind.
@@ -200,7 +205,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 
 **General:**
 - `?`: Show keyboard shortcut help
-- `M`: Toggle sound effects on/off
 - `I` or `V`: Toggle BelAtro score overlay (per-trick breakdown popup)
 - `Q`: Quit to main menu or exit
 - `H`: View Game History (round-by-round, with contract / taker / tricks / declarations)
@@ -241,7 +245,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 - **Statistics:** unified global tracking of games played, win rates, best rounds, and BelAtro expansion milestones.
 - **Responsive Layout (3 tiers):** Three preset layouts — **compact** (80×32, fits 1366×768), **standard** (96×38), **spacious** (120×48+). The game picks the largest preset that fits your terminal on every render, so resizing mid-game adapts automatically; cards, side columns, and HUD verbosity all scale with the preset. Vertical centering pads tall terminals so the game never clings to the top.
 - **Alternate Screen Buffer:** Both classic Belote and BelAtro run in a dedicated terminal buffer for a clean, non-overlapping interface — your shell scrollback stays untouched after you quit.
-- **Sound Effects:** Enhanced auditory feedback for trick wins, Belote, and Capot, with a built-in mute toggle.
 - **Declarations:** Automatic detection and announcement of sequences (Tierce, Quarte, etc.) and Carrés after the first trick.
 - **Live HUD:** Real-time round scoring displays points won during the current round, with a smooth "rolling" numerical animation for total scores.
 - **High Fidelity:** Implementation of French Belote rules according to the [official rules of the Fédération Française de Belote](https://www.ffbelote.org/regles-officielle-belote/), including a two-round bidding system, "Dix de Der", "Capot" (252 pts), and "Litige" (tie-break). All six contracts are bidable in round 2: the four card suits, **Tout Atout** (every suit acts as trump within its own led-suit group; press `a`), and **Sans Atout** (no trump, lead-suit highest wins; press `s`).
@@ -273,7 +276,7 @@ belote/
 │   ├── scoring.py     # Declarations, round scoring, capot
 │   ├── ai.py          # Three-tier AI (easy/medium/hard)
 │   ├── config.py      # Global configuration and timings
-│   ├── context.py     # Global managers (Audio, Terminal)
+│   ├── context.py     # Global managers (Terminal)
 │   ├── themes.py      # Color theme management
 │   ├── ui/            # Modular UI package
 │   ├── ansi.py        # ANSI escape helpers (colors, cursor)

{belote_cli-3.3.3 → belote_cli-3.3.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "belote-cli"
-version = "3.3.3"
+version = "3.3.4"
 description = "A 4-player terminal card game"
 readme = "README.md"
 requires-python = ">=3.10"

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/__init__.py

@@ -1,3 +1,3 @@
-__version__ = "3.3.3"
+__version__ = "3.3.4"
 
 __all__ = ["__version__"]

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/context.py

@@ -4,18 +4,6 @@ import shutil
 import sys
 
 
-class AudioManager:
-    def __init__(self) -> None:
-        self.muted = False
-
-    def toggle_mute(self) -> bool:
-        self.muted = not self.muted
-        return self.muted
-
-    def is_muted(self) -> bool:
-        return self.muted
-
-
 class TerminalContext:
     def __init__(self) -> None:
         self._size_cache: tuple[int, int] | None = None
@@ -30,6 +18,4 @@ class TerminalContext:
         self._size_cache = None
 
 
-# Global instances
-AUDIO = AudioManager()
 TERMINAL = TerminalContext()

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/gameflow.py

@@ -46,7 +46,6 @@ from .ui import (
     announce,
     display,
     patch_trick_card,
-    play_sound,
     prompt_bid,
     prompt_card,
 )
@@ -187,7 +186,6 @@ def run_play(
 
         # 3. If this completes a trick, pause longer and show announcements
         if len(display_state.current_trick) == 4:
-            play_sound("trick")
             # Non-skippable minimum dwell so all four cards are always visible
             # before the trick clears, even when the user has skipped earlier
             # animations or is on the "instant" speed preset.
@@ -215,7 +213,6 @@ def run_play(
                     )
                     is not None
                 ):
-                    play_sound("capot")
                     announce(
                         "CAPOT!", duration=trick_pause * 1.2 if not skip_anims else 0, reader=reader
                     )
@@ -228,7 +225,6 @@ def run_play(
         if len(display_state.current_trick) == 4 and len(current.completed_tricks) == 0:
             for decl in current.declarations:
                 if decl.kind in ("sequence", "carre"):
-                    play_sound("declaration")
                     msg = f"{decl.seat.name}: {decl.kind.upper()}"
                     if decl.kind == "sequence":
                         # Sequence length (3=tierce, 4=quarte, 5=quinte)
@@ -264,8 +260,6 @@ def run_play(
             a11y.announce_trick_won(current.last_trick_winner, pts)
 
         if current.announced:
-            if "Belote" in current.announced:
-                play_sound("belote")
             announce(
                 current.announced,
                 duration=max(0.5, trick_pause * 0.6) if not skip_anims else 0,
@@ -377,8 +371,6 @@ def run_round(
         # Scoring Phase
         if current.phase == Phase.SCORING:
             breakdown = score_round(current)
-            if breakdown.is_failed:
-                play_sound("chute")
             display(current, None)
             sys.stdout.write(f"\r\n{'=' * 50}\r\n")
             sys.stdout.write("  Round Results:\r\n")

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/input.py

@@ -24,7 +24,6 @@ class Key(Enum):
     QUIT = "QUIT"
     HELP = "HELP"
     SORT = "SORT"
-    MUTE = "MUTE"
     THEME = "THEME"
     HIST = "HIST"
     OVERLAY = "OVERLAY"
@@ -151,8 +150,6 @@ class _UnixKeyReader:
                 return KeyEvent(Key.THEME)
             if ch.lower() == "o":
                 return KeyEvent(Key.SORT)
-            if ch.lower() == "m":
-                return KeyEvent(Key.MUTE)
             if ch.lower() == "i" or ch.lower() == "v":
                 return KeyEvent(Key.OVERLAY)
 
@@ -272,8 +269,6 @@ if os.name == "nt":
                 return KeyEvent(Key.THEME)
             if ch.lower() == b"o":
                 return KeyEvent(Key.SORT)
-            if ch.lower() == b"m":
-                return KeyEvent(Key.MUTE)
             if ch.lower() in (b"i", b"v"):
                 return KeyEvent(Key.OVERLAY)
 

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/ui/__init__.py

@@ -1,4 +1,4 @@
-from .announce import animate_score_update, announce, is_muted, play_sound, show_stats, toggle_mute
+from .announce import animate_score_update, announce, show_stats
 from .menu import show_ai_config, show_final_screen, show_main_menu
 from .prompts import prompt_bid, prompt_card, show_help, show_history, show_rules
 from .render import display, get_term_size, patch_trick_card, render
@@ -17,9 +17,6 @@ __all__ = [
     "show_ai_config",
     "show_final_screen",
     "announce",
-    "play_sound",
-    "toggle_mute",
     "show_stats",
     "animate_score_update",
-    "is_muted",
 ]

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/ui/announce.py

@@ -19,21 +19,12 @@ from ..ansi import (
     move,
     white_fg,
 )
-from ..context import AUDIO
 from ..game import GameState
 from ..input import KeyReader, interruptible_sleep
 from ..stats import get_session_stats, load_stats
 from .render import display_hud, get_term_size
 
 
-def is_muted() -> bool:
-    return AUDIO.is_muted()
-
-
-def toggle_mute() -> bool:
-    return AUDIO.toggle_mute()
-
-
 def announce(message: str, duration: float = 2.0, reader: KeyReader | None = None) -> None:
     """Display a transient announcement banner.
 
@@ -55,29 +46,6 @@ def announce(message: str, duration: float = 2.0, reader: KeyReader | None = Non
         time.sleep(duration)
 
 
-def play_sound(kind: str) -> None:
-    """Enhanced terminal sounds using frequency tones (where supported) or bells."""
-    if AUDIO.is_muted():
-        return
-
-    # Use XTerm OSC 777 or simple bells for now to keep it cross-terminal
-    if kind == "trick":
-        sys.stdout.write("\a")
-    elif kind == "belote":
-        sys.stdout.write("\a\a")
-    elif kind == "declaration":
-        sys.stdout.write("\a")
-    elif kind == "chute":
-        sys.stdout.write("\a\a\a")
-    elif kind == "capot":
-        # Arpeggio-like bell sequence
-        for _ in range(3):
-            sys.stdout.write("\a")
-            sys.stdout.flush()
-            time.sleep(0.1)
-    sys.stdout.flush()
-
-
 def show_stats(reader: KeyReader) -> None:
     """Display global game statistics."""
     stats = load_stats()

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/ui/menu.py

@@ -19,7 +19,6 @@ from ..ansi import (
 from ..game import GameState, Seat
 from ..input import Key, KeyReader
 from ..themes import THEMES, theme_manager
-from .announce import toggle_mute
 from .prompts import show_help
 from .render import get_term_size
 
@@ -195,8 +194,6 @@ def show_ai_config(reader: KeyReader, current_diffs: dict[Seat, str]) -> dict[Se
                 return current_diffs
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.UP:
                 sel = (sel - 1) % len(seats)
             case Key.DOWN:
@@ -279,8 +276,6 @@ def show_main_menu(
                 return "Quit", curr_diffs, curr_target, curr_speed
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name

{belote_cli-3.3.3 → belote_cli-3.3.4}/src/belote/ui/prompts.py

@@ -11,7 +11,6 @@ from ..ansi import (
     ansi_center,
     clear_screen,
     gold_fg,
-    green_fg,
     hide_cursor,
     red_fg,
     visible_len,
@@ -28,7 +27,6 @@ from ..game import (
 from ..input import Key, KeyReader
 from ..rules import RULES_CONTENT, RulesPage
 from ..themes import THEMES, theme_manager
-from .announce import is_muted, toggle_mute  # Need to implement these or import correctly
 from .render import display, get_term_size
 
 
@@ -91,9 +89,6 @@ def prompt_card(
                 # Re-find selection index
                 sel = next((i for i, c in enumerate(hand) if c == selected_card), 0)
                 continue
-            case Key.MUTE:
-                toggle_mute()
-                continue
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name
@@ -156,9 +151,6 @@ def prompt_bid(state: GameState, reader: KeyReader) -> Suit | str | None:
             case Key.HELP:
                 show_help(reader)
                 continue
-            case Key.MUTE:
-                toggle_mute()
-                continue
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name
@@ -195,7 +187,6 @@ def prompt_bid(state: GameState, reader: KeyReader) -> Suit | str | None:
 def show_help(reader: KeyReader) -> None:
     """Display a quick keyboard shortcut reference."""
     term_w, term_h = get_term_size()
-    sound_status = f"{red_fg()}OFF{RESET}" if is_muted() else f"{green_fg()}ON{RESET}"
 
     lines = [
         f"{BOLD}{gold_fg()}KEYBOARD SHORTCUTS{RESET}",
@@ -204,8 +195,6 @@ def show_help(reader: KeyReader) -> None:
         f"{white_fg()}General:{RESET}",
         "  [?]         Show this help screen",
         "  [Q]         Quit to menu / Exit",
-        "  [M]         Toggle Sound Effects",
-        f"              (Currently: {sound_status})",
         "  [T]         Cycle Theme",
         "  [Esc]       Cancel / Back",
         "",
@@ -295,8 +284,6 @@ def show_rules(reader: KeyReader) -> None:
                 return
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.UP:
                 scroll = max(0, scroll - 1)
             case Key.DOWN:

{belote_cli-3.3.3 → belote_cli-3.3.4}/tests/test_gameflow.py

@@ -51,7 +51,6 @@ def test_run_play_8_tricks() -> None:
     with (
         unittest.mock.patch("belote.gameflow.display"),
         unittest.mock.patch("belote.gameflow.patch_trick_card"),
-        unittest.mock.patch("belote.gameflow.play_sound"),
         unittest.mock.patch("belote.gameflow.announce"),
         unittest.mock.patch("belote.gameflow.prompt_card") as mock_prompt,
     ):