belote-cli 3.3.2__tar.gz → 3.3.4__tar.gz

{belote_cli-3.3.2 → belote_cli-3.3.4}/CHANGELOG.md

@@ -5,6 +5,82 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.3.4] - 2026-05-10
+
+Portability release — removes all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode was unaffected on the same Alpine box (it never imported `play_sound`), and Kubuntu / Lubuntu 24.10 / 25.10 (glibc) were unaffected in either mode. Rather than guard the BEL writes behind a libc-detection flag, the entire sound subsystem is removed: classic Belote and BelAtro now share the same "no bells" baseline. 549 tests still passing, ruff and mypy strict still clean.
+
+### Removed
+
+- **`src/belote/ui/announce.py::play_sound`** — terminal-bell helper (writes `\a` bytes for `trick` / `belote` / `declaration` / `chute` / `capot` events). Was called from five sites in `gameflow.py` (post-trick, capot, first-trick declarations, Belote announcement, chute on failed contract); all five call sites are deleted along with the function. BelAtro's `engine/round_driver.py` never imported it, so no BelAtro behaviour changes.
+- **`src/belote/ui/announce.py::is_muted` / `toggle_mute`** — wrappers around `AUDIO.is_muted()` / `AUDIO.toggle_mute()`. Re-exports dropped from `src/belote/ui/__init__.py::__all__`.
+- **`src/belote/context.py::AudioManager` + the `AUDIO` singleton** — process-wide mute state holder. `TerminalContext` and the `TERMINAL` singleton are kept (they back the terminal-size cache used elsewhere).
+- **`src/belote/input.py::Key.MUTE` + the `m` / `b"m"` key bindings** — `M` no longer triggers a special key event in either `_UnixKeyReader` or `_WindowsKeyReader`; it now falls through to `Key.CHAR` like any other letter (Belote has no other meaning for `M`).
+- **Three `case Key.MUTE: toggle_mute()` branches in `src/belote/ui/prompts.py`** (card prompt, bid prompt, rules viewer) — deleted along with the `from .announce import is_muted, toggle_mute` import.
+- **Two `case Key.MUTE: toggle_mute()` branches in `src/belote/ui/menu.py`** (AI config submenu, main menu) — deleted along with the `from .announce import toggle_mute` import.
+- **`[M] Toggle Sound Effects` line from the in-game help screen** (`src/belote/ui/prompts.py::show_help`) — plus the live `(Currently: ON/OFF)` status line that reflected `is_muted()`.
+- **`tests/test_gameflow.py`** — the obsolete `unittest.mock.patch("belote.gameflow.play_sound")` mock inside `test_run_play_8_tricks`'s `ExitStack` is gone; the test still passes (the underlying `display` / `patch_trick_card` / `announce` / `prompt_card` mocks remain).
+
+### Internal
+
+- **Tests**: still 549 passing.
+- **Strict gates**: pytest 549/549, mypy 0 errors (75 files — `context.py` lost one class but kept the module), ruff 0 violations.
+- **Unused-import sweep**: `green_fg` dropped from `src/belote/ui/prompts.py` imports (only the deleted `sound_status` line used it).
+
+### Why drop the bell instead of guarding it on musl
+
+`play_sound` only writes BEL (`\a`) bytes to stdout; writing those bytes is just `write(2)` and doesn't itself trigger SIGSYS on any sane libc. Whatever the precise mechanism on Alpine 23 (terminal-driver quirk, blocked downstream ioctl, or musl-specific signal-frame interaction with the existing `signal.signal(SIGINT/SIGTERM)` registration in `main.py:132-133`), the simplest and most robust answer is to stop writing the bell at all. Modern terminal emulators on every tested distro either ignored or visually-flashed the bell — no user-meaningful audio was being produced. The mute toggle exists only to suppress those flashes; with the bell gone, the toggle is dead weight.
+
+## [3.3.3] - 2026-05-10
+
+Audit-of-audit release — a fresh three-agent codebase pass (classic engine / BelAtro mode / tests + UI) produced ~50 candidate findings. Verification cut that to **3 real fixes** plus **3 net-new invariant test suites** for properties the prior 3.3.x cycles silently relied on. ~14 rejected claims are catalogued at the bottom of this entry so they aren't re-investigated next cycle. 549 tests passing (up from 537), ruff and mypy strict still clean. Plan file at `/home/mrrobot/.claude/plans/bug-hunt-code-performance-tingly-barto.md`.
+
+### Fixed
+
+- **`src/belote/game.py::sort_hand` (F1)** — Under the Tout Atout contract every card should sort by the trump rank ladder (`J > 9 > A > 10 > K > Q > 8 > 7`). Pre-3.3.3 the sort key gated `_TRUMP_RANK_IDX` on `c.suit == trump`, which is *always* false when `trump is Suit.TOUT_ATOUT` because `Card.suit` is one of `SPADES/HEARTS/DIAMONDS/CLUBS` (TA is a contract-level marker, not a card suit). Result: the South hand displayed in the non-trump order whenever the player bid or held TA. Fix: explicit `all_trump = trump is Suit.TOUT_ATOUT` branch in `sort_key`. Also extends `_SUIT_IDX_CACHE` to pre-build the TA entry so the hot path stays cache-resident. UI-only — no scoring impact. Regression test in `tests/test_game_logic.py::test_sort_hand_uses_trump_ladder_under_tout_atout`.
+- **`src/belote/belatro/main.py::_play_blind` (F2)** — Boss assignment on the boss blind now draws from `self.run._get_rng().choice(ALL_BOSS_MODIFIERS)`. Pre-3.3.3 the function imported `random` inline and called `random.choice()` on the module-level RNG — the same class of bug the 3.2.0 release fixed for shop generation and the three RNG-using tarots (`LeJugement` / `LaPretresse` / `LeFou`). Boss assignment was the last unseeded RNG site in the BelAtro round flow; ghost-run reproducibility now observes the same boss for the same seed regardless of prior process-wide RNG state. Regression tests in `tests/belatro/test_belatro.py::TestBossSelectionDeterminism` (behaviour + source-grep against the anti-pattern).
+- **`src/belote/belatro/items/tarots.py::LeJugement` (F3)** — The tarot's description promises *"a random Common Joker"* but the implementation drew from `registry.get_available_jokers(run.profile)` — the full unlocked pool across all rarities. Late-run players with Rare/Legendary jokers unlocked could roll Legendary off this tarot, which is strictly stronger than advertised and mis-prices the consumable. Fix: filter the pool to `getattr(v, "rarity", Rarity.COMMON) == Rarity.COMMON` before the choice; existing empty-pool guard handles the (rare) case where no Commons are available. Regression tests in `tests/belatro/test_belatro.py::TestLeJugementRarity`.
+
+### Added — invariant tests
+
+These are the three test suites the 3.3.x bug cycle has been silently asking for. Each one would have caught at least one prior bug from below.
+
+- **`tests/test_properties.py` — scoring conservation per contract (T1)** — Three new tests drive seeded full rounds and assert `table_taker_pts + table_defender_pts == 162` (normal) / `258` (Tout Atout) / `130` (Sans Atout). Plus a card-consumption invariant: after a full round every hand is empty and exactly 8 tricks were recorded. Would have caught the L'Anarchie belote-zero (3.3.1) and the La Rupture HUD divergence (3.3.1/3.3.2) years earlier had it existed at the time. Also includes a small `_drive_full_round` helper for future scoring-pin tests (handles the round-2-only TA/SA bidding flow).
+- **`tests/test_replay.py` — replay round-trip + seeded determinism (T2)** — Two new tests: (a) record each played card from a seeded run, replay them into a fresh `GameState` built from the same seed, assert identical final state across `team_scores` / `completed_tricks` / `belote_tracker` / `belote_announcer` / `last_trick_winner`; (b) drive the same seed twice and assert identical 32-card sequences. Pins the determinism promise the 3.3.1 AI-RNG fix and the 3.3.2 replay-RNG fix established.
+- **`tests/belatro/test_hud_synergy.py` — solo-half pair test (T3)** — The existing file already exercises the "both halves present → badge fires" direction. The new test adds the negative direction: for each pair in `_SYNERGY_PAIRS`, feed a single half into `detect_synergies` and assert no badge fires. Trip-wire for any change to the synergy matcher that accidentally promotes lone jokers to a pair badge.
+
+### Internal
+
+- **Tests**: 537 → 549 (+12 — 3 F-regressions + 4 T1 + 2 T2 + 1 T3 + extra cross-suit / TA sanity assertions).
+- **Strict gates**: pytest 549/549, mypy 0 errors (76 files), ruff 0 violations.
+- **`_SUIT_IDX_CACHE` widened**: now pre-builds for `(None, Suit.TOUT_ATOUT, *_SUITS_ORDER)` instead of just `(None, *_SUITS_ORDER)`. Removes a per-render cache miss under TA but is otherwise a no-op.
+
+### Rejected — claims catalogued (so they aren't re-investigated)
+
+The three Explore agents that drove this audit surfaced many plausible-sounding findings; the ones below fell apart on direct read of the current code and are documented here to save the next cycle from re-investigating them.
+
+**Already fixed in 3.3.1/3.3.2 (agents read against stale priors):**
+- "`_hard_play` returns `legal[0]` under Sans Atout" — fixed in 3.3.1.
+- "`AIPlayer.__init__` constructs unseeded `Random()`" — fixed in 3.3.1; `analyze_round` followed in 3.3.2.
+- "`AIMemory.last_voids_key` not reset on mid-round undo" — fixed in 3.3.1.
+- "Live HUD diverges from final score under La Rupture" — fixed in 3.3.1 (`compute_trick_winners`) + 3.3.2 (`is_capot(tricks=…)`).
+- "Belote/Rebelote silently zeroed under L'Anarchie when trump rotates" — fixed in 3.3.1 via `GameState.belote_announcer`.
+
+**Interpretive, not bugs:**
+- "`ScoreAccumulator` applies edition before partner-tier scaling, so Holo isn't tier-scaled" — by design. Editions ride along once per joker trigger; tier extras re-apply the *base* joker result. Otherwise an elite-tier Polychrome partner joker would compound geometrically.
+- "Libra's `coinche_multiplier=1.0 × event.coinche_level` makes coinche pay ×5, not ×4" — description is ambiguous; the math matches the Phase 3 design doc (`+1 Mult per coinche level on success`).
+- "Pluto `capot_bonus = 48` is additive to 252 = 300" — that *is* the advertised behaviour.
+- "`_TIERCE_LIKE` has title-case dead entries (`Tierce`/`Quarte`/`Quinte`)" — `decl.kind` is always lowercase (`sequence`/`carre`/`belote`/`rebelote`), so only `"sequence"` ever matches. The joker fires correctly on every Tierce/Quarte/Quinte; the title-case entries are dead but harmless.
+- "QuinteRoyale arms on `event.points >= 100` instead of declaration length" — Quinte = 100 pts in classic Belote and `event.points` is the unmodified `get_declaration_points([...])` computed inline at emit time; the proxy is sound.
+- "`EventBus.emit` has no try/except around handlers" — broad-except would mask real bugs in joker/accumulator code. Current handlers are internal; an exception should surface in dev/test rather than be swallowed.
+- "Negative-edition jokers still pay the 1.5× shop markup" — design: Negative is the rarest edition and grants a permanent +1 joker slot.
+- "Boss `random.choice` doesn't respect profile unlocks" — there is no boss-unlock system in the data model; all bosses are always available by design.
+- "ToutStreak / LeSergent reset semantics don't match flavour text" — joker authoring judgment call. Behaviour matches the registry definition.
+
+**Already addressed by existing code:**
+- "`ScoreAccumulator.update_state` clones `_joker_state` per event" — intentional shallow copy; `test_joker_state_only_contains_scalar_values` pins the scalar invariant.
+- "Registry duplicate-ID overwrites silently" — fixed in 3.2.0; all four `register_*` methods assert same-class re-registration.
+- "`_SUIT_IDX_CACHE` missing TOUT_ATOUT" — addressed as part of F1 (now in the cache).
+
 ## [3.3.2] - 2026-05-10
 
 Residual-audit release — a fresh full-codebase pass after 3.3.1 turned up three real findings (a HIGH live-HUD divergence under La Rupture, a MEDIUM determinism leak in `replay.analyze_round`, and a LOW cosmetic chips display). The same pass flagged ~5 plausible-sounding "performance wins" and other claims that fell apart on verification — catalogued in the plan file at `/home/mrrobot/.claude/plans/bug-hunt-code-performance-cheeky-globe.md` so they aren't re-investigated. 537 tests passing (up from 535), ruff and mypy strict still clean.

{belote_cli-3.3.2 → belote_cli-3.3.4}/DEVELOPMENT.md

@@ -84,14 +84,15 @@ PYTHONPATH=src mypy --strict src/
 # Linting (0 violations expected)
 ruff check src/ tests/
 
-# Full test suite (535 tests expected)
+# Full test suite (549 tests expected)
 PYTHONPATH=src pytest
 ```
 
-Current baseline (3.3.1):
-- **mypy**: 0 errors (strict mode)
+Current baseline (3.3.4):
+- **mypy**: 0 errors (strict mode, 75 files)
 - **ruff**: 0 violations
-- **pytest**: 535 tests, 0 failures
+- **pytest**: 549 tests, 0 failures
+- 3.3.4 covered: removed all terminal-bell / sound code (`play_sound`, `AudioManager`, `[M]` mute key) to fix a SIGSYS crash on Alpine 23 / musl after the first classic-mode trick. BelAtro and glibc distros were unaffected; classic Belote and BelAtro now share the same "no bells" baseline.
 
 Run all gates before committing:
 

{belote_cli-3.3.2 → belote_cli-3.3.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: belote-cli
-Version: 3.3.2
+Version: 3.3.4
 Summary: A 4-player terminal card game
 Project-URL: Homepage, https://github.com/ElysiumDisc/belote
 Project-URL: Repository, https://github.com/ElysiumDisc/belote
@@ -45,6 +45,20 @@ Description-Content-Type: text/markdown
 
 Complete implementation of the French card game Belote for the terminal, with a full-screen green felt table and full card graphics at compass positions (N/W/E/S).
 
+## What's new in 3.3.4
+
+- **Portability fix** — Removed all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode and every glibc-based distro (Kubuntu / Lubuntu 24.10 / 25.10) were unaffected, but rather than guard the BEL writes behind a libc check, the entire sound subsystem is gone — `play_sound`, `AudioManager` / `AUDIO`, `is_muted` / `toggle_mute`, the `[M]` mute key, and the help-screen mute line. Classic Belote and BelAtro now share the same "no bells" baseline.
+- **Test coverage** — Still 549 tests. Strict gates clean: pytest 549/549, mypy 0 errors, ruff 0 violations.
+
+## What's new in 3.3.3
+
+- **Determinism** — Boss assignment in BelAtro mode now draws from the run's seeded RNG instead of the module-level `random`. This was the last unseeded RNG site in the round flow (shop and tarots were converted in 3.2.0, AI in 3.3.1, replay analysis in 3.3.2). Same seed now reproduces the same boss on the boss blind.
+- **UI** — Hands sort by the trump-rank ladder under Tout Atout (Jack first, then 9 / A / 10 / K / Q / 8 / 7). Pre-3.3.3 the predicate `c.suit == trump` was always false under TA because Card.suit is never `Suit.TOUT_ATOUT`, so the South hand displayed in the non-trump order whenever the player bid TA.
+- **Tarot** — Le Jugement now correctly grants only Common jokers as advertised. Pre-3.3.3 the code drew from the full unlocked pool, so late-run players with Rare/Legendary unlocks could roll out-of-rarity jokers off this tarot.
+- **Test moat** — Three new invariant test suites added: scoring-conservation property (`table_taker + table_defender == 162 / 258 / 130` for normal / Tout Atout / Sans Atout), seeded-round replay determinism (same seed → same card sequence → same final state), and HUD synergy-badge negative test (solo half of a pair must not fire the badge). These would have caught most of the 3.3.x bug cycle from below.
+- **Audit reconciliation** — A fresh three-agent codebase pass surfaced ~50 candidate findings; the three above held up under verification and the rest are catalogued in `CHANGELOG.md` so they aren't re-investigated.
+- **Test coverage** — 549 tests (up from 537). Strict gates still clean: pytest 549/549, mypy 0 errors (76 files), ruff 0 violations.
+
 ## What's new in 3.3.1
 
 - **Scoring correctness under bosses** — La Rupture (`no_consecutive_team_wins`) used to be applied to the live HUD but silently ignored by `score_round`, so the running total and final score diverged and impossible capots could be reported. L'Anarchie (dynamic trump) rotated `state.trump` mid-round, after which scoring's `belote_holders.get(trump)` lookup missed any Belote announced on the original trump and silently zeroed the 20/40 bonus. Both are fixed: a new `compute_trick_winners` helper is the single source of truth for La Rupture-aware winner resolution, and a new `belote_announcer: Seat` field captures the announcing seat at declaration time so the rotated trump no longer matters.
@@ -234,7 +248,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 
 **General:**
 - `?`: Show keyboard shortcut help
-- `M`: Toggle sound effects on/off
 - `I` or `V`: Toggle BelAtro score overlay (per-trick breakdown popup)
 - `Q`: Quit to main menu or exit
 - `H`: View Game History (round-by-round, with contract / taker / tricks / declarations)
@@ -275,7 +288,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 - **Statistics:** unified global tracking of games played, win rates, best rounds, and BelAtro expansion milestones.
 - **Responsive Layout (3 tiers):** Three preset layouts — **compact** (80×32, fits 1366×768), **standard** (96×38), **spacious** (120×48+). The game picks the largest preset that fits your terminal on every render, so resizing mid-game adapts automatically; cards, side columns, and HUD verbosity all scale with the preset. Vertical centering pads tall terminals so the game never clings to the top.
 - **Alternate Screen Buffer:** Both classic Belote and BelAtro run in a dedicated terminal buffer for a clean, non-overlapping interface — your shell scrollback stays untouched after you quit.
-- **Sound Effects:** Enhanced auditory feedback for trick wins, Belote, and Capot, with a built-in mute toggle.
 - **Declarations:** Automatic detection and announcement of sequences (Tierce, Quarte, etc.) and Carrés after the first trick.
 - **Live HUD:** Real-time round scoring displays points won during the current round, with a smooth "rolling" numerical animation for total scores.
 - **High Fidelity:** Implementation of French Belote rules according to the [official rules of the Fédération Française de Belote](https://www.ffbelote.org/regles-officielle-belote/), including a two-round bidding system, "Dix de Der", "Capot" (252 pts), and "Litige" (tie-break). All six contracts are bidable in round 2: the four card suits, **Tout Atout** (every suit acts as trump within its own led-suit group; press `a`), and **Sans Atout** (no trump, lead-suit highest wins; press `s`).
@@ -307,7 +319,7 @@ belote/
 │   ├── scoring.py     # Declarations, round scoring, capot
 │   ├── ai.py          # Three-tier AI (easy/medium/hard)
 │   ├── config.py      # Global configuration and timings
-│   ├── context.py     # Global managers (Audio, Terminal)
+│   ├── context.py     # Global managers (Terminal)
 │   ├── themes.py      # Color theme management
 │   ├── ui/            # Modular UI package
 │   ├── ansi.py        # ANSI escape helpers (colors, cursor)

{belote_cli-3.3.2 → belote_cli-3.3.4}/README.md

@@ -2,6 +2,20 @@
 
 Complete implementation of the French card game Belote for the terminal, with a full-screen green felt table and full card graphics at compass positions (N/W/E/S).
 
+## What's new in 3.3.4
+
+- **Portability fix** — Removed all terminal-bell / sound code, which was triggering SIGSYS ("Bad system call") on Alpine 23 (musl libc) the moment the first trick completed in classic Belote mode. BelAtro mode and every glibc-based distro (Kubuntu / Lubuntu 24.10 / 25.10) were unaffected, but rather than guard the BEL writes behind a libc check, the entire sound subsystem is gone — `play_sound`, `AudioManager` / `AUDIO`, `is_muted` / `toggle_mute`, the `[M]` mute key, and the help-screen mute line. Classic Belote and BelAtro now share the same "no bells" baseline.
+- **Test coverage** — Still 549 tests. Strict gates clean: pytest 549/549, mypy 0 errors, ruff 0 violations.
+
+## What's new in 3.3.3
+
+- **Determinism** — Boss assignment in BelAtro mode now draws from the run's seeded RNG instead of the module-level `random`. This was the last unseeded RNG site in the round flow (shop and tarots were converted in 3.2.0, AI in 3.3.1, replay analysis in 3.3.2). Same seed now reproduces the same boss on the boss blind.
+- **UI** — Hands sort by the trump-rank ladder under Tout Atout (Jack first, then 9 / A / 10 / K / Q / 8 / 7). Pre-3.3.3 the predicate `c.suit == trump` was always false under TA because Card.suit is never `Suit.TOUT_ATOUT`, so the South hand displayed in the non-trump order whenever the player bid TA.
+- **Tarot** — Le Jugement now correctly grants only Common jokers as advertised. Pre-3.3.3 the code drew from the full unlocked pool, so late-run players with Rare/Legendary unlocks could roll out-of-rarity jokers off this tarot.
+- **Test moat** — Three new invariant test suites added: scoring-conservation property (`table_taker + table_defender == 162 / 258 / 130` for normal / Tout Atout / Sans Atout), seeded-round replay determinism (same seed → same card sequence → same final state), and HUD synergy-badge negative test (solo half of a pair must not fire the badge). These would have caught most of the 3.3.x bug cycle from below.
+- **Audit reconciliation** — A fresh three-agent codebase pass surfaced ~50 candidate findings; the three above held up under verification and the rest are catalogued in `CHANGELOG.md` so they aren't re-investigated.
+- **Test coverage** — 549 tests (up from 537). Strict gates still clean: pytest 549/549, mypy 0 errors (76 files), ruff 0 violations.
+
 ## What's new in 3.3.1
 
 - **Scoring correctness under bosses** — La Rupture (`no_consecutive_team_wins`) used to be applied to the live HUD but silently ignored by `score_round`, so the running total and final score diverged and impossible capots could be reported. L'Anarchie (dynamic trump) rotated `state.trump` mid-round, after which scoring's `belote_holders.get(trump)` lookup missed any Belote announced on the original trump and silently zeroed the 20/40 bonus. Both are fixed: a new `compute_trick_winners` helper is the single source of truth for La Rupture-aware winner resolution, and a new `belote_announcer: Seat` field captures the announcing seat at declaration time so the rotated trump no longer matters.
@@ -191,7 +205,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 
 **General:**
 - `?`: Show keyboard shortcut help
-- `M`: Toggle sound effects on/off
 - `I` or `V`: Toggle BelAtro score overlay (per-trick breakdown popup)
 - `Q`: Quit to main menu or exit
 - `H`: View Game History (round-by-round, with contract / taker / tricks / declarations)
@@ -232,7 +245,6 @@ belote --difficulty hard --target 500 --seed 123 --speed fast
 - **Statistics:** unified global tracking of games played, win rates, best rounds, and BelAtro expansion milestones.
 - **Responsive Layout (3 tiers):** Three preset layouts — **compact** (80×32, fits 1366×768), **standard** (96×38), **spacious** (120×48+). The game picks the largest preset that fits your terminal on every render, so resizing mid-game adapts automatically; cards, side columns, and HUD verbosity all scale with the preset. Vertical centering pads tall terminals so the game never clings to the top.
 - **Alternate Screen Buffer:** Both classic Belote and BelAtro run in a dedicated terminal buffer for a clean, non-overlapping interface — your shell scrollback stays untouched after you quit.
-- **Sound Effects:** Enhanced auditory feedback for trick wins, Belote, and Capot, with a built-in mute toggle.
 - **Declarations:** Automatic detection and announcement of sequences (Tierce, Quarte, etc.) and Carrés after the first trick.
 - **Live HUD:** Real-time round scoring displays points won during the current round, with a smooth "rolling" numerical animation for total scores.
 - **High Fidelity:** Implementation of French Belote rules according to the [official rules of the Fédération Française de Belote](https://www.ffbelote.org/regles-officielle-belote/), including a two-round bidding system, "Dix de Der", "Capot" (252 pts), and "Litige" (tie-break). All six contracts are bidable in round 2: the four card suits, **Tout Atout** (every suit acts as trump within its own led-suit group; press `a`), and **Sans Atout** (no trump, lead-suit highest wins; press `s`).
@@ -264,7 +276,7 @@ belote/
 │   ├── scoring.py     # Declarations, round scoring, capot
 │   ├── ai.py          # Three-tier AI (easy/medium/hard)
 │   ├── config.py      # Global configuration and timings
-│   ├── context.py     # Global managers (Audio, Terminal)
+│   ├── context.py     # Global managers (Terminal)
 │   ├── themes.py      # Color theme management
 │   ├── ui/            # Modular UI package
 │   ├── ansi.py        # ANSI escape helpers (colors, cursor)

{belote_cli-3.3.2 → belote_cli-3.3.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "belote-cli"
-version = "3.3.2"
+version = "3.3.4"
 description = "A 4-player terminal card game"
 readme = "README.md"
 requires-python = ">=3.10"

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/__init__.py

@@ -1,3 +1,3 @@
-__version__ = "3.3.1"
+__version__ = "3.3.4"
 
 __all__ = ["__version__"]

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/belatro/items/tarots.py

@@ -32,9 +32,17 @@ class LeJugement(Tarot):
     description = "Instantly gain a random Common Joker."
 
     def use(self, run: BelAtroRun, context: object) -> None:
+        from .base import Rarity
         from .registry import registry
         run.last_tarot_message = None
-        avail = registry.get_available_jokers(run.profile)
+        # Description promises a Common joker — pre-3.3.3 the pool was the
+        # full unlocked set, so late-run players could roll Rare/Legendary
+        # off this tarot and mis-price it. Filter to Rarity.COMMON only.
+        avail = {
+            k: v
+            for k, v in registry.get_available_jokers(run.profile).items()
+            if getattr(v, "rarity", Rarity.COMMON) == Rarity.COMMON
+        }
         if not avail:
             run.last_tarot_message = "Le Jugement: no jokers available to grant."
             return

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/belatro/main.py

@@ -270,11 +270,13 @@ class BelAtroGame:
             if self.run.card_enhancements.pop("disable_next_boss", False):
                 pass  # boss stays None; deliberately skip the reveal animation
             else:
-                import random
-
                 from .run.boss import ALL_BOSS_MODIFIERS
 
-                boss_cls = random.choice(ALL_BOSS_MODIFIERS)
+                # Use the run's seeded RNG, not the module-level random — same
+                # determinism fix the 3.2.0 release applied to shop generation
+                # and the three RNG-using tarots. Boss assignment was the last
+                # unseeded RNG site in the BelAtro round flow.
+                boss_cls = self.run._get_rng().choice(ALL_BOSS_MODIFIERS)
                 boss = boss_cls()
                 BelAtroAnnounce.boss_reveal(boss, self.reader)
 

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/context.py

@@ -4,18 +4,6 @@ import shutil
 import sys
 
 
-class AudioManager:
-    def __init__(self) -> None:
-        self.muted = False
-
-    def toggle_mute(self) -> bool:
-        self.muted = not self.muted
-        return self.muted
-
-    def is_muted(self) -> bool:
-        return self.muted
-
-
 class TerminalContext:
     def __init__(self) -> None:
         self._size_cache: tuple[int, int] | None = None
@@ -30,6 +18,4 @@ class TerminalContext:
         self._size_cache = None
 
 
-# Global instances
-AUDIO = AudioManager()
 TERMINAL = TerminalContext()

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/game.py

@@ -1059,21 +1059,27 @@ def _build_suit_idx(trump: Suit | None) -> dict[Suit, int]:
 
 
 # Pre-compute suit→position maps for every possible trump value (None + the
-# four card suits). sort_hand is called frequently during rendering and this
-# keeps the hot path branch-free.
+# four card suits + TOUT_ATOUT). sort_hand is called frequently during
+# rendering and this keeps the hot path branch-free.
 _SUIT_IDX_CACHE: Final[dict[Suit | None, dict[Suit, int]]] = {
-    trump: _build_suit_idx(trump) for trump in (None, *_SUITS_ORDER)
+    trump: _build_suit_idx(trump) for trump in (None, Suit.TOUT_ATOUT, *_SUITS_ORDER)
 }
 
 
 def sort_hand(hand: tuple[Card, ...], trump: Suit | None) -> tuple[Card, ...]:
     """Sort hand by suit and rank (trump first, then others, honors together)."""
     suit_idx = _SUIT_IDX_CACHE.get(trump) or _build_suit_idx(trump)
+    # Under Tout Atout every card is trump, so the trump-rank ladder applies
+    # to *every* suit. `c.suit == trump` would always be False here because
+    # Card.suit is one of SPADES/HEARTS/DIAMONDS/CLUBS — TOUT_ATOUT is a
+    # contract-level marker, never a card suit.
+    all_trump = trump is Suit.TOUT_ATOUT
 
     def sort_key(c: Card) -> tuple[int, int]:
+        is_trump = all_trump or c.suit == trump
         return (
             suit_idx[c.suit],
-            _TRUMP_RANK_IDX[c.rank] if c.suit == trump else _NORMAL_RANK_IDX[c.rank],
+            _TRUMP_RANK_IDX[c.rank] if is_trump else _NORMAL_RANK_IDX[c.rank],
         )
 
     return tuple(sorted(hand, key=sort_key))

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/gameflow.py

@@ -46,7 +46,6 @@ from .ui import (
     announce,
     display,
     patch_trick_card,
-    play_sound,
     prompt_bid,
     prompt_card,
 )
@@ -187,7 +186,6 @@ def run_play(
 
         # 3. If this completes a trick, pause longer and show announcements
         if len(display_state.current_trick) == 4:
-            play_sound("trick")
             # Non-skippable minimum dwell so all four cards are always visible
             # before the trick clears, even when the user has skipped earlier
             # animations or is on the "instant" speed preset.
@@ -215,7 +213,6 @@ def run_play(
                     )
                     is not None
                 ):
-                    play_sound("capot")
                     announce(
                         "CAPOT!", duration=trick_pause * 1.2 if not skip_anims else 0, reader=reader
                     )
@@ -228,7 +225,6 @@ def run_play(
         if len(display_state.current_trick) == 4 and len(current.completed_tricks) == 0:
             for decl in current.declarations:
                 if decl.kind in ("sequence", "carre"):
-                    play_sound("declaration")
                     msg = f"{decl.seat.name}: {decl.kind.upper()}"
                     if decl.kind == "sequence":
                         # Sequence length (3=tierce, 4=quarte, 5=quinte)
@@ -264,8 +260,6 @@ def run_play(
             a11y.announce_trick_won(current.last_trick_winner, pts)
 
         if current.announced:
-            if "Belote" in current.announced:
-                play_sound("belote")
             announce(
                 current.announced,
                 duration=max(0.5, trick_pause * 0.6) if not skip_anims else 0,
@@ -377,8 +371,6 @@ def run_round(
         # Scoring Phase
         if current.phase == Phase.SCORING:
             breakdown = score_round(current)
-            if breakdown.is_failed:
-                play_sound("chute")
             display(current, None)
             sys.stdout.write(f"\r\n{'=' * 50}\r\n")
             sys.stdout.write("  Round Results:\r\n")

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/input.py

@@ -24,7 +24,6 @@ class Key(Enum):
     QUIT = "QUIT"
     HELP = "HELP"
     SORT = "SORT"
-    MUTE = "MUTE"
     THEME = "THEME"
     HIST = "HIST"
     OVERLAY = "OVERLAY"
@@ -151,8 +150,6 @@ class _UnixKeyReader:
                 return KeyEvent(Key.THEME)
             if ch.lower() == "o":
                 return KeyEvent(Key.SORT)
-            if ch.lower() == "m":
-                return KeyEvent(Key.MUTE)
             if ch.lower() == "i" or ch.lower() == "v":
                 return KeyEvent(Key.OVERLAY)
 
@@ -272,8 +269,6 @@ if os.name == "nt":
                 return KeyEvent(Key.THEME)
             if ch.lower() == b"o":
                 return KeyEvent(Key.SORT)
-            if ch.lower() == b"m":
-                return KeyEvent(Key.MUTE)
             if ch.lower() in (b"i", b"v"):
                 return KeyEvent(Key.OVERLAY)
 

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/ui/__init__.py

@@ -1,4 +1,4 @@
-from .announce import animate_score_update, announce, is_muted, play_sound, show_stats, toggle_mute
+from .announce import animate_score_update, announce, show_stats
 from .menu import show_ai_config, show_final_screen, show_main_menu
 from .prompts import prompt_bid, prompt_card, show_help, show_history, show_rules
 from .render import display, get_term_size, patch_trick_card, render
@@ -17,9 +17,6 @@ __all__ = [
     "show_ai_config",
     "show_final_screen",
     "announce",
-    "play_sound",
-    "toggle_mute",
     "show_stats",
     "animate_score_update",
-    "is_muted",
 ]

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/ui/announce.py

@@ -19,21 +19,12 @@ from ..ansi import (
     move,
     white_fg,
 )
-from ..context import AUDIO
 from ..game import GameState
 from ..input import KeyReader, interruptible_sleep
 from ..stats import get_session_stats, load_stats
 from .render import display_hud, get_term_size
 
 
-def is_muted() -> bool:
-    return AUDIO.is_muted()
-
-
-def toggle_mute() -> bool:
-    return AUDIO.toggle_mute()
-
-
 def announce(message: str, duration: float = 2.0, reader: KeyReader | None = None) -> None:
     """Display a transient announcement banner.
 
@@ -55,29 +46,6 @@ def announce(message: str, duration: float = 2.0, reader: KeyReader | None = Non
         time.sleep(duration)
 
 
-def play_sound(kind: str) -> None:
-    """Enhanced terminal sounds using frequency tones (where supported) or bells."""
-    if AUDIO.is_muted():
-        return
-
-    # Use XTerm OSC 777 or simple bells for now to keep it cross-terminal
-    if kind == "trick":
-        sys.stdout.write("\a")
-    elif kind == "belote":
-        sys.stdout.write("\a\a")
-    elif kind == "declaration":
-        sys.stdout.write("\a")
-    elif kind == "chute":
-        sys.stdout.write("\a\a\a")
-    elif kind == "capot":
-        # Arpeggio-like bell sequence
-        for _ in range(3):
-            sys.stdout.write("\a")
-            sys.stdout.flush()
-            time.sleep(0.1)
-    sys.stdout.flush()
-
-
 def show_stats(reader: KeyReader) -> None:
     """Display global game statistics."""
     stats = load_stats()

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/ui/menu.py

@@ -19,7 +19,6 @@ from ..ansi import (
 from ..game import GameState, Seat
 from ..input import Key, KeyReader
 from ..themes import THEMES, theme_manager
-from .announce import toggle_mute
 from .prompts import show_help
 from .render import get_term_size
 
@@ -195,8 +194,6 @@ def show_ai_config(reader: KeyReader, current_diffs: dict[Seat, str]) -> dict[Se
                 return current_diffs
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.UP:
                 sel = (sel - 1) % len(seats)
             case Key.DOWN:
@@ -279,8 +276,6 @@ def show_main_menu(
                 return "Quit", curr_diffs, curr_target, curr_speed
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name

{belote_cli-3.3.2 → belote_cli-3.3.4}/src/belote/ui/prompts.py

@@ -11,7 +11,6 @@ from ..ansi import (
     ansi_center,
     clear_screen,
     gold_fg,
-    green_fg,
     hide_cursor,
     red_fg,
     visible_len,
@@ -28,7 +27,6 @@ from ..game import (
 from ..input import Key, KeyReader
 from ..rules import RULES_CONTENT, RulesPage
 from ..themes import THEMES, theme_manager
-from .announce import is_muted, toggle_mute  # Need to implement these or import correctly
 from .render import display, get_term_size
 
 
@@ -91,9 +89,6 @@ def prompt_card(
                 # Re-find selection index
                 sel = next((i for i, c in enumerate(hand) if c == selected_card), 0)
                 continue
-            case Key.MUTE:
-                toggle_mute()
-                continue
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name
@@ -156,9 +151,6 @@ def prompt_bid(state: GameState, reader: KeyReader) -> Suit | str | None:
             case Key.HELP:
                 show_help(reader)
                 continue
-            case Key.MUTE:
-                toggle_mute()
-                continue
             case Key.THEME:
                 themes_list = list(THEMES.keys())
                 curr_theme = theme_manager.current_name
@@ -195,7 +187,6 @@ def prompt_bid(state: GameState, reader: KeyReader) -> Suit | str | None:
 def show_help(reader: KeyReader) -> None:
     """Display a quick keyboard shortcut reference."""
     term_w, term_h = get_term_size()
-    sound_status = f"{red_fg()}OFF{RESET}" if is_muted() else f"{green_fg()}ON{RESET}"
 
     lines = [
         f"{BOLD}{gold_fg()}KEYBOARD SHORTCUTS{RESET}",
@@ -204,8 +195,6 @@ def show_help(reader: KeyReader) -> None:
         f"{white_fg()}General:{RESET}",
         "  [?]         Show this help screen",
         "  [Q]         Quit to menu / Exit",
-        "  [M]         Toggle Sound Effects",
-        f"              (Currently: {sound_status})",
         "  [T]         Cycle Theme",
         "  [Esc]       Cancel / Back",
         "",
@@ -295,8 +284,6 @@ def show_rules(reader: KeyReader) -> None:
                 return
             case Key.HELP:
                 show_help(reader)
-            case Key.MUTE:
-                toggle_mute()
             case Key.UP:
                 scroll = max(0, scroll - 1)
             case Key.DOWN: