bec-widgets 0.82.0__tar.gz → 0.82.1__tar.gz

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/CHANGELOG.md

@@ -1,5 +1,27 @@
 # CHANGELOG
 
+## v0.82.1 (2024-07-07)
+
+### Fix
+
+* fix(motor_map): bug where motors without limits were selected ([`c78cd89`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/c78cd898f203f950d7cb589eb5609feaa88062cf))
+
+### Refactor
+
+* refactor(setting_dialog): moved to qt_utils ([`3826bb3`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/3826bb3d9e870e85709b5b20ef09a4d22641280c))
+
+* refactor(toolbar): toolbar moved from widgets to qt_utils ([`7ffc06f`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/7ffc06f3c7ddd86a1681408a75221b9bbadb236b))
+
+### Test
+
+* test(setting_dialog): tests added ([`74a249b`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/74a249bd065d01006cb532bfff2a9bfedb34b592))
+
+### Unknown
+
+* tests(motor_map_widget): tests added ([`734f4c7`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/734f4c77507a1edafd477d81b5f7401d8e759be2))
+
+* feat(settings_dialog):apply button ([`2020953`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/2020953b933b6fcad61ecc770588d39518c26fdd))
+
 ## v0.82.0 (2024-07-07)
 
 ### Feature
@@ -114,8 +136,6 @@
 
 * feat(bec_connector): export config to yaml ([`a391f30`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/a391f3018c50fee6a4a06884491b957df80c3cd3))
 
-* feat(utils): colors added convertor for rgba to hex ([`572f2fb`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/572f2fb8110d5cb0e80f3ca45ce57ef405572456))
-
 ### Fix
 
 * fix(waveform): scatter 2D brush error ([`215d59c`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/215d59c8bfe7fda9aff8cec8353bef9e1ce2eca1))
@@ -125,15 +145,3 @@
 * fix(figure): if/else logic corrected in subplot_factory ([`3e78723`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/3e787234c7274b0698423d7bf9a4c54ec46bad5f))
 
 * fix(image): processing of already displayed data; closes #106 ([`1173510`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/1173510105d2d70d7e498c2ac1e122cea3a16597))
-
-* fix(bec_figure): full reconstruction with config from other bec figure ([`b6e1e20`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/b6e1e20b7c8549bb092e981062329e601411dda6))
-
-* fix(motor_map): API changes updates current visualisation; motor_map can be initialised from config ([`2e2d422`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/2e2d422910685a2527a3d961a468c787f771ca44))
-
-* fix(image): image add_custom_image fixed, closes #225 ([`f0556e4`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/f0556e44113ffee66cf735aa2dd758c62cb634f4))
-
-* fix(figure): subplot methods consolidated; added subplot factory ([`4a97105`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/4a97105e4bd2ce77d72dfe5f8307dd9ee65b21b0))
-
-* fix(image): image can be fully reconstructed from config ([`797f73c`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/797f73c39aa73e07d6311f3de4baea53f6c380e0))
-
-* fix(image_item): vrange added int for pydantic model check ([`b8f796f`](https://gitlab.psi.ch/bec/bec_widgets/-/commit/b8f796fd3fcc15641e8fc6a3ca75c344ce90fc45))

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: bec_widgets
-Version: 0.82.0
+Version: 0.82.1
 Summary: BEC Widgets
 Project-URL: Bug Tracker, https://gitlab.psi.ch/bec/bec_widgets/issues
 Project-URL: Homepage, https://gitlab.psi.ch/bec/bec_widgets

bec_widgets-0.82.1/bec_widgets/qt_utils/settings_dialog.py

@@ -0,0 +1,107 @@
+from qtpy.QtCore import Slot
+from qtpy.QtWidgets import QDialog, QDialogButtonBox, QHBoxLayout, QPushButton, QVBoxLayout, QWidget
+
+
+class SettingWidget(QWidget):
+    """
+    Abstract class for a settings widget to enforce the implementation of the accept_changes and display_current_settings.
+    Can be used for toolbar actions to display the settings of a widget.
+
+    Args:
+        target_widget (QWidget): The widget that the settings will be taken from and applied to.
+    """
+
+    def __init__(self, parent=None, *args, **kwargs):
+        super().__init__(parent, *args, **kwargs)
+
+        self.target_widget = None
+
+    def set_target_widget(self, target_widget: QWidget):
+        self.target_widget = target_widget
+
+    @Slot()
+    def accept_changes(self):
+        """
+        Accepts the changes made in the settings widget and applies them to the target widget.
+        """
+        pass
+
+    @Slot(dict)
+    def display_current_settings(self, config_dict: dict):
+        """
+        Displays the current settings of the target widget in the settings widget.
+
+        Args:
+            config_dict(dict): The current settings of the target widget.
+        """
+        pass
+
+
+class SettingsDialog(QDialog):
+    """
+    Dialog to display and edit the settings of a widget with accept and cancel buttons.
+
+    Args:
+        parent (QWidget): The parent widget of the dialog.
+        target_widget (QWidget): The widget that the settings will be taken from and applied to.
+        settings_widget (SettingWidget): The widget that will display the settings.
+    """
+
+    def __init__(
+        self,
+        parent=None,
+        settings_widget: SettingWidget = None,
+        window_title: str = "Settings",
+        config: dict = None,
+        *args,
+        **kwargs,
+    ):
+        super().__init__(parent, *args, **kwargs)
+
+        self.setModal(False)
+
+        self.setWindowTitle(window_title)
+
+        self.widget = settings_widget
+        self.widget.set_target_widget(parent)
+        if config is None:
+            config = parent.get_config()
+
+        self.widget.display_current_settings(config)
+
+        self.button_box = QDialogButtonBox(QDialogButtonBox.Ok | QDialogButtonBox.Cancel)
+
+        self.apply_button = QPushButton("Apply")
+
+        button_layout = QHBoxLayout()
+        button_layout.addWidget(self.button_box.button(QDialogButtonBox.Cancel))
+        button_layout.addWidget(self.apply_button)
+        button_layout.addWidget(self.button_box.button(QDialogButtonBox.Ok))
+
+        self.button_box.accepted.connect(self.accept)
+        self.button_box.rejected.connect(self.reject)
+        self.apply_button.clicked.connect(self.apply_changes)
+
+        self.layout = QVBoxLayout(self)
+        self.layout.setContentsMargins(5, 5, 5, 5)
+        self.layout.addWidget(self.widget)
+        self.layout.addLayout(button_layout)
+
+        ok_button = self.button_box.button(QDialogButtonBox.Ok)
+        ok_button.setDefault(True)
+        ok_button.setAutoDefault(True)
+
+    @Slot()
+    def accept(self):
+        """
+        Accept the changes made in the settings widget and close the dialog.
+        """
+        self.widget.accept_changes()
+        super().accept()
+
+    @Slot()
+    def apply_changes(self):
+        """
+        Apply the changes made in the settings widget without closing the dialog.
+        """
+        self.widget.accept_changes()

{bec_widgets-0.82.0/bec_widgets/widgets/toolbar → bec_widgets-0.82.1/bec_widgets/qt_utils}/toolbar.py

@@ -3,8 +3,7 @@ from collections import defaultdict
 
 # pylint: disable=no-name-in-module
 from qtpy.QtCore import QSize
-from qtpy.QtGui import QAction
-from qtpy.QtWidgets import QHBoxLayout, QLabel, QSpinBox, QToolBar, QWidget
+from qtpy.QtWidgets import QToolBar, QWidget
 
 
 class ToolBarAction(ABC):
@@ -18,34 +17,6 @@ class ToolBarAction(ABC):
         """
 
 
-class ColumnAdjustAction(ToolBarAction):
-    """Toolbar spinbox to adjust number of columns in the plot layout"""
-
-    def add_to_toolbar(self, toolbar: QToolBar, target: QWidget):
-        """Creates a access history button for the toolbar.
-
-        Args:
-            toolbar (QToolBar): The toolbar to add the action to.
-            target (QWidget): The widget that the 'Access Scan History' action will be targeted.
-
-        Returns:
-            QAction: The 'Access Scan History' action created for the toolbar.
-        """
-        widget = QWidget()
-        layout = QHBoxLayout(widget)
-
-        label = QLabel("Columns:")
-        spin_box = QSpinBox()
-        spin_box.setMinimum(1)  # Set minimum value
-        spin_box.setMaximum(10)  # Set maximum value
-        spin_box.setValue(target.get_column_count())  # Initial value
-        spin_box.valueChanged.connect(lambda value: target.set_column_count(value))
-
-        layout.addWidget(label)
-        layout.addWidget(spin_box)
-        toolbar.addWidget(widget)
-
-
 class ModularToolBar(QToolBar):
     """Modular toolbar with optional automatic initialization.
     Args:

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/bec_widgets/widgets/figure/plots/motor_map/motor_map.py

@@ -271,11 +271,12 @@ class BECMotorMap(BECPlotBase):
     def _swap_limit_map(self):
         """Swap the limit map."""
         self.plot_item.removeItem(self.plot_components["limit_map"])
-        self.plot_components["limit_map"] = self._make_limit_map(
-            self.config.signals.x.limits, self.config.signals.y.limits
-        )
-        self.plot_components["limit_map"].setZValue(-1)
-        self.plot_item.addItem(self.plot_components["limit_map"])
+        if self.config.signals.x.limits is not None and self.config.signals.y.limits is not None:
+            self.plot_components["limit_map"] = self._make_limit_map(
+                self.config.signals.x.limits, self.config.signals.y.limits
+            )
+            self.plot_components["limit_map"].setZValue(-1)
+            self.plot_item.addItem(self.plot_components["limit_map"])
 
     def _make_motor_map(self):
         """
@@ -284,9 +285,10 @@ class BECMotorMap(BECPlotBase):
         # Create limit map
         motor_x_limit = self.config.signals.x.limits
         motor_y_limit = self.config.signals.y.limits
-        self.plot_components["limit_map"] = self._make_limit_map(motor_x_limit, motor_y_limit)
-        self.plot_item.addItem(self.plot_components["limit_map"])
-        self.plot_components["limit_map"].setZValue(-1)
+        if motor_x_limit is not None or motor_y_limit is not None:
+            self.plot_components["limit_map"] = self._make_limit_map(motor_x_limit, motor_y_limit)
+            self.plot_item.addItem(self.plot_components["limit_map"])
+            self.plot_components["limit_map"].setZValue(-1)
 
         # Create scatter plot
         scatter_size = self.config.scatter_size

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/bec_widgets/widgets/motor_map/motor_map_dialog/motor_map_settings.py

@@ -1,19 +1,19 @@
 import os
 
 from qtpy.QtCore import Slot
-from qtpy.QtWidgets import QDialog, QDialogButtonBox, QLabel, QVBoxLayout, QWidget
+from qtpy.QtWidgets import QVBoxLayout
 
+from bec_widgets.qt_utils.settings_dialog import SettingWidget
 from bec_widgets.utils import UILoader
 from bec_widgets.utils.widget_io import WidgetIO
 
 
-class MotorMapSettings(QWidget):
-    def __init__(self, parent=None, target_widget: QWidget = None, *args, **kwargs):
+class MotorMapSettings(SettingWidget):
+    def __init__(self, parent=None, *args, **kwargs):
         super().__init__(parent, *args, **kwargs)
         current_path = os.path.dirname(__file__)
 
         self.ui = UILoader(self).loader(os.path.join(current_path, "motor_map_settings.ui"))
-        self.target_widget = target_widget
 
         self.layout = QVBoxLayout(self)
         self.layout.addWidget(self.ui)
@@ -45,29 +45,3 @@ class MotorMapSettings(QWidget):
             self.target_widget.set_scatter_size(scatter_size)
             self.target_widget.set_background_value(background_intensity)
             self.target_widget.set_color(color)
-
-
-class MotorMapDialog(QDialog):
-    def __init__(self, parent=None, target_widget: QWidget = None, *args, **kwargs):
-        super().__init__(parent, *args, **kwargs)
-
-        self.setModal(False)
-
-        self.setWindowTitle("Motor Map Settings")
-
-        self.target_widget = target_widget
-        self.widget = MotorMapSettings(target_widget=self.target_widget)
-        self.widget.display_current_settings(self.target_widget._config_dict)
-        self.button_box = QDialogButtonBox(QDialogButtonBox.Ok | QDialogButtonBox.Cancel)
-
-        self.button_box.accepted.connect(self.accept)
-        self.button_box.rejected.connect(self.reject)
-
-        self.layout = QVBoxLayout(self)
-        self.layout.addWidget(self.widget)
-        self.layout.addWidget(self.button_box)
-
-    @Slot()
-    def accept(self):
-        self.widget.accept_changes()
-        super().accept()

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/bec_widgets/widgets/motor_map/motor_map_dialog/motor_map_toolbar.py

@@ -4,8 +4,8 @@ from qtpy.QtCore import QSize
 from qtpy.QtGui import QAction, QIcon
 from qtpy.QtWidgets import QHBoxLayout, QLabel, QWidget
 
+from bec_widgets.qt_utils.toolbar import ToolBarAction
 from bec_widgets.widgets.device_combobox.device_combobox import DeviceComboBox
-from bec_widgets.widgets.toolbar.toolbar import ToolBarAction
 
 
 class DeviceSelectionAction(ToolBarAction):

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/bec_widgets/widgets/motor_map/motor_map_widget.py

@@ -4,17 +4,18 @@ import sys
 
 from qtpy.QtWidgets import QVBoxLayout, QWidget
 
+from bec_widgets.qt_utils.settings_dialog import SettingsDialog
+from bec_widgets.qt_utils.toolbar import ModularToolBar
 from bec_widgets.utils import BECConnector
 from bec_widgets.widgets.figure import BECFigure
 from bec_widgets.widgets.figure.plots.motor_map.motor_map import MotorMapConfig
-from bec_widgets.widgets.motor_map.motor_map_dialog.motor_map_settings import MotorMapDialog
+from bec_widgets.widgets.motor_map.motor_map_dialog.motor_map_settings import MotorMapSettings
 from bec_widgets.widgets.motor_map.motor_map_dialog.motor_map_toolbar import (
     ConnectAction,
     DeviceSelectionAction,
     ResetHistoryAction,
     SettingsAction,
 )
-from bec_widgets.widgets.toolbar import ModularToolBar
 
 
 class BECMotorMapWidget(BECConnector, QWidget):
@@ -92,7 +93,9 @@ class BECMotorMapWidget(BECConnector, QWidget):
         toolbar_y.setStyleSheet("QComboBox {{ background-color: " "; }}")
 
     def show_settings(self) -> None:
-        dialog = MotorMapDialog(self, target_widget=self)
+        dialog = SettingsDialog(
+            self, settings_widget=MotorMapSettings(), window_title="Motor Map Settings"
+        )
         dialog.exec()
 
     ###################################

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "bec_widgets"
-version = "0.82.0"
+version = "0.82.1"
 description = "BEC Widgets"
 requires-python = ">=3.10"
 classifiers = [

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/tests/unit_tests/client_mocks.py

@@ -72,6 +72,13 @@ class FakePositioner(FakeDevice):
         return MagicMock(get=MagicMock(return_value=self.read_value))
 
 
+class Positioner(FakePositioner):
+    """just placeholder for testing embeded isinstance check in DeviceCombobox"""
+
+    def __init__(self, name="test", limits=None, read_value=1.0):
+        super().__init__(name, limits, read_value)
+
+
 class DMMock:
     def __init__(self):
         self.devices = DeviceContainer()
@@ -95,6 +102,7 @@ DEVICES = [
     FakeDevice("bpm3a"),
     FakeDevice("bpm3i"),
     FakeDevice("eiger"),
+    Positioner("test", limits=[-10, 10], read_value=2.0),
 ]
 
 

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/tests/unit_tests/test_device_input_base.py

@@ -63,4 +63,4 @@ def test_device_input_base_get_device_list(device_input_base):
 
 def test_device_input_base_get_filters(device_input_base):
     filters = device_input_base.get_available_filters()
-    assert filters == {"FakePositioner", "FakeDevice"}
+    assert filters == {"FakePositioner", "FakeDevice", "Positioner"}

{bec_widgets-0.82.0 → bec_widgets-0.82.1}/tests/unit_tests/test_device_input_widgets.py

@@ -67,6 +67,7 @@ def test_device_input_combobox_init(device_input_combobox):
         "bpm3a",
         "bpm3i",
         "eiger",
+        "test",
     ]
 
 
@@ -153,6 +154,7 @@ def test_device_input_line_edit_init(device_input_line_edit):
         "bpm3a",
         "bpm3i",
         "eiger",
+        "test",
     ]
 
 

bec_widgets-0.82.1/tests/unit_tests/test_motor_map_widget.py

@@ -0,0 +1,196 @@
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from bec_widgets.widgets.motor_map.motor_map_dialog.motor_map_settings import MotorMapSettings
+from bec_widgets.widgets.motor_map.motor_map_widget import BECMotorMapWidget
+
+from .client_mocks import mocked_client
+
+
+@pytest.fixture
+def motor_map_widget(qtbot, mocked_client):
+    widget = BECMotorMapWidget(client=mocked_client())
+    widget.toolbar.widgets["motor_x"].device_combobox.set_device_filter("FakePositioner")
+    widget.toolbar.widgets["motor_y"].device_combobox.set_device_filter("FakePositioner")
+    qtbot.addWidget(widget)
+    qtbot.waitExposed(widget)
+    yield widget
+    widget.close()
+
+
+@pytest.fixture
+def mock_motor_map(motor_map_widget):
+    motor_map_mock = MagicMock()
+    motor_map_widget.map = motor_map_mock
+    return motor_map_mock
+
+
+def test_motor_map_widget_init(motor_map_widget):
+    assert motor_map_widget is not None
+    assert motor_map_widget.client is not None
+    assert isinstance(motor_map_widget, BECMotorMapWidget)
+    assert motor_map_widget.config.widget_class == "BECMotorMapWidget"
+
+    # check initial state of toolbar actions
+    assert motor_map_widget.toolbar.widgets["connect"].action.isEnabled() == True
+    assert motor_map_widget.toolbar.widgets["config"].action.isEnabled() == False
+    assert motor_map_widget.toolbar.widgets["history"].action.isEnabled() == False
+    assert (
+        motor_map_widget.toolbar.widgets["motor_x"].device_combobox.config.device_filter
+        == "FakePositioner"
+    )
+    assert (
+        motor_map_widget.toolbar.widgets["motor_y"].device_combobox.config.device_filter
+        == "FakePositioner"
+    )
+    assert motor_map_widget.map.motor_x is None
+    assert motor_map_widget.map.motor_y is None
+
+
+###################################
+# Toolbar Actions
+###################################
+
+
+def test_motor_map_widget_change_motors_enable_toolbar(motor_map_widget):
+    motor_map_widget.change_motors("samx", "samy")
+    assert motor_map_widget.map.motor_x == "samx"
+    assert motor_map_widget.map.motor_y == "samy"
+    assert motor_map_widget.toolbar.widgets["motor_x"].device_combobox.currentText() == "samx"
+    assert motor_map_widget.toolbar.widgets["motor_y"].device_combobox.currentText() == "samy"
+    assert motor_map_widget.toolbar.widgets["config"].action.isEnabled() == True
+    assert motor_map_widget.toolbar.widgets["history"].action.isEnabled() == True
+
+
+###################################
+# Wrapper methods for MotorMap
+###################################
+
+
+def test_change_motors(motor_map_widget, mock_motor_map):
+    motor_map_widget.change_motors("motor_x", "motor_y", "motor_x_entry", "motor_y_entry", True)
+    mock_motor_map.change_motors.assert_called_once_with(
+        "motor_x", "motor_y", "motor_x_entry", "motor_y_entry", True
+    )
+
+
+def test_get_data(motor_map_widget, mock_motor_map):
+    motor_map_widget.get_data()
+    mock_motor_map.get_data.assert_called_once()
+
+
+def test_reset_history(motor_map_widget, mock_motor_map):
+    motor_map_widget.reset_history()
+    mock_motor_map.reset_history.assert_called_once()
+
+
+def test_set_color(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_color("blue")
+    mock_motor_map.set_color.assert_called_once_with("blue")
+
+
+def test_set_max_points(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_max_points(100)
+    mock_motor_map.set_max_points.assert_called_once_with(100)
+
+
+def test_set_precision(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_precision(2)
+    mock_motor_map.set_precision.assert_called_once_with(2)
+
+
+def test_set_num_dim_points(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_num_dim_points(50)
+    mock_motor_map.set_num_dim_points.assert_called_once_with(50)
+
+
+def test_set_background_value(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_background_value(128)
+    mock_motor_map.set_background_value.assert_called_once_with(128)
+
+
+def test_set_scatter_size(motor_map_widget, mock_motor_map):
+    motor_map_widget.set_scatter_size(10)
+    mock_motor_map.set_scatter_size.assert_called_once_with(10)
+
+
+###################################
+# MotorMap Dialog
+###################################
+
+
+def test_motor_map_widget_clicked(motor_map_widget, qtbot):
+    motor_map_widget.toolbar.widgets["motor_x"].device_combobox.setCurrentText("samx")
+    motor_map_widget.toolbar.widgets["motor_y"].device_combobox.setCurrentText("samy")
+    motor_map_widget.toolbar.widgets["connect"].action.trigger()
+
+    qtbot.wait(200)
+
+    assert motor_map_widget.map.motor_x == "samx"
+    assert motor_map_widget.map.motor_y == "samy"
+    assert motor_map_widget.toolbar.widgets["config"].action.isEnabled() == True
+    assert motor_map_widget.toolbar.widgets["history"].action.isEnabled() == True
+
+
+@pytest.fixture
+def motor_map_settings(qtbot):
+    widget = MotorMapSettings()
+    qtbot.addWidget(widget)
+    qtbot.waitExposed(widget)
+    yield widget
+    widget.close()
+
+
+def test_display_current_settings(motor_map_settings):
+    config = {
+        "max_points": 100,
+        "num_dim_points": 50,
+        "precision": 2,
+        "scatter_size": 10,
+        "background_value": 128,
+        "color": (255, 0, 0, 255),
+    }
+
+    with patch("bec_widgets.utils.widget_io.WidgetIO.set_value") as mock_set_value:
+        with patch.object(motor_map_settings.ui.color, "setColor") as mock_set_color:
+            motor_map_settings.display_current_settings(config)
+            mock_set_value.assert_any_call(motor_map_settings.ui.max_points, config["max_points"])
+            mock_set_value.assert_any_call(
+                motor_map_settings.ui.trace_dim, config["num_dim_points"]
+            )
+            mock_set_value.assert_any_call(motor_map_settings.ui.precision, config["precision"])
+            mock_set_value.assert_any_call(
+                motor_map_settings.ui.scatter_size, config["scatter_size"]
+            )
+            mock_set_value.assert_any_call(
+                motor_map_settings.ui.background_value, 50
+            )  # 128/255*100 = 50
+            mock_set_color.assert_called_once_with(config["color"])
+
+
+def test_accept_changes(motor_map_settings):
+    with patch(
+        "bec_widgets.utils.widget_io.WidgetIO.get_value", side_effect=[100, 50, 2, 10, 50]
+    ) as mock_get_value:
+        with patch.object(
+            motor_map_settings.ui.color, "get_color", return_value=(255, 0, 0, 255)
+        ) as mock_get_color:
+            mock_target_widget = MagicMock()
+            motor_map_settings.set_target_widget(mock_target_widget)
+
+            motor_map_settings.accept_changes()
+
+            mock_get_value.assert_any_call(motor_map_settings.ui.max_points)
+            mock_get_value.assert_any_call(motor_map_settings.ui.trace_dim)
+            mock_get_value.assert_any_call(motor_map_settings.ui.precision)
+            mock_get_value.assert_any_call(motor_map_settings.ui.scatter_size)
+            mock_get_value.assert_any_call(motor_map_settings.ui.background_value)
+            mock_get_color.assert_called_once()
+
+            mock_target_widget.set_max_points.assert_called_once_with(100)
+            mock_target_widget.set_num_dim_points.assert_called_once_with(50)
+            mock_target_widget.set_precision.assert_called_once_with(2)
+            mock_target_widget.set_scatter_size.assert_called_once_with(10)
+            mock_target_widget.set_background_value.assert_called_once_with(127)
+            mock_target_widget.set_color.assert_called_once_with((255, 0, 0, 255))