avios-cli 0.6.0__tar.gz → 0.6.1__tar.gz

{avios_cli-0.6.0 → avios_cli-0.6.1}/CHANGELOG.md

@@ -6,6 +6,14 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [0.6.1] - 2026-11-11
+
+### Fixed
+- `avios login ba` no longer reports "reward-flight login did not succeed" when BA's
+  reward app runs on the main `ba_session_id` session instead of issuing a separate
+  `__session`/`appSession*` cookie. The login now completes once the reward page is
+  loaded with a valid session.
+
 ## [0.6.0] - 2026-08-11
 
 ### Added

{avios_cli-0.6.0 → avios_cli-0.6.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: avios-cli
-Version: 0.6.0
+Version: 0.6.1
 Summary: A CLI, TUI and MCP server for Avios balances, transactions, and BA reward-flight availability.
 Project-URL: Homepage, https://github.com/alexechoi/avios-cli
 Project-URL: Repository, https://github.com/alexechoi/avios-cli

{avios_cli-0.6.0 → avios_cli-0.6.1}/src/avios/__init__.py

@@ -4,4 +4,4 @@ View your Avios balance, transactions and reward-flight availability from the
 terminal, or serve them to an AI agent with ``avios-mcp``.
 """
 
-__version__ = "0.6.0"
+__version__ = "0.6.1"

{avios_cli-0.6.0 → avios_cli-0.6.1}/src/avios/auth.py

@@ -33,6 +33,7 @@ from avios.session import cookie_header_from
 LOGIN_TIMEOUT_MS = 300_000  # 5 minutes to complete password + captcha + MFA
 LOGIN_POLL_MS = 2_000  # how often to check whether the session is authenticated
 SUPPORTED_BROWSERS = ("chrome", "firefox", "edge", "brave", "safari", "chromium")
+BA_ACCOUNT_SESSION_COOKIE = "ba_session_id"
 BA_REWARD_SEARCH_PATH = "/en-GB/spend-avios/search-reward-flights"
 
 # Chromium-family user-data roots per browser (relative to home), used to discover
@@ -140,14 +141,29 @@ def login_via_browser(
     return _only_avios(cookies)
 
 
-def _has_ba_reward_session(ctx: Any) -> bool:
-    """Whether BA's separate reward-search application session is present."""
-    names = {
+def _avios_cookie_names(ctx: Any) -> set[str]:
+    return {
         str(cookie.get("name", ""))
         for cookie in ctx.cookies()
         if "avios.com" in str(cookie.get("domain", ""))
     }
-    return "__session" in names or any(name.startswith("appSession") for name in names)
+
+
+def _has_ba_reward_session(ctx: Any) -> bool:
+    """Whether a session usable by BA's reward-search application is present.
+
+    BA historically issued a separate ``__session``/``appSession*`` cookie for the
+    reward app. It now also serves the reward app from the main ``ba_session_id``
+    session without setting those cookies, so that cookie counts too. The caller
+    still requires the browser to be sitting on the reward page, so a redirect to a
+    separate login keeps the wait going.
+    """
+    names = _avios_cookie_names(ctx)
+    return (
+        "__session" in names
+        or BA_ACCOUNT_SESSION_COOKIE in names
+        or any(name.startswith("appSession") for name in names)
+    )
 
 
 def _wait_for_ba_reward_auth(ctx: Any, page: Any, base_url: str, timeout_ms: int) -> bool:

{avios_cli-0.6.0 → avios_cli-0.6.1}/tests/test_auth.py

@@ -124,13 +124,14 @@ class _FakeRequest:
 
 
 class _FakePage:
-    def __init__(self) -> None:
+    def __init__(self, redirect_to: str | None = None) -> None:
         self.visited: list[str] = []
         self.url = ""
+        self._redirect_to = redirect_to
 
     def goto(self, url: str, **kwargs: object) -> None:
         self.visited.append(url)
-        self.url = url
+        self.url = self._redirect_to or url
 
     def wait_for_timeout(self, ms: int) -> None:
         pass
@@ -140,11 +141,16 @@ class _FakePage:
 
 
 class _FakeContext:
-    def __init__(self, ok_after: int, cookies: list[dict[str, str]]) -> None:
+    def __init__(
+        self,
+        ok_after: int,
+        cookies: list[dict[str, str]],
+        redirect_to: str | None = None,
+    ) -> None:
         self.request = _FakeRequest(ok_after)
         self._cookies = cookies
         self.closed = False
-        self.page = _FakePage()
+        self.page = _FakePage(redirect_to)
 
     def new_page(self) -> _FakePage:
         return self.page
@@ -208,10 +214,23 @@ def test_login_captures_only_after_authenticated(settings: Settings) -> None:
     assert ctx.page.visited[-1].endswith("/en-GB/spend-avios/search-reward-flights")
 
 
+def test_ba_login_accepts_account_session_on_reward_page(settings: Settings) -> None:
+    cookies = [{"name": "ba_session_id", "value": "x", "domain": "www.avios.com"}]
+    ctx = _FakeContext(ok_after=1, cookies=cookies)
+
+    captured = login_via_browser(
+        BA, settings=settings, timeout_ms=4_000, playwright_factory=_FakeFactory(ctx)
+    )
+
+    assert captured == cookies
+    assert ctx.page.visited[-1].endswith("/en-GB/spend-avios/search-reward-flights")
+
+
 def test_ba_login_waits_for_separate_reward_session(settings: Settings) -> None:
     ctx = _FakeContext(
         ok_after=1,
         cookies=[{"name": "ba_session_id", "value": "x", "domain": "www.avios.com"}],
+        redirect_to="https://www.avios.com/reward-login",
     )
 
     with pytest.raises(LoginError, match="reward-flight login"):