audiometa-python 0.6.1__tar.gz → 0.7.1__tar.gz

{audiometa_python-0.6.1/audiometa_python.egg-info → audiometa_python-0.7.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: audiometa-python
-Version: 0.6.1
+Version: 0.7.1
 Summary: A comprehensive Python library for reading and writing audio metadata across multiple formats
 Author: AudioMeta Python Contributors
 Author-email: Andreas Garcia <garcia.andreas.1991@gmail.com>

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/__init__.py

@@ -30,6 +30,7 @@ from .manager._rating_supporting.id3v2._Id3v2Manager import _Id3v2Manager
 from .manager._rating_supporting.riff._RiffManager import _RiffManager
 from .manager._rating_supporting.vorbis._VorbisManager import _VorbisManager
 from .manager.id3v1._Id3v1Manager import _Id3v1Manager
+from .utils.flac_md5_state import FlacMd5State
 from .utils.metadata_format import MetadataFormat
 from .utils.metadata_writing_strategy import MetadataWritingStrategy
 from .utils.types import UnifiedMetadata, UnifiedMetadataValue
@@ -1106,8 +1107,8 @@ def get_duration_in_sec(file: PublicFileType) -> float:
     return audio_file.get_duration_in_sec()
 
 
-def is_flac_md5_valid(file: PublicFileType) -> bool:
-    """Check if a FLAC file's MD5 signature is valid.
+def is_flac_md5_valid(file: PublicFileType) -> FlacMd5State:
+    """Check the MD5 checksum validation state of a FLAC file.
 
     This function verifies the integrity of a FLAC file by checking its MD5 signature.
     Only works with FLAC files.
@@ -1116,17 +1117,27 @@ def is_flac_md5_valid(file: PublicFileType) -> bool:
         file: Audio file path (str or Path; must be FLAC)
 
     Returns:
-        True if MD5 signature is valid, False otherwise
+        FlacMd5State indicating the validation state:
+        - FlacMd5State.VALID: MD5 is set and matches the audio data
+        - FlacMd5State.UNSET: MD5 is all zeros (not set)
+        - FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1: MD5 is set but cannot be validated due to ID3v1 tags
+        - FlacMd5State.INVALID: MD5 is set but doesn't match the audio data (corrupted)
 
     Raises:
         FileTypeNotSupportedError: If the file is not a FLAC file
         FileNotFoundError: If the file does not exist
 
     Examples:
+        from audiometa import is_flac_md5_valid, FlacMd5State
+
         # Check FLAC file integrity
-        is_valid = is_flac_md5_valid("song.flac")
-        if is_valid:
+        state = is_flac_md5_valid("song.flac")
+        if state == FlacMd5State.VALID:
             print("FLAC file is intact")
+        elif state == FlacMd5State.UNSET:
+            print("MD5 checksum is not set")
+        elif state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1:
+            print("MD5 cannot be validated due to ID3v1 tags")
         else:
             print("FLAC file may be corrupted")
     """
@@ -1134,7 +1145,7 @@ def is_flac_md5_valid(file: PublicFileType) -> bool:
     try:
         return audio_file.is_flac_file_md5_valid()
     except FileCorruptedError:
-        return False
+        return FlacMd5State.INVALID
 
 
 def fix_md5_checking(file: PublicFileType) -> str:
@@ -1237,7 +1248,9 @@ def get_full_metadata(
                 "file_extension": audio_file.file_extension,
                 "audio_format_name": audio_file.get_audio_format_name(),
                 "is_flac_md5_valid": (
-                    audio_file.is_flac_file_md5_valid() if audio_file.file_extension == ".flac" else None
+                    audio_file.is_flac_file_md5_valid() == FlacMd5State.VALID
+                    if audio_file.file_extension == ".flac"
+                    else None
                 ),
             }
         except Exception:

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/_audio_file.py

@@ -23,6 +23,7 @@ from .exceptions import (
 )
 from .manager._rating_supporting.id3v2._id3v2_constants import ID3V2_HEADER_SIZE
 from .manager._rating_supporting.riff._riff_constants import RIFF_HEADER_SIZE
+from .utils.flac_md5_state import FlacMd5State
 from .utils.metadata_format import MetadataFormat
 from .utils.mutagen_exception_handler import handle_mutagen_exception
 from .utils.tool_path_resolver import get_tool_path
@@ -280,14 +281,31 @@ class _AudioFile:
         except Exception:
             return False
 
-    def is_flac_file_md5_valid(self) -> bool:
+    def _has_id3v1_tags(self) -> bool:
+        """Check if FLAC file has ID3v1 tags.
+
+        Only ID3v1 tags cause validation failures, so we only need to check for ID3v1.
+        ID3v2 tags do not interfere with flac -t validation.
+        """
+        try:
+            with Path(self.file_path).open("rb") as f:
+                # Check for ID3v1 at the end (last 128 bytes)
+                f.seek(-128, 2)
+                id3v1_header = f.read(3)
+                return id3v1_header == b"TAG"
+        except Exception:
+            return False
+
+    def is_flac_file_md5_valid(self) -> FlacMd5State:
         if self.file_extension != ".flac":
             msg = "The file is not a FLAC file"
             raise FileTypeNotSupportedError(msg)
 
+        # Check if MD5 is unset (all zeros)
         if self._is_md5_unset():
-            return False
+            return FlacMd5State.UNSET
 
+        # Run flac -t to validate MD5
         result = subprocess.run([get_tool_path("flac"), "-t", self.file_path], capture_output=True, check=False)
 
         # Combine stdout and stderr as flac may output to either
@@ -295,20 +313,26 @@ class _AudioFile:
         stderr_output = result.stderr.decode()
         combined_output = stdout_output + stderr_output
 
-        # flac -t returns 0 on success, non-zero on error
-        # If return code is non-zero, the file is invalid
-        if result.returncode != 0:
-            return False
+        # Check for explicit success message
+        if result.returncode == 0 and "ok" in combined_output.lower():
+            return FlacMd5State.VALID
 
-        # Check for explicit error messages (shouldn't happen with return code 0, but defensive)
+        # Check for ID3v1-related errors when ID3v1 tags are present
+        has_id3v1 = self._has_id3v1_tags()
+        if has_id3v1 and "FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC" in combined_output:
+            return FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+
+        # Check for explicit MD5 mismatch (corruption)
         if "MD5 signature mismatch" in combined_output:
-            return False
-        if "FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC" in combined_output:
-            return False
+            return FlacMd5State.INVALID
 
-        # Check for explicit success message
-        if "ok" in combined_output.lower():
-            return True
+        # If flac -t failed and we have ID3v1 tags, it's likely due to ID3v1 interference
+        if has_id3v1 and result.returncode != 0:
+            return FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+
+        # If return code is non-zero and no specific error message, assume invalid
+        if result.returncode != 0:
+            return FlacMd5State.INVALID
 
         # If return code was 0 but no "ok" found, something unexpected happened
         msg = "The Flac file md5 check failed"

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/test/tests/integration/technical_info/flac_md5/test_invalid_md5/test_audio_data_corruption.py

@@ -1,6 +1,6 @@
 import pytest
 
-from audiometa import is_flac_md5_valid
+from audiometa import FlacMd5State, is_flac_md5_valid
 from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
 from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_audio_data, ensure_flac_has_md5
 
@@ -18,4 +18,5 @@ class TestAudioDataCorruption:
             # If the decoded PCM is unchanged, the MD5 will still match (correct behavior).
             # Manual MD5 verification works correctly - it will detect when MD5 doesn't match PCM.
             # This test verifies the function handles this scenario gracefully.
-            assert isinstance(result, bool)
+            assert isinstance(result, FlacMd5State)
+            assert result in [FlacMd5State.VALID, FlacMd5State.INVALID]

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/test/tests/integration/technical_info/flac_md5/test_invalid_md5/test_flipped_md5.py

@@ -2,7 +2,7 @@ from pathlib import Path
 
 import pytest
 
-from audiometa import fix_md5_checking, is_flac_md5_valid
+from audiometa import FlacMd5State, fix_md5_checking, is_flac_md5_valid
 from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
 from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_md5, ensure_flac_has_md5
 
@@ -14,16 +14,18 @@ class TestFlippedMd5:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "flip_all")
 
-            assert not is_flac_md5_valid(test_file), "Flipped MD5 should be detected as invalid"
+            assert is_flac_md5_valid(test_file) == FlacMd5State.INVALID, "Flipped MD5 should be detected as INVALID"
 
     def test_fix_md5_checking_flac(self):
         with temp_file_with_metadata({}, "flac") as test_file:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "flip_all")
 
-            assert not is_flac_md5_valid(test_file), "Test file should have invalid MD5 for fix_md5_checking test"
+            assert (
+                is_flac_md5_valid(test_file) == FlacMd5State.INVALID
+            ), "Test file should have invalid MD5 for fix_md5_checking test"
 
             fixed_file_path = fix_md5_checking(test_file)
-            assert is_flac_md5_valid(fixed_file_path), "Fixed file should have valid MD5"
+            assert is_flac_md5_valid(fixed_file_path) == FlacMd5State.VALID, "Fixed file should have valid MD5"
 
             Path(fixed_file_path).unlink()

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/test/tests/integration/technical_info/flac_md5/test_invalid_md5/test_partial_md5.py

@@ -2,7 +2,7 @@ from pathlib import Path
 
 import pytest
 
-from audiometa import fix_md5_checking, is_flac_md5_valid
+from audiometa import FlacMd5State, fix_md5_checking, is_flac_md5_valid
 from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
 from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_md5, ensure_flac_has_md5
 
@@ -14,16 +14,18 @@ class TestPartialMd5:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "partial")
 
-            assert not is_flac_md5_valid(test_file), "Partially corrupted MD5 should be detected as invalid"
+            assert (
+                is_flac_md5_valid(test_file) == FlacMd5State.INVALID
+            ), "Partially corrupted MD5 should be detected as INVALID"
 
     def test_fix_md5_checking_with_partial_corruption(self):
         with temp_file_with_metadata({}, "flac") as test_file:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "partial")
 
-            assert not is_flac_md5_valid(test_file), "Partially corrupted MD5 should be invalid"
+            assert is_flac_md5_valid(test_file) == FlacMd5State.INVALID, "Partially corrupted MD5 should be INVALID"
 
             fixed_file_path = fix_md5_checking(test_file)
-            assert is_flac_md5_valid(fixed_file_path), "Fixed file should have valid MD5"
+            assert is_flac_md5_valid(fixed_file_path) == FlacMd5State.VALID, "Fixed file should have valid MD5"
 
             Path(fixed_file_path).unlink()

{audiometa_python-0.6.1 → audiometa_python-0.7.1}/audiometa/test/tests/integration/technical_info/flac_md5/test_invalid_md5/test_random_md5.py

@@ -2,7 +2,7 @@ from pathlib import Path
 
 import pytest
 
-from audiometa import fix_md5_checking, is_flac_md5_valid
+from audiometa import FlacMd5State, fix_md5_checking, is_flac_md5_valid
 from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
 from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_md5, ensure_flac_has_md5
 
@@ -14,16 +14,18 @@ class TestRandomMd5:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "random")
 
-            assert not is_flac_md5_valid(test_file), "Random MD5 corruption should be detected as invalid"
+            assert (
+                is_flac_md5_valid(test_file) == FlacMd5State.INVALID
+            ), "Random MD5 corruption should be detected as INVALID"
 
     def test_fix_md5_checking_with_random_corruption(self):
         with temp_file_with_metadata({}, "flac") as test_file:
             ensure_flac_has_md5(test_file)
             corrupt_md5(test_file, "random")
 
-            assert not is_flac_md5_valid(test_file), "Random MD5 corruption should be invalid"
+            assert is_flac_md5_valid(test_file) == FlacMd5State.INVALID, "Random MD5 corruption should be INVALID"
 
             fixed_file_path = fix_md5_checking(test_file)
-            assert is_flac_md5_valid(fixed_file_path), "Fixed file should have valid MD5"
+            assert is_flac_md5_valid(fixed_file_path) == FlacMd5State.VALID, "Fixed file should have valid MD5"
 
             Path(fixed_file_path).unlink()

audiometa_python-0.7.1/audiometa/test/tests/integration/technical_info/flac_md5/test_metadata_combinations/test_md5_invalid_with_metadata_combinations.py

@@ -0,0 +1,101 @@
+"""Test INVALID MD5 state with metadata format combinations that support validation."""
+
+import pytest
+
+from audiometa import FlacMd5State, is_flac_md5_valid
+from audiometa.test.helpers.id3v1 import ID3v1MetadataSetter
+from audiometa.test.helpers.id3v2 import ID3v2MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.helpers.vorbis import VorbisMetadataSetter
+from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_md5, ensure_flac_has_md5
+
+
+@pytest.mark.integration
+class TestMd5InvalidWithMetadataCombinations:
+    """Test INVALID MD5 state with metadata format combinations that support validation."""
+
+    def test_invalid_md5_no_metadata(self):
+        """Test INVALID state with no metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.INVALID, "Clean FLAC with invalid MD5 should return INVALID"
+
+    def test_invalid_md5_vorbis_only(self):
+        """Test INVALID state with Vorbis metadata only."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.INVALID, "FLAC with Vorbis metadata and invalid MD5 should return INVALID"
+
+    def test_invalid_md5_id3v2_only(self):
+        """Test INVALID state with ID3v2 metadata only."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.INVALID, "FLAC with ID3v2 metadata and invalid MD5 should return INVALID"
+
+    def test_invalid_md5_vorbis_and_id3v2(self):
+        """Test INVALID state with Vorbis and ID3v2 metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.INVALID
+            ), "FLAC with Vorbis and ID3v2 metadata and invalid MD5 should return INVALID"
+
+    def test_invalid_md5_with_id3v1_returns_uncheckable(self):
+        """Test that invalid MD5 with ID3v1 returns UNCHECKABLE_DUE_TO_ID3, not INVALID."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "FLAC with ID3v1 should return UNCHECKABLE_DUE_TO_ID3 even if MD5 corrupted (ID3v1 takes precedence)"
+
+    def test_invalid_md5_vorbis_and_id3v1_returns_uncheckable(self):
+        """Test that invalid MD5 with Vorbis and ID3v1 returns UNCHECKABLE_DUE_TO_ID3."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "FLAC with Vorbis and ID3v1 metadata should return UNCHECKABLE_DUE_TO_ID3 (ID3v1 takes precedence)"
+
+    def test_invalid_md5_id3v1_and_id3v2_returns_uncheckable(self):
+        """Test that invalid MD5 with ID3v1 and ID3v2 returns UNCHECKABLE_DUE_TO_ID3."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "FLAC with ID3v1 and ID3v2 metadata should return UNCHECKABLE_DUE_TO_ID3 (ID3v1 takes precedence)"
+
+    def test_invalid_md5_all_formats_returns_uncheckable(self):
+        """Test that invalid MD5 with all metadata formats returns UNCHECKABLE_DUE_TO_ID3."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "FLAC with all metadata formats should return UNCHECKABLE_DUE_TO_ID3 (ID3v1 takes precedence)"

audiometa_python-0.7.1/audiometa/test/tests/integration/technical_info/flac_md5/test_metadata_combinations/test_md5_state_precedence.py

@@ -0,0 +1,39 @@
+"""Test that state detection follows correct precedence rules for MD5 validation."""
+
+import pytest
+
+from audiometa import FlacMd5State, is_flac_md5_valid
+from audiometa.test.helpers.id3v1 import ID3v1MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.tests.integration.technical_info.flac_md5.conftest import (
+    corrupt_md5,
+    create_flac_without_md5,
+    ensure_flac_has_md5,
+)
+
+
+@pytest.mark.integration
+class TestMd5StatePrecedence:
+    """Test that state detection follows correct precedence rules."""
+
+    def test_unset_takes_precedence_over_uncheckable(self):
+        """Test that UNSET state takes precedence over UNCHECKABLE_DUE_TO_ID3."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            create_flac_without_md5(test_file)
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNSET
+            ), "UNSET should take precedence over UNCHECKABLE_DUE_TO_ID3 when MD5 is unset"
+
+    def test_uncheckable_takes_precedence_over_invalid_when_id3v1_present(self):
+        """Test that UNCHECKABLE_DUE_TO_ID3 takes precedence over INVALID when ID3v1 is present."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "UNCHECKABLE_DUE_TO_ID3 should take precedence over INVALID when ID3v1 is present"

audiometa_python-0.7.1/audiometa/test/tests/integration/technical_info/flac_md5/test_metadata_combinations/test_md5_unset_with_metadata_combinations.py

@@ -0,0 +1,101 @@
+"""Test UNSET MD5 state with all metadata format combinations."""
+
+import pytest
+
+from audiometa import FlacMd5State, is_flac_md5_valid
+from audiometa.test.helpers.id3v1 import ID3v1MetadataSetter
+from audiometa.test.helpers.id3v2 import ID3v2MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.helpers.vorbis import VorbisMetadataSetter
+from audiometa.test.tests.integration.technical_info.flac_md5.conftest import (
+    create_flac_without_md5,
+    ensure_flac_has_md5,
+)
+
+
+@pytest.mark.integration
+class TestMd5UnsetWithMetadataCombinations:
+    """Test UNSET MD5 state with all metadata format combinations."""
+
+    def test_unset_md5_no_metadata(self):
+        """Test UNSET state with no metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            create_flac_without_md5(test_file)
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.UNSET, "Clean FLAC with unset MD5 should return UNSET"
+
+    def test_unset_md5_vorbis_only(self):
+        """Test UNSET state with Vorbis metadata only."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.UNSET, "FLAC with Vorbis metadata and unset MD5 should return UNSET"
+
+    def test_unset_md5_id3v2_only(self):
+        """Test UNSET state with ID3v2 metadata only."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.UNSET, "FLAC with ID3v2 metadata and unset MD5 should return UNSET"
+
+    def test_unset_md5_id3v1_only(self):
+        """Test UNSET state with ID3v1 metadata only (should still be UNSET, not UNCHECKABLE)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNSET
+            ), "FLAC with ID3v1 metadata and unset MD5 should return UNSET (unset takes precedence)"
+
+    def test_unset_md5_vorbis_and_id3v2(self):
+        """Test UNSET state with Vorbis and ID3v2 metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.UNSET, "FLAC with Vorbis and ID3v2 metadata and unset MD5 should return UNSET"
+
+    def test_unset_md5_vorbis_and_id3v1(self):
+        """Test UNSET state with Vorbis and ID3v1 metadata (unset takes precedence)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNSET
+            ), "FLAC with Vorbis and ID3v1 metadata and unset MD5 should return UNSET (unset takes precedence)"
+
+    def test_unset_md5_id3v1_and_id3v2(self):
+        """Test UNSET state with ID3v1 and ID3v2 metadata (unset takes precedence)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNSET
+            ), "FLAC with ID3v1 and ID3v2 metadata and unset MD5 should return UNSET (unset takes precedence)"
+
+    def test_unset_md5_all_formats(self):
+        """Test UNSET state with all metadata formats (unset takes precedence)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            create_flac_without_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNSET
+            ), "FLAC with all metadata formats and unset MD5 should return UNSET (unset takes precedence)"

audiometa_python-0.7.1/audiometa/test/tests/integration/technical_info/flac_md5/test_metadata_combinations/test_md5_validation_fails_with_id3v1.py

@@ -0,0 +1,61 @@
+"""Test that MD5 validation returns UNCHECKABLE_DUE_TO_ID3 when ID3v1 tags are present."""
+
+import pytest
+
+from audiometa import FlacMd5State, is_flac_md5_valid
+from audiometa.test.helpers.id3v1 import ID3v1MetadataSetter
+from audiometa.test.helpers.id3v2 import ID3v2MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.helpers.vorbis import VorbisMetadataSetter
+from audiometa.test.tests.integration.technical_info.flac_md5.conftest import ensure_flac_has_md5
+
+
+@pytest.mark.integration
+class TestMd5ValidationFailsWithId3v1:
+    """Test that MD5 validation returns UNCHECKABLE_DUE_TO_ID3 when ID3v1 tags are present.
+
+    These tests confirm that validation fails (returns UNCHECKABLE_DUE_TO_ID3) for all
+    metadata combinations that include ID3v1 tags, regardless of other metadata formats.
+    """
+
+    def test_validation_fails_id3v1_only(self):
+        """Test that validation fails with ID3v1 metadata only."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            state = is_flac_md5_valid(test_file)
+            assert state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1, "Validation should fail with ID3v1 metadata only"
+
+    def test_validation_fails_vorbis_and_id3v1(self):
+        """Test that validation fails with Vorbis and ID3v1 metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "Validation should fail with Vorbis and ID3v1 metadata"
+
+    def test_validation_fails_id3v1_and_id3v2(self):
+        """Test that validation fails with ID3v1 and ID3v2 metadata."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "Validation should fail with ID3v1 and ID3v2 metadata"
+
+    def test_validation_fails_all_formats(self):
+        """Test that validation fails with all metadata formats (ID3v1 present)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            VorbisMetadataSetter.add_title(test_file, "Vorbis Title")
+            ID3v1MetadataSetter.set_title(test_file, "ID3v1 Title")
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.UNCHECKABLE_DUE_TO_ID3V1
+            ), "Validation should fail with all metadata formats when ID3v1 is present"

audiometa_python-0.7.1/audiometa/test/tests/integration/technical_info/flac_md5/test_metadata_combinations/test_md5_validation_with_id3v2_only.py

@@ -0,0 +1,42 @@
+"""Test that ID3v2 tags alone do NOT cause validation failures."""
+
+import pytest
+
+from audiometa import FlacMd5State, is_flac_md5_valid
+from audiometa.test.helpers.id3v2 import ID3v2MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.tests.integration.technical_info.flac_md5.conftest import corrupt_md5, ensure_flac_has_md5
+
+
+@pytest.mark.integration
+class TestMd5ValidationWithId3v2Only:
+    """Test that ID3v2 tags alone do NOT cause validation failures.
+
+    These tests verify that ID3v2 tags (without ID3v1) do not interfere with validation
+    and return appropriate states (VALID or INVALID) based on actual MD5 state.
+    """
+
+    def test_id3v2_alone_with_valid_md5_returns_valid(self):
+        """Test that ID3v2 tags alone with valid MD5 return VALID (not UNCHECKABLE)."""
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.VALID
+            ), "ID3v2 tags alone with valid MD5 should return VALID, not UNCHECKABLE_DUE_TO_ID3"
+
+    def test_id3v2_alone_with_invalid_md5_returns_invalid(self):
+        """Test that ID3v2 tags alone with invalid MD5 return INVALID (not UNCHECKABLE).
+
+        This confirms that ID3v2 tags do NOT cause validation failures - even with
+        corrupted MD5, we get INVALID (actual corruption) rather than UNCHECKABLE_DUE_TO_ID3.
+        """
+        with temp_file_with_metadata({}, "flac") as test_file:
+            ensure_flac_has_md5(test_file)
+            ID3v2MetadataSetter.set_metadata(test_file, {"title": "ID3v2 Title"})
+            corrupt_md5(test_file, "random")
+            state = is_flac_md5_valid(test_file)
+            assert (
+                state == FlacMd5State.INVALID
+            ), "ID3v2 alone with invalid MD5 returns INVALID, not UNCHECKABLE. Proves ID3v2 doesn't cause failures."