audiometa-python 0.2.9__tar.gz → 0.3.0__tar.gz

{audiometa_python-0.2.9/audiometa_python.egg-info → audiometa_python-0.3.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: audiometa-python
-Version: 0.2.9
+Version: 0.3.0
 Summary: A comprehensive Python library for reading and writing audio metadata across multiple formats
 Author: AudioMeta Python Contributors
 Author-email: Andreas Garcia <garcia.andreas.1991@gmail.com>

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/__init__.py

@@ -510,6 +510,21 @@ def validate_metadata_for_update(
             if isinstance(track_number_value, str | int):
                 _MetadataManager.validate_track_number(track_number_value)
 
+    # Validate disc number if present and non-empty
+    if UnifiedMetadataKey.DISC_NUMBER in normalized_metadata:
+        disc_number_value = normalized_metadata[UnifiedMetadataKey.DISC_NUMBER]
+        if disc_number_value is not None:
+            from .manager._MetadataManager import _MetadataManager
+
+            _MetadataManager.validate_disc_number(disc_number_value)
+
+    # Validate disc total if present
+    if UnifiedMetadataKey.DISC_TOTAL in normalized_metadata:
+        disc_total_value = normalized_metadata[UnifiedMetadataKey.DISC_TOTAL]
+        from .manager._MetadataManager import _MetadataManager
+
+        _MetadataManager.validate_disc_total(disc_total_value)
+
 
 def update_metadata(
     file: PublicFileType,

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/manager/_MetadataManager.py

@@ -158,6 +158,63 @@ class _MetadataManager:
                 track_number,
             )
 
+    @staticmethod
+    def validate_disc_number(disc_number: int) -> None:
+        """Validate disc number format.
+
+        Disc numbers must be non-negative integers.
+
+        Args:
+            disc_number: The disc number to validate (int)
+
+        Raises:
+            InvalidMetadataFieldFormatError: If the disc number format is invalid
+
+        Examples:
+            >>> _MetadataManager.validate_disc_number(1)  # Valid
+            >>> _MetadataManager.validate_disc_number(0)  # Valid
+            >>> _MetadataManager.validate_disc_number(-1)  # Raises InvalidMetadataFieldFormatError
+        """
+        if not isinstance(disc_number, int):
+            raise InvalidMetadataFieldFormatError(
+                UnifiedMetadataKey.DISC_NUMBER.value, "integer", str(type(disc_number).__name__)
+            )
+
+        if disc_number < 0:
+            raise InvalidMetadataFieldFormatError(
+                UnifiedMetadataKey.DISC_NUMBER.value, "non-negative integer", str(disc_number)
+            )
+
+    @staticmethod
+    def validate_disc_total(disc_total: int | None) -> None:
+        """Validate disc total format.
+
+        Disc totals must be non-negative integers or None.
+
+        Args:
+            disc_total: The disc total to validate (int or None)
+
+        Raises:
+            InvalidMetadataFieldFormatError: If the disc total format is invalid
+
+        Examples:
+            >>> _MetadataManager.validate_disc_total(2)  # Valid
+            >>> _MetadataManager.validate_disc_total(None)  # Valid
+            >>> _MetadataManager.validate_disc_total(-1)  # Raises InvalidMetadataFieldFormatError
+        """
+        if disc_total is None:
+            return
+
+        if not isinstance(disc_total, int):
+            raise InvalidMetadataFieldFormatError(
+                UnifiedMetadataKey.DISC_TOTAL.value, "integer or None", str(type(disc_total).__name__)
+            )
+
+        if disc_total < 0:
+            raise InvalidMetadataFieldFormatError(
+                UnifiedMetadataKey.DISC_TOTAL.value, "non-negative integer", str(disc_total)
+            )
+
     @abstractmethod
     def _extract_mutagen_metadata(self) -> MutagenMetadata:
         raise NotImplementedError
@@ -535,7 +592,7 @@ class _MetadataManager:
         if unified_metadata_key_optional_type is float:
             return float(value[0]) if value else None
         if origin is not None and (origin == Union or (hasattr(origin, "__name__") and origin.__name__ == "UnionType")):
-            # Handle union types like int | float
+            # Handle union types like int | float or int | None
             arg_types = get_args(unified_metadata_key_optional_type)
             if int in arg_types and float in arg_types:
                 # For int | float, prefer int if it's a whole number, otherwise float
@@ -547,6 +604,12 @@ class _MetadataManager:
                         return num_value
                 except (ValueError, TypeError):
                     return None
+            if int in arg_types and type(None) in arg_types:
+                # For int | None, convert to int if value exists, otherwise None
+                try:
+                    return int(value[0]) if value else None
+                except (ValueError, TypeError):
+                    return None
         if unified_metadata_key_optional_type is str:
             return str(value[0]) if value else None
         if unified_metadata_key_optional_type == list[str]:

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/manager/_rating_supporting/id3v2/_Id3v2Manager.py

@@ -25,6 +25,7 @@ from mutagen.id3._frames import (
     TMOO,
     TPE1,
     TPE2,
+    TPOS,
     TPUB,
     TRCK,
     TSRC,
@@ -213,6 +214,7 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
         YEAR = "TYER"  # ID3v2.3 year
         DATE = "TDAT"  # ID3v2.3 date (DDMM)
         TRACK_NUMBER = "TRCK"
+        DISC_NUMBER = "TPOS"
         BPM = "TBPM"
 
         # Additional metadata fields
@@ -240,6 +242,7 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
         Id3TextFrame.YEAR: TYER,
         Id3TextFrame.DATE: TDAT,
         Id3TextFrame.TRACK_NUMBER: TRCK,
+        Id3TextFrame.DISC_NUMBER: TPOS,
         Id3TextFrame.BPM: TBPM,
         Id3TextFrame.RATING: POPM,
         Id3TextFrame.COMPOSERS: TCOM,
@@ -271,6 +274,8 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
             UnifiedMetadataKey.LANGUAGE: self.Id3TextFrame.LANGUAGE,
             UnifiedMetadataKey.RELEASE_DATE: self.Id3TextFrame.RECORDING_TIME,
             UnifiedMetadataKey.TRACK_NUMBER: self.Id3TextFrame.TRACK_NUMBER,
+            UnifiedMetadataKey.DISC_NUMBER: None,
+            UnifiedMetadataKey.DISC_TOTAL: None,
             UnifiedMetadataKey.BPM: self.Id3TextFrame.BPM,
             UnifiedMetadataKey.COMPOSERS: self.Id3TextFrame.COMPOSERS,
             UnifiedMetadataKey.PUBLISHER: self.Id3TextFrame.PUBLISHER,
@@ -289,6 +294,8 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
             UnifiedMetadataKey.LANGUAGE: self.Id3TextFrame.LANGUAGE,
             UnifiedMetadataKey.RELEASE_DATE: self.Id3TextFrame.RECORDING_TIME,
             UnifiedMetadataKey.TRACK_NUMBER: self.Id3TextFrame.TRACK_NUMBER,
+            UnifiedMetadataKey.DISC_NUMBER: None,
+            UnifiedMetadataKey.DISC_TOTAL: None,
             UnifiedMetadataKey.BPM: self.Id3TextFrame.BPM,
             UnifiedMetadataKey.COMPOSERS: self.Id3TextFrame.COMPOSERS,
             UnifiedMetadataKey.PUBLISHER: self.Id3TextFrame.PUBLISHER,
@@ -434,6 +441,56 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
             if app_metadata_value is not None:
                 # Add new TXXX frame with desc 'REPLAYGAIN'
                 raw_mutagen_metadata.add(TXXX(encoding=3, desc="REPLAYGAIN", text=str(app_metadata_value)))
+        elif unified_metadata_key in (UnifiedMetadataKey.DISC_NUMBER, UnifiedMetadataKey.DISC_TOTAL):
+            tpos_key = self.Id3TextFrame.DISC_NUMBER
+            tpos_frame_class = TPOS
+            encoding = 0 if self.id3v2_version[1] == ID3V2_VERSION_3 else 3
+
+            if unified_metadata_key == UnifiedMetadataKey.DISC_NUMBER:
+                current_tpos = raw_mutagen_metadata.get(tpos_key)
+                current_total = None
+                if current_tpos and len(current_tpos.text) > 0:
+                    tpos_str = str(current_tpos.text[0])
+                    import re
+
+                    match = re.match(r"^(\d+)/(\d+)$", tpos_str)
+                    if match:
+                        current_total = int(match.group(2))
+
+                raw_mutagen_metadata.delall(tpos_key)
+                if app_metadata_value is not None:
+                    if not isinstance(app_metadata_value, int):
+                        msg = f"DISC_NUMBER must be an integer, got {type(app_metadata_value).__name__}"
+                        raise TypeError(msg)
+                    disc_number = min(255, max(0, app_metadata_value))
+                    tpos_value = f"{disc_number}/{current_total}" if current_total is not None else str(disc_number)
+                    raw_mutagen_metadata.add(tpos_frame_class(encoding=encoding, text=tpos_value))
+            elif unified_metadata_key == UnifiedMetadataKey.DISC_TOTAL:
+                current_tpos = raw_mutagen_metadata.get(tpos_key)
+                current_disc_number = None
+                if current_tpos and len(current_tpos.text) > 0:
+                    tpos_str = str(current_tpos.text[0])
+                    import re
+
+                    match = re.match(r"^(\d+)(?:/(\d+))?$", tpos_str)
+                    if match:
+                        current_disc_number = int(match.group(1))
+
+                raw_mutagen_metadata.delall(tpos_key)
+                if app_metadata_value is not None:
+                    if not isinstance(app_metadata_value, int):
+                        msg = f"DISC_TOTAL must be an integer, got {type(app_metadata_value).__name__}"
+                        raise TypeError(msg)
+                    disc_total = min(255, max(0, app_metadata_value))
+                    if current_disc_number is not None:
+                        tpos_value = f"{current_disc_number}/{disc_total}"
+                        raw_mutagen_metadata.add(tpos_frame_class(encoding=encoding, text=tpos_value))
+                    else:
+                        msg = "Cannot set DISC_TOTAL without DISC_NUMBER"
+                        raise ValueError(msg)
+                elif current_disc_number is not None:
+                    tpos_value = str(current_disc_number)
+                    raw_mutagen_metadata.add(tpos_frame_class(encoding=encoding, text=tpos_value))
         else:
             super()._update_undirectly_mapped_metadata(  # type: ignore[safe-super]
                 cast(Any, raw_mutagen_metadata), app_metadata_value, unified_metadata_key
@@ -453,6 +510,34 @@ class _Id3v2Manager(_RatingSupportingMetadataManager):
                 return None
             first_value = replaygain_value[0]
             return cast(UnifiedMetadataValue, first_value)
+        if unified_metadata_key == UnifiedMetadataKey.DISC_NUMBER:
+            tpos_key = self.Id3TextFrame.DISC_NUMBER
+            if tpos_key not in raw_clean_metadata:
+                return None
+            tpos_value = raw_clean_metadata[tpos_key]
+            if tpos_value is None or len(tpos_value) == 0:
+                return None
+            tpos_str = str(tpos_value[0])
+            import re
+
+            match = re.match(r"^(\d+)(?:/(\d+))?$", tpos_str)
+            if match:
+                return int(match.group(1))
+            return None
+        if unified_metadata_key == UnifiedMetadataKey.DISC_TOTAL:
+            tpos_key = self.Id3TextFrame.DISC_NUMBER
+            if tpos_key not in raw_clean_metadata:
+                return None
+            tpos_value = raw_clean_metadata[tpos_key]
+            if tpos_value is None or len(tpos_value) == 0:
+                return None
+            tpos_str = str(tpos_value[0])
+            import re
+
+            match = re.match(r"^(\d+)/(\d+)$", tpos_str)
+            if match:
+                return int(match.group(2))
+            return None
         msg = f"Metadata key not handled: {unified_metadata_key}"
         raise MetadataFieldNotSupportedByMetadataFormatError(msg)
 

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/manager/_rating_supporting/vorbis/_VorbisManager.py

@@ -48,6 +48,8 @@ class _VorbisManager(_RatingSupportingMetadataManager):
         GENRES_NAMES = "GENRE"
         DATE = "DATE"  # Creation/Release date
         TRACK_NUMBER = "TRACKNUMBER"
+        DISC_NUMBER = "DISCNUMBER"
+        DISC_TOTAL = "DISCTOTAL"
         COMMENT = "COMMENT"
         PERFORMER = "PERFORMER"
         COPYRIGHT = "COPYRIGHT"
@@ -80,6 +82,8 @@ class _VorbisManager(_RatingSupportingMetadataManager):
             UnifiedMetadataKey.LANGUAGE: self.VorbisKey.LANGUAGE,
             UnifiedMetadataKey.RELEASE_DATE: self.VorbisKey.DATE,
             UnifiedMetadataKey.TRACK_NUMBER: self.VorbisKey.TRACK_NUMBER,
+            UnifiedMetadataKey.DISC_NUMBER: self.VorbisKey.DISC_NUMBER,
+            UnifiedMetadataKey.DISC_TOTAL: self.VorbisKey.DISC_TOTAL,
             UnifiedMetadataKey.BPM: self.VorbisKey.BPM,
             UnifiedMetadataKey.COMPOSERS: self.VorbisKey.COMPOSERS,
             UnifiedMetadataKey.COPYRIGHT: self.VorbisKey.COPYRIGHT,
@@ -98,6 +102,8 @@ class _VorbisManager(_RatingSupportingMetadataManager):
             UnifiedMetadataKey.LANGUAGE: self.VorbisKey.LANGUAGE,
             UnifiedMetadataKey.RELEASE_DATE: self.VorbisKey.DATE,
             UnifiedMetadataKey.TRACK_NUMBER: self.VorbisKey.TRACK_NUMBER,
+            UnifiedMetadataKey.DISC_NUMBER: self.VorbisKey.DISC_NUMBER,
+            UnifiedMetadataKey.DISC_TOTAL: self.VorbisKey.DISC_TOTAL,
             UnifiedMetadataKey.BPM: self.VorbisKey.BPM,
             UnifiedMetadataKey.COMPOSERS: self.VorbisKey.COMPOSERS,
             UnifiedMetadataKey.COPYRIGHT: self.VorbisKey.COPYRIGHT,
@@ -312,6 +318,13 @@ class _VorbisManager(_RatingSupportingMetadataManager):
 
         self._validate_and_process_rating(unified_metadata)
 
+        # Handle DISC_NUMBER and DISC_TOTAL relationship: if DISC_NUMBER is None, DISC_TOTAL should also be None
+        if (
+            UnifiedMetadataKey.DISC_NUMBER in unified_metadata
+            and unified_metadata[UnifiedMetadataKey.DISC_NUMBER] is None
+        ):
+            unified_metadata[UnifiedMetadataKey.DISC_TOTAL] = None
+
         # Get current metadata
         current_metadata = self._extract_mutagen_metadata()
 
@@ -365,6 +378,8 @@ class _VorbisManager(_RatingSupportingMetadataManager):
                 "GENRE": "GENRE",
                 "COMMENT": "COMMENT",
                 "TRACKNUMBER": "TRACKNUMBER",
+                "DISCNUMBER": "DISCNUMBER",
+                "DISCTOTAL": "DISCTOTAL",
                 "BPM": "BPM",
                 "COMPOSER": "COMPOSER",
                 "COPYRIGHT": "COPYRIGHT",

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/test/helpers/id3v2/id3v2_metadata_setter.py

@@ -43,6 +43,7 @@ class ID3v2MetadataSetter:
                 "mood": "--TMOO",
                 "key": "--TKEY",
                 "publisher": "--TPUB",
+                "disc_number": "--TPOS",
             }
         else:
             tool = "mid3v2"
@@ -70,6 +71,7 @@ class ID3v2MetadataSetter:
                 "key": "--TKEY",
                 "publisher": "--TPUB",
                 "bpm": "--TBPM",
+                "disc_number": "--TPOS",
             }
 
         metadata_added = False

{audiometa_python-0.2.9 → audiometa_python-0.3.0}/audiometa/test/helpers/vorbis/vorbis_metadata_setter.py

@@ -60,6 +60,8 @@ class VorbisMetadataSetter:
             "url": "URL",
             "isrc": "ISRC",
             "publisher": "PUBLISHER",
+            "disc_number": "DISCNUMBER",
+            "disc_total": "DISCTOTAL",
         }
 
         metadata_added = False

audiometa_python-0.3.0/audiometa/test/tests/integration/metadata_field/disc_number/test_deleting.py

@@ -0,0 +1,97 @@
+import pytest
+
+from audiometa import get_unified_metadata_field, update_metadata
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.utils.metadata_format import MetadataFormat
+from audiometa.utils.unified_metadata_key import UnifiedMetadataKey
+
+
+@pytest.mark.integration
+class TestDiscNumberDeleting:
+    def test_delete_disc_number_id3v2(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.ID3V2,
+            )
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) == 2
+
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: None}, metadata_format=MetadataFormat.ID3V2)
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) is None
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+
+    def test_delete_disc_total_only_id3v2(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.ID3V2,
+            )
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) == 2
+
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_TOTAL: None}, metadata_format=MetadataFormat.ID3V2)
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+
+    def test_delete_disc_number_vorbis(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.VORBIS,
+            )
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) == 2
+
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: None}, metadata_format=MetadataFormat.VORBIS)
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) is None
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+
+    def test_delete_disc_total_only_vorbis(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.VORBIS,
+            )
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) == 2
+
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_TOTAL: None}, metadata_format=MetadataFormat.VORBIS)
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 1
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+
+    def test_delete_disc_number_preserves_other_fields(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(
+                test_file,
+                {
+                    UnifiedMetadataKey.DISC_NUMBER: 1,
+                    UnifiedMetadataKey.DISC_TOTAL: 2,
+                    UnifiedMetadataKey.TITLE: "Test Title",
+                    UnifiedMetadataKey.ARTISTS: ["Test Artist"],
+                },
+            )
+
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: None})
+
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) is None
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.TITLE) == "Test Title"
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.ARTISTS) == ["Test Artist"]
+
+    def test_delete_disc_number_already_none(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: None})
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) is None
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL) is None
+
+    def test_delete_disc_number_zero(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: 0}, metadata_format=MetadataFormat.ID3V2)
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) == 0
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: None})
+            assert get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER) is None

audiometa_python-0.3.0/audiometa/test/tests/integration/metadata_field/disc_number/test_reading.py

@@ -0,0 +1,92 @@
+import pytest
+
+from audiometa import get_unified_metadata_field
+from audiometa.test.helpers.id3v2.id3v2_metadata_setter import ID3v2MetadataSetter
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.test.helpers.vorbis.vorbis_metadata_setter import VorbisMetadataSetter
+from audiometa.utils.unified_metadata_key import UnifiedMetadataKey
+
+
+@pytest.mark.integration
+class TestDiscNumberReading:
+    def test_id3v2_with_total(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            ID3v2MetadataSetter.set_metadata(test_file, {"disc_number": "1/2"})
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total == 2
+
+    def test_id3v2_without_total(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            ID3v2MetadataSetter.set_metadata(test_file, {"disc_number": "1"})
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total is None
+
+    def test_id3v2_max_value(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            ID3v2MetadataSetter.set_metadata(test_file, {"disc_number": "99/99"})
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 99
+            assert disc_total == 99
+
+    def test_vorbis_with_total(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            VorbisMetadataSetter.set_metadata(test_file, {"disc_number": "1", "disc_total": "2"})
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total == 2
+
+    def test_vorbis_without_total(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            VorbisMetadataSetter.set_metadata(test_file, {"disc_number": "2"})
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 2
+            assert disc_total is None
+
+    def test_id3v1_not_supported(self):
+        from audiometa.exceptions import MetadataFieldNotSupportedByMetadataFormatError
+        from audiometa.utils.metadata_format import MetadataFormat
+
+        with temp_file_with_metadata({}, "id3v1") as test_file:
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_NUMBER metadata not supported by ID3v1 format",
+            ):
+                get_unified_metadata_field(
+                    test_file, UnifiedMetadataKey.DISC_NUMBER, metadata_format=MetadataFormat.ID3V1
+                )
+
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_TOTAL metadata not supported by ID3v1 format",
+            ):
+                get_unified_metadata_field(
+                    test_file, UnifiedMetadataKey.DISC_TOTAL, metadata_format=MetadataFormat.ID3V1
+                )
+
+    def test_riff_not_supported(self):
+        from audiometa.exceptions import MetadataFieldNotSupportedByMetadataFormatError
+        from audiometa.utils.metadata_format import MetadataFormat
+
+        with temp_file_with_metadata({}, "wav") as test_file:
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_NUMBER metadata not supported by RIFF format",
+            ):
+                get_unified_metadata_field(
+                    test_file, UnifiedMetadataKey.DISC_NUMBER, metadata_format=MetadataFormat.RIFF
+                )
+
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_TOTAL metadata not supported by RIFF format",
+            ):
+                get_unified_metadata_field(
+                    test_file, UnifiedMetadataKey.DISC_TOTAL, metadata_format=MetadataFormat.RIFF
+                )

audiometa_python-0.3.0/audiometa/test/tests/integration/metadata_field/disc_number/test_writing.py

@@ -0,0 +1,153 @@
+import pytest
+
+from audiometa import get_unified_metadata_field, update_metadata
+from audiometa.test.helpers.temp_file_with_metadata import temp_file_with_metadata
+from audiometa.utils.metadata_format import MetadataFormat
+from audiometa.utils.unified_metadata_key import UnifiedMetadataKey
+
+
+@pytest.mark.integration
+class TestDiscNumberWriting:
+    @pytest.mark.parametrize(
+        ("disc_number", "disc_total", "expected_disc_number", "expected_disc_total"),
+        [
+            (1, None, 1, None),
+            (1, 2, 1, 2),
+            (99, 99, 99, 99),
+        ],
+    )
+    def test_id3v2_disc_number_writing(self, disc_number, disc_total, expected_disc_number, expected_disc_total):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            metadata = {UnifiedMetadataKey.DISC_NUMBER: disc_number}
+            if disc_total is not None:
+                metadata[UnifiedMetadataKey.DISC_TOTAL] = disc_total
+            update_metadata(test_file, metadata, metadata_format=MetadataFormat.ID3V2)
+
+            result_disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            result_disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert result_disc_number == expected_disc_number
+            assert result_disc_total == expected_disc_total
+
+    @pytest.mark.parametrize(
+        ("disc_number", "disc_total", "expected_disc_number", "expected_disc_total"),
+        [
+            (1, None, 1, None),
+            (1, 2, 1, 2),
+            (99, 99, 99, 99),
+        ],
+    )
+    def test_vorbis_disc_number_writing(self, disc_number, disc_total, expected_disc_number, expected_disc_total):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            metadata = {UnifiedMetadataKey.DISC_NUMBER: disc_number}
+            if disc_total is not None:
+                metadata[UnifiedMetadataKey.DISC_TOTAL] = disc_total
+            update_metadata(test_file, metadata, metadata_format=MetadataFormat.VORBIS)
+
+            result_disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            result_disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert result_disc_number == expected_disc_number
+            assert result_disc_total == expected_disc_total
+
+    def test_id3v2_disc_number_with_total_combines_format(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.ID3V2,
+            )
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total == 2
+
+    def test_id3v2_disc_number_without_total_writes_simple_format(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(test_file, {UnifiedMetadataKey.DISC_NUMBER: 1}, metadata_format=MetadataFormat.ID3V2)
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total is None
+
+    def test_vorbis_disc_number_writes_separate_fields(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 1, UnifiedMetadataKey.DISC_TOTAL: 2},
+                metadata_format=MetadataFormat.VORBIS,
+            )
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 1
+            assert disc_total == 2
+
+    def test_id3v2_disc_number_max_value_truncated(self):
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 256, UnifiedMetadataKey.DISC_TOTAL: 300},
+                metadata_format=MetadataFormat.ID3V2,
+            )
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 255
+            assert disc_total == 255
+
+    def test_vorbis_disc_number_no_limit(self):
+        with temp_file_with_metadata({}, "flac") as test_file:
+            update_metadata(
+                test_file,
+                {UnifiedMetadataKey.DISC_NUMBER: 256, UnifiedMetadataKey.DISC_TOTAL: 300},
+                metadata_format=MetadataFormat.VORBIS,
+            )
+            disc_number = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_NUMBER)
+            disc_total = get_unified_metadata_field(test_file, UnifiedMetadataKey.DISC_TOTAL)
+            assert disc_number == 256
+            assert disc_total == 300
+
+    def test_id3v1_not_supported(self):
+        from audiometa.exceptions import MetadataFieldNotSupportedByMetadataFormatError
+
+        with temp_file_with_metadata({}, "mp3") as test_file:
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_NUMBER metadata not supported by ID3v1 format",
+            ):
+                update_metadata(
+                    test_file,
+                    {UnifiedMetadataKey.DISC_NUMBER: 1},
+                    metadata_format=MetadataFormat.ID3V1,
+                )
+
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_TOTAL metadata not supported by ID3v1 format",
+            ):
+                update_metadata(
+                    test_file,
+                    {UnifiedMetadataKey.DISC_TOTAL: 2},
+                    metadata_format=MetadataFormat.ID3V1,
+                )
+
+    def test_riff_not_supported(self):
+        from audiometa.exceptions import MetadataFieldNotSupportedByMetadataFormatError
+
+        with temp_file_with_metadata({}, "wav") as test_file:
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_NUMBER metadata not supported by RIFF format",
+            ):
+                update_metadata(
+                    test_file,
+                    {UnifiedMetadataKey.DISC_NUMBER: 1},
+                    metadata_format=MetadataFormat.RIFF,
+                )
+
+            with pytest.raises(
+                MetadataFieldNotSupportedByMetadataFormatError,
+                match="UnifiedMetadataKey.DISC_TOTAL metadata not supported by RIFF format",
+            ):
+                update_metadata(
+                    test_file,
+                    {UnifiedMetadataKey.DISC_TOTAL: 2},
+                    metadata_format=MetadataFormat.RIFF,
+                )