atsfill 0.0.4.dev135__tar.gz → 0.0.4.dev136__tar.gz

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: atsfill
-Version: 0.0.4.dev135
+Version: 0.0.4.dev136
 Summary: Read, dry-run and submit job application forms on hiring systems: Ashby, Greenhouse, Teamtailor, Welcome to the Jungle.
 Keywords: job-applications,ats,ashby,greenhouse,teamtailor,ai-agents,cli
 Author: shbernal
@@ -137,7 +137,7 @@ A dry run or a `send` through an adapter no send was verified on carries a `warn
 
 One home can send for more than one user: `--user <name>` gives each their own sessions, double-send guard and `[users.<name>]` section in the config file ([ADR 0015](docs/adr/0015-users-and-accounts.md)).
 Given an account's email (`atsfill login <adapter> --email`) and a password source (a `[password-commands]` entry such as `rbw get example.com {email}`, or `--password -` on stdin), atsfill signs in by itself, and again whenever a form command finds the session signed out.
-When a system emails an OTP, on a sign-in, a sign-up or a form, atsfill gets it from the user's `[otp-commands]` entry, a command that reads the mailbox (`{email}` and `{since}` are filled in), and types it in; without one the command ends `blocked: email_otp`.
+When a system emails an OTP, on a sign-in, a sign-up or a form, atsfill gets it from the user's `[otp-commands]` entry, a command that reads the mailbox (`{email}` and `{since}` are filled in), and types it in; without one the command ends `blocked: no_otp_command`.
 Where a system's sign-up allows it, `atsfill login <adapter> --create --email <address>` (with `--details <file.json>` where the sign-up asks the user's name, phone or address) creates the account with a password atsfill generates and keeps in the system's secret store, never printed; creating an account is a side effect, never part of `fill` or `send`.
 
 ## How it works

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/README.md

@@ -109,7 +109,7 @@ A dry run or a `send` through an adapter no send was verified on carries a `warn
 
 One home can send for more than one user: `--user <name>` gives each their own sessions, double-send guard and `[users.<name>]` section in the config file ([ADR 0015](docs/adr/0015-users-and-accounts.md)).
 Given an account's email (`atsfill login <adapter> --email`) and a password source (a `[password-commands]` entry such as `rbw get example.com {email}`, or `--password -` on stdin), atsfill signs in by itself, and again whenever a form command finds the session signed out.
-When a system emails an OTP, on a sign-in, a sign-up or a form, atsfill gets it from the user's `[otp-commands]` entry, a command that reads the mailbox (`{email}` and `{since}` are filled in), and types it in; without one the command ends `blocked: email_otp`.
+When a system emails an OTP, on a sign-in, a sign-up or a form, atsfill gets it from the user's `[otp-commands]` entry, a command that reads the mailbox (`{email}` and `{since}` are filled in), and types it in; without one the command ends `blocked: no_otp_command`.
 Where a system's sign-up allows it, `atsfill login <adapter> --create --email <address>` (with `--details <file.json>` where the sign-up asks the user's name, phone or address) creates the account with a password atsfill generates and keeps in the system's secret store, never printed; creating an account is a side effect, never part of `fill` or `send`.
 
 ## How it works

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "atsfill"
-version = "0.0.4.dev135"
+version = "0.0.4.dev136"
 description = "Read, dry-run and submit job application forms on hiring systems: Ashby, Greenhouse, Teamtailor, Welcome to the Jungle."
 readme = "README.md"
 license = "MIT"

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/pyproject.toml.orig

@@ -1,6 +1,6 @@
 [project]
 name = "atsfill"
-version = "0.0.4.dev135"
+version = "0.0.4.dev136"
 description = "Read, dry-run and submit job application forms on hiring systems: Ashby, Greenhouse, Teamtailor, Welcome to the Jungle."
 readme = "README.md"
 license = "MIT"

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/src/atsfill/adapters/greenhouse.py

@@ -14,9 +14,9 @@ from contextlib import suppress
 from typing import Any
 from urllib.parse import parse_qs, urlencode, urlsplit
 
-from atsfill.core import browser
-from atsfill.core.adapter import Gap, Unsupported
-from atsfill.core.browser import HTTP_TIMEOUT_S, Page, Timeout
+from atsfill.core import browser, otp
+from atsfill.core.adapter import Blocked, Gap, Unsupported
+from atsfill.core.browser import HTTP_TIMEOUT_S, BrowserError, Page, Timeout
 from atsfill.core.results import Answer, Field, FieldType, SideEffect
 
 HOSTS = re.compile(r"^(job-boards|boards)(\.eu)?\.greenhouse\.io$")
@@ -33,6 +33,7 @@ HYDRATE_TIMEOUT_MS = 15_000
 FORM_TIMEOUT_MS = 20_000
 ANSWER_TIMEOUT_MS = 15_000  # an upload's file name, a suggestion: past it, a mismatch
 SUBMIT_TIMEOUT_MS = 90_000
+SUBMIT_POLL_MS = 500  # for the confirmation or the OTP step
 HYDRATE_POLL_MS = 500  # for a select's list to open, per click
 KEY_DELAY_MS = 20
 API_TYPES = {
@@ -43,6 +44,11 @@ API_TYPES = {
     "multi_value_multi_select": FieldType.MULTI_CHOICE,
 }
 YES_NO = ["Yes", "No"]
+CONFIRMATION = re.compile(r"/confirmation")
+# The OTP step a submit can stop at: a box per character of the OTP it emails.
+OTP_STEP = "fieldset#email-verification"
+OTP_INPUTS = f"{OTP_STEP} input[id^='security-input-']"
+OTP_ERROR = "#email-verification-error"
 # Sections the page adds or names its own way, or shows a question of only on another answer
 # (EEOC race after Hispanic/Latino): `request_read` declines a posting with any (ADR 0011).
 UNMAPPED = ("education", "compliance", "demographic_questions")
@@ -234,8 +240,24 @@ class Greenhouse:
         return {k: v for k, v in values.items() if v not in (None, "", [])}
 
     def submit(self, page: Page) -> str | None:
-        browser.click(page.locator(f"{FORM} button[type=submit]"))
-        page.wait_for_url(re.compile(r"/confirmation"), timeout=SUBMIT_TIMEOUT_MS)
+        """Submits, then types the emailed OTP where the step asks for one and submits again.
+        The evidence is the confirmation page."""
+        button = page.locator(f"{FORM} button[type=submit]")
+        browser.click(button)
+        if not _confirmed(page, OTP_INPUTS):
+            email = page.locator(f"{FORM} {_by_id('email')}").input_value()
+            otp.enter(page.locator(OTP_INPUTS), email, "the submit")
+            browser.click(button)
+            try:
+                confirmed = _confirmed(page, OTP_ERROR)
+            except Timeout:
+                if not page.locator(f"{OTP_INPUTS}:visible").count():
+                    raise
+                stayed = "unhandled_rendering: the submit stayed at the OTP step"
+                raise Unsupported(stayed) from None
+            if not confirmed:
+                message = page.locator(OTP_ERROR).first.inner_text().strip()
+                raise Blocked(f"otp_rejected: the submit did not take the OTP: {message}")
         return page.url
 
     def _field(self, page: Page, raw: dict[str, Any]) -> Field:
@@ -317,6 +339,19 @@ def _wait_until_live(page: Page) -> None:
         return
 
 
+def _confirmed(page: Page, step: str) -> bool:
+    """True once the page reaches the confirmation, False once `step` shows instead."""
+    deadline = time.monotonic() + SUBMIT_TIMEOUT_MS / 1000
+    while time.monotonic() < deadline:
+        with suppress(BrowserError):  # the page navigating away
+            if CONFIRMATION.search(page.url):
+                return True
+            if page.locator(f"{step}:visible").count():
+                return False
+        page.wait_for_timeout(SUBMIT_POLL_MS)
+    raise Timeout(f"no confirmation within {SUBMIT_TIMEOUT_MS} ms")
+
+
 def _board_job(url: str) -> tuple[str, str] | None:
     """The board and job id of a board URL: `/<board>/jobs/<id>` or `embed/job_app?for&token`."""
     parts = urlsplit(url)

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/src/atsfill/adapters/oracle.py

@@ -376,7 +376,7 @@ class Oracle:
                     timeout=STEP_TIMEOUT_MS
                 )
             except browser.Timeout:
-                raise Blocked("email_otp: the email step did not take the OTP") from None
+                raise Blocked("otp_rejected: the email step did not take the OTP") from None
         if page.locator(MANUALLY).count():
             _click(page, page.locator(MANUALLY).first)
             page.locator("apply-flow-block").first.wait_for(timeout=STEP_TIMEOUT_MS)

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/src/atsfill/adapters/successfactors.py

@@ -279,7 +279,7 @@ class SuccessFactors:
             page.locator(PASSCODE).wait_for(state="hidden", timeout=SIGN_IN_TIMEOUT_MS)
         except Timeout:
             message = self._message(page)
-            raise Blocked(f"email_otp: the sign-up did not take the OTP: {message}") from None
+            raise Blocked(f"otp_rejected: the sign-up did not take the OTP: {message}") from None
 
     def browser_read(self, page: Page) -> list[Field]:
         self._candidate(page)

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/src/atsfill/core/adapter.py

@@ -120,8 +120,8 @@ class SignsIn(NeedsAccount, Protocol):
 
     def sign_in(self, page: Page, email: str, password: str) -> None:
         """Signs in on the page `login_url` loaded. Raises `Blocked` for what the system waits
-        for (`email_link`, `email_otp`, `sms_otp`, `captcha`), `Refused` for what it turns down,
-        `Unsupported` for a page it does not know."""
+        for (`email_link`, `email_otp`, `sms_otp`, `captcha`, the OTP command's reasons),
+        `Refused` for what it turns down, `Unsupported` for a page it does not know."""
         ...
 
 

{atsfill-0.0.4.dev135 → atsfill-0.0.4.dev136}/src/atsfill/core/otp.py

@@ -53,17 +53,21 @@ def source(user: str, adapter: str, scope: str | None) -> Generator[None]:
 
 def enter(inputs: Locator, email: str, step: str) -> None:
     """Types the OTP emailed to `email` into the step's input, or one character into each of
-    its inputs. Raises `Blocked` (`email_otp`) when there is no entry, or no OTP within
-    `OTP_TIMEOUT_S`; `step` names where the OTP was asked, for the reason."""
+    its inputs. Raises `Blocked`: `no_otp_command` without an entry, `otp_not_received` when the
+    command prints none within `OTP_TIMEOUT_S`, `otp_rejected` when what it prints does not fit
+    the inputs; `step` names where the OTP was asked, for the reason."""
     current = _source.get()
-    asked = f"email_otp: {step} sent an OTP to {email}"
+    asked = f"{step} sent an OTP to {email}"
     if current is None or current.command is None:
         adapter = current.adapter if current else "the adapter"
-        raise Blocked(f"{asked}; no `otp-commands` entry for {adapter}")
+        raise Blocked(f"no_otp_command: {asked}; no `otp-commands` entry for {adapter}")
     otp = _wait(current, email, asked)
     count = inputs.count()
     if count > 1 and count != len(otp):
-        raise Blocked(f"{asked}; the OTP command printed {len(otp)} characters for {count} inputs")
+        raise Blocked(
+            f"otp_rejected: {asked}; the OTP command printed {len(otp)} characters"
+            f" for {count} inputs"
+        )
     if count > 1:
         for box, character in zip(inputs.all(), otp, strict=True):
             box.press_sequentially(character)
@@ -90,12 +94,15 @@ def _wait(current: Source, email: str, asked: str) -> str:
             break
         except OSError as e:
             raise Blocked(
-                f"{asked}; the OTP command `{args[0]}` failed: {type(e).__name__}"
+                f"otp_not_received: {asked}; the OTP command `{args[0]}` failed: {type(e).__name__}"
             ) from None
         if run.returncode == 0 and (otp := next(iter(run.stdout.split()), "")):
             return otp
         time.sleep(min(POLL_S, max(0.0, deadline - time.monotonic())))
-    raise Blocked(f"{asked}; the OTP command `{args[0]}` printed none within {OTP_TIMEOUT_S}s")
+    raise Blocked(
+        f"otp_not_received: {asked}; the OTP command `{args[0]}` printed none"
+        f" within {OTP_TIMEOUT_S}s"
+    )
 
 
 def _now() -> datetime: