arelle-release 2.37.38__tar.gz → 2.37.40__tar.gz

{arelle_release-2.37.38/arelle_release.egg-info → arelle_release-2.37.40}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: arelle-release
-Version: 2.37.38
+Version: 2.37.40
 Summary: An open source XBRL platform.
 Author-email: "arelle.org" <support@arelle.org>
 License-Expression: Apache-2.0

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/ModelInstanceObject.py

@@ -1266,7 +1266,7 @@ class ModelContext(ModelObject):
 
     def isEntityIdentifierEqualTo(self, cntx2):
         """(bool) -- True if entityIdentifier values are equal (scheme and text value)"""
-        return self.entityIdentifierHash == cntx2.entityIdentifierHash
+        return self.entityIdentifier == cntx2.entityIdentifier
 
     def isEqualTo(self, cntx2, dimensionalAspectModel=None) -> bool:
         if dimensionalAspectModel is None: dimensionalAspectModel = self.modelXbrl.hasXDT

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/ValidateXbrlCalcs.py

@@ -12,6 +12,8 @@ from arelle import Locale, XbrlConst, XbrlUtil
 from arelle.ModelObject import ObjectPropertyViewWrapper
 from arelle.PythonUtil import flattenSequence, strTruncate
 from arelle.XmlValidateConst import UNVALIDATED, VALID
+from arelle.utils.Contexts import partitionModelXbrlContexts
+from arelle.utils.Units import partitionModelXbrlUnits
 
 if TYPE_CHECKING:
     from _decimal import Decimal
@@ -147,27 +149,15 @@ class ValidateXbrlCalcs:
 
         # identify equal contexts
         modelXbrl.profileActivity()
-        uniqueContextHashes = {}
-        for context in modelXbrl.contexts.values():
-            h = context.contextDimAwareHash
-            if h in uniqueContextHashes:
-                if context.isEqualTo(uniqueContextHashes[h]):
-                    self.mapContext[context] = uniqueContextHashes[h]
-            else:
-                uniqueContextHashes[h] = context
-        del uniqueContextHashes
+        for exemplar_context, *contexts in partitionModelXbrlContexts(modelXbrl).values():
+            for context in contexts:
+                self.mapContext[context] = exemplar_context
         modelXbrl.profileActivity("... identify equal contexts", minTimeToShow=1.0)
 
         # identify equal units
-        uniqueUnitHashes = {}
-        for unit in modelXbrl.units.values():
-            h = unit.hash
-            if h in uniqueUnitHashes:
-                if unit.isEqualTo(uniqueUnitHashes[h]):
-                    self.mapUnit[unit] = uniqueUnitHashes[h]
-            else:
-                uniqueUnitHashes[h] = unit
-        del uniqueUnitHashes
+        for exemplar_unit, *units in partitionModelXbrlUnits(modelXbrl).values():
+            for unit in units:
+                self.mapUnit[unit] = exemplar_unit
         modelXbrl.profileActivity("... identify equal units", minTimeToShow=1.0)
 
         # identify concepts participating in essence-alias relationships

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/_version.py

@@ -17,5 +17,5 @@ __version__: str
 __version_tuple__: VERSION_TUPLE
 version_tuple: VERSION_TUPLE
 
-__version__ = version = '2.37.38'
-__version_tuple__ = version_tuple = (2, 37, 38)
+__version__ = version = '2.37.40'
+__version_tuple__ = version_tuple = (2, 37, 40)

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/DBA/rules/__init__.py

@@ -5,6 +5,7 @@ from __future__ import annotations
 
 import datetime
 import itertools
+from collections import defaultdict
 from collections.abc import Callable, Iterable
 from typing import Optional, cast
 
@@ -14,6 +15,7 @@ from arelle.ModelValue import QName
 from arelle.ModelXbrl import ModelXbrl
 from arelle.typing import TypeGetText
 from arelle.UrlUtil import scheme
+from arelle.utils.Contexts import ContextHashKey
 from arelle.utils.validate.Validation import Validation
 from arelle.ValidateFilingText import parseImageDataURL
 from arelle.ValidateXbrl import ValidateXbrl
@@ -266,19 +268,18 @@ def getFactsGroupedByContextId(modelXbrl: ModelXbrl, *conceptQns: QName) -> dict
     return dict(sorted(groupedFacts.items()))
 
 
-def groupFactsByContextHash(facts: set[ModelFact] ) -> dict[str, list[ModelFact]]:
+def groupFactsByContextHash(facts: set[ModelFact]) -> dict[ContextHashKey, list[ModelFact]]:
     """
-    Groups facts by their contextDimAwareHash.
-    :return: A dictionary of contextDimAwareHashes to list of facts.
+    Groups facts by their context hash key.
+    :return: A dictionary of context hash keys to list of facts.
     """
-    groupedFacts: dict[str, list[ModelFact]] = {}
+    groupedFacts: defaultdict[ContextHashKey, list[ModelFact]] = defaultdict(list)
     for fact in facts:
         if fact.xValid >= VALID:
-            contextHash = fact.context.contextDimAwareHash
-            if contextHash not in groupedFacts:
-                groupedFacts[contextHash] = []
+            contextHash = ContextHashKey(fact.context, dimensionalAspectModel=True)
             groupedFacts[contextHash].append(fact)
-    return dict(sorted(groupedFacts.items()))
+    groupedFacts.default_factory = None
+    return groupedFacts
 
 
 def lookup_namespaced_facts(modelXbrl: ModelXbrl, namespaceURI: str) -> set[ModelFact]:

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/DBA/rules/fr.py

@@ -602,9 +602,9 @@ def rule_fr57(
     DBA.FR57.Equality(Error):
     Assets (fsa:Assets) must equal Liabilities (fsa:LiabilitiesAndEquity)
     """
-    currenStartDateFacts =  getFactsWithDimension(val,pluginData.reportingPeriodStartDateQn, pluginData.consolidatedSoloDimensionQn, [pluginData.consolidatedMemberQn, pluginData.soloMemberQn])
+    currentStartDateFacts = getFactsWithDimension(val, pluginData.reportingPeriodStartDateQn, pluginData.consolidatedSoloDimensionQn, [pluginData.consolidatedMemberQn, pluginData.soloMemberQn])
     currentEndDateFacts = getFactsWithDimension(val, pluginData.reportingPeriodEndDateQn, pluginData.consolidatedSoloDimensionQn, [pluginData.consolidatedMemberQn, pluginData.soloMemberQn])
-    currentGroupedFacts = groupFactsByContextHash(currenStartDateFacts.union(currentEndDateFacts))
+    currentGroupedFacts = groupFactsByContextHash(currentStartDateFacts.union(currentEndDateFacts))
     precedingEndDateFacts = getFactsWithDimension(val, pluginData.precedingReportingPeriodEndDateQn, pluginData.consolidatedSoloDimensionQn, [pluginData.consolidatedMemberQn, pluginData.soloMemberQn])
     precedingStartDateFacts = getFactsWithDimension(val, pluginData.precedingReportingPeriodStartDateQn, pluginData.consolidatedSoloDimensionQn, [pluginData.consolidatedMemberQn, pluginData.soloMemberQn])
     precedingGroupedFacts = groupFactsByContextHash(precedingEndDateFacts.union(precedingStartDateFacts))
@@ -635,7 +635,7 @@ def rule_fr57(
         equityFacts = getFactsWithoutDimension(val, pluginData.equityQn)
         profitLossFacts = getFactsWithoutDimension(val, pluginData.profitLossQn)
         liabilitiesAndEquityFacts = getFactsWithoutDimension(val, pluginData.liabilitiesAndEquityQn)
-        for context, facts in currentGroupedFacts.items():
+        for facts in currentGroupedFacts.values():
             if len(facts) == 2:
                 for fact in facts:
                     if fact.qname == pluginData.reportingPeriodStartDateQn:

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/DBA/rules/tr.py

@@ -42,8 +42,10 @@ def rule_tr01(
         gsd_facts = lookup_namespaced_facts(val.modelXbrl, NAMESPACE_GSD)
         facts_in_error = []
         for fact in gsd_facts:
-            if (fact.context.entityIdentifier != cvr_fact.context.entityIdentifier or
-                    fact.context.periodHash != cvr_fact.context.periodHash):
+            if not (
+                fact.context.isEntityIdentifierEqualTo(cvr_fact.context) and
+                fact.context.isPeriodEqualTo(cvr_fact.context)
+            ):
                 facts_in_error.append(fact)
         if len(facts_in_error) > 0:
             yield Validation.error(

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/EBA/__init__.py

@@ -17,6 +17,7 @@ from arelle.ValidateUtr import ValidateUtr
 from arelle.Version import authorLabel, copyrightLabel
 from arelle.XbrlConst import qnEnumerationItemTypes
 from arelle.ModelInstanceObject import ModelFact
+from arelle.utils.Contexts import getDuplicateContextGroups
 import regex as re
 from lxml import etree
 from collections import defaultdict
@@ -484,17 +485,13 @@ def validateFacts(val, factsToCheck):
 
     del unitHashes
 
-    cntxHashes = {}
+    if not getattr(modelXbrl, "isStreamingMode", False):
+        for contexts in getDuplicateContextGroups(modelXbrl):
+            modelXbrl.log("WARNING" if val.isEIOPAfullVersion else "ERROR",
+                "EIOPA.S.2.7.b",
+                _("Duplicate contexts MUST NOT be reported, contexts %(cntx1)s and %(cntx2)s are equivalent.'"),
+                modelObject=contexts, cntx1=contexts[0].id, cntx2=contexts[1].id)
     for cntx in modelXbrl.contexts.values():
-        h = cntx.contextDimAwareHash
-        if h in cntxHashes and cntx.isEqualTo(cntxHashes[h]):
-            if not getattr(modelXbrl, "isStreamingMode", False):
-                modelXbrl.log("WARNING" if val.isEIOPAfullVersion else "ERROR",
-                    "EIOPA.S.2.7.b",
-                    _("Duplicate contexts MUST NOT be reported, contexts %(cntx1)s and %(cntx2)s are equivalent.'"),
-                    modelObject=(cntx, cntxHashes[h]), cntx1=cntx.id, cntx2=cntxHashes[h].id)
-        else:
-            cntxHashes[h] = cntx
         for _dim in cntx.qnameDims.values():
             _dimQn = _dim.dimensionQname
             prefixUsed(val, _dimQn.namespaceURI, _dimQn.prefix)

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/EDINET/rules/gfm.py

@@ -3,6 +3,7 @@ See COPYRIGHT.md for copyright information.
 """
 from __future__ import annotations
 
+from datetime import timedelta
 from typing import Any, cast, Iterable
 
 import regex
@@ -16,7 +17,9 @@ from arelle.ValidateXbrlCalcs import insignificantDigits
 from arelle.XbrlConst import qnXbrlScenario, qnXbrldiExplicitMember, xhtmlBaseIdentifier, xmlBaseIdentifier
 from arelle.XmlValidate import VALID
 from arelle.typing import TypeGetText
+from arelle.utils.Contexts import getDuplicateContextGroups
 from arelle.utils.PluginHooks import ValidationHook
+from arelle.utils.Units import getDuplicateUnitGroups
 from arelle.utils.validate.Decorator import validation
 from arelle.utils.validate.Validation import Validation
 from arelle.utils.validate.ValidationUtil import etreeIterWithDepth
@@ -213,6 +216,100 @@ def rule_gfm_1_2_5(
         )
 
 
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_gfm_1_2_7(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC5700W: [GFM 1.2.7] An instance must not contain duplicate xbrli:context elements.
+    """
+    for contexts in getDuplicateContextGroups(val.modelXbrl):
+        yield Validation.warning(
+            codes='EDINET.EC5700W.GFM.1.2.7',
+            msg=_('Duplicate context. Remove the duplicate.'),
+            modelObject = contexts
+        )
+
+
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_gfm_1_2_8(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC5700W: [GFM 1.2.8] Every xbrli:context element must appear in at least one
+    contextRef attribute in the same instance.
+    """
+    unused_contexts = list(set(val.modelXbrl.contexts.values()) - set(val.modelXbrl.contextsInUse))
+    unused_contexts.sort(key=lambda x: x.id)
+    for context in unused_contexts:
+        yield Validation.warning(
+            codes='EDINET.EC5700W.GFM.1.2.8',
+            msg=_('If you are not using a context, delete it if it is not needed.'),
+            modelObject = context
+        )
+
+
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_gfm_1_2_9(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC5700W: [GFM 1.2.9] The same date must not appear as the content of both an xbrli:startDate and
+    an xbrli:endDate in an instance.
+    """
+    invalidDurationContexts = []
+    for contexts in val.modelXbrl.contextsByDocument().values():
+        for context in contexts:
+            if not context.isInstantPeriod:
+                if context.endDatetime and context.startDatetime and context.startDatetime == context.endDatetime - timedelta(days=1):
+                    invalidDurationContexts.append(context)
+    if len(invalidDurationContexts) > 0:
+        for context in invalidDurationContexts:
+            yield Validation.warning(
+                codes='EDINET.EC5700W.GFM.1.2.9',
+                msg=_("Set the context's startDate and endDate elements to different dates."),
+                modelObject=context
+            )
+
+
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+    disclosureSystems=[DISCLOSURE_SYSTEM_EDINET],
+)
+def rule_gfm_1_2_10(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    EDINET.EC5700W: [GFM 1.2.10] Element xbrli:xbrl must not have duplicate child xbrli:unit elements.
+    """
+    for duplicateUnits in getDuplicateUnitGroups(val.modelXbrl):
+        yield Validation.warning(
+            codes='EDINET.EC5700W.GFM.1.2.10',
+            msg=_('The unit element contains duplicate content. Please remove the duplicates.'),
+            modelObject = duplicateUnits
+        )
+
 
 @validation(
     hook=ValidationHook.XBRL_FINALLY,

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/ESEF/ESEF_2021/ValidateXbrlFinally.py

@@ -24,6 +24,8 @@ from arelle.ModelRelationshipSet import ModelRelationshipSet
 from arelle.ModelValue import QName, qname
 from arelle.utils.validate.ValidationUtil import etreeIterWithDepth
 from arelle.PythonUtil import isLegacyAbs, strTruncate
+from arelle.utils.Contexts import partitionModelXbrlContexts
+from arelle.utils.Units import partitionModelXbrlUnits
 from arelle.utils.validate.DetectScriptsInXhtml import containsScriptMarkers
 from arelle.UrlUtil import decodeBase64DataImage, isHttpUrl, scheme
 from arelle.ValidateFilingText import parseImageDataURL
@@ -564,27 +566,17 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
         # identify unique contexts and units
         mapContext = {}
         mapUnit = {}
-        uniqueContextHashes: dict[Any, Any] = {}
-        for context in modelXbrl.contexts.values():
-            h = context.contextDimAwareHash
-            if h in uniqueContextHashes:
-                if context.isEqualTo(uniqueContextHashes[h]):
-                    mapContext[context] = uniqueContextHashes[h]
-            else:
-                uniqueContextHashes[h] = context
-        del uniqueContextHashes
-        uniqueUnitHashes: dict[Any, Any] = {}
+        for exemplar_context, *contexts in partitionModelXbrlContexts(modelXbrl).values():
+            for context in contexts:
+                mapContext[context] = exemplar_context
         utrValidator = ValidateUtr(modelXbrl)
         utrUnitIds = set(u.unitId
                          for unitItemType in utrValidator.utrItemTypeEntries.values()
                          for u in unitItemType.values())
+        for exemplar_unit, *units in partitionModelXbrlUnits(modelXbrl).values():
+            for unit in units:
+                mapUnit[unit] = exemplar_unit
         for unit in modelXbrl.units.values():
-            h = unit.hash
-            if h in uniqueUnitHashes:
-                if unit.isEqualTo(uniqueUnitHashes[h]):
-                    mapUnit[unit] = uniqueUnitHashes[h]
-            else:
-                uniqueUnitHashes[h] = unit
             # check if any custom measure is in UTR
             for measureTerm in unit.measures:
                 for measure in measureTerm:
@@ -594,7 +586,6 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
                             modelXbrl.warning("ESEF.RTS.III.1.G1-7-1.customUnitInUtr",
                                 _("Custom measure SHOULD NOT duplicate a UnitID of UTR: %(measure)s"),
                                 modelObject=unit, measure=measure)
-        del uniqueUnitHashes
 
         reportedMandatory: set[QName] = set()
         precisionFacts = set()

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/ESEF/ESEF_Current/ValidateXbrlFinally.py

@@ -30,6 +30,8 @@ from arelle.utils.validate.ESEFImage import ImageValidationParameters, checkSVGC
 from arelle.utils.validate.ValidationUtil import etreeIterWithDepth
 from arelle.PythonUtil import isLegacyAbs, normalizeSpace
 from arelle.PythonUtil import strTruncate
+from arelle.utils.Contexts import partitionModelXbrlContexts
+from arelle.utils.Units import partitionModelXbrlUnits
 from arelle.utils.validate.DetectScriptsInXhtml import containsScriptMarkers
 from arelle.UrlUtil import isHttpUrl
 from arelle.ValidateUtr import ValidateUtr
@@ -629,27 +631,17 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
         # identify unique contexts and units
         mapContext = {}
         mapUnit = {}
-        uniqueContextHashes: dict[Any, Any] = {}
-        for context in modelXbrl.contexts.values():
-            h = context.contextDimAwareHash
-            if h in uniqueContextHashes:
-                if context.isEqualTo(uniqueContextHashes[h]):
-                    mapContext[context] = uniqueContextHashes[h]
-            else:
-                uniqueContextHashes[h] = context
-        del uniqueContextHashes
-        uniqueUnitHashes: dict[Any, Any] = {}
+        for exemplar_context, *contexts in partitionModelXbrlContexts(modelXbrl).values():
+            for context in contexts:
+                mapContext[context] = exemplar_context
         utrValidator = ValidateUtr(modelXbrl)
         utrUnitIds = set(u.unitId
                          for unitItemType in utrValidator.utrItemTypeEntries.values()
                          for u in unitItemType.values())
+        for exemplar_unit, *units in partitionModelXbrlUnits(modelXbrl).values():
+            for unit in units:
+                mapUnit[unit] = exemplar_unit
         for unit in modelXbrl.units.values():
-            h = unit.hash
-            if h in uniqueUnitHashes:
-                if unit.isEqualTo(uniqueUnitHashes[h]):
-                    mapUnit[unit] = uniqueUnitHashes[h]
-            else:
-                uniqueUnitHashes[h] = unit
             # check if any custom measure is in UTR
             for measureTerm in unit.measures:
                 for measure in measureTerm:
@@ -659,7 +651,6 @@ def validateXbrlFinally(val: ValidateXbrl, *args: Any, **kwargs: Any) -> None:
                             modelXbrl.warning("ESEF.RTS.III.1.G1-7-1.customUnitInUtr",
                                 _("Custom measure SHOULD NOT duplicate a UnitID of UTR: %(measure)s"),
                                 modelObject=unit, measure=measure)
-        del uniqueUnitHashes
 
         reportedMandatory: set[QName] = set()
         precisionFacts = set()

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/FERC/__init__.py

@@ -33,6 +33,7 @@ from arelle.PrototypeDtsObject import LinkPrototype, LocPrototype, ArcPrototype
 from arelle.Version import authorLabel, copyrightLabel
 from arelle.XbrlConst import xbrli, xhtml
 from arelle.XmlValidateConst import VALID
+from arelle.utils.Contexts import getDuplicateContextGroups
 
 def dislosureSystemTypes(disclosureSystem, *args, **kwargs):
     # return ((disclosure system name, variable name), ...)
@@ -121,7 +122,6 @@ def validateXbrlFinally(val, *args, **kwargs):
 
     #6.5.4 scenario
     segContexts = set()
-    uniqueContextHashes = {}
     contextIDs = set()
     precisionFacts = set()
     formType = None
@@ -133,16 +133,12 @@ def validateXbrlFinally(val, *args, **kwargs):
     for c in modelXbrl.contexts.values():
         if XmlUtil.hasChild(c, xbrli, "segment"):
             segContexts.add(c)
-        h = c.contextDimAwareHash
-        if h in uniqueContextHashes:
-            if c.isEqualTo(uniqueContextHashes[h]):
-                modelXbrl.error("FERC.6.05.07",
-                    _("The instance document contained more than one context equivalent to %(context)s (%(context2)s).  "
-                      "Please remove duplicate contexts from the instance."),
-                    modelObject=(c, uniqueContextHashes[h]), context=c.id, context2=uniqueContextHashes[h].id)
-        else:
-            uniqueContextHashes[h] = c
         contextIDs.add(c.id)
+    for contexts in getDuplicateContextGroups(modelXbrl):
+        modelXbrl.error("FERC.6.05.07",
+            _("The instance document contained more than one context equivalent to %(context)s (%(context2)s).  "
+                "Please remove duplicate contexts from the instance."),
+            modelObject=contexts, context=contexts[0].id, context2=contexts[1].id)
 
     if segContexts:
         modelXbrl.error("FERC.6.05.04",

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/NL/PluginValidationDataExtension.py

@@ -414,25 +414,13 @@ class PluginValidationDataExtension(PluginData):
         calcRelSet = modelXbrl.relationshipSet(XbrlConst.summationItems)
         dimensionalData = self.getDimensionalData(modelXbrl)
         primaryItems = dimensionalData.primaryItems
-        domainMembers = dimensionalData.domainMembers
         extensionData = self.getExtensionData(modelXbrl)
         for concept in extensionData.extensionConcepts:
-            extLineItem = False
             if concept.isPrimaryItem and \
                     not concept.isAbstract and \
                     concept in primaryItems and \
                     not widerNarrowerRelSet.contains(concept) and \
                     not calcRelSet.fromModelObject(concept):
-                extLineItem = True
-            elif concept.isAbstract and \
-                    concept not in domainMembers and \
-                    concept.type is not None and \
-                    not concept.type.isDomainItemType and \
-                    not concept.isHypercubeItem and \
-                    not concept.isDimensionItem and \
-                    not widerNarrowerRelSet.contains(concept):
-                extLineItem = True
-            if extLineItem:
                 if not generalSpecialRelSet.contains(concept):
                     extLineItemsNotAnchored.add(concept)
                 else:

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/NL/rules/fr_nl.py

@@ -18,6 +18,7 @@ from arelle.ModelObject import ModelObject, ModelComment
 from arelle.ModelValue import QName, qname
 from arelle.ValidateXbrl import ValidateXbrl
 from arelle.typing import TypeGetText
+from arelle.utils.Contexts import partitionModelXbrlContexts
 from arelle.utils.PluginHooks import ValidationHook
 from arelle.utils.validate.Decorator import validation
 from arelle.utils.validate.Validation import Validation
@@ -579,10 +580,7 @@ def rule_fr_nl_3_04(
     """
     FR-NL-3.04: An XBRL instance document MUST NOT contain duplicate 'xbrli:context' elements
     """
-    duplicates = defaultdict(list)
-    for context in val.modelXbrl.contexts.values():
-        duplicates[context.contextDimAwareHash].append(context)
-    for duplicate_contexts in duplicates.values():
+    for duplicate_contexts in partitionModelXbrlContexts(val.modelXbrl).values():
         if len(duplicate_contexts) > 1:
             yield Validation.error(
                 codes='NL.FR-NL-3.04',

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/NL/rules/nl_kvk.py

@@ -1711,11 +1711,11 @@ def rule_nl_kvk_4_4_6_1(
                     unreportedLbLocs.add(rel.fromLocator)
     if len(unreportedLbLocs) > 0:
         yield Validation.warning(
-            # Subtitle is capitalized inconsistently here because is tmatches the conformance suite. This may change in the future.
+            # Subtitle is capitalized inconsistently here because it matches the conformance suite. This may change in the future.
             codes='NL.NL-KVK.4.4.6.1.UsableConceptsNotAppliedByTaggedFacts',
             modelObject=unreportedLbLocs,
-            msg=_('Axis is missing a default member or the default member does not match the taxonomy defaults. '
-                  'Update to set default member based on taxonomy defaults.')
+            msg=_('Concept was found but not reported on any facts. '
+                  'Remove any unused concepts or ensure concept is applied to applicable facts.'),
         )
 
 

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/ROS/ValidationPluginExtension.py

@@ -10,6 +10,7 @@ from .PluginValidationDataExtension import PluginValidationDataExtension
 
 _: TypeGetText
 
+EQUITY = 'Equity'
 IE_PROFIT_LOSS = 'ProfitLossBeforeTax'
 IE_PROFIT_LOSS_ORDINARY = 'ProfitLossOnOrdinaryActivitiesBeforeTax'
 PRINCIPAL_CURRENCY = 'PrincipalCurrencyUsedInBusinessReport'

{arelle_release-2.37.38 → arelle_release-2.37.40}/arelle/plugin/validate/ROS/rules/ros.py

@@ -19,14 +19,15 @@ from arelle.ModelInstanceObject import ModelInlineFact, ModelUnit
 from arelle.ModelValue import qname
 from arelle.ModelXbrl import ModelXbrl
 from arelle.PythonUtil import strTruncate
+from arelle.utils.Contexts import partitionModelXbrlContexts
+from arelle.utils.Units import partitionModelXbrlUnits
 from arelle.utils.PluginHooks import ValidationHook
 from arelle.utils.validate.Decorator import validation
 from arelle.utils.validate.Validation import Validation
 from arelle.ValidateXbrlCalcs import inferredDecimals, rangeValue
 from arelle.XbrlConst import qnXbrliMonetaryItemType, qnXbrliXbrl, xhtml
 from arelle.XmlValidateConst import VALID
-from . import errorOnNegativeFact
-from ..ValidationPluginExtension import IE_PROFIT_LOSS_ORDINARY, IE_PROFIT_LOSS, PRINCIPAL_CURRENCY, TURNOVER_REVENUE
+from ..ValidationPluginExtension import EQUITY, PRINCIPAL_CURRENCY, TURNOVER_REVENUE
 from ..PluginValidationDataExtension import MANDATORY_ELEMENTS,  SCHEMA_PATTERNS, TR_NAMESPACES, PluginValidationDataExtension
 
 
@@ -167,7 +168,6 @@ def rule_main(
         schemeEntityIds = set()
         mapContext = {} # identify unique contexts and units
         mapUnit = {}
-        uniqueContextHashes: dict[str, str] = {}
         hasCRO = False
         unsupportedSchemeContexts = []
         mismatchIdentifierContexts = []
@@ -180,13 +180,10 @@ def rule_main(
                 mismatchIdentifierContexts.append(context)
             if scheme == "http://www.cro.ie/":
                 hasCRO = True
-            h = context.contextDimAwareHash
-            if h in uniqueContextHashes:
-                if context.isEqualTo(uniqueContextHashes[h]):
-                    mapContext[context] = uniqueContextHashes[h]
-            else:
-                uniqueContextHashes[h] = context
-        del uniqueContextHashes
+        for exemplar_context, *contexts in partitionModelXbrlContexts(modelXbrl).values():
+            for context in contexts:
+                mapContext[context] = exemplar_context
+
         if len(schemeEntityIds) > 1:
             modelXbrl.error("ROS:differentContextEntityIdentifiers",
                             _("Context entity identifier not all the same: %(schemeEntityIds)s."),
@@ -202,15 +199,9 @@ def rule_main(
                             modelObject=mismatchIdentifierContexts,
                             identifiers=", ".join(sorted(set(c.entityIdentifier[1] for c in mismatchIdentifierContexts))))
 
-        uniqueUnitHashes: dict[str, ModelUnit] = {}
-        for unit in modelXbrl.units.values():
-            h = unit.hash
-            if h in uniqueUnitHashes:
-                if unit.isEqualTo(uniqueUnitHashes[h]):
-                    mapUnit[unit] = uniqueUnitHashes[h]
-            else:
-                uniqueUnitHashes[h] = unit
-        del uniqueUnitHashes
+        for exemplar_unit, *units in partitionModelXbrlUnits(modelXbrl).values():
+            for unit in units:
+                mapUnit[unit] = exemplar_unit
 
         if hasCRO and "ie-common" in nsMap:
             mandatory.add(qname("ie-common:CompaniesRegistrationOfficeNumber", nsMap))  # type-ignore[arg-type]
@@ -293,6 +284,42 @@ def rule_main(
     modelXbrl.modelManager.showStatus(None)
 
 
+@validation(
+    hook=ValidationHook.XBRL_FINALLY,
+)
+def rule_ros19(
+        pluginData: PluginValidationDataExtension,
+        val: ValidateXbrl,
+        *args: Any,
+        **kwargs: Any,
+) -> Iterable[Validation]:
+    """
+    ROS: Rule 19: DPLTurnoverRevenue should be tested to be less than or equal to 10x the absolute value of Equity
+    """
+    equity_facts = val.modelXbrl.factsByLocalName.get(EQUITY, set())
+    largest_equity_fact = None
+    for e_fact in equity_facts:
+        if e_fact.xValid >= VALID:
+            if largest_equity_fact is None or abs(int(e_fact.value)) > abs(int(largest_equity_fact.value)):
+                largest_equity_fact = e_fact
+
+    turnover_facts = val.modelXbrl.factsByLocalName.get(TURNOVER_REVENUE, set())
+    largest_turnover_fact = None
+    for t_fact in turnover_facts:
+        if t_fact.xValid >= VALID:
+            if largest_turnover_fact is None or int(t_fact.value) > int(largest_turnover_fact.value):
+                largest_turnover_fact = t_fact
+
+    if (largest_equity_fact is not None and
+            largest_turnover_fact is not None and
+            int(largest_turnover_fact.value) > (10 * abs(int(largest_equity_fact.value)))):
+        yield Validation.error(
+            "ROS.19",
+            _("Turnover / Revenue (DPLTurnoverRevenue) may exceed the maximum expected value. Please review the submission and, if correct, test your submission with Revenue Online's iXBRL test facility."),
+            modelObject=[largest_equity_fact, largest_turnover_fact],
+        )
+
+
 @validation(
     hook=ValidationHook.XBRL_FINALLY,
 )