ara-cli 0.1.9.63__tar.gz → 0.1.9.65__tar.gz

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: ara_cli
-Version: 0.1.9.63
+Version: 0.1.9.65
 Requires-Dist: litellm
 Requires-Dist: llama-index
 Requires-Dist: llama-index-llms-openai

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/README.md

@@ -6,7 +6,6 @@
   - [update dependencies](#update-dependencies)
   - [test and run during development](#test-and-run-during-development)
   - [set version and build and install locally for testing outside of container](#set-version-and-build-and-install-locally-for-testing-outside-of-container)
-  - [upload to test pypi with test pypi API key](#upload-to-test-pypi-with-test-pypi-api-key)
   - [upload to live pypi with talsen team production API key (from main branch)](#upload-to-live-pypi-with-talsen-team-production-api-key-from-main-branch)
 
 # ara usage 
@@ -59,6 +58,8 @@ To update dependencies, add package names in `setup.py`. The packages will ONLY
 4. Test the functionality
 
 
+<!-- 
+#### DEPRECATED
 ## upload to test pypi with test pypi API key
 1. run `bash deploy.sh`
 2. run `login.sh`
@@ -73,19 +74,20 @@ twine upload --repository testpypi dist/* --verbose -u __token__ -p pypi-AgENdGV
 
 this will upload to a test pypi account.
 
-
-6. run `python3 -m pip install --index-url https://test.pypi.org/simple/ ara_cli==<VERSION>`
-7. run `ara -h`
-8. if everything has worked (upload, installation and usage) you can now continue to upload the package to pypi (live)
+1. run `python3 -m pip install --index-url https://test.pypi.org/simple/ ara_cli==<VERSION>`
+2. run `ara -h`
+3. if everything has worked (upload, installation and usage) you can now continue to upload the package to pypi (live)
+ -->
 
 
 ## upload to live pypi with talsen team production API key (from main branch)
 1. run `bash deploy.sh`
 2. run `login.sh`
-3. `dist` folder should still be there from the testupload (otherwise do `python setup.py sdist bdist_wheel` inside the container again), do NOT upload to live without previously testing in test pypi!
-4. Get the API-Key from [nextcloud](https://cloud.talsen.team/apps/keeweb/?open=%2Finfrastructure%2Fpublic-services%2Fapi-keys.kdbx)
-5. Get the Password from Hans or DevOps
-6. run the following command: 
+3. from inside container run `python setup.py sdist bdist_wheel`
+4. `dist` folder should now contain the built wheel ready to upload
+5. Get the API-Key from [nextcloud](https://cloud.talsen.team/apps/keeweb/?open=%2Finfrastructure%2Fpublic-services%2Fapi-keys.kdbx)
+6. Get the Password from Hans or DevOps
+7. run the following command: 
 ```bash
 twine upload dist/* --verbose -u __token__ -p <API-Key>
 ```

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/ara_command_action.py

@@ -18,6 +18,8 @@ def create_action(args):
     from ara_cli.classifier import Classifier
     from ara_cli.filename_validator import is_valid_filename
     from ara_cli.template_manager import SpecificationBreakdownAspects
+    from ara_cli.artefact_reader import ArtefactReader
+    from ara_cli.artefact_fuzzy_search import find_closest_rule
 
     check_validity(Classifier.is_valid_classifier(args.classifier), "Invalid classifier provided. Please provide a valid classifier.")
     check_validity(is_valid_filename(args.parameter), "Invalid filename provided. Please provide a valid filename.")
@@ -25,11 +27,20 @@ def create_action(args):
     def handle_parent_arguments(args):
         parent_classifier = args.parent_classifier if hasattr(args, "parent_classifier") else None
         parent_name = args.parent_name if hasattr(args, "parent_name") else None
+        rule = args.rule if hasattr(args, 'rule') else None
+        invalid_classifier_message = "Invalid parent classifier provided. Please provide a valid classifier"
+        invalid_name_message = "Invalid filename provided for parent. Please provide a valid filename."
+        if parent_classifier and parent_name and rule:
+            check_validity(Classifier.is_valid_classifier(parent_classifier), invalid_classifier_message)
+            check_validity(is_valid_filename(parent_name), invalid_name_message)
+            parent_artefact = ArtefactReader.read_single_artefact(artefact_name=parent_name, classifier=parent_classifier)
+            rule = find_closest_rule(parent_artefact, rule)
+            return parent_classifier, parent_name, rule
         if parent_classifier and parent_name:
-            check_validity(Classifier.is_valid_classifier(parent_classifier), "Invalid parent classifier provided. Please provide a valid classifier")
-            check_validity(is_valid_filename(parent_name), "Invalid filename provided for parent. Please provide a valid filename.")
-            return parent_classifier, parent_name
-        return None, None
+            check_validity(Classifier.is_valid_classifier(parent_classifier), invalid_classifier_message)
+            check_validity(is_valid_filename(parent_name), invalid_name_message)
+            return parent_classifier, parent_name, rule
+        return None, None, None
 
     def handle_aspect_creation(args):
         aspect = args.aspect if hasattr(args, "aspect") else None
@@ -43,12 +54,12 @@ def create_action(args):
                 sys.exit(1)
         return False
 
-    parent_classifier, parent_name = handle_parent_arguments(args)
+    parent_classifier, parent_name, rule = handle_parent_arguments(args)
     if handle_aspect_creation(args):
         return
 
     artefact_creator = ArtefactCreator()
-    artefact_creator.run(args.parameter, args.classifier, parent_classifier, parent_name)
+    artefact_creator.run(args.parameter, args.classifier, parent_classifier, parent_name, rule)
 
 
 def delete_action(args):
@@ -122,15 +133,17 @@ def list_action(args):
 
 def list_tags_action(args):
     from ara_cli.tag_extractor import TagExtractor
+    from ara_cli.list_filter import ListFilter
 
-    tag_classifier = None
-    if args.include_classifier:
-        tag_classifier = args.include_classifier
+    list_filter = ListFilter(
+        include_extension=args.include_classifier,
+        exclude_extension=args.exclude_classifier,
+    )
 
     tag_extractor = TagExtractor()
     tags = tag_extractor.extract_tags(
-        include_classifier=tag_classifier,
-        filtered_extra_column=getattr(args, "filtered_extra_column", False)
+        filtered_extra_column=getattr(args, "filtered_extra_column", False),
+        list_filter=list_filter
     )
 
     if args.json:
@@ -334,14 +347,18 @@ def reconnect_action(args):
     from ara_cli.artefact_models.artefact_load import artefact_from_content
     from ara_cli.artefact_models.artefact_model import Contribution
     from ara_cli.artefact_reader import ArtefactReader
+    from ara_cli.artefact_fuzzy_search import find_closest_rule
 
     classifier = args.classifier
     artefact_name = args.parameter
     parent_classifier = args.parent_classifier
     parent_name = args.parent_name
+    rule = args.rule if hasattr(args, 'rule') else None
 
     read_error_message = f"Could not connect {classifier} '{artefact_name}' to {parent_classifier} '{parent_name}'"
 
+    feedback_message = f"Updated contribution of {classifier} '{artefact_name}' to {parent_classifier} '{parent_name}'"
+
     content, artefact_info = ArtefactReader.read_artefact(
         artefact_name=artefact_name,
         classifier=classifier
@@ -367,14 +384,27 @@ def reconnect_action(args):
         content=parent_content
     )
 
-    artefact.contribution = Contribution(
+    contribution = Contribution(
         artefact_name=parent.title,
         classifier=parent.artefact_type
     )
+
+    if rule:
+        try:
+            closest_rule = find_closest_rule(parent, rule)
+            contribution.rule = closest_rule
+            feedback_message += f" using rule '{closest_rule}'"
+        except TypeError as e:
+            print(f"{type(e).__name__}:", e)
+            exit(1)
+
+    artefact.contribution = contribution
     with open(artefact.file_path, 'w') as file:
         artefact_content = artefact.serialize()
         file.write(artefact_content)
 
+    print(feedback_message + ".")
+
 
 def read_status_action(args):
     from ara_cli.file_classifier import FileClassifier

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/ara_command_parser.py

@@ -18,6 +18,7 @@ def create_parser(subparsers):
     contribution_parser = option_parser.add_parser("contributes-to")
     contribution_parser.add_argument("parent_classifier", choices=classifiers, help="Classifier of the parent")
     contribution_parser.add_argument("parent_name",  help="Name of a parent artefact").completer = ParentNameCompleter()
+    contribution_parser.add_argument("-r", "--rule", dest="rule", action="store")
 
     aspect_parser = option_parser.add_parser("aspect")
     aspect_parser.add_argument("aspect", choices=aspects, help="Adds additional specification breakdown aspects in data directory.")
@@ -70,12 +71,16 @@ def add_filter_flags(parser):
     extension_group.add_argument(
         "-i",
         "--include-extension",
+        "--include-classifier",
+        dest="include_extension",
         nargs='+',
         help='list of extensions to include in listing'
     )
     extension_group.add_argument(
         "-e",
         "--exclude-extension",
+        "--exclude-classifier",
+        dest="exclude_extension",
         nargs='+',
         help='list of extensions to exclude from listing'
     )
@@ -121,6 +126,7 @@ def list_tags_parser(subparsers):
     tags_parser = subparsers.add_parser("list-tags", help="Show tags")
     tags_parser.add_argument("--json", "-j", help="Output tags as JSON", action=argparse.BooleanOptionalAction)
     tags_parser.add_argument("--include-classifier", choices=classifiers, help="Show tags for an artefact type")
+    tags_parser.add_argument("--exclude_classifier", choices=classifiers, help="Show tags for an artefact type")
     tags_parser.add_argument("--filtered-extra-column", action="store_true", help="Filter tags for extra column") 
 
 
@@ -184,6 +190,7 @@ def reconnect_parser(subparsers):
     reconnect_parser.add_argument("parameter", help="Filename of artefact").completer = ArtefactCompleter()
     reconnect_parser.add_argument("parent_classifier", choices=classifiers, help="Classifier of the parent artefact type")
     reconnect_parser.add_argument("parent_name", help="Filename of parent artefact").completer = ParentNameCompleter()
+    reconnect_parser.add_argument("-r", "--rule", dest="rule", action="store")
 
 
 def read_status_parser(subparsers):

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_autofix.py

@@ -83,9 +83,8 @@ def construct_prompt(artefact_type, reason, file_path, artefact_text):
 
     prompt = (
         f"Correct the following {artefact_type} artefact to fix the issue: {reason}. "
-        "Provide the complete, corrected artefact. Do not reformulate the artefact, "
+        "Provide the corrected artefact. Do not reformulate the artefact, "
         "just fix the pydantic model errors, use correct grammar. "
-        "Do not remove comments. "
         "You should follow the name of the file "
         f"from its path {file_path} for naming the arteafact's title. "
         "You are not allowed to use file extention in the artefact title. "
@@ -114,7 +113,7 @@ def run_agent(prompt, artefact_class):
     from pydantic_ai import Agent
     # gpt-4o
     # anthropic:claude-3-7-sonnet-20250219
-    agent = Agent(model="gpt-4o",
+    agent = Agent(model="anthropic:claude-3-7-sonnet-20250219",
                   result_type=artefact_class, instrument=True)
     result = agent.run_sync(prompt)
     return result.data

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_creator.py

@@ -87,7 +87,7 @@ class ArtefactCreator:
         artefact._parent = matching_artefacts[0]
         return artefact
 
-    def run(self, filename, classifier, parent_classifier=None, parent_name=None):
+    def run(self, filename, classifier, parent_classifier=None, parent_name=None, rule=None):
         # make sure this function is always called from the ara top level directory
         original_directory = os.getcwd()
         navigator = DirectoryNavigator()
@@ -111,7 +111,8 @@ class ArtefactCreator:
         if parent_classifier and parent_name:
             artefact.set_contribution(
                 artefact_name=parent_name,
-                classifier=parent_classifier
+                classifier=parent_classifier,
+                rule=rule
             )
 
         artefact_content = artefact.serialize()

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_fuzzy_search.py

@@ -1,9 +1,10 @@
 import difflib
+from textwrap import indent
 from typing import Optional
 
 
-def suggest_close_names(artefact_name: str, all_artefact_names: list[str], message: str):
-    closest_matches = difflib.get_close_matches(artefact_name, all_artefact_names, cutoff=0.5)
+def suggest_close_names(artefact_name: str, all_artefact_names: list[str], message: str, cutoff=0.5):
+    closest_matches = difflib.get_close_matches(artefact_name, all_artefact_names, cutoff=cutoff)
     print(message)
     if not closest_matches:
         return
@@ -38,3 +39,21 @@ def find_closest_name_match(artefact_name: str, all_artefact_names: list[str]) -
         return None
     closest_match = closest_matches[0]
     return closest_match
+
+
+def find_closest_rule(parent_artefact: 'Artefact', rule: str):
+    parent_classifier = parent_artefact.artefact_type.value
+    parent_title = parent_artefact.title
+    if not hasattr(parent_artefact, 'rules'):
+        raise TypeError(f"{parent_classifier.capitalize()} artefact '{parent_title}' can not possess rules. Only userstories and epics have rules.")
+    rules = parent_artefact.rules
+    if rule in rules:
+        return rule
+    print(f"Rule '{rule}' does not match existing rules in {parent_classifier} artefact '{parent_title}'. Attempting to find closest match among existing rules.")
+    closest_matches = difflib.get_close_matches(rule, rules, cutoff=0.5)
+    rules_list_string = indent('\n'.join(rules), prefix='\t- ')
+    if not closest_matches:
+        raise ValueError(f"Can not determine a match for rule '{rule}' in {parent_classifier} artefact '{parent_title}'. Found rules:\n{rules_list_string}")
+    closest_match = closest_matches[0]
+    print(f"Found closest matching rule of '{closest_match}'")
+    return closest_match

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_models/artefact_model.py

@@ -401,9 +401,10 @@ class Artefact(BaseModel, ABC):
             return description
         return f"{description}{self.description}"
 
-    def set_contribution(self, artefact_name, classifier):
+    def set_contribution(self, artefact_name, classifier, rule=None):
         contribution = Contribution(
             artefact_name=artefact_name,
-            classifier=classifier
+            classifier=classifier,
+            rule=rule
         )
         self.contribution = contribution

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_models/feature_artefact_model.py

@@ -1,5 +1,5 @@
 from pydantic import BaseModel, field_validator, model_validator, Field
-from typing import List, Dict, Tuple, Union
+from typing import List, Dict, Tuple, Union, Optional
 from ara_cli.artefact_models.artefact_model import Artefact, ArtefactType, Intent
 import re
 
@@ -98,6 +98,35 @@ class Example(BaseModel):
         return cls(values=values)
 
 
+class Background(BaseModel):
+    steps: List[str] = Field(
+        description="A list of Gherkin 'Given' type steps that describe what the background does."
+    )
+
+    @field_validator('steps', mode='before')
+    def validate_steps(cls, v: List[str]) -> List[str]:
+        """Ensure steps are non-empty and stripped."""
+        steps = [step.strip() for step in v if step.strip()]
+        if not steps:
+            raise ValueError("steps list must not be empty")
+        return steps
+
+    @classmethod
+    def from_lines(cls, lines: List[str], start_idx: int) -> Tuple['Background', int]:
+        """Parse a Background from a list of lines starting at start_idx."""
+        if not lines[start_idx].startswith('Background:'):
+            raise ValueError("Expected 'Background:' at start index")
+
+        steps = []
+        idx = start_idx + 1
+        while idx < len(lines) and not lines[idx].startswith('Background:'):
+            step = lines[idx].strip()
+            if step:
+                steps.append(step)
+            idx += 1
+        return cls(steps=steps), idx
+
+
 class Scenario(BaseModel):
     title: str = Field(
         description="The name of the scenario, giving a short summary of the test case. It comes from the 'Scenario:' line in the feature file."
@@ -213,6 +242,8 @@ class FeatureArtefact(Artefact):
     artefact_type: ArtefactType = ArtefactType.feature
     intent: FeatureIntent
     scenarios: List[Union[Scenario, ScenarioOutline]] = Field(default=None)
+    background: Optional[Background] = Field(
+        default=None, description="Highly optional background Gherkin steps for Feature Artefacts. This steps apply for all scenarios and scenario outlines in this feature file.")
 
     @field_validator('artefact_type')
     def validate_artefact_type(cls, v):
@@ -229,6 +260,16 @@ class FeatureArtefact(Artefact):
     def _artefact_type(cls) -> ArtefactType:
         return ArtefactType.feature
 
+    def _serialize_background(self) -> str:
+        """Helper method to dispatch background serialization."""
+        if not self.background:
+            return ""
+        lines = []
+        lines.append("  Background:")
+        for step in self.background.steps:
+            lines.append(f"    {step}")
+        return "\n".join(lines)
+
     def _serialize_scenario(self, scenario: Union[Scenario, ScenarioOutline]) -> str:
         """Helper method to dispatch scenario serialization."""
         if isinstance(scenario, Scenario):
@@ -309,6 +350,10 @@ class FeatureArtefact(Artefact):
         lines.append(description)
         lines.append("")
 
+        if self.background:
+            lines.append(self._serialize_background())
+            lines.append("")
+
         if self.scenarios:
             for scenario in self.scenarios:
                 lines.append(self._serialize_scenario(scenario))
@@ -321,9 +366,11 @@ class FeatureArtefact(Artefact):
         fields = super()._parse_common_fields(text)
 
         intent = FeatureIntent.deserialize(text)
+        background = cls.deserialize_background(text)
         scenarios = cls.deserialize_scenarios(text)
 
         fields['scenarios'] = scenarios
+        fields['background'] = background
         fields['intent'] = intent
 
         return cls(**fields)
@@ -348,3 +395,19 @@ class FeatureArtefact(Artefact):
             else:
                 idx += 1
         return scenarios
+
+    @classmethod
+    def deserialize_background(cls, text):
+        lines = [line.strip()
+                 for line in text.strip().splitlines() if line.strip()]
+
+        background = None
+        idx = 0
+        while idx < len(lines):
+            line = lines[idx].strip()
+            if line.startswith('Background:'):
+                background, next_idx = Background.from_lines(lines, idx)
+                break
+            else:
+                idx += 1
+        return background

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/artefact_reader.py

@@ -1,6 +1,7 @@
 from ara_cli.classifier import Classifier
 from ara_cli.file_classifier import FileClassifier
 from ara_cli.artefact_models.artefact_model import Artefact
+from ara_cli.artefact_models.artefact_load import artefact_from_content
 from ara_cli.artefact_fuzzy_search import suggest_close_name_matches_for_parent, suggest_close_name_matches
 from typing import Dict, List
 import os
@@ -9,7 +10,7 @@ import re
 
 class ArtefactReader:
     @staticmethod
-    def read_artefact(artefact_name, classifier):
+    def read_artefact(artefact_name, classifier) -> tuple[str, dict[str, str]]:
         if not Classifier.is_valid_classifier(classifier):
             print("Invalid classifier provided. Please provide a valid classifier.")
             return None, None
@@ -34,6 +35,27 @@ class ArtefactReader:
 
         return None, None
 
+    @staticmethod
+    def read_single_artefact(artefact_name, classifier, classified_file_info=None) -> Artefact:
+        if not Classifier.is_valid_classifier(classifier):
+            print("Invalid classifier provided. Please provide a valid classifier.")
+            return None
+        if not classified_file_info:
+            file_classifier = FileClassifier(os)
+            classified_file_info = file_classifier.classify_files()
+        artefact_info_of_classifier = classified_file_info.get(classifier, [])
+
+        for artefact_info in artefact_info_of_classifier:
+            file_path = artefact_info["file_path"]
+            artefact_title = artefact_info["title"]
+            if artefact_title == artefact_name:
+                with open(file_path, 'r') as file:
+                    content = file.read()
+                artefact = artefact_from_content(content)
+                artefact._file_path = file_path
+                return artefact
+        return None
+
     @staticmethod
     def extract_parent_tree(artefact_content):
         artefact_titles = Classifier.artefact_titles()

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/prompt_extractor.py

@@ -184,10 +184,14 @@ def handle_existing_file(filename, block_content):
         create_file_if_not_exist(filename, block_content)
     else:
         print(f"File {filename} exists, creating modification prompt")
-        prompt = create_prompt_for_file_modification(block_content, filename)
+        prompt_text = create_prompt_for_file_modification(block_content, filename)
+        messages = [{"role": "user", "content": prompt_text}]
         response = ""
-        for chunk in send_prompt(prompt):
-            response += chunk.content
+
+        for chunk in send_prompt(messages):
+            content = chunk.choices[0].delta.content
+            if content:
+                response += content
         modify_and_save_file(response, filename)
 
 

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/prompt_handler.py

@@ -355,8 +355,12 @@ def prepend_system_prompt(message_list):
 
 
 def append_images_to_message(message, image_data_list):
-    message_content = message["content"]
-    message["content"] = message_content + image_data_list
+    if not image_data_list:
+        return message
+    new_content_list = [{"type": "text", "text": message}]
+    new_content_list.extend(image_data_list)
+    
+    message["content"] = new_content_list
 
     return message
 
@@ -376,14 +380,23 @@ def create_and_send_custom_prompt(classifier, parameter):
     append_headings(classifier, parameter, "prompt")
     write_prompt_result(classifier, parameter, prompt)
 
-    message_list = append_images_to_message(combined_content_markdown, image_data_list)
-    append_headings(classifier, parameter, "result")
+    base_message = {
+        "role": "user",
+        "content": combined_content_markdown
+    }
+
+    final_message = append_images_to_message(base_message, image_data_list)
 
+    message_list_to_send = [final_message]
+
+    append_headings(classifier, parameter, "result")
     artefact_data_path = f"ara/{sub_directory}/{parameter}.data/{classifier}.prompt_log.md"
     with open(artefact_data_path, 'a') as file:
-        for chunk in send_prompt(message_list):
-            file.write(chunk.content)
-            file.flush()
+        for chunk in send_prompt(message_list_to_send):
+            content = chunk.choices[0].delta.content
+            if content:
+                file.write(content)
+                file.flush()
     # write_prompt_result(classifier, parameter, response)
 
 

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/tag_extractor.py

@@ -1,12 +1,18 @@
 import os
-from ara_cli.artefact_models.artefact_load import artefact_from_content
+from ara_cli.list_filter import ListFilter, filter_list
+from ara_cli.artefact_lister import ArtefactLister
 
 
 class TagExtractor:
     def __init__(self, file_system=None):
         self.file_system = file_system or os
 
-    def extract_tags(self, navigate_to_target=False, include_classifier=None, filtered_extra_column=False):
+    def extract_tags(
+        self,
+        navigate_to_target=False,
+        filtered_extra_column=False,
+        list_filter: ListFilter | None = None
+    ):
         from ara_cli.template_manager import DirectoryNavigator
         from ara_cli.artefact_reader import ArtefactReader
 
@@ -16,24 +22,29 @@ class TagExtractor:
 
         artefacts = ArtefactReader.read_artefacts()
 
-        if include_classifier:
-            artefacts = {include_classifier: artefacts[include_classifier]}
+        filtered_artefacts = filter_list(
+            list_to_filter=artefacts,
+            list_filter=list_filter,
+            content_retrieval_strategy=ArtefactLister.artefact_content_retrieval,
+            file_path_retrieval=ArtefactLister.artefact_path_retrieval,
+            tag_retrieval=ArtefactLister.artefact_tags_retrieval
+        )
 
         unique_tags = set()
 
         if filtered_extra_column:
             status_tags = {"to-do", "in-progress", "review", "done", "closed"}
-            filtered_artefacts = []
+            artefacts_to_process = []
 
-            for artefact_list in artefacts.values():
+            for artefact_list in filtered_artefacts.values():
                 for artefact in artefact_list:
                     tags = artefact.tags + \
                         [artefact.status] if artefact.status else artefact.tags
                     tag_set = set(tag for tag in tags if tag is not None)
                     if not tag_set & status_tags:
-                        filtered_artefacts.append(artefact)
+                        artefacts_to_process.append(artefact)
 
-            for artefact in filtered_artefacts:
+            for artefact in artefacts_to_process:
                 tags = [tag for tag in (
                     artefact.tags + [artefact.status]) if tag is not None]
                 for tag in tags:
@@ -46,7 +57,7 @@ class TagExtractor:
                     unique_tags.add(tag)
 
         else:
-            for artefact_list in artefacts.values():
+            for artefact_list in filtered_artefacts.values():
                 for artefact in artefact_list:
                     user_tags = [f"user_{tag}" for tag in artefact.users]
                     tags = [tag for tag in (artefact.tags + [artefact.status] + user_tags) if tag is not None]

{ara_cli-0.1.9.63 → ara_cli-0.1.9.65}/ara_cli/tests/test_ara_command_action.py

@@ -26,8 +26,10 @@ def mock_dependencies():
         "ara_cli.filename_validator.is_valid_filename"
     ) as mock_is_valid_filename, patch(
         "ara_cli.template_manager.SpecificationBreakdownAspects"
-    ) as MockSpecificationBreakdownAspects:
-        yield MockArtefactCreator, MockClassifier, mock_is_valid_filename, MockSpecificationBreakdownAspects
+    ) as MockSpecificationBreakdownAspects, patch(
+        "ara_cli.artefact_fuzzy_search.find_closest_rule"
+    ) as mock_find_closest_rule:
+        yield MockArtefactCreator, MockClassifier, mock_is_valid_filename, MockSpecificationBreakdownAspects, mock_find_closest_rule
 
 
 @pytest.fixture
@@ -129,9 +131,11 @@ def test_create_action_validity_checks(
         MockClassifier,
         mock_is_valid_filename,
         MockSpecificationBreakdownAspects,
+        mock_find_closest_rule,
     ) = mock_dependencies
     MockClassifier.is_valid_classifier.return_value = classifier_valid
     mock_is_valid_filename.return_value = filename_valid
+    mock_find_closest_rule.return_value = None
 
     args = MagicMock()
     args.classifier = "test_classifier"