amochka 0.4.3__tar.gz → 0.4.4__tar.gz

{amochka-0.4.3 → amochka-0.4.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: amochka
-Version: 0.4.3
+Version: 0.4.4
 Summary: Python library for working with amoCRM API with ETL capabilities
 Author-email: Timur <timurdt@gmail.com>
 License: MIT

{amochka-0.4.3 → amochka-0.4.4}/amochka/__init__.py

@@ -2,7 +2,7 @@
 amochka: Библиотека для работы с API amoCRM.
 """
 
-__version__ = "0.4.3"
+__version__ = "0.4.4"
 
 from .client import AmoCRMClient, CacheConfig
 from .errors import (

{amochka-0.4.3 → amochka-0.4.4}/amochka/client.py

@@ -1228,6 +1228,8 @@ class AmoCRMClient:
         if end_ts is not None:
             params["filter[updated_at][to]"] = end_ts
         note_type_param = self._format_filter_values(note_type)
+        if isinstance(note_type_param, (list, tuple, set)):
+            note_type_param = ",".join(note_type_param)
         if note_type_param:
             params["filter[note_type]"] = note_type_param
         entity_param = self._format_filter_values(entity_ids)
@@ -1597,8 +1599,11 @@ class AmoCRMClient:
             "page": 1,
             "limit": 250
         }
-        if note_type is not None:
-            params["filter[note_type]"] = note_type
+        note_type_param = self._format_filter_values(note_type)
+        if isinstance(note_type_param, (list, tuple, set)):
+            note_type_param = ",".join(note_type_param)
+        if note_type_param:
+            params["filter[note_type]"] = note_type_param
         if extra_params:
             params.update(extra_params)
         
@@ -1606,7 +1611,7 @@ class AmoCRMClient:
         while True:
             response = self._make_request("GET", endpoint, params=params)
             if not response:
-                self.logger.warning(f"Empty response for notes {entity} {entity_id}, stopping pagination")
+                self.logger.debug(f"Empty response for notes {entity} {entity_id}, stopping pagination")
                 break
             if response and "_embedded" in response and "notes" in response["_embedded"]:
                 notes.extend(response["_embedded"]["notes"])
@@ -1690,7 +1695,7 @@ class AmoCRMClient:
         while True:
             response = self._make_request("GET", "/api/v4/events", params=params)
             if not response:
-                self.logger.warning(f"Empty response for events {entity} {entity_id}, stopping pagination")
+                self.logger.debug(f"Empty response for events {entity} {entity_id}, stopping pagination")
                 break
             if response and "_embedded" in response and "events" in response["_embedded"]:
                 events.extend(response["_embedded"]["events"])

{amochka-0.4.3 → amochka-0.4.4}/amochka.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: amochka
-Version: 0.4.3
+Version: 0.4.4
 Summary: Python library for working with amoCRM API with ETL capabilities
 Author-email: Timur <timurdt@gmail.com>
 License: MIT

{amochka-0.4.3 → amochka-0.4.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "amochka"
-version = "0.4.3"
+version = "0.4.4"
 description = "Python library for working with amoCRM API with ETL capabilities"
 readme = "README.md"
 authors = [

{amochka-0.4.3 → amochka-0.4.4}/tests/test_notes_events.py

@@ -32,6 +32,46 @@ def test_get_entity_events_handles_none_response(monkeypatch):
     assert client.get_entity_events("lead", 1, get_all=True) == []
 
 
+def test_get_entity_notes_note_type_list_serialized(monkeypatch):
+    client = make_client()
+    captured = {}
+
+    def fake_request(method, endpoint, params=None, **kwargs):
+        captured["params"] = params
+        return {"_embedded": {"notes": []}, "_page_count": 1}
+
+    monkeypatch.setattr(client, "_make_request", fake_request)
+    notes = client.get_entity_notes("lead", 1, note_type=["common", "call_in"])
+    assert notes == []
+    assert captured["params"]["filter[note_type]"] == "common,call_in"
+
+
+def test_get_entity_notes_note_type_string_kept(monkeypatch):
+    client = make_client()
+    captured = {}
+
+    def fake_request(method, endpoint, params=None, **kwargs):
+        captured["params"] = params
+        return {"_embedded": {"notes": []}, "_page_count": 1}
+
+    monkeypatch.setattr(client, "_make_request", fake_request)
+    client.get_entity_notes("lead", 1, note_type="common")
+    assert captured["params"]["filter[note_type]"] == "common"
+
+
+def test_iter_notes_note_type_list_serialized(monkeypatch):
+    client = make_client()
+    captured = {}
+
+    def fake_request(method, endpoint, params=None, **kwargs):
+        captured["params"] = params
+        return {"_embedded": {"notes": []}, "_page_count": 1}
+
+    monkeypatch.setattr(client, "_make_request", fake_request)
+    list(client.iter_notes(note_type=["common", "call_in"], max_pages=1))
+    assert captured["params"]["filter[note_type]"] == "common,call_in"
+
+
 def test_get_entity_note_invalid_response_raises(monkeypatch):
     client = make_client()
     monkeypatch.setattr(client, "_make_request", lambda *args, **kwargs: None)