alissa-tools-github-revloop 0.29.0__tar.gz → 0.30.1__tar.gz

{alissa_tools_github_revloop-0.29.0/src/main/alissa_tools_github_revloop.egg-info → alissa_tools_github_revloop-0.30.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-revloop
-Version: 0.29.0
+Version: 0.30.1
 Summary: ALISSA-TOOLS-GITHUB-REVLOOP
 Home-page: https://alissa.app
 Author: Fahera

{alissa_tools_github_revloop-0.29.0 → alissa_tools_github_revloop-0.30.1}/src/main/alissa/tools/github/revloop/__main__.py

@@ -13,6 +13,7 @@ from .alissa_client import AlissaClient, AlissaError
 from .config import (
     BOW_OWNERS_ENV,
     BOWS_REFRESH_POLLS_ENV,
+    FLEET_VITALS_ENV,
     HUB_ADD,
     HUB_SKIP,
     LOOP_EVENTS_ENV,
@@ -200,6 +201,15 @@ def build_parser() -> argparse.ArgumentParser:
         "evidence; 0 queues immediately and relies on the directive alone",
     )
 
+    over.add_argument(
+        "--verdict-cooldown-s",
+        type=int,
+        metavar="SECONDS",
+        help="how long after a verdict lands on a head no round may be queued "
+        "on that same head, whatever the PR's requested_reviewers snapshot "
+        "says; 0 leaves the review_requested timeline check to decide alone",
+    )
+
     over.add_argument(
         "--review-task-miss-ttl-polls",
         type=int,
@@ -253,6 +263,23 @@ def build_parser() -> argparse.ArgumentParser:
         action="store_false",
         help="do not push loop telemetry even if the config enables it",
     )
+    vitals = over.add_mutually_exclusive_group()
+    vitals.add_argument(
+        "--fleet-vitals",
+        dest="fleet_vitals_enabled",
+        action="store_true",
+        default=None,
+        help="push one fleet-vitals snapshot (heartbeat, sessions, inbox, "
+        "rate, memory) to Studio's POST /v1/loop/fleet-vitals at the end of "
+        "every completed poll pass — best-effort, never fatal. "
+        f"Overridden by ${FLEET_VITALS_ENV}",
+    )
+    vitals.add_argument(
+        "--no-fleet-vitals",
+        dest="fleet_vitals_enabled",
+        action="store_false",
+        help="do not push fleet vitals even if the config enables it",
+    )
     over.add_argument(
         "--alissa-endpoint",
         dest="alissa_endpoint",
@@ -303,10 +330,12 @@ def overrides_from(args: argparse.Namespace) -> dict:
         "max_concurrent_sessions": args.max_concurrent_sessions,
         "checks_wait_seconds": args.checks_wait_seconds,
         "checks_spawn_wait_seconds": args.checks_spawn_wait_seconds,
+        "verdict_cooldown_s": args.verdict_cooldown_s,
         "review_task_miss_ttl_polls": args.review_task_miss_ttl_polls,
         "task_list_self_scope": args.task_list_self_scope,
         "task_list_bow_id": args.task_list_bow_id,
         "loop_events_enabled": args.loop_events_enabled,
+        "fleet_vitals_enabled": args.fleet_vitals_enabled,
         "alissa_endpoint": args.alissa_endpoint,
         "dry_run": args.dry_run,
     }

{alissa_tools_github_revloop-0.29.0 → alissa_tools_github_revloop-0.30.1}/src/main/alissa/tools/github/revloop/alissa_client.py

@@ -1,5 +1,6 @@
-"""Alissa REST access — loop telemetry's one write (issue #112) and the two
-reads `repos_source: bows` needs (issue #119).
+"""Alissa REST access — loop telemetry's write (issue #112), the fleet-vitals
+write beside it (issue #126) and the two reads `repos_source: bows` needs
+(issue #119).
 
 This is the SECOND Alissa adapter in the package, and the split is deliberate.
 `alissa.py` shells out to the `alissa` CLI, which is the daemon's established
@@ -62,6 +63,12 @@ ENV_TOKEN = "ALISSA_API_TOKEN"
 # rather than silently posting a request the API will 400.
 MAX_EVENTS_PER_POST = 200
 
+# The `error` code a 403 carries when the token's user has not activated the
+# stacked app that owns the loop ingest. Advisory (classification keys on the
+# status), but the vitals pusher reads it to warn ONCE with the activate URL
+# instead of once per pass.
+NOT_ACTIVATED = "not_activated"
+
 
 class _RefuseRedirects(urllib.request.HTTPRedirectHandler):
     """Refuse every redirect instead of following it (PR #113 round 1).
@@ -246,6 +253,22 @@ class AlissaClient:
         payload = self._request("/v1/loop-events", {"events": events})
         return payload if isinstance(payload, dict) else {}
 
+    def post_fleet_vitals(self, snapshot: dict) -> dict:
+        """Replace this seat's fleet-vitals snapshot (`POST
+        /v1/loop/fleet-vitals`, issue #126).
+
+        One body, one seat, replaced on every call — there is no batching
+        and no dedupe key, because the API keeps only the LATEST snapshot per
+        user×seat (loop events are the history). Returns the API's
+        `{"seat", "receivedAt", "replaced"}` payload (empty dict when the
+        body was empty), for the caller's debug line. The API is strict —
+        unknown keys 400, lists cap at 50, the body at 64 KB — and the
+        BUILDER (`fleet_vitals`) owns fitting the snapshot to that, so this
+        method sends exactly what it is handed.
+        """
+        payload = self._request("/v1/loop/fleet-vitals", snapshot)
+        return payload if isinstance(payload, dict) else {}
+
     def ping(self) -> Identity:
         """The identity this token acts as (`GET /v1/ping`).
 

{alissa_tools_github_revloop-0.29.0 → alissa_tools_github_revloop-0.30.1}/src/main/alissa/tools/github/revloop/config.py

@@ -15,6 +15,9 @@ site. `loop_events_enabled` (`ALISSA_REV_LOOP_EVENTS_ENABLED`, see
 `env_loop_events_enabled`) has it because a container deployment toggles
 telemetry with one variable and no config-file edit (issue #112); the env wins
 over both other layers so the two env-backed keys share one precedence story.
+`fleet_vitals_enabled` (`ALISSA_REV_FLEET_VITALS_ENABLED`, see
+`env_fleet_vitals_enabled`) is the second Studio push and rides the same rail
+through the same boolean reader (issue #126).
 The three `repos_source: bows` keys (issue #119) ride the same rail for the
 same container reason: `repos_source` (`ALISSA_REVIEW_REPOS_SOURCE`),
 `bows_refresh_polls` (`ALISSA_REVIEW_BOWS_REFRESH_POLLS`) and `bow_owners`
@@ -187,10 +190,12 @@ CONFIG_KEYS = (
     "max_concurrent_sessions",
     "checks_wait_seconds",
     "checks_spawn_wait_seconds",
+    "verdict_cooldown_s",
     "review_task_miss_ttl_polls",
     "task_list_self_scope",
     "task_list_bow_id",
     "loop_events_enabled",
+    "fleet_vitals_enabled",
     "alissa_endpoint",
     "dry_run",
 )
@@ -206,6 +211,11 @@ TASK_LIST_BOW_ENV = "ALISSA_REVIEW_TASK_BOW"
 # module docstring for the shared precedence story.
 LOOP_EVENTS_ENV = "ALISSA_REV_LOOP_EVENTS_ENABLED"
 
+# The environment variable toggling the fleet-vitals push (issue #126): one
+# snapshot of this daemon's live state per completed pass, to Studio's
+# `POST /v1/loop/fleet-vitals`. Same rail and same reader as LOOP_EVENTS_ENV.
+FLEET_VITALS_ENV = "ALISSA_REV_FLEET_VITALS_ENABLED"
+
 # The three `repos_source: bows` rails (issue #119). Same precedence as the two
 # above -- env > file > flag -- and the same blank-falls-through rule, because
 # the container bakes every knob as an ENV that renders `""` when unset.
@@ -258,18 +268,21 @@ def _validate_alissa_endpoint(endpoint: str) -> str:
     )
 
 
-def env_loop_events_enabled(
-    environ: "Mapping[str, str] | None" = None,
+def _env_bool(
+    name: str, environ: "Mapping[str, str] | None" = None,
 ) -> "bool | None":
-    """The loop-events toggle from the environment, or None when unset.
-
-    None and empty are the SAME answer — an exported-but-empty variable is how
-    a container renders "unset" (the Dockerfile bakes empty ENV defaults), and
-    it must fall through to the file/CLI layers rather than read as false. A
-    non-boolean spelling raises: the startup phase turns a ValueError into
-    `config error` + exit 2, which is where a typo belongs.
+    """One boolean env rail: True/False, or None when unset.
+
+    Shared by every boolean the environment can set (`LOOP_EVENTS_ENV`,
+    `FLEET_VITALS_ENV`) so the accepted spellings and the refusal are one
+    rule, not two copies that drift (issue #126). None and empty are the SAME
+    answer — an exported-but-empty variable is how a container renders
+    "unset" (the Dockerfile bakes empty ENV defaults), and it must fall
+    through to the file/CLI layers rather than read as false. A non-boolean
+    spelling raises, naming the variable: the startup phase turns a
+    ValueError into `config error` + exit 2, which is where a typo belongs.
     """
-    raw = (os.environ if environ is None else environ).get(LOOP_EVENTS_ENV)
+    raw = (os.environ if environ is None else environ).get(name)
     value = (raw or "").strip().lower()
     if not value:
         return None
@@ -278,11 +291,27 @@ def env_loop_events_enabled(
     if value in _ENV_FALSE:
         return False
     raise ValueError(
-        f"{LOOP_EVENTS_ENV} must be a boolean "
+        f"{name} must be a boolean "
         f"(1/0, true/false, yes/no, on/off), got {raw!r}"
     )
 
 
+def env_loop_events_enabled(
+    environ: "Mapping[str, str] | None" = None,
+) -> "bool | None":
+    """The loop-events toggle from the environment, or None when unset —
+    `_env_bool` over LOOP_EVENTS_ENV."""
+    return _env_bool(LOOP_EVENTS_ENV, environ)
+
+
+def env_fleet_vitals_enabled(
+    environ: "Mapping[str, str] | None" = None,
+) -> "bool | None":
+    """The fleet-vitals toggle from the environment, or None when unset —
+    `_env_bool` over FLEET_VITALS_ENV (issue #126)."""
+    return _env_bool(FLEET_VITALS_ENV, environ)
+
+
 def env_task_list_bow_id(environ: "Mapping[str, str] | None" = None) -> "str | None":
     """The review BOW id from the environment, or None when it is not set.
 
@@ -511,6 +540,24 @@ DEFAULT_CHECKS_WAIT_SECONDS = 30 * 60
 # still-running rollup, which is the directive-only posture.
 DEFAULT_CHECKS_SPAWN_WAIT_SECONDS = 15 * 60
 
+# How long, after a verdict lands on a head, NO round may be queued on that same
+# head -- whatever the PR's `requested_reviewers` snapshot says (issue #128).
+#
+# GitHub consumes a review request the moment the requested identity submits a
+# review, but not atomically with the daemon's reads: on studio #1243 a
+# `request_changes` verdict landed at 14:35:32 and the poll ten seconds later
+# still saw the reviewer in `requested_reviewers`, queued round 2 on the SAME
+# head, and that phantom round bounced on the CR8 triage gate -- which made the
+# devloop spawn a second fix session on one branch. The cooldown is the blunt
+# guard against that propagation lag: two polls' worth at the default cadence,
+# long enough for the request the verdict consumed to be gone from every read.
+# The precise guard is the timeline check in loop._admit_round, which admits a
+# same-head round only on a `review_requested` event NEWER than the verdict;
+# the cooldown spares that check a GitHub call in exactly the window where the
+# stale snapshot is most likely. 0 disables the cooldown and leaves the timeline
+# check to decide alone.
+DEFAULT_VERDICT_COOLDOWN_SECONDS = 120
+
 # How many polls a PR with NO review task may be taken on trust before the
 # daemon searches the task corpus for one again (issue #87).
 #
@@ -750,6 +797,12 @@ class Config:
     # timer to configure.
     checks_spawn_wait_seconds: int = DEFAULT_CHECKS_SPAWN_WAIT_SECONDS
 
+    # How long after a verdict lands on a head no round may be queued on that
+    # same head, regardless of the PR's `requested_reviewers` snapshot; see
+    # DEFAULT_VERDICT_COOLDOWN_SECONDS. 0 is legal and means "no cooldown": the
+    # timeline check alone decides whether a same-head round is admitted.
+    verdict_cooldown_s: int = DEFAULT_VERDICT_COOLDOWN_SECONDS
+
     # How many polls a PR with no review task is taken on trust before the
     # corpus is searched again; see DEFAULT_REVIEW_TASK_MISS_TTL_POLLS. Floor 1
     # -- there is no value that turns the negative cache off.
@@ -786,6 +839,15 @@ class Config:
     # when on: a failed push is one WARN and the pass completes.
     loop_events_enabled: bool = False
 
+    # Whether the loop pushes one FLEET-VITALS snapshot — heartbeat, poll
+    # durations, the reviewer-session roster, rate, memory, queue depth, the
+    # operator inbox — to Studio's `POST /v1/loop/fleet-vitals` at the end
+    # of every completed pass (issue #126), so a Factory with no console URL
+    # for this seat can still render its card. OFF by default for the same
+    # reason `loop_events_enabled` is; toggled by FLEET_VITALS_ENV above the
+    # file and the CLI; best-effort when on (one WARN per failed pass).
+    fleet_vitals_enabled: bool = False
+
     # The Alissa/Studio API base the loop-events client posts to. One knob so
     # a staging deployment can point telemetry somewhere else; everything else
     # about the client (its bearer token) comes from the environment.
@@ -884,8 +946,8 @@ class Config:
         "not specified on the CLI" and fall through to the file / defaults.
 
         `environ` is the fourth layer and applies to the env-backed keys
-        (`task_list_bow_id`, `loop_events_enabled`, `repos_source`,
-        `bows_refresh_polls`, `bow_owners`); it wins over both of the others
+        (`task_list_bow_id`, `loop_events_enabled`, `fleet_vitals_enabled`,
+        `repos_source`, `bows_refresh_polls`, `bow_owners`); it wins over both of the others
         (see the module docstring). Defaults to the real environment, so
         callers that do not care pass nothing.
         """
@@ -941,6 +1003,11 @@ class Config:
         env_events = env_loop_events_enabled(environ)
         if env_events is not None:
             raw["loop_events_enabled"] = env_events
+        # ...and the fleet-vitals toggle (issue #126), the same rail through
+        # the same reader.
+        env_vitals = env_fleet_vitals_enabled(environ)
+        if env_vitals is not None:
+            raw["fleet_vitals_enabled"] = env_vitals
 
         # The three bows rails (issue #119), same layer and same reason: the
         # container hands the daemon its mode with one variable. Each is
@@ -1103,6 +1170,10 @@ class Config:
                 f"checks_spawn_wait_seconds must be >= 0, got {spawn_wait}"
             )
 
+        cooldown = int(raw.get("verdict_cooldown_s", cls.verdict_cooldown_s))
+        if cooldown < 0:
+            raise ValueError(f"verdict_cooldown_s must be >= 0, got {cooldown}")
+
         miss_ttl = int(
             raw.get("review_task_miss_ttl_polls", cls.review_task_miss_ttl_polls)
         )
@@ -1171,10 +1242,12 @@ class Config:
             max_concurrent_sessions=max_sessions,
             checks_wait_seconds=checks_wait,
             checks_spawn_wait_seconds=spawn_wait,
+            verdict_cooldown_s=cooldown,
             review_task_miss_ttl_polls=miss_ttl,
             task_list_self_scope=bool(raw.get("task_list_self_scope", False)),
             task_list_bow_id=bow_id,
             loop_events_enabled=bool(raw.get("loop_events_enabled", False)),
+            fleet_vitals_enabled=bool(raw.get("fleet_vitals_enabled", False)),
             alissa_endpoint=endpoint,
             dry_run=bool(raw.get("dry_run", False)),
         )