alissa-tools-github-revloop 0.21.0__tar.gz → 0.23.0__tar.gz

{alissa_tools_github_revloop-0.21.0/src/main/alissa_tools_github_revloop.egg-info → alissa_tools_github_revloop-0.23.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-revloop
-Version: 0.21.0
+Version: 0.23.0
 Summary: ALISSA-TOOLS-GITHUB-REVLOOP
 Home-page: https://alissa.app
 Author: Fahera

{alissa_tools_github_revloop-0.21.0 → alissa_tools_github_revloop-0.23.0}/src/main/alissa/tools/github/revloop/alissa.py

@@ -13,8 +13,42 @@ from .proc import CommandError, run, run_json
 
 log = logging.getLogger(__name__)
 
-# A review task is "open" while it can still receive a verdict.
-OPEN_STATUSES = {"committed", "in_progress", "pending_validation", "todo"}
+# The seven canonical Alissa task statuses -- `TaskStatusSchema` in the studio
+# repo (`packages/client/src/schemas/common.ts`). Mirrored here for the reason
+# the studio CLI mirrors it into `TASK_STATUSES` rather than importing it: what
+# this module needs is the SET of names, not the schema that validates them.
+#
+# It is the vocabulary the `--status` filter below is allowed to speak. CLI
+# 0.2.0 validates `--status` against exactly these seven client-side and exits 1
+# on anything else BEFORE issuing any request, so a single non-canonical value
+# does not narrow the call slightly less -- it costs the whole narrowed call.
+#
+# A status Alissa adds lands HERE first: a name added to `OPEN_STATUSES` alone
+# reads as non-canonical and drops the narrowing for the whole fleet. That is
+# the safe direction -- wide, never a wrong task resolved -- and the canonical
+# test fails on it, but it fails naming `OPEN_STATUSES`, which is the constant
+# that is right; this is the one that is stale (PR #98 round 1).
+CANONICAL_TASK_STATUSES = frozenset(
+    {
+        "draft",
+        "committed",
+        "in_progress",
+        "blocked",
+        "pending_validation",
+        "validated",
+        "cancelled",
+    }
+)
+
+# A review task is "open" while it can still receive a verdict. Every member is
+# canonical, and a test pins that: a status Alissa cannot issue is dead weight
+# in `is_open` and poison in the `--status` filter derived from it.
+#
+# `todo` was such a member until 0.22.0 (issue #97). Alissa has never had that
+# status, so `is_open` could never match it -- but it was still reaching CLI
+# 0.2.0's `--status` validator, which rejects the call over it, which in turn
+# drops this process back to the unnarrowed whole-corpus list for good.
+OPEN_STATUSES = {"committed", "in_progress", "pending_validation"}
 
 # -- narrowing the `alissa task list` call (issue #87) ------------------------
 #
@@ -26,13 +60,48 @@ OPEN_STATUSES = {"committed", "in_progress", "pending_validation", "todo"}
 # not evidence, and this daemon turns a non-zero `alissa` exit into a SKIPPED
 # decision, so sending a flag the CLI does not have costs a review.
 
-# Statuses a LIVE review task can hold. Deliberately OPEN_STATUSES itself and
-# not a hand-written list: `is_review_task_for` already rejects every other
+# Statuses a LIVE review task can hold. Deliberately derived from OPEN_STATUSES
+# and not a hand-written list: `is_review_task_for` already rejects every other
 # status client-side, so filtering server-side on exactly this set cannot change
 # which task the daemon resolves -- it only stops shipping the rows over the
 # wire. Any status added to `is_open` is added here by construction.
+#
+# The canonical guard below does not weaken that invariant, and is deliberately
+# not an INTERSECTION with the canonical set, which would: an intersection makes
+# the filter a strict subset of the open set the moment the two disagree, so the
+# daemon would stop fetching rows `is_open` still accepts -- a skipped review,
+# reported as an empty corpus. The whole derivation is kept or nothing is sent.
+# Sending nothing degrades to the call the daemon has always made: wide, but
+# complete, which is the direction every other failure on this path degrades in.
 TASK_LIST_STATUS_FLAG = "--status"
-TASK_LIST_STATUS_FILTER = ",".join(sorted(OPEN_STATUSES))
+
+
+def _status_filter(statuses: "set[str] | frozenset[str]") -> str:
+    """The `--status` argument for `statuses`, or `""` when they cannot be one.
+
+    `""` means "do not narrow by status". It is returned for a set carrying any
+    non-canonical value, because such a value is not a filter the CLI serves
+    less precisely -- it is one the CLI refuses outright, taking the `--view`
+    and `--self` narrowing down with it and pinning this process to the
+    whole-corpus list (`list_tasks`). One wide call beats every call being wide.
+
+    Pure on purpose. The condition is a code defect and deserves saying out
+    loud, but not from here: this runs at IMPORT, which is the one moment the
+    daemon's logging is not configured yet (see
+    `Alissa._warn_status_filter_dropped`). The tests are what pin the condition;
+    the runtime warning is the second line, and it is emitted where it can both
+    be formatted and be true.
+    """
+    if set(statuses) - CANONICAL_TASK_STATUSES:
+        return ""
+    return ",".join(sorted(statuses))
+
+
+TASK_LIST_STATUS_FILTER = _status_filter(OPEN_STATUSES)
+
+# Why the filter above is empty, when it is -- kept for the diagnostic, which
+# cannot be emitted from module scope. Empty in the healthy case.
+NON_CANONICAL_OPEN_STATUSES = tuple(sorted(OPEN_STATUSES - CANONICAL_TASK_STATUSES))
 
 # `--self` drops the SPONSOR's corpus and keeps only the calling actor's rows.
 #
@@ -320,6 +389,9 @@ class Alissa:
         # wrongly is worse than a list that is large: `find_review_task` reads an
         # empty corpus as "this PR has no review task".
         self._task_list_narrowing_disabled = False
+        # One diagnostic per client for a status filter that could not be sent
+        # (see `_warn_status_filter_dropped`); this path runs every poll pass.
+        self._status_filter_warned = False
 
     # -- the `alissa task list` narrowing probe -----------------------------
 
@@ -365,6 +437,38 @@ class Alissa:
         self._task_list_flags = flags
         return flags
 
+    def _warn_status_filter_dropped(self) -> None:
+        """Say, once, that a status narrowing this CLI offers is going unused.
+
+        Not emitted where the filter is COMPUTED, which is import time, and that
+        is the whole point of it living here (PR #98 round 1): `__main__` pulls
+        this module in through `.loop` long before it calls
+        `logging.basicConfig`, so a warning at module scope falls through to
+        `logging.lastResort` -- bare on stderr, no timestamp or logger name, and
+        outside whatever handler the deployment configured.
+
+        It would also be premature there. At import nothing yet knows whether
+        this CLI serves `--status` at all, and on a CLI that does not, the
+        filter costs nothing and there is nothing to warn about. Here the
+        message is only emitted when the flag was on offer and could not be
+        used, which is the only case where the defect actually costs reads.
+        """
+        if self._status_filter_warned:
+            return
+        self._status_filter_warned = True
+        reason = (
+            "non-canonical status(es) in OPEN_STATUSES: "
+            + ", ".join(NON_CANONICAL_OPEN_STATUSES)
+            if NON_CANONICAL_OPEN_STATUSES
+            else "OPEN_STATUSES is empty"
+        )
+        log.warning(
+            "`alissa task list` offers --status and this daemon is not using "
+            "it (%s) -- the CLI rejects the whole call over one unknown value, "
+            "so the corpus is listed unnarrowed",
+            reason,
+        )
+
     def task_list_argv(self, *, narrow_status: bool = True) -> list[str]:
         """The narrowest `alissa task list` this CLI actually supports.
 
@@ -375,8 +479,14 @@ class Alissa:
         if self._task_list_narrowing_disabled:
             return argv
         flags = self.probe_task_list()
+        # An empty filter is not a filter: `_status_filter` answers `""` when
+        # the open set carries a status the CLI would reject, and sending
+        # `--status ""` would be that same rejected call with an extra step.
         if flags.status and narrow_status:
-            argv += [TASK_LIST_STATUS_FLAG, TASK_LIST_STATUS_FILTER]
+            if TASK_LIST_STATUS_FILTER:
+                argv += [TASK_LIST_STATUS_FLAG, TASK_LIST_STATUS_FILTER]
+            else:
+                self._warn_status_filter_dropped()
         if flags.self_scope and self._task_list_self_scope:
             argv.append(TASK_LIST_SELF_FLAG)
         if flags.digest:

{alissa_tools_github_revloop-0.21.0 → alissa_tools_github_revloop-0.23.0}/src/main/alissa/tools/github/revloop/prreview.py

@@ -75,9 +75,9 @@ def _review_task_ref(alissa: Alissa, owner: str, repo: str, number: int) -> str
     Deliberately not `Alissa.find_review_task` (which filters to open tasks): we
     still want the ref just after the task is validated, to read its verdict.
     `narrow_status=False` says the same thing to the LIST call for the same
-    reason -- the daemon's server-side status filter is exactly its `is_open`
-    set, and narrowing by it here would re-impose the filter this function
-    exists to avoid.
+    reason -- the daemon's server-side status filter is either exactly its
+    `is_open` set or absent altogether, and in the first case narrowing by it
+    here would re-impose the filter this function exists to avoid.
     """
     pattern = re.compile(
         rf"^Review PR\s+{re.escape(owner)}/{re.escape(repo)}#{number}\b", re.IGNORECASE

alissa_tools_github_revloop-0.23.0/src/main/alissa/tools/github/revloop/version

@@ -0,0 +1 @@
+0.23.0

{alissa_tools_github_revloop-0.21.0 → alissa_tools_github_revloop-0.23.0/src/main/alissa_tools_github_revloop.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-revloop
-Version: 0.21.0
+Version: 0.23.0
 Summary: ALISSA-TOOLS-GITHUB-REVLOOP
 Home-page: https://alissa.app
 Author: Fahera

alissa_tools_github_revloop-0.21.0/src/main/alissa/tools/github/revloop/version

@@ -1 +0,0 @@
-0.21.0