alissa-tools-github-genloop 0.1.3__tar.gz → 0.1.4__tar.gz

{alissa_tools_github_genloop-0.1.3/src/main/alissa_tools_github_genloop.egg-info → alissa_tools_github_genloop-0.1.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-genloop
-Version: 0.1.3
+Version: 0.1.4
 Summary: ALISSA-TOOLS-GITHUB-GENLOOP
 Home-page: https://alissa.app
 Author: Fahera

{alissa_tools_github_genloop-0.1.3 → alissa_tools_github_genloop-0.1.4}/src/main/alissa/tools/github/genloop/github.py

@@ -13,8 +13,14 @@ same fallback orcloop's `ci-green` read uses. It reads only the run of record:
 the newest plan-lint run of the trusted event (`pull_request_target`, the job
 that publishes the `plan-lint` check run), mapped onto the check run's
 `{conclusion}` shape. The offline `pull_request` run never counts, as it never
-does on the check-runs path. A denied 403 ("Resource not accessible") is
-latched for the process -- every later read goes straight to the Actions path;
+does on the check-runs path. A `failure` is red only when the job's publish
+step (`Publish the plan-lint check run …`, `if: always()`) succeeded: that
+step is the only thing that creates the check run, and it publishes `failure`
+itself when the linter never reported. When the publish step failed (a 5xx
+on its POST), no check run exists, so the fallback reads None, as the
+check-runs path would; the run's jobs (`actions/runs/<id>/jobs`) say which.
+A denied 403 ("Resource not accessible") is latched for the process -- every
+later read goes straight to the Actions path;
 any other 403 (a secondary rate limit) falls back for that read only. When
 the Actions read fails too, the warning is logged once per PR per head and
 `LintUnreadable` is raised, which the caller skips quietly.
@@ -48,6 +54,9 @@ LINT_WORKFLOW = ".github/workflows/plan-lint.yml"
 # conclusion passes through verbatim, so only `failure` is a red lint, as on
 # the check-runs path; the offline `pull_request` run is never read.
 LINT_EVENT = "pull_request_target"
+# The trusted job's step that publishes the `plan-lint` check run, matched as a
+# prefix of the step name (`GitHub(lint_publish_step=...)` names another).
+LINT_PUBLISH_STEP = "Publish the plan-lint check run"
 # The 403 body of a token that cannot read check runs, as against a rate limit.
 _DENIED_MARKER = "resource not accessible"
 # A plan PR thread longer than this many pages of 100 comments is read only up to here.
@@ -111,10 +120,12 @@ class Comment:
 
 
 class GitHub:
-    def __init__(self, *, timeout: int = 60, lint_workflow: str = LINT_WORKFLOW, lint_event: str = LINT_EVENT):
+    def __init__(self, *, timeout: int = 60, lint_workflow: str = LINT_WORKFLOW, lint_event: str = LINT_EVENT,
+                 lint_publish_step: str = LINT_PUBLISH_STEP):
         self.timeout = timeout
         self.lint_workflow = lint_workflow
         self.lint_event = lint_event
+        self.lint_publish_step = lint_publish_step
         # Latched on the first 403 from check-runs: this token cannot read them.
         self._check_runs_denied = False
         # (repo, pr) -> the head whose unreadable lint has been logged already;
@@ -274,7 +285,8 @@ class GitHub:
     def _lint_actions_run(self, repo: str, sha: str) -> dict | None:
         """The newest plan-lint run of `lint_event` on `sha` as a check run:
         its conclusion verbatim once completed, pending (None) before, and
-        None when there is no such run yet."""
+        None when there is no such run yet -- or when it failed only because
+        its publish step did, so that no check run exists."""
         data = self._api(
             "-X", "GET", f"repos/{repo}/actions/runs", "-f", f"head_sha={sha}", "-f", "per_page=100",
         )
@@ -287,12 +299,31 @@ class GitHub:
             return None
         head = max(trusted, key=_run_order)
         completed = head.get("status") == "completed"
+        if completed and head.get("conclusion") == "failure" and not self._lint_published(repo, head):
+            return None
         return {
             "id": head.get("id"), "name": LINT_CHECK_NAME, "source": "actions",
             "status": "completed" if completed else str(head.get("status") or "") or "in_progress",
             "conclusion": head.get("conclusion") if completed else None, "html_url": head.get("html_url"),
         }
 
+    def _lint_published(self, repo: str, run: dict) -> bool:
+        """Whether the failed `run` published its `plan-lint` check run: its
+        publish step succeeded, or no step of its jobs is the publish step (the
+        failure then stands, as before this read)."""
+        path = f"repos/{repo}/actions/runs/{run.get('id')}/jobs"
+        data = self._api("-X", "GET", path, "-f", "per_page=100")
+        jobs = data.get("jobs") if isinstance(data, dict) else None
+        if not isinstance(jobs, list):
+            raise CommandError(["gh", "api", path], 0, "no jobs in the answer")
+        steps = [s for j in jobs if isinstance(j, dict) for s in (j.get("steps") or [])
+                 if isinstance(s, dict) and str(s.get("name") or "").startswith(self.lint_publish_step)]
+        if not steps or any(s.get("conclusion") == "success" for s in steps):
+            return True
+        log.debug("genloop: plan-lint run %s on %s failed without publishing its check run — no lint, "
+                  "as on the check-runs path", run.get("id"), repo)
+        return False
+
     def _is_lint_workflow(self, r: dict) -> bool:
         path = str(r.get("path") or "").split("@", 1)[0]
         return self.lint_workflow in (path, str(r.get("name") or ""))

alissa_tools_github_genloop-0.1.4/src/main/alissa/tools/github/genloop/version

@@ -0,0 +1 @@
+0.1.4

{alissa_tools_github_genloop-0.1.3 → alissa_tools_github_genloop-0.1.4/src/main/alissa_tools_github_genloop.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-genloop
-Version: 0.1.3
+Version: 0.1.4
 Summary: ALISSA-TOOLS-GITHUB-GENLOOP
 Home-page: https://alissa.app
 Author: Fahera

alissa_tools_github_genloop-0.1.3/src/main/alissa/tools/github/genloop/version

@@ -1 +0,0 @@
-0.1.3