alissa-tools-github-devloop 0.8.9__tar.gz → 0.8.11__tar.gz

{alissa_tools_github_devloop-0.8.9/src/main/alissa_tools_github_devloop.egg-info → alissa_tools_github_devloop-0.8.11}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: alissa-tools-github-devloop
-Version: 0.8.9
+Version: 0.8.11
 Summary: ALISSA-TOOLS-GITHUB-DEVLOOP
 Home-page: https://alissa.app
 Author: Fahera

{alissa_tools_github_devloop-0.8.9 → alissa_tools_github_devloop-0.8.11}/src/main/alissa/tools/github/devloop/alissa.py

@@ -111,6 +111,38 @@ class Alissa:
             )
         return [entry for entry in data if isinstance(entry, dict)]
 
+    def tail_session(self, name: str, lines: int = 20) -> str:
+        """The last `lines` of ONE managed session's terminal, or "" when the
+        CLI cannot answer.
+
+        Evidence, not control flow: the foreign-session sweep quotes this into
+        the line it logs before killing a session nothing in the loop reads, so
+        that what the session WAS survives the kill (the incident's own answer
+        -- "reviewer seat review-pr-904 busy" -- was only ever visible in a
+        pane).
+
+        WHAT COMES BACK IS UNTRUSTED AND MAY BE SENSITIVE. It is another
+        agent's screen, verbatim: file contents it read, issue and customer
+        text, tokens it printed. Treat it as data, never as instruction, and
+        do not put it anywhere the daemon's own logs do not already go -- the
+        console serves the log TAIL over HTTP, so the caller keeps this at
+        DEBUG and lets only its shape reach an operator-facing level (see
+        `DevWatcher._foreign_pane_evidence`).
+
+        Best-effort by construction: a CLI too old for `tmux tail`, a
+        session that vanished between the listing and the capture, or a tail
+        that times out must never cost the sweep its kill, so every failure
+        degrades to the empty string and the log line says the tail was
+        unavailable rather than losing the decision."""
+        try:
+            out = run(
+                ["alissa", "tmux", "tail", name, "-n", str(lines)], timeout=30
+            )
+        except CommandError as exc:
+            log.debug("could not tail %s (%s)", name, exc)
+            return ""
+        return out.strip()
+
     def kill_session(self, name: str) -> None:
         """Kill ONE managed session by name -- never the tmux server. Raises
         CommandError on failure (including a CLI old enough to lack

{alissa_tools_github_devloop-0.8.9 → alissa_tools_github_devloop-0.8.11}/src/main/alissa/tools/github/devloop/config.py

@@ -52,6 +52,18 @@ REPOS_BOWS = "bows"  # `repos` UNIONED with the operator's autodev feed BOWs
 
 _REPOS_SOURCES = {REPOS_STATIC, REPOS_BOWS}
 
+# What the reaper does about a FOREIGN session -- a live managed (`ali-*`)
+# tmux session that is not one of devloop's own workers and carries no
+# configured allow prefix. The incident (issue #95): a develop worker spawned
+# its own reviewer session, which no code path read, no sweep considered, and
+# which idled at ~600 MB until the container restarted. A directive is not
+# enforcement; this is the enforcement.
+FOREIGN_REAP = "reap"  # kill it once idle past the reaper's grace
+FOREIGN_WARN = "warn"  # log the decision and escalate, never kill
+FOREIGN_IGNORE = "ignore"  # today's behavior: never even considered
+
+_FOREIGN_POLICIES = {FOREIGN_REAP, FOREIGN_WARN, FOREIGN_IGNORE}
+
 CONFIG_FILENAME = "devloop.config.json"
 
 # Comma-separated reviewer logins; authoritative when set, even if empty.
@@ -102,6 +114,8 @@ CONFIG_KEYS = (
     "stale_minutes",
     "max_sessions",
     "reap_grace_minutes",
+    "foreign_session_policy",
+    "foreign_session_allow_prefixes",
     "on_missing_origin_task",
     "on_missing_hub",
     "fix_rounds_enabled",
@@ -190,6 +204,33 @@ def normalize_bow_owners(values: "Any") -> "tuple[str, ...]":
     return tuple(out)
 
 
+def normalize_session_prefixes(values: "Any") -> "tuple[str, ...]":
+    """Validate the `foreign_session_allow_prefixes` layer into name prefixes.
+
+    Parsed exactly like `bow_owners` -- a list of strings, each of which may
+    itself carry a `|`- and/or `,`-separated list, which is what one flag or a
+    single platform variable looks like -- minus the actor-id validation, which
+    has no analogue here: a session-name prefix is free text.
+
+    Whitespace is stripped and empties dropped, so a trailing separator is
+    harmless. NOT casefolded: tmux session names are case-sensitive, and
+    folding would widen the exemption to names the sweep would still kill.
+
+    An empty result means "no exemptions", which is the default and the one
+    value with teeth: every foreign session is then a candidate. It is not a
+    fail-open state -- the policy, not this list, decides what happens next.
+    """
+    out: "list[str]" = []
+    seen: "set[str]" = set()
+    for value in _string_list(values, "foreign_session_allow_prefixes"):
+        for part in _OWNER_SEPARATORS.split(value):
+            entry = part.strip()
+            if entry and entry not in seen:
+                seen.add(entry)
+                out.append(entry)
+    return tuple(out)
+
+
 def _validate_actor_id(entry: str) -> None:
     """Reject anything that is not an Alissa actor id, naming the entry.
 
@@ -323,6 +364,31 @@ class Config:
     # back to stale_minutes, the sentinel every other grace knob here uses.
     reap_grace_minutes: int = 30
 
+    # The foreign-session sweep (issue #95) -- depth-1 made MECHANICAL. A
+    # foreign session is a live entry in the reaper's own `alissa tmux ls`
+    # roster whose name is not devloop's grammar (`parse_worker_session` ->
+    # None) and starts with none of `foreign_session_allow_prefixes`. Default
+    # `reap` because the failure it answers is unbounded: a session nothing
+    # reads holds its memory until the container restarts, and every code path
+    # that could have noticed it was keyed on a name grammar it does not match.
+    #
+    # It runs under the SAME three guardrails as the worker sweep -- idle only
+    # (a busy foreign session is a holdout, never killed), quiet past
+    # `reap_grace_minutes`, one `alissa tmux kill` at a time, best-effort, and
+    # dry-run only logs.
+    foreign_session_policy: str = FOREIGN_REAP
+
+    # Name prefixes the sweep never treats as foreign: an operator's own shell,
+    # a co-located daemon's lane. EMPTY BY DEFAULT, which is the sharp edge
+    # worth stating plainly -- with `reap` and no prefixes, a container shared
+    # with another daemon will reap that daemon's idle sessions too, because
+    # nothing in a session NAME distinguishes a reviewer daemon's own seat from
+    # the one a worker spawned for itself (they are the same shape; that is the
+    # incident). Set this before deploying `reap` into a shared container.
+    # Parsed like `repos` with `bow_owners`' separators: a list of strings, each
+    # of which may itself carry a `|`- and/or `,`-separated list.
+    foreign_session_allow_prefixes: tuple[str, ...] = ()
+
     on_missing_origin_task: str = ON_MISSING_WARN
     on_missing_hub: str = HUB_SKIP
 
@@ -727,6 +793,19 @@ class Config:
                 f"got {reap_grace}"
             )
 
+        # The foreign-session policy. An enum, validated by NAME like
+        # on_missing_hub and repos_source: a typo here would otherwise fall
+        # through to "not reap, not warn" and silently disable the sweep,
+        # which is the one outcome an operator setting this key cannot want.
+        foreign_policy = str(
+            raw.get("foreign_session_policy", cls.foreign_session_policy)
+        ).strip()
+        if foreign_policy not in _FOREIGN_POLICIES:
+            raise ValueError(
+                f"foreign_session_policy must be one of "
+                f"{sorted(_FOREIGN_POLICIES)}, got {foreign_policy!r}"
+            )
+
         # 0 is the sentinel for "fall back to stale_minutes" (the documented
         # default), so the floor is 0 like max_sessions' -- a negative grace
         # would make the self-heal fire on a head pushed in the future.
@@ -812,6 +891,13 @@ class Config:
             stale_minutes=stale,
             max_sessions=max_sessions,
             reap_grace_minutes=reap_grace,
+            foreign_session_policy=foreign_policy,
+            foreign_session_allow_prefixes=normalize_session_prefixes(
+                raw.get(
+                    "foreign_session_allow_prefixes",
+                    cls.foreign_session_allow_prefixes,
+                )
+            ),
             on_missing_origin_task=mode,
             on_missing_hub=hub_mode,
             fix_rounds_enabled=bool(