agentirc-cli 9.1.0__tar.gz → 9.3.0__tar.gz

agentirc_cli-9.3.0/.claude/skills/pr-review/scripts/pr-sonar.sh

@@ -0,0 +1,93 @@
+#!/usr/bin/env bash
+# pr-sonar.sh — list every SonarCloud finding attached to a PR.
+#
+# Surfaces what the GitHub-side `poll` cannot: SonarCloud issues,
+# security hotspots, and the duplication breakdown. The
+# sonarqubecloud[bot] PR comment only links to the dashboard — actual
+# findings live behind the SonarCloud API.
+#
+# Usage: pr-sonar.sh [--repo OWNER/REPO] [--sonar-key KEY] PR_NUMBER
+#
+# Defaults:
+#   --repo        auto-detected via `gh repo view`
+#   --sonar-key   derived from repo as `<owner>_<name>`
+#
+# Anonymous SonarCloud access is sufficient for public projects.
+# Requires: gh, jq, curl, python3.
+
+set -euo pipefail
+
+REPO=""
+SONAR_KEY=""
+
+while [[ $# -gt 0 ]]; do
+    case "$1" in
+        --repo) REPO="$2"; shift 2 ;;
+        --sonar-key) SONAR_KEY="$2"; shift 2 ;;
+        *) break ;;
+    esac
+done
+
+PR_NUMBER="${1:?Usage: pr-sonar.sh [--repo OWNER/REPO] [--sonar-key KEY] PR_NUMBER}"
+
+if [[ -z "$REPO" ]]; then
+    REPO=$(gh repo view --json nameWithOwner -q .nameWithOwner)
+fi
+if [[ -z "$SONAR_KEY" ]]; then
+    SONAR_KEY="${REPO%%/*}_${REPO##*/}"
+fi
+
+echo "════════════════ SONARCLOUD (project=$SONAR_KEY, PR=$PR_NUMBER) ════════════════"
+
+# ── Quality gate
+QG=$(curl -fsS "https://sonarcloud.io/api/qualitygates/project_status?projectKey=${SONAR_KEY}&pullRequest=${PR_NUMBER}" || echo '{}')
+QG_STATUS=$(echo "$QG" | jq -r '.projectStatus.status // "UNKNOWN"')
+echo "Quality Gate: $QG_STATUS"
+echo "$QG" | jq -r '.projectStatus.conditions[]? | select(.status != "OK") | "  ✗ \(.metricKey) = \(.actualValue) (threshold \(.comparator) \(.errorThreshold))"' || true
+
+# ── Issues (BUG / VULNERABILITY / CODE_SMELL)
+ISSUES=$(curl -fsS "https://sonarcloud.io/api/issues/search?componentKeys=${SONAR_KEY}&pullRequest=${PR_NUMBER}&statuses=OPEN,CONFIRMED&ps=500" || echo '{}')
+ISSUE_TOTAL=$(echo "$ISSUES" | jq -r '.total // 0')
+echo
+echo "── Issues ($ISSUE_TOTAL OPEN/CONFIRMED) ─────────────────────────────"
+if [[ "$ISSUE_TOTAL" != "0" ]]; then
+    echo "$ISSUES" | jq -r '
+        .issues[] |
+        "  [\(.rule)] \(.severity)  \(.component | sub("^[^:]+:"; ""))(:\(.line // "?"))\n     \(.message)"
+    '
+fi
+
+# ── Security hotspots
+HOTSPOTS=$(curl -fsS "https://sonarcloud.io/api/hotspots/search?projectKey=${SONAR_KEY}&pullRequest=${PR_NUMBER}&status=TO_REVIEW&ps=500" || echo '{}')
+HOTSPOT_TOTAL=$(echo "$HOTSPOTS" | jq -r '.paging.total // 0')
+echo
+echo "── Hotspots ($HOTSPOT_TOTAL TO_REVIEW) ──────────────────────────────"
+if [[ "$HOTSPOT_TOTAL" != "0" ]]; then
+    echo "$HOTSPOTS" | jq -r '
+        .hotspots[] |
+        "  [\(.ruleKey)] \(.vulnerabilityProbability)  \(.component | sub("^[^:]+:"; ""))(:\(.line // "?"))\n     \(.message)"
+    '
+fi
+
+# ── Duplication
+MEAS=$(curl -fsS "https://sonarcloud.io/api/measures/component?component=${SONAR_KEY}&pullRequest=${PR_NUMBER}&metricKeys=new_duplicated_lines_density,new_duplicated_lines,new_duplicated_blocks" || echo '{}')
+DUP_PCT=$(echo "$MEAS" | jq -r '.component.measures[]? | select(.metric == "new_duplicated_lines_density") | .periods[0].value // ""')
+DUP_LINES=$(echo "$MEAS" | jq -r '.component.measures[]? | select(.metric == "new_duplicated_lines") | .periods[0].value // ""')
+DUP_BLOCKS=$(echo "$MEAS" | jq -r '.component.measures[]? | select(.metric == "new_duplicated_blocks") | .periods[0].value // ""')
+echo
+echo "── Duplication on new code ──────────────────────────────────────────"
+echo "  density: ${DUP_PCT:-?}%   lines: ${DUP_LINES:-?}   blocks: ${DUP_BLOCKS:-?}"
+
+if [[ "${DUP_BLOCKS:-0}" != "0" && -n "${DUP_BLOCKS:-}" ]]; then
+    # Per-file duplication: list every file with duplicated_lines on new code.
+    # Sonar doesn't expose per-PR duplication-by-file directly; surface the
+    # files that appear in the issues + hotspots as a weak proxy.
+    DUP_FILES=$(echo "$ISSUES" | jq -r '[.issues[] | .component | sub("^[^:]+:"; "")] | unique | .[]')
+    if [[ -n "$DUP_FILES" ]]; then
+        echo "  files with findings (likely duplication source):"
+        echo "$DUP_FILES" | sed 's/^/    - /'
+    fi
+fi
+
+echo
+echo "Dashboard: https://sonarcloud.io/dashboard?id=${SONAR_KEY}&pullRequest=${PR_NUMBER}"

{agentirc_cli-9.1.0 → agentirc_cli-9.3.0}/.claude/skills/pr-review/scripts/workflow.sh

@@ -3,7 +3,8 @@
 #
 # Subcommands:
 #   lint              run the portability lint on the current diff (staged + unstaged)
-#   poll <PR>         fetch and display review comments
+#   poll <PR>         fetch and display review comments + SonarCloud findings
+#   sonar <PR>        list every SonarCloud issue / hotspot / duplication on a PR
 #   reply <PR>        batch reply to review comments (JSONL on stdin), --resolve
 #   delta             dump CLAUDE.md head + culture.yaml for each sibling project
 #                     listed in skills.local.yaml (alignment-delta check)
@@ -53,6 +54,12 @@ case "$cmd" in
     poll)
         PR="${1:?Usage: workflow.sh poll <PR>}"
         bash "$SCRIPT_DIR/pr-comments.sh" "$PR"
+        echo
+        bash "$SCRIPT_DIR/pr-sonar.sh" "$PR"
+        ;;
+    sonar)
+        PR="${1:?Usage: workflow.sh sonar <PR>}"
+        bash "$SCRIPT_DIR/pr-sonar.sh" "$PR"
         ;;
     reply)
         PR="${1:?Usage: workflow.sh reply <PR>  (JSONL on stdin)}"

agentirc_cli-9.3.0/CHANGELOG.md

@@ -0,0 +1,204 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+Format follows [Keep a Changelog](https://keepachangelog.com/).
+
+## [9.3.0] - 2026-05-01
+
+### Added
+
+- Test suite migration (PR-B3): 36 server-core / telemetry tests
+  vendored from `culture@df50942` (~6,500 LOC). 315 tests run under
+  `pytest -n auto` in ~29 seconds.
+  - 21 server-core tests in `tests/` cover IRC lifecycle, channels,
+    rooms, threads, history, federation (S2S), events, mentions,
+    and the icon skill.
+  - 15 telemetry integration tests in `tests/telemetry/` cover audit
+    JSONL emission, OTLP span injection on dispatch, S2S relay
+    spans, metrics initialization, and trace-context propagation.
+  - Test helper modules `_fakes.py` and `_metrics_helpers.py` also
+    vendored verbatim under the same package.
+- `tests/conftest.py` — adapted from culture. Drops the
+  `_BOTS_DIR_*` patches and the `server_with_bot` /
+  `server_with_bots` fixtures (see Changed below). Keeps the
+  `IRCTestClient` raw-TCP helper and the IRCd lifecycle, telemetry,
+  and audit fixtures.
+- `.claude/skills/pr-review/scripts/pr-sonar.sh` — new script that
+  fetches every SonarCloud issue, security hotspot, and duplication
+  measure for a PR via the SonarCloud API. `workflow.sh poll` now
+  runs it after `pr-comments.sh`; `workflow.sh sonar <PR>` runs it
+  standalone. Closes the gap where the GitHub-side poll only saw
+  the SonarCloud bot's "Quality Gate failed" link without the
+  underlying findings. Re-vendor to `steward` after this PR merges.
+- Three `[tool.citation]` packages:
+  `culture-tests-conftest` (paraphrase),
+  `culture-tests-server-core` (mostly quote, paraphrase for
+  `test_events_basic.py`), and `culture-tests-telemetry` (mostly
+  quote, paraphrase for `test_tracing.py`).
+
+### Changed
+
+- `agentirc/server_link.py:_replay_event` — parameter renamed from
+  `_seq` (PR-B1's unused-arg compliance variant) back to `seq` to
+  match the upstream signature culture's tests assume; signature
+  carries `# noqa: ARG002 # NOSONAR S1172`. Hash refreshed.
+
+### Fixed (post-review)
+
+- `requires-python = ">=3.10"` → `">=3.11"`; classifiers updated
+  (drop 3.10, add 3.13). Resolves Copilot/Qodo "asyncio.timeout
+  not in 3.10" findings. The 3.10 floor was inherited from PR-B1/B2
+  and would have ImportError'd on the first test run.
+- 2 SonarCloud `python:S5332` security hotspots cleared via
+  `# NOSONAR S5332` annotations on `tests/telemetry/test_config.py`'s
+  localhost OTLP test fixtures (URLs never reach the wire).
+- New `tests/_helpers.py` (agentirc-native, not cited) extracts the
+  duplicated "boot two linked IRCds" pattern into `boot_linked_pair`
+  + `link_pair`. Refactored 9 sites that previously inlined ~22
+  lines of identical scaffolding: 5 in `test_federation.py`, 3 in
+  `test_link_reconnect.py`, plus the `linked_servers` conftest
+  fixture. Drops ~180 duplicated lines, addressing SonarCloud's
+  >3% duplication threshold while keeping the cited test bodies
+  readable. Re-snapshots from culture replay this extraction
+  mechanically.
+- 42 SonarCloud OPEN issues cleared via inline `# NOSONAR <rule>`
+  annotations: `python:S1172` (server_link `_replay_event`'s upstream
+  signature compat), `python:S2068` (3 test fixture passwords),
+  `python:S7483` (3 `IRCTestClient.recv*` / `_wait_for_span` timeout
+  params kept by upstream design — see `RECV_TIMEOUT_SECONDS`
+  module-level note), `python:S7494` (2 `dict(t.split("=") for t in
+  tags)` patterns vendored verbatim from culture), `python:S125`
+  (1 `# 311 RPL_WHOISUSER` documentation comment SonarCloud
+  misclassified as commented-out code), `python:S1481` × 21
+  (`server_a, server_b = linked_servers` tuple-unpack sites where
+  one or both vars are used by the federation fixture but unread in
+  the test body — same idiom across 3 files; underscore-prefix
+  rename would diverge from culture upstream and complicate
+  re-snapshots).
+
+### Deferred / out of scope
+
+- Three bot-fixtured telemetry tests
+  (`test_bot_event_dispatch_span.py`, `test_bot_run_span.py`,
+  `test_metrics_bots.py`) and `test_welcome_bot.py` stay in culture
+  — they depend on the real `BotManager` (forbidden by agentirc's
+  dependency boundary). Bucket C tests (cli/console/daemon/clients)
+  also remain in culture indefinitely.
+- `tests/telemetry/conftest.py` is not migrated; its only consumer
+  was the deferred bot-fixtured tests above.
+- Bootstrap docs (`docs/api-stability.md`, `docs/cli.md`,
+  `docs/deployment.md`) ship in PR-B4.
+
+## [9.2.0] - 2026-05-01
+
+### Added
+
+- `agentirc/protocol.py` — public, semver-tracked module consolidating
+  IRC verb names, numeric reply codes (re-exported from
+  `_internal.protocol.replies`), and IRCv3 / agentirc tag names. Wire-
+  format quirks (`ROOMETAEND`, `ROOMETASET` typos; `ERR_NOSUCHCHANNEL`
+  semantic misuse; `STHREAD` verb collapse) are preserved verbatim with
+  explanatory comments — they require coordinated cross-repo bumps to
+  fix.
+- `agentirc/client.py` — IRC client transport vendored from
+  `culture/agentirc/client.py` at SHA `df50942`. Body unchanged; only
+  imports rewritten. The bootstrap spec originally said this would
+  "stay in culture" but its dependency surface (already-vendored
+  `_internal` support modules + opentelemetry) made vendoring the
+  cleaner path. Without it, `agentirc/ircd.py:580`'s runtime
+  `from agentirc.client import Client` raised `ImportError` on the
+  first TCP IRC connection.
+- Real `agentirc/cli.py` — verb dispatch extracted from
+  `culture/cli/server.py`. New verbs: `serve` (foreground, no PID;
+  for systemd `Type=simple` and containers), `restart`, `link`
+  (peer-spec validator), `logs` (cat / tail of `~/.culture/logs/server-
+  <name>.log`). Existing verbs `start`/`stop`/`status` reuse culture's
+  proven daemonize / `_wait_for_port` / `_wait_for_graceful_stop` /
+  `_force_kill` helpers.
+- Internal support modules:
+  - `agentirc/_internal/pidfile.py` — PID/port file management.
+    `is_managed_process()` recognizes both `culture` and
+    `agentirc`/`agentirc-cli` argv tokens; `is_culture_process` is
+    preserved as a thin alias.
+  - `agentirc/_internal/cli_shared/{constants,mesh}.py` — minimal
+    subset of `culture/cli/shared`. Keeps `DEFAULT_CONFIG`, `LOG_DIR`,
+    `culture_runtime_dir()`, `parse_link()`. Drops everything that
+    touched `culture.bots.config`, `culture.credentials`,
+    `culture.mesh_config`.
+- Citations recorded in `[tool.citation]`: `culture-pidfile`,
+  `culture-cli-shared`, `culture-client`, `culture-cli-server`.
+
+### Changed
+
+- Default server name changed from `culture` to `agentirc` in
+  `agentirc.cli`. PID/port files at `~/.culture/pids/server-<name>.{pid,
+  port}` keep their existing layout per the "Defaults preserve culture
+  continuity" rule, but the default fallback name no longer collides
+  with culture's daemon when both run on the same host.
+- Dropped culture-only verbs (`default`, `rename`, `archive`,
+  `unarchive`) from agentirc's CLI surface — they manage culture's
+  agent manifest, which agentirc does not own.
+- Dropped `--mesh-config` from `agentirc start` — depends on
+  `culture.credentials` / `culture.mesh_config` (out of scope).
+
+### Notes
+
+- End-to-end smoke verified: `agentirc start --port 16667` boots,
+  TCP NICK/USER handshake returns `001 RPL_WELCOME` from a real
+  `IRCd`, `agentirc stop` shuts cleanly. `agentirc serve` is now
+  byte-indistinguishable from `culture server start` for the lifecycle
+  contract culture's shim relies on.
+- Test suite migration (PR-B3) is the only remaining bootstrap slice.
+
+## [9.1.0] - 2026-04-30
+
+### Added
+
+- Server-core vendored from `culture` at SHA `df50942`. The `agentirc`
+  package now contains the IRCd (`ircd.py`), server-to-server linking
+  (`server_link.py`), channel/event/store/skill modules, `remote_client.py`
+  (peer-server ghost client), and the four built-in skills
+  (`skills/{rooms,threads,history,icon}.py`).
+- Internal vendored support modules under `agentirc/_internal/`:
+  - `aio` (`maybe_await`)
+  - `constants` (system user/channel constants)
+  - `protocol/` (IRC `Message` and numeric `replies`)
+  - `telemetry/` (OpenTelemetry audit/tracing/metrics — full subpackage)
+  - `virtual_client` (`VirtualClient` for in-process bot integration)
+  - `bots/{bot_manager,http_listener}` (no-op stubs; culture replaces
+    these at runtime when wrapping an `IRCd`)
+- `[tool.citation]` block in `pyproject.toml` enumerating every vendored
+  file with a quote/paraphrase/synthesize status, source URL, and
+  sha256, validated by `cite check`.
+- Runtime dependencies: `opentelemetry-api`, `opentelemetry-sdk`,
+  `opentelemetry-exporter-otlp-proto-grpc` (all `>=1.22`).
+- Dev dependency: `citation-cli` (provides the `cite` console script).
+
+### Changed
+
+- Bootstrap spec deviation: `remote_client.py` was originally listed as
+  "do not copy" but turned out to be server-side (used by `server_link`
+  and `virtual_client` for peer-server users in channel member lists).
+  Vendored as public `agentirc/remote_client.py`. See commit `8b4a6d8`.
+
+### Notes
+
+- `agentirc/cli.py` still ships only `version`; the `serve|start|stop|
+  restart|status|link|logs` lifecycle verbs remain stubs. The real CLI
+  is the next slice (PR-B2).
+- Tests are not migrated yet (PR-B3).
+
+## [9.0.0] - 2026-04-30
+
+### Added
+
+- Initial bootstrap of `agentirc-cli` as an installable Python package.
+- Skeleton `agentirc/{__init__,__main__,cli}.py` with `version` verb
+  wired up and lifecycle verbs (`serve|start|stop|restart|status|link|
+  logs`) as stubs.
+- Console scripts: both `agentirc` and `agentirc-cli` map to
+  `agentirc.cli:main`.
+- Major version starts at `9.0.0` to leapfrog the
+  `agentirc-cli==8.7.X.devN` squat that culture previously published to
+  TestPyPI, so dev releases sort as the actual "Latest".

{agentirc_cli-9.1.0 → agentirc_cli-9.3.0}/CLAUDE.md

@@ -2,14 +2,21 @@
 
 This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
 
-## Current state: server-core landed (9.1.0), CLI stubbed (PR-B2 next)
+## Current state: bootstrap functionally complete (9.3.0); docs slice (PR-B4) remains
 
-This repo is the agentirc server-core extraction out of the sibling project [`culture`](https://github.com/OriNachum/culture). As of 9.1.0, the IRCd server core is in place — `agentirc/{ircd,server_link,channel,events,skill,remote_client,…}.py` and `agentirc/skills/{rooms,threads,history,icon}.py` are all present, copied from `culture@df50942` via the `cite-don't-copy` pattern (see `[tool.citation]` in `pyproject.toml`). Internal vendored support modules live under `agentirc/_internal/` (`aio`, `constants`, `protocol/`, `telemetry/`, `virtual_client`, `bots/` stubs).
+This repo is the agentirc server-core extraction out of the sibling project [`culture`](https://github.com/OriNachum/culture). As of 9.3.0:
+
+- **Server-core** (`agentirc/{ircd,server_link,channel,events,skill,remote_client,…}.py`, `agentirc/skills/{rooms,threads,history,icon}.py`) — vendored from `culture@df50942` via the `cite-don't-copy` pattern (see `[tool.citation]` in `pyproject.toml`).
+- **Client transport** (`agentirc/client.py`) — vendored from `culture/agentirc/client.py` in PR-B2. The bootstrap spec originally said this would "stay in culture", but the dependency-boundary analysis after PR-B1 showed `client.py` only imports already-vendored support modules plus opentelemetry. Without it, `agentirc/ircd.py:580`'s runtime `from agentirc.client import Client` raised `ImportError` on the first TCP IRC connection.
+- **Public CLI** (`agentirc/cli.py`) — real verb dispatch extracted from `culture/cli/server.py`. Verbs: `serve` (foreground, no PID; for systemd `Type=simple` and containers), `start`/`stop`/`status` (lifecycle), `restart`, `link` (peer-spec validator), `logs` (cat / tail of `~/.culture/logs/server-<name>.log`), `version`.
+- **Public protocol** (`agentirc/protocol.py`) — verb name constants, numerics, IRCv3 tag names. Wire-format quirks (`ROOMETAEND`, `ROOMETASET` typos, `ERR_NOSUCHCHANNEL` semantic misuse, `STHREAD` verb collapse) preserved verbatim — they need coordinated cross-repo bumps to fix.
+- **Test suite** (PR-B3, 9.3.0) — 36 tests vendored from `culture@df50942` (~6.5kloc), 315 tests run under `pytest -n auto` in ~29s on default workers. Three telemetry tests (`test_bot_event_dispatch_span`, `test_bot_run_span`, `test_metrics_bots`) and `test_welcome_bot` stay in culture because they depend on the real `BotManager`. `tests/conftest.py` was adapted to drop bot-loader sandboxing and the `server_with_bot` / `server_with_bots` fixtures.
+- **Internal support** (`agentirc/_internal/`) — `aio`, `constants`, `protocol/`, `telemetry/`, `virtual_client`, `pidfile` (PR-B2), `cli_shared/` (PR-B2), `bots/` stubs.
+
+End-to-end verified: `agentirc start --port <p>` boots a real IRCd, TCP NICK/USER handshake returns `001 RPL_WELCOME`, `agentirc stop` shuts cleanly. `agentirc serve` is byte-indistinguishable from `culture server start` for the lifecycle contract culture's shim relies on.
 
 What is **not** done yet:
-- **`agentirc/cli.py`** is still the Shape A stub. All lifecycle verbs (`serve`, `start`, `stop`, `restart`, `status`, `link`, `logs`) print "not yet implemented" and exit 1. The real CLI lands in PR-B2 (extracted from `../culture/culture/cli/server.py`).
-- **`agentirc/protocol.py`** does not exist yet (PR-B2 also).
-- **Test suite migration** is PR-B3.
+- **Bootstrap docs (PR-B4)** — `docs/api-stability.md`, `docs/cli.md`, `docs/deployment.md`. Pure prose; not gating on culture's cutover (the public API surface is already importable; PR-B4 just documents the contract).
 
 Read the bootstrap spec at `docs/superpowers/specs/2026-04-30-bootstrap-design.md` for the full plan; it is the operative source of truth and is intentionally self-contained. The culture-side counterpart spec is at `../culture/docs/superpowers/specs/2026-04-30-agentirc-extraction-design.md` — not normally needed, but explains *why* if a decision looks arbitrary.
 
@@ -31,11 +38,19 @@ There are three different names in play. Don't conflate them:
 
 ## What lives here vs. in culture
 
-- **Server-core (here):** `ircd.py`, `server_link.py`, `channel.py`, `config.py`, `events.py`, the stores (`room_store`, `thread_store`, `history_store`), `rooms_util.py`, `skill.py`, `remote_client.py`, and the `skills/` directory (`rooms`, `threads`, `history`, `icon`). Vendored support under `agentirc/_internal/` (`aio`, `constants`, `protocol/`, `telemetry/`, `virtual_client`, `bots/` stubs).
-- **Stays in culture:** `client.py` (full IRC client transport, used by bots) and any test that exercises the IRC *client transport* rather than the server. Note: the bootstrap spec originally also listed `remote_client.py` as "stays in culture", but it turned out to be a 43-line server-side ghost-client stub used by `server_link.py`; it's vendored here. See PR-B1 commit history.
-- **Newly created here:** `agentirc/cli.py` (today: skeleton stub from PR Shape A; PR-B2 extracts the real one from `../culture/culture/cli/server.py`), `agentirc/__main__.py`. **Coming in PR-B2:** `agentirc/protocol.py` (consolidates verb names, numerics, and extension tag names currently inlined as string literals in `ircd.py` / `client.py`).
+- **Server-core (here):** `ircd.py`, `server_link.py`, `channel.py`, `config.py`, `events.py`, the stores (`room_store`, `thread_store`, `history_store`), `rooms_util.py`, `skill.py`, `remote_client.py`, and the `skills/` directory (`rooms`, `threads`, `history`, `icon`).
+- **Client transport (here, since 9.2.0):** `client.py` — vendored in PR-B2. Pre-9.2 the bootstrap spec said "stays in culture"; that assumption broke down once we found `client.py` only imports already-vendored modules and that the IRCd needs it at runtime to accept TCP clients.
+- **Internal support (here):** `agentirc/_internal/{aio, constants, protocol/, telemetry/, virtual_client, pidfile, cli_shared/}` plus `bots/` no-op stubs (the real `culture.bots.*` depends on backend SDKs forbidden by agentirc's dependency boundary; culture replaces the stubs at runtime when wrapping an IRCd).
+- **Stays in culture:** `culture.bots.*` (the real bot manager), `culture.config` / `culture.bots.config` (agent-manifest concerns), `culture.cli.shared.{ipc,display,formatting,process}` (CLI ergonomics agentirc doesn't need), `culture.credentials` / `culture.mesh_config` (OS-keyring + mesh.yaml).
+
+When migrating tests, the rule is: pure server tests come here, transport tests **also** come here now that we own `client.py`, mixed tests stay in culture and get rewritten to drive `agentirc serve` as a subprocess fixture rather than importing `IRCd` directly. When unsure, **prefer copying the test here** — this repo owns the IRCd and the client transport.
 
-When migrating tests, the rule is: pure server tests come here, transport tests stay in culture, mixed tests stay in culture and get rewritten to drive `agentirc serve` as a subprocess fixture rather than importing `IRCd` directly. When unsure, **prefer copying the test here** — this repo owns the IRCd.
+### Test layout (since 9.3.0)
+
+- `tests/conftest.py` — paraphrase of culture's conftest. Drops the `_BOTS_DIR_*` `unittest.mock.patch` calls (no-op against agentirc's bot stubs) and the `server_with_bot` / `server_with_bots` fixtures. Keeps `IRCTestClient`, the IRCd lifecycle fixtures (`server`, `linked_servers`, `make_client*`, `server_welcome_disabled`), telemetry fixtures (`tracing_exporter`, `metrics_reader`, `audit_dir`), and the `TEST_LINK_PASSWORD` constant.
+- `tests/test_*.py` — 21 server-core tests + the agentirc-native `test_cli.py`. Cover IRC lifecycle, channels, rooms, threads, history, federation, events, mentions, the icon skill.
+- `tests/telemetry/test_*.py` — 15 telemetry integration tests covering audit JSONL emission, OTLP span injection on dispatch, S2S relay spans, metrics initialization, trace-context propagation. Uses two private helper modules `_fakes.py` (FakeWriter etc.) and `_metrics_helpers.py`. No `tests/telemetry/conftest.py` (the upstream one was bot-coupled).
+- Tests left in culture: `test_bot_event_dispatch_span.py`, `test_bot_run_span.py`, `test_metrics_bots.py`, `test_welcome_bot.py` (bot-manager-coupled), plus the entire bucket-C surface (cli, console, daemon, clients, credentials).
 
 ## Public API contract (semver-tracked)
 
@@ -49,6 +64,11 @@ Only three modules are public. Everything else is internal and may be refactored
 
 `agentirc.cli.dispatch(argv)` is the function `culture`'s `culture server` shim calls — it must accept the exact same flag set, exit codes, and stderr formatting that `culture server` produces today. Do not "improve" CLI ergonomics during the bootstrap; that breaks the transparency contract culture relies on. `dispatch()` returns `int` on successful command dispatch and lets argparse's `SystemExit` propagate on `--help`/`--version`/parse-errors per Python convention; in-process callers (i.e. culture's shim) must catch `SystemExit` themselves or use `subprocess`.
 
+Two intentional, additive deltas vs. culture's CLI:
+
+- `agentirc status` prints `Server 'X': running (PID N, port P)` when a port file is present — culture only prints `(PID N)`. Strictly a superset; culture's shim relies on exit codes, not output parsing.
+- `agentirc start` no longer accepts `--mesh-config` (depends on `culture.credentials` and `culture.mesh_config`, out of agentirc's scope). Use `--link name:host:port:password[:trust]` flags instead.
+
 ## Defaults preserve culture continuity
 
 - Default `--config` path: `~/.culture/server.yaml` (yes, `.culture/`, not `.agentirc/`).
@@ -70,20 +90,25 @@ Do not rename on-disk artifacts during the bootstrap. That is explicitly out of
 # Dev setup
 uv venv && uv pip install -e ".[dev]"
 
-# Tests (the spec mandates parallel; no tests yet — collected 0)
+# Tests (315 collected, ~29s on default workers)
 pytest -n auto
 
 # Run a single test
 pytest tests/path/to/test_file.py::test_name -v
 
-# CLI smoke (works today against the skeleton)
+# CLI smoke
 agentirc --help
 agentirc-cli --help          # alias of agentirc
-agentirc version             # prints "agentirc 9.0.0"
+agentirc version             # prints "agentirc 9.3.0"
 python -m agentirc version   # equivalent
 
-# Lifecycle verbs (stubs in 9.0.0; real impls land with the IRCd extraction)
-agentirc serve --config ~/.culture/server.yaml
+# Lifecycle (functional since 9.2.0)
+agentirc serve --config ~/.culture/server.yaml          # foreground, no PID
+agentirc start --name spark --host 127.0.0.1 --port 6667  # daemonize
+agentirc status --name spark
+agentirc stop --name spark
+agentirc logs --name spark -f                            # tail -f the daemon log
+agentirc link 'peer1:host:6667:secret:full'              # parse + validate spec
 ```
 
 CLI verbs: `serve`, `start`, `stop`, `restart`, `status`, `link`, `logs`, `version`. Of these, only `start`, `stop`, `status` have a `culture server …` analogue today; the rest are agentirc-only additions. Culture's pure-passthrough shim only ever emits its existing verbs, so the additions don't break it.
@@ -129,7 +154,8 @@ Per-machine paths for these skills go in `.claude/skills.local.yaml` (gitignored
 
 The full list lives in §"Acceptance criteria" of the bootstrap spec. The non-obvious ones:
 
-- `pip install agentirc-cli==9.0.0` on a clean venv produces working `agentirc` *and* `agentirc-cli` binaries (both pointing at `agentirc.cli:main`).
-- `agentirc serve` is byte-indistinguishable from `culture server start` (same socket, same logs, same systemd integration).
-- `agentirc.config.LinkConfig`, `agentirc.config.PeerSpec`, `agentirc.cli.dispatch`, `agentirc.protocol.*` all import from a clean Python session.
-- `docs/api-stability.md` names the three public modules.
+- `pip install agentirc-cli==9.3.0` on a clean venv produces working `agentirc` *and* `agentirc-cli` binaries (both pointing at `agentirc.cli:main`). ✅ since 9.0.0.
+- `agentirc serve` is byte-indistinguishable from `culture server start` (same socket, same logs, same systemd integration). ✅ since 9.2.0.
+- `agentirc.config.{ServerConfig, LinkConfig, TelemetryConfig}`, `agentirc.cli.{main, dispatch}`, `agentirc.protocol.*` all import from a clean Python session. ✅ since 9.2.0.
+- `pytest -n auto` passes for the migrated suite (315 tests, ~29s). ✅ since 9.3.0.
+- `docs/api-stability.md` names the three public modules. ⏳ pending PR-B4.

{agentirc_cli-9.1.0 → agentirc_cli-9.3.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agentirc-cli
-Version: 9.1.0
+Version: 9.3.0
 Summary: Agent-friendly IRCd: server core for AI agent meshes
 Project-URL: Homepage, https://github.com/OriNachum/agentirc
 Project-URL: Issues, https://github.com/OriNachum/agentirc/issues
@@ -32,11 +32,11 @@ Classifier: Development Status :: 3 - Alpha
 Classifier: Intended Audience :: Developers
 Classifier: License :: OSI Approved :: MIT License
 Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.10
 Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
+Classifier: Programming Language :: Python :: 3.13
 Classifier: Topic :: Communications :: Chat :: Internet Relay Chat
-Requires-Python: >=3.10
+Requires-Python: >=3.11
 Requires-Dist: opentelemetry-api>=1.22
 Requires-Dist: opentelemetry-exporter-otlp-proto-grpc>=1.22
 Requires-Dist: opentelemetry-sdk>=1.22

agentirc_cli-9.3.0/agentirc/_internal/cli_shared/constants.py

@@ -0,0 +1,56 @@
+"""Shared constants for the agentirc CLI.
+
+Vendored from culture@df50942 (`culture/cli/shared/constants.py`) and
+trimmed to the subset agentirc actually consumes. Bot-related constants
+(``BOT_CONFIG_FILE``, ``LEGACY_CONFIG``, ``AGENTS_YAML``, etc.) are
+dropped; agentirc has no bot configuration concept.
+
+Default paths (``~/.culture/server.yaml``, ``~/.culture/logs``) are kept
+intact per the "Defaults preserve culture continuity" rule in
+CLAUDE.md, so agentirc and culture daemons share state directories on a
+host without separate config trees.
+"""
+
+from __future__ import annotations
+
+import os
+import stat
+
+DEFAULT_CONFIG = os.path.expanduser("~/.culture/server.yaml")
+LOG_DIR = os.path.expanduser("~/.culture/logs")
+
+_CONFIG_HELP = "Config file path"
+_SERVER_NAME_HELP = "Server name"
+
+
+def culture_runtime_dir() -> str:
+    """Return a user-private directory for daemon sockets.
+
+    Resolution order:
+
+    1. ``$XDG_RUNTIME_DIR`` when set (Linux/systemd default — already
+       user-private at ``/run/user/<uid>``).
+    2. ``~/.culture/run/`` otherwise (typical macOS path), created mode
+       0700 if missing and re-tightened to 0700 on every call so a
+       hand-created or pre-existing dir cannot leak sockets.
+
+    Raises ``RuntimeError`` when neither ``XDG_RUNTIME_DIR`` nor a
+    resolvable home directory is available — silently writing a literal
+    ``~/.culture/run`` directory in CWD would surprise callers and the
+    daemons (which now route through this resolver) would fail at
+    socket-bind time anyway.
+    """
+    xdg = os.environ.get("XDG_RUNTIME_DIR")
+    if xdg:
+        return xdg
+    home = os.path.expanduser("~")
+    if not home or home == "~" or not os.path.isabs(home):
+        raise RuntimeError(
+            "culture_runtime_dir(): cannot resolve a home directory "
+            "(os.path.expanduser('~') returned %r). Set $HOME or "
+            "$XDG_RUNTIME_DIR before running agentirc commands." % home
+        )
+    fallback = os.path.join(home, ".culture", "run")
+    os.makedirs(fallback, mode=0o700, exist_ok=True)
+    os.chmod(fallback, stat.S_IRWXU)
+    return fallback

agentirc_cli-9.3.0/agentirc/_internal/cli_shared/mesh.py

@@ -0,0 +1,39 @@
+"""Mesh and link helpers for the agentirc CLI.
+
+Vendored from culture@df50942 (`culture/cli/shared/mesh.py`), reduced
+to the single helper agentirc needs: ``parse_link``. The upstream
+helpers ``resolve_links_from_mesh`` and ``generate_mesh_from_agents``
+depend on culture's ``mesh_config`` / ``credentials`` modules, which
+manage agent mesh and OS-keyring credential lookup — concepts that do
+not belong in agentirc's dependency-bounded surface.
+"""
+
+from __future__ import annotations
+
+import argparse
+
+
+def parse_link(value: str):
+    """Parse a link spec: ``name:host:port:password[:trust]``.
+
+    Trust is extracted from the end if it matches a known value. This
+    allows passwords containing colons to round-trip through argparse
+    without escaping.
+    """
+    from agentirc.config import LinkConfig
+
+    trust = "full"
+    if value.endswith(":full") or value.endswith(":restricted"):
+        value, trust = value.rsplit(":", 1)
+
+    parts = value.split(":", 3)
+    if len(parts) != 4:
+        raise argparse.ArgumentTypeError(
+            f"Link must be name:host:port:password[:trust], got: {value}"
+        )
+    name, host, port_str, password = parts
+    try:
+        port = int(port_str)
+    except ValueError as exc:
+        raise argparse.ArgumentTypeError(f"Invalid port: {port_str}") from exc
+    return LinkConfig(name=name, host=host, port=port, password=password, trust=trust)