agentirc-cli 4.1.1__tar.gz → 4.1.2__tar.gz

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/).
 
+## [4.1.2] - 2026-04-06
+
+
+### Fixed
+
+- Clean up _mention_targets deque on prompt failure to prevent misrouted responses
+
 ## [4.1.1] - 2026-04-06
 
 

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agentirc-cli
-Version: 4.1.1
+Version: 4.1.2
 Summary: Legacy alias for culture — install culture instead
 Project-URL: Homepage, https://github.com/OriNachum/culture
 Author: Ori Nachum

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/acp/agent_runner.py

@@ -33,6 +33,7 @@ class ACPAgentRunner:
         system_prompt: str = "",
         on_exit: Callable[[int], Awaitable[None]] | None = None,
         on_message: Callable[[dict[str, Any]], Awaitable[None]] | None = None,
+        on_turn_error: Callable[[], Awaitable[None]] | None = None,
     ) -> None:
         self.model = model
         self.directory = directory
@@ -40,6 +41,7 @@ class ACPAgentRunner:
         self.system_prompt = system_prompt
         self.on_exit = on_exit
         self.on_message = on_message
+        self.on_turn_error = on_turn_error
 
         self._isolated_home: str | None = None
         self._process: asyncio.subprocess.Process | None = None
@@ -384,6 +386,8 @@ class ACPAgentRunner:
 
                 except Exception:
                     logger.exception("ACP turn error")
+                    if self.on_turn_error:
+                        await self.on_turn_error()
                 finally:
                     self._busy = False
 

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/acp/daemon.py

@@ -318,6 +318,11 @@ class ACPDaemon:
     # Agent runner helpers
     # ------------------------------------------------------------------
 
+    async def _on_turn_error(self) -> None:
+        """Clean up stale relay target when a prompt fails."""
+        if self._mention_targets:
+            self._mention_targets.popleft()
+
     async def _start_agent_runner(self) -> None:
         self._agent_runner = ACPAgentRunner(
             model=self.agent.model,
@@ -326,6 +331,7 @@ class ACPDaemon:
             system_prompt=self._build_system_prompt(),
             on_exit=self._on_agent_exit,
             on_message=self._on_agent_message,
+            on_turn_error=self._on_turn_error,
         )
         # Absorb the system prompt response without relaying to IRC
         self._mention_targets.append(None)

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/codex/agent_runner.py

@@ -23,12 +23,14 @@ class CodexAgentRunner:
         system_prompt: str = "",
         on_exit: Callable[[int], Awaitable[None]] | None = None,
         on_message: Callable[[dict[str, Any]], Awaitable[None]] | None = None,
+        on_turn_error: Callable[[], Awaitable[None]] | None = None,
     ) -> None:
         self.model = model
         self.directory = directory
         self.system_prompt = system_prompt
         self.on_exit = on_exit
         self.on_message = on_message
+        self.on_turn_error = on_turn_error
 
         self._isolated_home: str | None = None
         self._process: asyncio.subprocess.Process | None = None
@@ -318,6 +320,8 @@ class CodexAgentRunner:
 
                 except Exception:
                     logger.exception("Codex turn error")
+                    if self.on_turn_error:
+                        await self.on_turn_error()
 
         except asyncio.CancelledError:
             raise

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/codex/daemon.py

@@ -293,6 +293,11 @@ class CodexDaemon:
     # Agent runner helpers
     # ------------------------------------------------------------------
 
+    async def _on_turn_error(self) -> None:
+        """Clean up stale relay target when a prompt fails."""
+        if self._mention_targets:
+            self._mention_targets.popleft()
+
     async def _start_agent_runner(self) -> None:
         self._agent_runner = CodexAgentRunner(
             model=self.agent.model,
@@ -300,6 +305,7 @@ class CodexDaemon:
             system_prompt=self._build_system_prompt(),
             on_exit=self._on_agent_exit,
             on_message=self._on_agent_message,
+            on_turn_error=self._on_turn_error,
         )
         await self._agent_runner.start()
         logger.info("CodexAgentRunner started for %s", self.agent.nick)

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/copilot/agent_runner.py

@@ -23,6 +23,7 @@ class CopilotAgentRunner:
         skill_directories: list[str] | None = None,
         on_exit: Callable[[int], Awaitable[None]] | None = None,
         on_message: Callable[[dict[str, Any]], Awaitable[None]] | None = None,
+        on_turn_error: Callable[[], Awaitable[None]] | None = None,
     ) -> None:
         self.model = model
         self.directory = directory
@@ -30,6 +31,7 @@ class CopilotAgentRunner:
         self.skill_directories = skill_directories or []
         self.on_exit = on_exit
         self.on_message = on_message
+        self.on_turn_error = on_turn_error
 
         self._isolated_home: str | None = None
         self._client: Any = None
@@ -158,6 +160,8 @@ class CopilotAgentRunner:
 
                 except Exception:
                     logger.exception("Copilot session turn error")
+                    if self.on_turn_error:
+                        await self.on_turn_error()
                     if not self._stopping:
                         self._running = False
                         if self.on_exit:

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/culture/clients/copilot/daemon.py

@@ -293,6 +293,11 @@ class CopilotDaemon:
     # Agent runner helpers
     # ------------------------------------------------------------------
 
+    async def _on_turn_error(self) -> None:
+        """Clean up stale relay target when a prompt fails."""
+        if self._mention_targets:
+            self._mention_targets.popleft()
+
     async def _start_agent_runner(self) -> None:
         # Resolve installed skill path for the Copilot session
         skill_dirs: list[str] = []
@@ -307,6 +312,7 @@ class CopilotDaemon:
             skill_directories=skill_dirs,
             on_exit=self._on_agent_exit,
             on_message=self._on_agent_message,
+            on_turn_error=self._on_turn_error,
         )
         await self._agent_runner.start()
         logger.info("CopilotAgentRunner started for %s", self.agent.nick)

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/packages/agent-harness/daemon.py

@@ -258,6 +258,15 @@ class AgentDaemon:
             except Exception:
                 logger.exception("Poll loop error")
 
+    async def _on_turn_error(self) -> None:
+        """Clean up stale relay target when a prompt fails.
+
+        Wire this as the ``on_turn_error`` callback on your agent runner so
+        the ``_mention_targets`` deque stays in sync with the prompt queue.
+        """
+        if self._mention_targets:
+            self._mention_targets.popleft()
+
     def _on_mention(self, target: str, sender: str, text: str) -> None:
         """Called when the agent is @mentioned. Sends prompt to runner.
 

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "agentirc-cli"
-version = "4.1.1"
+version = "4.1.2"
 description = "Legacy alias for culture — install culture instead"
 readme = "README.md"
 license = "MIT"

agentirc_cli-4.1.2/tests/test_mention_target_cleanup.py

@@ -0,0 +1,135 @@
+"""Tests for _mention_targets deque cleanup on prompt failure.
+
+When a prompt fails (timeout, error), the corresponding _mention_targets
+entry must be cleaned up so that future responses route correctly.
+"""
+
+import asyncio
+import tempfile
+from unittest.mock import AsyncMock, MagicMock
+
+import pytest
+
+from culture.clients.acp.config import (
+    AgentConfig,
+    DaemonConfig,
+    ServerConnConfig,
+)
+from culture.clients.acp.daemon import ACPDaemon
+
+
+def _make_daemon(server_port: int) -> ACPDaemon:
+    config = DaemonConfig(
+        server=ServerConnConfig(host="127.0.0.1", port=server_port),
+        poll_interval=0,
+    )
+    agent = AgentConfig(
+        nick="testserv-bot",
+        directory="/tmp",
+        channels=["#general"],
+        acp_command=["echo"],
+    )
+    sock_dir = tempfile.mkdtemp()
+    return ACPDaemon(config, agent, socket_dir=sock_dir, skip_agent=True)
+
+
+def _inject_fake_runner(daemon):
+    """Inject a fake agent runner that records prompts."""
+    runner = MagicMock()
+    runner.is_running.return_value = True
+    runner.send_prompt = AsyncMock()
+    runner.stop = AsyncMock()
+    daemon._agent_runner = runner
+    return runner
+
+
+@pytest.mark.asyncio
+async def test_on_turn_error_pops_stale_target(server):
+    """_on_turn_error should pop the front entry from _mention_targets."""
+    daemon = _make_daemon(server.config.port)
+    await daemon.start()
+
+    # Simulate: poll enqueued a target, then the prompt failed
+    daemon._mention_targets.append("#general")
+    daemon._mention_targets.append("#code-review")
+    assert len(daemon._mention_targets) == 2
+
+    await daemon._on_turn_error()
+    assert len(daemon._mention_targets) == 1
+    assert daemon._mention_targets[0] == "#code-review"
+
+    await daemon.stop()
+
+
+@pytest.mark.asyncio
+async def test_on_turn_error_empty_deque_is_safe(server):
+    """_on_turn_error should be a no-op on an empty deque."""
+    daemon = _make_daemon(server.config.port)
+    await daemon.start()
+
+    assert len(daemon._mention_targets) == 0
+    await daemon._on_turn_error()  # should not raise
+    assert len(daemon._mention_targets) == 0
+
+    await daemon.stop()
+
+
+@pytest.mark.asyncio
+async def test_relay_routes_correctly_after_error_cleanup(server, make_client):
+    """After a failed prompt is cleaned up, the next response should route correctly."""
+    daemon = _make_daemon(server.config.port)
+    await daemon.start()
+    _inject_fake_runner(daemon)
+    await asyncio.sleep(0.5)
+
+    # Simulate: system prompt enqueued None, then timed out and was cleaned up
+    daemon._mention_targets.append(None)
+    await daemon._on_turn_error()  # cleans up None
+
+    # Now simulate a real mention that succeeds
+    daemon._mention_targets.append("#general")
+
+    # Simulate agent response
+    sent_messages = []
+    original_send = daemon._transport.send_privmsg
+
+    async def capture_send(target, text):
+        sent_messages.append((target, text))
+        await original_send(target, text)
+
+    daemon._transport.send_privmsg = capture_send
+
+    msg = {
+        "type": "assistant",
+        "content": [{"type": "text", "text": "Hello from bot!"}],
+    }
+    await daemon._relay_response_to_irc(msg)
+
+    assert len(sent_messages) == 1
+    assert sent_messages[0][0] == "#general"
+    assert "Hello from bot!" in sent_messages[0][1]
+    assert len(daemon._mention_targets) == 0
+
+    await daemon.stop()
+
+
+@pytest.mark.asyncio
+async def test_multiple_errors_drain_deque_correctly(server):
+    """Multiple consecutive errors should each pop one entry."""
+    daemon = _make_daemon(server.config.port)
+    await daemon.start()
+
+    # Simulate 3 failed prompts
+    daemon._mention_targets.append(None)  # system prompt
+    daemon._mention_targets.append("#general")  # poll 1
+    daemon._mention_targets.append("#general")  # poll 2
+
+    await daemon._on_turn_error()  # pops None
+    await daemon._on_turn_error()  # pops #general
+    assert len(daemon._mention_targets) == 1
+    assert daemon._mention_targets[0] == "#general"
+
+    await daemon._on_turn_error()  # pops last #general
+    assert len(daemon._mention_targets) == 0
+
+    await daemon.stop()

{agentirc_cli-4.1.1 → agentirc_cli-4.1.2}/uv.lock

@@ -561,7 +561,7 @@ wheels = [
 
 [[package]]
 name = "culture"
-version = "4.1.1"
+version = "4.1.2"
 source = { editable = "." }
 dependencies = [
     { name = "aiohttp" },