agentirc-cli 3.0.0__tar.gz → 3.0.1__tar.gz

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/).
 
+## [3.0.1] - 2026-04-06
+
+
+### Fixed
+
+- Fix empty error message when running `culture overview` against a starting or unreachable server
+
 ## [3.0.0] - 2026-04-06
 
 

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agentirc-cli
-Version: 3.0.0
+Version: 3.0.1
 Summary: Legacy alias for culture — install culture instead
 Project-URL: Homepage, https://github.com/OriNachum/culture
 Author: Ori Nachum

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/culture/cli.py

@@ -1593,14 +1593,31 @@ def _cmd_overview(args: argparse.Namespace) -> None:
         )
         return
 
-    mesh = asyncio.run(
-        collect_mesh_state(
-            host=config.server.host,
-            port=config.server.port,
-            server_name=config.server.name,
-            message_limit=message_limit,
+    host, port = config.server.host, config.server.port
+    try:
+        mesh = asyncio.run(
+            collect_mesh_state(
+                host=host,
+                port=port,
+                server_name=config.server.name,
+                message_limit=message_limit,
+            )
         )
-    )
+    except ConnectionRefusedError:
+        print(
+            f"Error: could not connect to {host}:{port} — is the server running?",
+            file=sys.stderr,
+        )
+        sys.exit(1)
+    except TimeoutError:
+        print(
+            f"Error: server at {host}:{port} not responding" " — it may still be starting up",
+            file=sys.stderr,
+        )
+        sys.exit(1)
+    except OSError as exc:
+        print(f"Error: {exc}", file=sys.stderr)
+        sys.exit(1)
     output = render_text(
         mesh,
         room_filter=args.room,

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/culture/overview/collector.py

@@ -116,28 +116,35 @@ async def _connect(
         timeout=REGISTER_TIMEOUT,
     )
     nick = _temp_nick(server_name)
-    writer.write(f"NICK {nick}\r\nUSER overview 0 * :overview\r\n".encode())
-    await writer.drain()
+    try:
+        writer.write(f"NICK {nick}\r\nUSER overview 0 * :overview\r\n".encode())
+        await writer.drain()
 
-    deadline = asyncio.get_event_loop().time() + REGISTER_TIMEOUT
-    while True:
-        remaining = deadline - asyncio.get_event_loop().time()
-        if remaining <= 0:
-            raise TimeoutError("Registration timed out")
-        data = await asyncio.wait_for(reader.readline(), timeout=remaining)
-        line = data.decode().strip()
-        if not line:
-            continue
-        msg = IRCMessage.parse(line)
-        if msg.command == "PING":
-            writer.write(f"PONG :{msg.params[0]}\r\n".encode())
-            await writer.drain()
-        elif msg.command == "001":
-            return reader, writer, nick
-        elif msg.command == "433":
-            nick = _temp_nick(server_name)
-            writer.write(f"NICK {nick}\r\n".encode())
-            await writer.drain()
+        deadline = asyncio.get_event_loop().time() + REGISTER_TIMEOUT
+        while True:
+            remaining = deadline - asyncio.get_event_loop().time()
+            if remaining <= 0:
+                raise TimeoutError("Registration timed out")
+            try:
+                data = await asyncio.wait_for(reader.readline(), timeout=remaining)
+            except asyncio.TimeoutError:
+                raise TimeoutError("Registration timed out") from None
+            line = data.decode().strip()
+            if not line:
+                continue
+            msg = IRCMessage.parse(line)
+            if msg.command == "PING":
+                writer.write(f"PONG :{msg.params[0]}\r\n".encode())
+                await writer.drain()
+            elif msg.command == "001":
+                return reader, writer, nick
+            elif msg.command == "433":
+                nick = _temp_nick(server_name)
+                writer.write(f"NICK {nick}\r\n".encode())
+                await writer.drain()
+    except BaseException:
+        await _disconnect(writer)
+        raise
 
 
 async def _disconnect(writer: asyncio.StreamWriter) -> None:

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "agentirc-cli"
-version = "3.0.0"
+version = "3.0.1"
 description = "Legacy alias for culture — install culture instead"
 readme = "README.md"
 license = "MIT"

agentirc_cli-3.0.1/tests/test_overview_cli.py

@@ -0,0 +1,133 @@
+"""Tests for overview CLI subcommand argument parsing and error handling."""
+
+import subprocess
+import sys
+from unittest.mock import patch
+
+import pytest
+
+
+def test_overview_help():
+    """The overview subcommand is registered and has help."""
+    result = subprocess.run(
+        [sys.executable, "-m", "culture", "overview", "--help"],
+        capture_output=True,
+        text=True,
+    )
+    assert result.returncode == 0
+    assert "--room" in result.stdout
+    assert "--agent" in result.stdout
+    assert "--messages" in result.stdout
+    assert "--serve" in result.stdout
+    assert "--refresh" in result.stdout
+
+
+def test_overview_default_args():
+    """Default args parse correctly."""
+    from culture.cli import _build_parser
+
+    parser = _build_parser()
+    args = parser.parse_args(["overview"])
+    assert args.command == "overview"
+    assert args.room is None
+    assert args.agent is None
+    assert args.messages == 4
+    assert args.serve is False
+    assert args.refresh == 5
+
+
+def test_overview_with_flags():
+    from culture.cli import _build_parser
+
+    parser = _build_parser()
+    args = parser.parse_args(["overview", "--room", "#general", "--messages", "10"])
+    assert args.room == "#general"
+    assert args.messages == 10
+
+
+def test_overview_connection_refused(capsys):
+    """ConnectionRefusedError produces a helpful message."""
+    from culture.cli import _build_parser, _cmd_overview
+
+    parser = _build_parser()
+    args = parser.parse_args(["overview"])
+
+    with patch(
+        "culture.overview.collector.collect_mesh_state",
+        side_effect=ConnectionRefusedError(111, "Connection refused"),
+    ):
+        with pytest.raises(SystemExit, match="1"):
+            _cmd_overview(args)
+
+    captured = capsys.readouterr()
+    assert "is the server running?" in captured.err
+
+
+def test_overview_timeout(capsys):
+    """TimeoutError produces a helpful message."""
+    from culture.cli import _build_parser, _cmd_overview
+
+    parser = _build_parser()
+    args = parser.parse_args(["overview"])
+
+    with patch(
+        "culture.overview.collector.collect_mesh_state",
+        side_effect=TimeoutError("Registration timed out"),
+    ):
+        with pytest.raises(SystemExit, match="1"):
+            _cmd_overview(args)
+
+    captured = capsys.readouterr()
+    assert "not responding" in captured.err
+    assert "still be starting up" in captured.err
+
+
+def test_overview_os_error(capsys):
+    """OSError shows the original error details."""
+    from culture.cli import _build_parser, _cmd_overview
+
+    parser = _build_parser()
+    args = parser.parse_args(["overview"])
+
+    with patch(
+        "culture.overview.collector.collect_mesh_state",
+        side_effect=OSError("Name or service not known"),
+    ):
+        with pytest.raises(SystemExit, match="1"):
+            _cmd_overview(args)
+
+    captured = capsys.readouterr()
+    assert "Name or service not known" in captured.err
+
+
+@pytest.mark.asyncio
+async def test_connect_timeout_has_message():
+    """_connect raises TimeoutError with a non-empty message on registration timeout."""
+    import asyncio
+
+    from culture.overview.collector import _connect
+
+    # TCP server that accepts but never sends IRC 001 (silent handshake)
+    stop = asyncio.Event()
+
+    async def hold_open(reader, writer):
+        await stop.wait()
+        writer.close()
+
+    server = await asyncio.start_server(hold_open, "127.0.0.1", 0)
+    port = server.sockets[0].getsockname()[1]
+
+    try:
+        with pytest.raises(TimeoutError, match="Registration timed out"):
+            import culture.overview.collector as col
+
+            original = col.REGISTER_TIMEOUT
+            col.REGISTER_TIMEOUT = 0.5
+            try:
+                await _connect("127.0.0.1", port, "test")
+            finally:
+                col.REGISTER_TIMEOUT = original
+    finally:
+        stop.set()
+        server.close()
+        await server.wait_closed()

{agentirc_cli-3.0.0 → agentirc_cli-3.0.1}/uv.lock

@@ -561,7 +561,7 @@ wheels = [
 
 [[package]]
 name = "culture"
-version = "3.0.0"
+version = "3.0.1"
 source = { editable = "." }
 dependencies = [
     { name = "aiohttp" },

agentirc_cli-3.0.0/tests/test_overview_cli.py

@@ -1,42 +0,0 @@
-"""Tests for overview CLI subcommand argument parsing."""
-
-import subprocess
-import sys
-
-
-def test_overview_help():
-    """The overview subcommand is registered and has help."""
-    result = subprocess.run(
-        [sys.executable, "-m", "culture", "overview", "--help"],
-        capture_output=True,
-        text=True,
-    )
-    assert result.returncode == 0
-    assert "--room" in result.stdout
-    assert "--agent" in result.stdout
-    assert "--messages" in result.stdout
-    assert "--serve" in result.stdout
-    assert "--refresh" in result.stdout
-
-
-def test_overview_default_args():
-    """Default args parse correctly."""
-    from culture.cli import _build_parser
-
-    parser = _build_parser()
-    args = parser.parse_args(["overview"])
-    assert args.command == "overview"
-    assert args.room is None
-    assert args.agent is None
-    assert args.messages == 4
-    assert args.serve is False
-    assert args.refresh == 5
-
-
-def test_overview_with_flags():
-    from culture.cli import _build_parser
-
-    parser = _build_parser()
-    args = parser.parse_args(["overview", "--room", "#general", "--messages", "10"])
-    assert args.room == "#general"
-    assert args.messages == 10