agentic-devtools 0.2.22__tar.gz → 0.2.23__tar.gz

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agentic-devtools
-Version: 0.2.22
+Version: 0.2.23
 Summary: AI assistant helper commands for the Dragonfly platform
 Author: Dragonfly Team
 License-Expression: MIT

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/agentic_devtools/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '0.2.22'
-__version_tuple__ = version_tuple = (0, 2, 22)
+__version__ = version = '0.2.23'
+__version_tuple__ = version_tuple = (0, 2, 23)
 
 __commit_id__ = commit_id = None

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/agentic_devtools/cli/azure_devops/__init__.py

@@ -129,6 +129,7 @@ from .pull_request_details_commands import get_pull_request_details
 
 # Review state exports
 from .review_state import (
+    COMPLETE_STATUSES,
     FileEntry,
     FolderEntry,
     OverallSummary,
@@ -137,6 +138,7 @@ from .review_state import (
     SuggestionEntry,
     add_suggestion_to_file,
     clear_suggestions_for_re_review,
+    compute_aggregate_status,
     get_file_entry,
     get_folder_entry,
     get_review_state_file_path,
@@ -272,6 +274,8 @@ __all__ = [
     "update_file_status",
     "add_suggestion_to_file",
     "clear_suggestions_for_re_review",
+    "compute_aggregate_status",
+    "COMPLETE_STATUSES",
     # Status cascade
     "PatchOperation",
     "derive_folder_status",

agentic_devtools-0.2.23/agentic_devtools/cli/azure_devops/pr_summary_commands.py

@@ -0,0 +1,43 @@
+"""
+Pull Request Summary Commands (deprecated).
+
+This module is retained only for backward compatibility. The legacy flow
+that generated overarching PR review comments has been removed. PR summaries
+are now produced automatically during ``agdt-review-pull-request`` scaffolding
+via ``review_templates.py`` and ``status_cascade.py``.
+"""
+
+import sys
+
+
+def generate_overarching_pr_comments() -> bool:  # pragma: no cover
+    """
+    Generate overarching review comments for each folder and overall PR summary.
+
+    .. deprecated::
+        This function is deprecated. PR summaries are now generated automatically
+        during agdt-review-pull-request scaffolding. The entry point
+        (agdt-generate-pr-summary) has been removed.
+
+    Returns:
+        False (always) — this function is deprecated and no longer functional.
+    """
+    print(
+        "ERROR: generate_overarching_pr_comments() is deprecated. "
+        "PR summaries are now generated automatically during "
+        "agdt-review-pull-request scaffolding.",
+        file=sys.stderr,
+    )
+    return False
+
+
+def generate_overarching_pr_comments_cli() -> None:
+    """
+    CLI entry point for generate_overarching_pr_comments.
+
+    .. deprecated::
+        This command is deprecated. PR summaries are now generated automatically
+        during agdt-review-pull-request scaffolding. The entry point
+        (agdt-generate-pr-summary) has been removed.
+    """
+    generate_overarching_pr_comments()

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/agentic_devtools/cli/azure_devops/review_state.py

@@ -25,6 +25,41 @@ class ReviewStatus(str, Enum):
     NEEDS_WORK = "needs-work"
 
 
+# Statuses that indicate a file/folder review is complete
+COMPLETE_STATUSES = frozenset({ReviewStatus.APPROVED.value, ReviewStatus.NEEDS_WORK.value})
+
+
+def compute_aggregate_status(statuses: List[str]) -> str:
+    """Compute an aggregate status from a list of child statuses.
+
+    This is the single source of truth for status derivation rules:
+    - No statuses or all unreviewed → unreviewed
+    - At least 1 started, not all complete → in-progress
+    - All complete, all Approved → approved
+    - All complete, any Needs Work → needs-work
+
+    Args:
+        statuses: List of status strings (ReviewStatus values).
+
+    Returns:
+        Derived aggregate status string.
+    """
+    if not statuses:
+        return ReviewStatus.UNREVIEWED.value
+
+    any_started = any(s != ReviewStatus.UNREVIEWED.value for s in statuses)
+    all_complete = all(s in COMPLETE_STATUSES for s in statuses)
+
+    if not any_started:
+        return ReviewStatus.UNREVIEWED.value
+    elif not all_complete:
+        return ReviewStatus.IN_PROGRESS.value
+    elif any(s == ReviewStatus.NEEDS_WORK.value for s in statuses):
+        return ReviewStatus.NEEDS_WORK.value
+    else:
+        return ReviewStatus.APPROVED.value
+
+
 @dataclass
 class SuggestionEntry:
     """A suggestion posted on a specific line/range of a file."""

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/agentic_devtools/cli/azure_devops/review_templates.py

@@ -6,7 +6,14 @@ file summaries, folder summaries, and the overall PR summary at each status.
 
 from typing import Dict, List
 
-from .review_state import FileEntry, FolderEntry, ReviewState, ReviewStatus, SuggestionEntry
+from .review_state import (
+    FileEntry,
+    FolderEntry,
+    ReviewState,
+    ReviewStatus,
+    SuggestionEntry,
+    compute_aggregate_status,
+)
 
 _STATUS_DISPLAY: Dict[str, str] = {
     ReviewStatus.UNREVIEWED.value: "Unreviewed",
@@ -140,11 +147,13 @@ def render_folder_summary(
     approved: List[FileEntry] = []
     in_progress: List[FileEntry] = []
     unreviewed: List[FileEntry] = []
+    file_statuses: List[str] = []
 
     for file_path in folder_entry.files:
         fe = files.get(file_path)
         if fe is None:
             continue
+        file_statuses.append(fe.status)
         if fe.status == ReviewStatus.NEEDS_WORK.value:
             needs_work.append(fe)
         elif fe.status == ReviewStatus.APPROVED.value:
@@ -153,15 +162,10 @@ def render_folder_summary(
             in_progress.append(fe)
         else:
             unreviewed.append(fe)
-
-    if needs_work:
-        folder_status = "Needs Work"
-    elif in_progress:
-        folder_status = "In Progress"
-    elif approved:
-        folder_status = "Approved"
-    else:
-        folder_status = "Unreviewed"
+    folder_status = _STATUS_DISPLAY.get(
+        compute_aggregate_status(file_statuses),
+        "Unreviewed",
+    )
 
     lines: List[str] = [
         f"## Folder Review Summary: {folder_name}",
@@ -218,14 +222,11 @@ def render_overall_summary(state: ReviewState, base_url: str) -> str:
         else:
             unreviewed.append(folder_name)
 
-    if needs_work:
-        overall_status = "Needs Work"
-    elif in_progress:
-        overall_status = "In Progress"
-    elif approved:
-        overall_status = "Approved"
-    else:
-        overall_status = "Unreviewed"
+    folder_statuses = [fe.status for fe in state.folders.values()]
+    overall_status = _STATUS_DISPLAY.get(
+        compute_aggregate_status(folder_statuses),
+        "Unreviewed",
+    )
 
     lines: List[str] = [
         "## Overall PR Review Summary",

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/agentic_devtools/cli/azure_devops/status_cascade.py

@@ -11,7 +11,7 @@ from typing import Dict, List
 
 from .config import AzureDevOpsConfig
 from .helpers import patch_comment, patch_thread_status
-from .review_state import ReviewState, ReviewStatus, normalize_file_path
+from .review_state import ReviewState, ReviewStatus, compute_aggregate_status, normalize_file_path
 from .review_templates import render_folder_summary, render_overall_summary
 
 # Thread status mapping: review status → Azure DevOps thread status
@@ -22,9 +22,6 @@ _THREAD_STATUS_MAP: Dict[str, str] = {
     ReviewStatus.NEEDS_WORK.value: "active",
 }
 
-# Statuses that indicate a file/folder review is complete
-_COMPLETE_STATUSES = frozenset({ReviewStatus.APPROVED.value, ReviewStatus.NEEDS_WORK.value})
-
 
 @dataclass
 class PatchOperation:
@@ -61,20 +58,7 @@ def derive_folder_status(state: ReviewState, folder_name: str) -> str:
     folder = state.folders[folder_name]
     file_statuses = [state.files[fp].status for fp in folder.files if fp in state.files]
 
-    if not file_statuses:
-        return ReviewStatus.UNREVIEWED.value
-
-    any_started = any(s != ReviewStatus.UNREVIEWED.value for s in file_statuses)
-    all_complete = all(s in _COMPLETE_STATUSES for s in file_statuses)
-
-    if not any_started:
-        return ReviewStatus.UNREVIEWED.value
-    elif not all_complete:
-        return ReviewStatus.IN_PROGRESS.value
-    elif any(s == ReviewStatus.NEEDS_WORK.value for s in file_statuses):
-        return ReviewStatus.NEEDS_WORK.value
-    else:
-        return ReviewStatus.APPROVED.value
+    return compute_aggregate_status(file_statuses)
 
 
 def derive_overall_status(state: ReviewState) -> str:
@@ -94,20 +78,7 @@ def derive_overall_status(state: ReviewState) -> str:
     """
     folder_statuses = [f.status for f in state.folders.values()]
 
-    if not folder_statuses:
-        return ReviewStatus.UNREVIEWED.value
-
-    any_started = any(s != ReviewStatus.UNREVIEWED.value for s in folder_statuses)
-    all_complete = all(s in _COMPLETE_STATUSES for s in folder_statuses)
-
-    if not any_started:
-        return ReviewStatus.UNREVIEWED.value
-    elif not all_complete:
-        return ReviewStatus.IN_PROGRESS.value
-    elif any(s == ReviewStatus.NEEDS_WORK.value for s in folder_statuses):
-        return ReviewStatus.NEEDS_WORK.value
-    else:
-        return ReviewStatus.APPROVED.value
+    return compute_aggregate_status(folder_statuses)
 
 
 def cascade_status_update(

agentic_devtools-0.2.23/tests/azure_devops/test_pr_summary_commands.py

@@ -0,0 +1,26 @@
+"""
+Tests for pr_summary_commands module.
+
+Covers:
+- Deprecated generate_overarching_pr_comments function
+- Deprecated generate_overarching_pr_comments_cli function
+"""
+
+from unittest.mock import patch
+
+from agentic_devtools.cli.azure_devops.pr_summary_commands import (
+    generate_overarching_pr_comments_cli,
+)
+
+
+class TestGenerateOverarchingPrCommentsCli:
+    """Tests for CLI entry point."""
+
+    def test_cli_calls_main_function(self, temp_state_dir, clear_state_before):
+        """CLI entry point should call generate_overarching_pr_comments."""
+        with patch(
+            "agentic_devtools.cli.azure_devops.pr_summary_commands.generate_overarching_pr_comments"
+        ) as mock_func:
+            mock_func.return_value = True
+            generate_overarching_pr_comments_cli()
+            mock_func.assert_called_once()

agentic_devtools-0.2.23/tests/unit/cli/azure_devops/pr_summary_commands/test_generate_overarching_pr_comments.py

@@ -0,0 +1,22 @@
+"""
+Tests for pr_summary_commands module.
+
+Covers:
+- Deprecated generate_overarching_pr_comments function returns False
+"""
+
+from agentic_devtools.cli.azure_devops.pr_summary_commands import (
+    generate_overarching_pr_comments,
+)
+
+
+class TestGenerateOverarchingPrComments:
+    """Tests for deprecated generate_overarching_pr_comments function."""
+
+    def test_returns_false_deprecated(self, capsys):
+        """Deprecated function should return False and print deprecation message."""
+        result = generate_overarching_pr_comments()
+
+        assert result is False
+        captured = capsys.readouterr()
+        assert "deprecated" in captured.err

agentic_devtools-0.2.23/tests/unit/cli/azure_devops/review_state/test_compute_aggregate_status.py

@@ -0,0 +1,68 @@
+"""Tests for compute_aggregate_status function."""
+
+from agentic_devtools.cli.azure_devops.review_state import compute_aggregate_status
+
+
+class TestComputeAggregateStatus:
+    """Tests for compute_aggregate_status."""
+
+    def test_empty_list_returns_unreviewed(self):
+        """Empty status list returns unreviewed."""
+        assert compute_aggregate_status([]) == "unreviewed"
+
+    def test_all_unreviewed_returns_unreviewed(self):
+        """All unreviewed statuses return unreviewed."""
+        assert compute_aggregate_status(["unreviewed", "unreviewed"]) == "unreviewed"
+
+    def test_single_unreviewed_returns_unreviewed(self):
+        """Single unreviewed status returns unreviewed."""
+        assert compute_aggregate_status(["unreviewed"]) == "unreviewed"
+
+    def test_some_approved_some_unreviewed_returns_in_progress(self):
+        """Mix of approved and unreviewed returns in-progress."""
+        assert compute_aggregate_status(["approved", "unreviewed"]) == "in-progress"
+
+    def test_some_in_progress_some_unreviewed_returns_in_progress(self):
+        """Mix of in-progress and unreviewed returns in-progress."""
+        assert compute_aggregate_status(["in-progress", "unreviewed"]) == "in-progress"
+
+    def test_all_in_progress_returns_in_progress(self):
+        """All in-progress returns in-progress."""
+        assert compute_aggregate_status(["in-progress", "in-progress"]) == "in-progress"
+
+    def test_approved_and_in_progress_returns_in_progress(self):
+        """Mix of approved and in-progress returns in-progress."""
+        assert compute_aggregate_status(["approved", "in-progress"]) == "in-progress"
+
+    def test_needs_work_and_unreviewed_returns_in_progress(self):
+        """Mix of needs-work and unreviewed returns in-progress."""
+        assert compute_aggregate_status(["needs-work", "unreviewed"]) == "in-progress"
+
+    def test_needs_work_and_in_progress_returns_in_progress(self):
+        """Mix of needs-work and in-progress returns in-progress."""
+        assert compute_aggregate_status(["needs-work", "in-progress"]) == "in-progress"
+
+    def test_all_approved_returns_approved(self):
+        """All approved returns approved."""
+        assert compute_aggregate_status(["approved", "approved"]) == "approved"
+
+    def test_single_approved_returns_approved(self):
+        """Single approved returns approved."""
+        assert compute_aggregate_status(["approved"]) == "approved"
+
+    def test_all_complete_any_needs_work_returns_needs_work(self):
+        """All complete with any needs-work returns needs-work."""
+        assert compute_aggregate_status(["approved", "needs-work"]) == "needs-work"
+
+    def test_all_needs_work_returns_needs_work(self):
+        """All needs-work returns needs-work."""
+        assert compute_aggregate_status(["needs-work", "needs-work"]) == "needs-work"
+
+    def test_single_needs_work_returns_needs_work(self):
+        """Single needs-work returns needs-work."""
+        assert compute_aggregate_status(["needs-work"]) == "needs-work"
+
+    def test_all_four_statuses_returns_in_progress(self):
+        """Mix of all four statuses returns in-progress (not all complete)."""
+        statuses = ["approved", "needs-work", "in-progress", "unreviewed"]
+        assert compute_aggregate_status(statuses) == "in-progress"

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/tests/unit/cli/azure_devops/review_templates/test_render_folder_summary.py

@@ -194,3 +194,26 @@ class TestRenderFolderSummary:
         assert "### Approved" in result
         assert "### In Progress" in result
         assert "### Unreviewed" in result
+        assert "*Status:* In Progress" in result
+
+    def test_some_approved_some_unreviewed_returns_in_progress(self):
+        """Test folder status is In Progress when some files approved and some unreviewed."""
+        paths = {
+            "/src/a.py": _make_file_entry("/src/a.py", status="approved"),
+            "/src/b.py": _make_file_entry("/src/b.py", status="unreviewed"),
+            "/src/c.py": _make_file_entry("/src/c.py", status="unreviewed"),
+        }
+        folder_entry = _make_folder_entry(files=list(paths.keys()))
+        result = render_folder_summary("src", folder_entry, paths, _BASE_URL)
+        assert "*Status:* In Progress" in result
+
+    def test_approved_and_in_progress_and_unreviewed_returns_in_progress(self):
+        """Test folder status is In Progress with mix of approved, in-progress, and unreviewed."""
+        paths = {
+            "/src/a.py": _make_file_entry("/src/a.py", status="approved"),
+            "/src/b.py": _make_file_entry("/src/b.py", status="in-progress"),
+            "/src/c.py": _make_file_entry("/src/c.py", status="unreviewed"),
+        }
+        folder_entry = _make_folder_entry(files=list(paths.keys()))
+        result = render_folder_summary("src", folder_entry, paths, _BASE_URL)
+        assert "*Status:* In Progress" in result

{agentic_devtools-0.2.22 → agentic_devtools-0.2.23}/tests/unit/cli/azure_devops/review_templates/test_render_overall_summary.py

@@ -139,8 +139,8 @@ class TestRenderOverallSummary:
         assert "src" in result
         assert "lib" in result
 
-    def test_needs_work_takes_precedence_over_in_progress(self):
-        """Test Needs Work status takes precedence over In Progress."""
+    def test_needs_work_and_in_progress_returns_in_progress(self):
+        """Test In Progress status when some folders need work and some are in-progress."""
         state = _make_state(
             folders={
                 "a": _make_folder_entry(1, 2, "in-progress"),
@@ -148,7 +148,7 @@ class TestRenderOverallSummary:
             }
         )
         result = render_overall_summary(state, _BASE_URL)
-        assert "*Status:* Needs Work" in result
+        assert "*Status:* In Progress" in result
 
     def test_in_progress_takes_precedence_over_approved(self):
         """Test In Progress status takes precedence over Approved."""
@@ -160,3 +160,14 @@ class TestRenderOverallSummary:
         )
         result = render_overall_summary(state, _BASE_URL)
         assert "*Status:* In Progress" in result
+
+    def test_some_approved_some_unreviewed_returns_in_progress(self):
+        """Test overall status is In Progress when some folders approved and some unreviewed."""
+        state = _make_state(
+            folders={
+                "src": _make_folder_entry(1, 2, "approved"),
+                "lib": _make_folder_entry(3, 4, "unreviewed"),
+            }
+        )
+        result = render_overall_summary(state, _BASE_URL)
+        assert "*Status:* In Progress" in result