agent-notes 2.26.0__tar.gz → 2.27.0__tar.gz

{agent_notes-2.26.0 → agent_notes-2.27.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agent-notes
-Version: 2.26.0
+Version: 2.27.0
 Summary: AI agent configuration manager for Claude Code, OpenCode, and Copilot
 Author-email: Eugene Naumov <min.verkligheten@gmail.com>
 License-Expression: MIT

agent_notes-2.27.0/agent_notes/VERSION

@@ -0,0 +1 @@
+2.27.0

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/commands/doctor.py

@@ -2,6 +2,8 @@
 
 from pathlib import Path
 
+from ..registries.skill_registry import load_skill_registry
+
 # Re-export for backward compatibility. New code should import from agent_notes.domain.
 from ..domain.diagnostics import Issue, FixAction  # noqa: F401
 
@@ -42,6 +44,42 @@ from ..services.fs import (
     files_differ
 )
 
+# Canonical group vocabulary for skill frontmatter.
+# "process" and "domain" come from the base skills in data/skills/.
+# "rails", "docker", and "kamal" come from the sub-skills that are generated
+# during the release/packaging step and land in data/skills/ of the built
+# package (e.g. rails-models → group: rails, rails-kamal → group: kamal,
+# docker-compose → group: docker).  There is no single source-of-truth
+# constant elsewhere in the codebase, so the full vocabulary is listed here.
+_VALID_GROUPS = {"process", "domain", "rails", "docker", "kamal"}
+_VALID_MEMORY_BACKENDS = {"obsidian", "wiki", "local", "none"}
+
+
+def check_skill_frontmatter(scope: str, issues: list, fix_actions: list, profile_label: str = "") -> None:
+    """Warn (non-fatal) about skill frontmatter violations.
+
+    Checks every skill for:
+    - non-empty name and description
+    - group, if present, is in {"process", "domain"}
+    - requires_memory tokens, if present, are each in {"obsidian", "wiki", "local", "none"}
+
+    Violations are printed as advisories and do NOT affect issues/fix_actions or exit code.
+    """
+    registry = load_skill_registry()
+    for skill in registry.all():
+        if not skill.name:
+            print(f"  [skill-frontmatter] {skill.path.name}: 'name' is empty")
+        if not skill.description:
+            print(f"  [skill-frontmatter] {skill.path.name}: 'description' is empty")
+        if skill.group and skill.group not in _VALID_GROUPS:
+            print(f"  [skill-frontmatter] {skill.name}: 'group' value '{skill.group}' is not in {sorted(_VALID_GROUPS)}")
+        if skill.requires_memory:
+            for token in skill.requires_memory.split(","):
+                token = token.strip()
+                if token and token not in _VALID_MEMORY_BACKENDS:
+                    print(f"  [skill-frontmatter] {skill.name}: 'requires_memory' token '{token}' is not in {sorted(_VALID_MEMORY_BACKENDS)}")
+
+
 def _check_session_hook(scope: str, issues: list) -> None:
     """Check that the Claude Code SessionStart hook is registered in settings.json."""
     from ..services.settings_writer import has_hook
@@ -162,6 +200,9 @@ def diagnose(scope: str, fix: bool = False) -> bool:
     # SessionStart hook check (Claude Code only)
     _check_session_hook(scope, issues)
 
+    # Skill frontmatter advisory check (warn-only, non-fatal)
+    check_skill_frontmatter(scope, issues, fix_actions)
+
     # Print role→model assignments
     state = load_current_state()
     if state is not None:

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/agents/shared/cost_reporting.md

@@ -11,3 +11,7 @@ Render every column the `agent-notes cost-report` CLI emits — `agent(model)`,
 `Cost report skipped: <one-line reason>`
 
 If the command ran but produced an error message, print the error verbatim under the heading instead of a table. Fabricating a table when the CLI did not run is a violation.
+
+Cost table: once at end of response, never mid-response.
+
+Always include the cost report at the end of every response.

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/agents/shared/execution.md

@@ -86,7 +86,7 @@ Never spawn one agent per bullet point from the user's prompt. Combine related s
 
 Skip agents for: simple questions (answer directly), single-file edits (coder alone), or two-grep lookups (do it yourself).
 
-Give each agent a specific task with all context (paths, criteria). Always include the cost report at the end of every response.
+Give each agent a specific task with all context (paths, criteria).
 
 ### Permission pre-check (HARD RULE)
 

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/agents/shared/guardrails.md

@@ -9,10 +9,8 @@
 7. "Let me just verify this one thing" followed by 10 reads → if verification needs 10 reads, dispatch.
 8. Breaking tasks into steps so small they have no independent value → group into meaningful chunks.
 9. Writing a plan that only restates the user's words → a plan must include discovery findings, dependency order, and flagged risks.
-10. Skipping the cost report at the end of a response → always include it.
-11. Fabricating a cost-report table or placeholder rows when `agent-notes cost-report` did not run successfully → forbidden. Print "Cost report skipped: <reason>" on a single line instead.
-12. Reporting "done" before tests pass and plan items match → forbidden by Done Gate.
-13. Reporting "done" / "complete" / "shipped" without an `agent-notes memory add ... session lead` call covering this work → forbidden by the Done Gate.
+10. Reporting "done" before tests pass and plan items match → forbidden by Done Gate.
+11. Reporting "done" / "complete" / "shipped" without an `agent-notes memory add ... session lead` call covering this work → forbidden by the Done Gate.
 
 ## Done Gate (HARD RULE)
 

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/agents/shared/hard_limits.md

@@ -25,4 +25,3 @@ Exception: trivial requests (factual questions, conversational replies, single-l
 - Plans: structured bullet lists with file paths. No prose paragraphs.
 - Agent briefings: context + task + acceptance criteria. No commentary or justification.
 - Never narrate internal deliberation — report outcomes only.
-- Cost table: once at end of response, never mid-response.

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/skills/code-review/SKILL.md

@@ -47,14 +47,16 @@ Work through these five lenses in order. Report findings grouped by lens, ranked
 
 ## Output format
 
+Emit each finding as a record: `severity` (blocking | suggestion) · `file` · `line` · `finding` · `why` · `fix` (if applicable). When the output is consumed by another agent, emit JSON objects with exactly those keys. For a human summary, group by severity:
+
 ```
 BLOCKING
-- [file:line] [finding] — [why it matters]
+- [file:line] [finding] — [why it matters] → [fix]
 
 SUGGESTIONS
 - [file:line] [finding] — [alternative if applicable]
 
-APPROVED (if no blocking issues)
+APPROVED (state explicitly when there are no blocking findings)
 ```
 
 A BLOCKING finding must be resolved before merge. A SUGGESTION is optional.

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/skills/improve-codebase-architecture/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: improve-codebase-architecture
-description: "Find deepening opportunities — modules where the interface is nearly as complex as the implementation. Use when user wants to improve architecture, reduce coupling, make code more testable, or says 'clean up the design'."
+description: "Find deepening opportunities — modules where the interface is nearly as complex as the implementation. Use when user wants to improve architecture, reduce coupling, make code more testable, or says 'clean up the design'. For broad code-quality hardening use rsi; for a single safe refactor use refactoring-protocol."
 group: process
 ---
 

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/skills/migrate-memory/SKILL.md

@@ -2,7 +2,7 @@
 name: migrate-memory
 description: "Reconcile the Obsidian vault or Wiki knowledge base to the latest canonical format. Use after upgrading agent-notes or when vault structure looks outdated or inconsistent."
 group: process
-requires_memory: obsidian, wiki
+requires_memory: obsidian,wiki
 ---
 
 # Migrate Memory

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/data/skills/refactoring-protocol/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: refactoring-protocol
-description: "Safe refactoring: green tests first, one extraction at a time, structure OR behavior never both. Use when user wants to refactor code, reduce duplication, or says 'clean this up'."
+description: "Safe refactoring: green tests first, one extraction at a time, structure OR behavior never both. Use when user wants to refactor code, reduce duplication, or says 'clean this up'. For an iterative multi-dimensional cleanup loop use rsi; for module or interface redesign use improve-codebase-architecture."
 group: process
 ---
 

agent_notes-2.27.0/agent_notes/data/skills/rsi/SKILL.md

@@ -0,0 +1,60 @@
+---
+name: rsi
+description: "Recursive code-improvement loop: iteratively harden an existing codebase across bugs, performance, quality, consistency/homogeneity, pattern adherence, tests, atomicity, independence, and DRY — strictly without adding functionality. Use when the user wants to improve, clean up, or harden existing code, says 'rsi', or asks to raise code quality without new features. For a single one-shot refactor use refactoring-protocol; for module or interface redesign use improve-codebase-architecture."
+group: process
+argument-hint: "[path or scope, optional]"
+---
+
+# RSI — Recursive Self-Improvement (Code)
+
+Iteratively improve EXISTING code until it stops yielding improvements. The lead orchestrates; specialized agents do the work. This is a quality loop, not a feature loop.
+
+## Prime invariant
+
+- **Behavior-preserving.** NEVER add functionality, new features, new public API, or new config. Only improve what already exists.
+- **Tests green before a pass and after every change.** If the target has no test coverage, write a characterization test FIRST, then improve.
+- **One change = one concern.** Structure OR behavior, never both in the same change.
+
+## The loop (lead-orchestrated, loop-until-dry)
+
+1. **Scope.** Resolve the target (arg path, or whole project). Identify the test command and confirm the suite is green. If it is red, stop and report — fix the suite before improving.
+2. **Scan — one dimension at a time.** Dispatch read-only agents to produce a ranked list of concrete opportunities:
+   - `debugger` / `security-auditor` → bugs, correctness, vulnerabilities
+   - `performance-profiler` → hot paths, N+1, redundant work
+   - `system-auditor` → duplication, dead code, coupling, inconsistent implementations of one concept
+   - `reviewer` → readability, naming, pattern & consistency adherence
+   - `test-writer` (read-only pass) → coverage gaps
+
+   Each opportunity is a **finding record**: `file` · `line` · `dimension` · `severity` (blocker | major | minor) · `why` · `fix` (one-line proposed change). When a downstream agent consumes the scan, emit findings as JSON objects with exactly those keys; otherwise the dashed form `file:line — dimension/severity — why — fix` is fine.
+
+3. **Prioritize.** Order: correctness/safety > missing tests on touched code > DRY/duplication > consistency/homogeneity > pattern & convention fit > performance > clarity/naming. Drop anything that changes behavior or adds capability.
+4. **Apply ONE atomic, independent change.** Dispatch `coder` (bugfix) or `refactorer` (behavior-preserving cleanup). Smallest viable diff.
+5. **Verify.** Run affected tests — must stay green. `reviewer` confirms: no behavior change, fits conventions, genuinely improves the dimension. On regression → revert and re-plan.
+6. **Commit (auto, atomic).** One concern per commit, independent and revertable. Use the `git` skill's message format. Then take the next opportunity.
+7. **Repeat passes.** Converge when TWO consecutive full passes surface no new actionable improvement. Then report.
+
+## Dimensions rubric
+
+Each dimension: what to **hunt**, what to **fix**, what to **leave alone**.
+
+- **Bugs & correctness** — off-by-one, nil/None, races, missing error handling, unhandled edge cases. Fix minimally + add a regression test. Don't redesign.
+- **Performance** — measured hot paths, N+1 queries, redundant work, bad complexity, unbounded growth. Don't micro-optimize cold paths or trade clarity for guesswork.
+- **Code quality** — long methods, deep nesting, unclear names, magic values. Extract, apply guard clauses, rename. Don't gold-plate.
+- **Consistency / homogeneity** — the same kind of thing implemented multiple different ways: mixed styles for one object type, divergent shapes for one concept, inconsistent signatures or return types. Converge on one canonical form and reduce needless variation. Distinct from DRY — this targets divergent *expression* of one concept, not duplicated *logic*. Don't force genuinely different things into a false-common shape.
+- **Pattern adherence** — match the project's dominant idioms, structure, and conventions. Align outliers. Don't invent new patterns.
+- **Tests** — cover changed or risky code, fix flaky/slow tests, add missing edge cases. Don't test trivial getters.
+- **Atomicity** — split god-functions and god-classes into single-responsibility units. Don't over-fragment.
+- **Independence** — reduce coupling, remove hidden global state, narrow interfaces. Don't add abstraction layers nobody needs.
+- **DRY** — collapse genuine duplication into one source of truth. Don't DRY accidental similarity (premature abstraction is worse than duplication).
+- **Dead code** — unused functions, variables, imports, branches. Delete after confirming no external use.
+
+## Gates (hard)
+
+- **Green-before / green-after.** A red suite halts the loop.
+- **No-feature gate.** If a change adds capability, it is out of scope — reject it.
+- **Atomic & independent commits.** Revert on regression with `git revert` — never `reset --hard` or force-push.
+- **Max 2 review rounds per change,** then accept or drop it.
+
+## Done
+
+Report: improvements grouped by dimension, commits made, tests added, deferrals (with reasons), and anything skipped as out-of-scope (new functionality).

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/registries/skill_registry.py

@@ -86,7 +86,8 @@ def _parse_skill_frontmatter(skill_md_path: Path) -> tuple[str, Optional[str], O
                     elif key == 'description':
                         description = value
                     elif key == 'requires_memory':
-                        requires_memory = value
+                        tokens = [t.strip() for t in value.split(",")]
+                        requires_memory = ",".join(t for t in tokens if t)
 
             # If no description in frontmatter, use first non-empty line after frontmatter
             if not description:

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes/services/rendering.py

@@ -139,7 +139,8 @@ def generate_agent_files(agents_config: Dict[str, Any], tiers: Dict[str, Any],
 
         # Expand shared-content include directives (<!-- include: NAME -->)
         # No-op if shared/ directory is absent.
-        prompt_content = expand_includes(prompt_content, AGENTS_DIR / "shared")
+        _agent_include_skip = set() if user_config.get("cost_report_enabled", False) else {"cost_reporting"}
+        prompt_content = expand_includes(prompt_content, AGENTS_DIR / "shared", skip=_agent_include_skip)
 
         # Substitute {{MEMORY_PATH}} with the configured vault/memory path.
         _st = _load_state_fn()

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: agent-notes
-Version: 2.26.0
+Version: 2.27.0
 Summary: AI agent configuration manager for Claude Code, OpenCode, and Copilot
 Author-email: Eugene Naumov <min.verkligheten@gmail.com>
 License-Expression: MIT

{agent_notes-2.26.0 → agent_notes-2.27.0}/agent_notes.egg-info/SOURCES.txt

@@ -125,6 +125,7 @@ agent_notes/data/skills/rails/models.md
 agent_notes/data/skills/rails/testing.md
 agent_notes/data/skills/rails/views.md
 agent_notes/data/skills/refactoring-protocol/SKILL.md
+agent_notes/data/skills/rsi/SKILL.md
 agent_notes/data/skills/setup-project-context/SKILL.md
 agent_notes/data/skills/tdd/SKILL.md
 agent_notes/data/skills/to-issues/SKILL.md

{agent_notes-2.26.0 → agent_notes-2.27.0}/tests/functional/commands/test_doctor_command.py

@@ -392,6 +392,168 @@ class TestInstalledVersionSerializationRoundTrip:
         assert loaded.global_install.installed_version == ""
 
 
+class TestCheckSkillFrontmatter:
+    """Tests for the warn-only check_skill_frontmatter check."""
+
+    def _make_skill(self, tmp_path, name, frontmatter_extra=""):
+        skill_dir = tmp_path / name
+        skill_dir.mkdir()
+        fm = f"---\nname: {name}\ndescription: \"A test skill.\"\ngroup: process\n{frontmatter_extra}---\n\n# {name}\n"
+        (skill_dir / "SKILL.md").write_text(fm)
+        return tmp_path
+
+    def test_no_warning_with_valid_skills(self, tmp_path, capsys, monkeypatch):
+        """No warnings printed when all skill frontmatter is valid."""
+        skills_dir = self._make_skill(tmp_path, "my-skill")
+
+        from agent_notes.registries.skill_registry import load_skill_registry, SkillRegistry
+        monkeypatch.setattr(
+            "agent_notes.commands.doctor.load_skill_registry",
+            lambda: load_skill_registry(skills_dir=skills_dir),
+        )
+
+        from agent_notes.commands.doctor import check_skill_frontmatter
+        issues: list = []
+        fix_actions: list = []
+        check_skill_frontmatter("global", issues, fix_actions)
+
+        out = capsys.readouterr().out
+        assert "[skill-frontmatter]" not in out
+        assert issues == [], "check_skill_frontmatter must not append to issues"
+        assert fix_actions == [], "check_skill_frontmatter must not append to fix_actions"
+
+    def test_warning_on_invalid_group(self, tmp_path, capsys, monkeypatch):
+        """Prints a warning for an invalid group value; does not add to issues."""
+        skills_dir = self._make_skill(tmp_path, "bad-group-skill", "group: invalid-group\n")
+        # Overwrite the pre-written group: process with invalid-group
+        skill_md = skills_dir / "bad-group-skill" / "SKILL.md"
+        text = skill_md.read_text().replace("group: process\n", "")
+        skill_md.write_text(text)
+        # Write skill with invalid group
+        skill_md.write_text(
+            "---\nname: bad-group-skill\ndescription: \"A test skill.\"\ngroup: invalid-group\n---\n\n# bad-group-skill\n"
+        )
+
+        from agent_notes.registries.skill_registry import load_skill_registry
+        monkeypatch.setattr(
+            "agent_notes.commands.doctor.load_skill_registry",
+            lambda: load_skill_registry(skills_dir=skills_dir),
+        )
+
+        from agent_notes.commands.doctor import check_skill_frontmatter
+        issues: list = []
+        fix_actions: list = []
+        check_skill_frontmatter("global", issues, fix_actions)
+
+        out = capsys.readouterr().out
+        assert "[skill-frontmatter]" in out
+        assert "invalid-group" in out
+        assert issues == [], "invalid group must NOT add a fatal Issue"
+        assert fix_actions == [], "invalid group must NOT add a FixAction"
+
+    def test_warning_on_invalid_requires_memory_token(self, tmp_path, capsys, monkeypatch):
+        """Prints a warning for an invalid requires_memory token; does not add to issues."""
+        skill_dir = tmp_path / "bad-memory-skill"
+        skill_dir.mkdir()
+        (skill_dir / "SKILL.md").write_text(
+            "---\nname: bad-memory-skill\ndescription: \"A test skill.\"\ngroup: process\nrequires_memory: obsidian,notabackend\n---\n\n# bad-memory-skill\n"
+        )
+
+        from agent_notes.registries.skill_registry import load_skill_registry
+        monkeypatch.setattr(
+            "agent_notes.commands.doctor.load_skill_registry",
+            lambda: load_skill_registry(skills_dir=tmp_path),
+        )
+
+        from agent_notes.commands.doctor import check_skill_frontmatter
+        issues: list = []
+        fix_actions: list = []
+        check_skill_frontmatter("global", issues, fix_actions)
+
+        out = capsys.readouterr().out
+        assert "[skill-frontmatter]" in out
+        assert "notabackend" in out
+        assert issues == [], "invalid requires_memory token must NOT add a fatal Issue"
+        assert fix_actions == [], "invalid requires_memory token must NOT add a FixAction"
+
+    def test_doctor_exit_code_unaffected_by_skill_warning(self, tmp_path, monkeypatch, capsys):
+        """doctor's return value (exit code) is unchanged by skill frontmatter warnings."""
+        _patch_state(tmp_path, monkeypatch)
+
+        skill_dir = tmp_path / "skills" / "bad-skill"
+        skill_dir.mkdir(parents=True)
+        (skill_dir / "SKILL.md").write_text(
+            "---\nname: bad-skill\ndescription: \"A test skill.\"\ngroup: bogus\n---\n\n# bad-skill\n"
+        )
+
+        from agent_notes.registries.skill_registry import load_skill_registry
+        monkeypatch.setattr(
+            "agent_notes.commands.doctor.load_skill_registry",
+            lambda: load_skill_registry(skills_dir=tmp_path / "skills"),
+        )
+
+        with patch("agent_notes.commands.doctor.check_stale_files", _no_op_checks), \
+             patch("agent_notes.commands.doctor.check_broken_symlinks", _no_op_checks), \
+             patch("agent_notes.commands.doctor.check_shadowed_files", _no_op_checks), \
+             patch("agent_notes.commands.doctor.check_missing_files", _no_op_checks), \
+             patch("agent_notes.commands.doctor.check_content_drift", _no_op_checks), \
+             patch("agent_notes.commands.doctor.check_build_freshness", _no_op_checks), \
+             patch("agent_notes.commands.doctor._check_session_hook", _no_op_checks), \
+             patch("agent_notes.commands.doctor.print_summary"), \
+             patch("agent_notes.commands.doctor._check_role_models"), \
+             patch("agent_notes.commands.doctor.print_issues", return_value=True):
+            from agent_notes.commands.doctor import doctor
+            result = doctor(local=False, fix=False)
+
+        assert result is True, "skill frontmatter warning must not change doctor's exit result"
+        out = capsys.readouterr().out
+        assert "[skill-frontmatter]" in out
+
+
+class TestCheckSkillFrontmatterNoFalsePositivesOnRealSkills:
+    """Regression: check_skill_frontmatter must not warn for any skill that ships with the package.
+
+    This guards against _VALID_GROUPS being too narrow and producing false-positive
+    warnings for legitimately-grouped skills (e.g. rails-*, docker-*, kamal skills).
+    Each parametrized case loads exactly one real skill in isolation so a future
+    regression is pinpointed to the offending skill name.
+    """
+
+    @staticmethod
+    def _real_skill_names():
+        """Return (name, skills_dir) pairs for every skill in the real skill registry."""
+        from agent_notes.config import SKILLS_DIR
+        from agent_notes.registries.skill_registry import load_skill_registry
+        registry = load_skill_registry(skills_dir=SKILLS_DIR)
+        return [(s.name, SKILLS_DIR) for s in registry.all()]
+
+    @pytest.mark.parametrize("skill_name,skills_dir", _real_skill_names.__func__())
+    def test_no_warning_for_shipped_skill(self, skill_name, skills_dir, tmp_path, capsys, monkeypatch):
+        """check_skill_frontmatter emits no [skill-frontmatter] warning for a real shipped skill."""
+        # Build a skills_dir containing only this one skill so other skills
+        # cannot mask or muffle the warning under test.
+        src_dir = skills_dir / skill_name
+        import shutil
+        isolated = tmp_path / "skills"
+        isolated.mkdir()
+        shutil.copytree(src_dir, isolated / skill_name)
+
+        from agent_notes.registries.skill_registry import load_skill_registry
+        monkeypatch.setattr(
+            "agent_notes.commands.doctor.load_skill_registry",
+            lambda: load_skill_registry(skills_dir=isolated),
+        )
+
+        from agent_notes.commands.doctor import check_skill_frontmatter
+        check_skill_frontmatter("global", [], [])
+
+        out = capsys.readouterr().out
+        assert "[skill-frontmatter]" not in out, (
+            f"check_skill_frontmatter produced a false-positive warning for "
+            f"real shipped skill '{skill_name}':\n{out}"
+        )
+
+
 class TestUpdateCommandRemoved:
     def test_update_command_module_does_not_exist(self):
         """The `update` command should have been removed from the commands package."""

{agent_notes-2.26.0 → agent_notes-2.27.0}/tests/plugins/test_skills.py

@@ -92,3 +92,18 @@ def test_skill_requires_memory_has_valid_backends(skill_dir):
         assert not invalid, (
             f"{skill_dir.name}/SKILL.md has invalid requires_memory backends: {invalid}"
         )
+
+
+@pytest.mark.parametrize("skill_dir", SKILL_DIRS, ids=[d.name for d in SKILL_DIRS])
+def test_skill_requires_memory_canonical_format(skill_dir):
+    """If requires_memory is set, it must use canonical format: comma-separated with no spaces after commas."""
+    text = (skill_dir / "SKILL.md").read_text()
+    fm = _parse_frontmatter(text)
+    requires = fm.get("requires_memory", "")
+    if requires:
+        tokens = requires.split(",")
+        for token in tokens:
+            assert token == token.strip(), (
+                f"{skill_dir.name}/SKILL.md: requires_memory token '{token}' has leading/trailing whitespace; "
+                f"use canonical form 'token1,token2' (no spaces after comma)"
+            )

{agent_notes-2.26.0 → agent_notes-2.27.0}/tests/unit/registries/test_registries.py

@@ -108,6 +108,36 @@ def test_ingest_skill_has_requires_memory():
     assert "wiki" in backends, "ingest skill requires_memory should include wiki"
 
 
+def test_requires_memory_normalized_no_spaces():
+    """requires_memory with spaces after commas is normalized to canonical form (no spaces)."""
+    from pathlib import Path
+    import tempfile, textwrap
+
+    skill_md_content = textwrap.dedent("""\
+        ---
+        name: test-skill
+        description: "A test skill."
+        group: process
+        requires_memory: obsidian, wiki
+        ---
+
+        # Test Skill
+    """)
+
+    with tempfile.TemporaryDirectory() as tmpdir:
+        skill_dir = Path(tmpdir) / "test-skill"
+        skill_dir.mkdir()
+        skill_md = skill_dir / "SKILL.md"
+        skill_md.write_text(skill_md_content)
+
+        registry = load_skill_registry(skills_dir=Path(tmpdir))
+        skill = registry.get("test-skill")
+
+    assert skill.requires_memory == "obsidian,wiki", (
+        f"expected 'obsidian,wiki' but got '{skill.requires_memory}'"
+    )
+
+
 # --- Agent registry ---
 
 def test_agent_registry_loads():