adloop 0.33.0__tar.gz → 0.33.1__tar.gz

{adloop-0.33.0 → adloop-0.33.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: adloop
-Version: 0.33.0
+Version: 0.33.1
 Summary: The AI command center for Google Ads, Reddit Ads, GA4, and tracking code.
 Keywords: mcp,google-ads,reddit-ads,google-analytics,ga4,cursor,marketing
 Author: Daniel Klose

{adloop-0.33.0 → adloop-0.33.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.33.0"
+version = "0.33.1"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 requires-python = ">=3.11"

{adloop-0.33.0 → adloop-0.33.1}/pyproject.toml.orig

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.33.0"
+version = "0.33.1"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 authors = [

{adloop-0.33.0 → adloop-0.33.1}/src/adloop/rules/adloop.md

@@ -345,7 +345,7 @@ Same draft → preview → `confirm_and_apply` gate; the plan carries `platform:
 
 **Approval cards (Claude, ChatGPT, VS Code and other apps with MCP Apps):** when the preview comes back with `approval: "card"`, the user sees it as an AdLoop approval card with Test run, Apply and Discard buttons, and approves there. Summarize the change and its warnings, then let the user decide on the card instead of asking for a "yes" in the chat. In those apps `confirm_and_apply(dry_run=false)` is refused with status `APPROVE_ON_CARD` (a dry run still works), because only the click applies; the AI cannot press the button. Do not retry. If the user says the card is not visible, tell them the workspace owner can allow approval in chat (AdLoop Cloud: Settings → Safety; self-hosted: `safety.allow_chat_approval`). After a click the card posts a message such as "Applied on the AdLoop approval card: ..."; continue from there (e.g. remind them to enable a new paused ad).
 
-**Confirmation dialogs (apps without cards that support elicitation):** when you call `confirm_and_apply(dry_run=false)` after the user's go-ahead, AdLoop itself asks the user in the app's confirmation dialog before anything changes; irreversible changes need an extra "cannot be undone" tick there. You do not answer that dialog. `NOT_CONFIRMED` means the user declined or closed it: nothing was changed, the preview stays pending, so ask what they want instead of retrying. Apps with neither cards nor dialogs keep the chat flow above.
+**Confirmation dialogs (apps without cards that support elicitation):** when you call `confirm_and_apply(dry_run=false)` after the user's go-ahead, AdLoop itself asks the user in the app's confirmation dialog before anything changes; irreversible changes need an extra "cannot be undone" tick there. You do not answer that dialog. `NOT_CONFIRMED` means the user declined or closed it: nothing was changed, the preview stays pending, so ask what they want instead of retrying. A dry run's `next_step` says when a dialog will follow, so tell the user to look out for it. `CONFIRMATION_UNANSWERED` means the app received the dialog but never returned an answer (some headless agents and IDE setups declare dialogs they cannot show): nothing was changed; ask the user whether a dialog appeared, and if their app cannot show one, relay the message's ways out (approval in chat, or an app with the approval card). Apps with neither cards nor dialogs keep the chat flow above.
 
 **Safety behaviors:**
 - New campaigns and RSAs (and every Reddit campaign, ad group and ad) are created as PAUSED — user must explicitly enable them after review.

{adloop-0.33.0 → adloop-0.33.1}/src/adloop/safety/approval.py

@@ -335,6 +335,64 @@ def _not_confirmed(plan: ChangePlan) -> dict:
     }
 
 
+def _dialog_unanswered(plan: ChangePlan) -> dict:
+    return {
+        "status": "CONFIRMATION_UNANSWERED",
+        "plan_id": plan.plan_id,
+        "operation": plan.operation,
+        "message": (
+            "AdLoop asked the user to confirm this change in a dialog of their app, "
+            "but the app never returned an answer, so nothing was changed and the "
+            "plan stays pending. Ask the user whether a confirmation dialog appeared. "
+            "If it did, call confirm_and_apply again and have them answer it. If their "
+            "app cannot show dialogs (for example a headless agent or a script), the "
+            "workspace owner can allow approval in chat (AdLoop Cloud: Settings -> "
+            "Safety -> 'Also allow approval in chat'; self-hosted: "
+            "safety.allow_chat_approval: true), or the change can be applied from an "
+            "app that shows AdLoop's approval card, such as Claude or ChatGPT. Calling "
+            "confirm_and_apply again sends the dialog once more."
+        ),
+    }
+
+
+def _mark_dialog(plan: ChangePlan, open_: bool) -> None:
+    """Record (or clear) that a dialog for this plan awaits an answer."""
+    from datetime import datetime, timezone
+
+    from adloop.safety.preview import store_plan
+
+    plan.dialog_requested_at = datetime.now(timezone.utc).isoformat() if open_ else ""
+    store_plan(plan)
+
+
+def dialog_expected(plan_id: str) -> bool:
+    """Whether a real apply of this plan will ask the user in a dialog.
+
+    Used after a successful dry run, so the AI can tell the user to look out
+    for it instead of letting an unanswered dialog look like a hang.
+    """
+    if _dialog_applies(plan_id) is None:
+        return False
+    try:
+        from fastmcp.server.dependencies import get_context
+
+        if get_context()._is_modern_protocol():
+            return True
+    except Exception:
+        return False
+    from adloop.runtime import deployment_mode
+
+    # Older protocols get the dialog only self-hosted (see confirm_in_dialog).
+    return deployment_mode() != "server"
+
+
+DIALOG_NOTE = (
+    "The real apply (dry_run=false) asks the user to confirm in a dialog shown by "
+    "their app; tell them to look out for it and answer it. If no dialog appears, "
+    "the call returns CONFIRMATION_UNANSWERED on the next attempt with the ways out."
+)
+
+
 def _dialog_applies(plan_id: str) -> ChangePlan | None:
     """The plan when a real apply must be confirmed in a dialog, else None."""
     from adloop.runtime import current_config
@@ -375,6 +433,14 @@ async def confirm_in_dialog(context: Any, plan_id: str) -> Any | None:
     if context._is_modern_protocol():
         responses = context.input_responses
         if responses is None:
+            if plan.dialog_requested_at:
+                # The last dialog for this plan was sent and this is a fresh
+                # call, not its answer: the app received the dialog and never
+                # returned one. Say so instead of sending another dialog the
+                # app will sit on until its timeout. Cleared, so asking again
+                # sends a new dialog.
+                _mark_dialog(plan, False)
+                return ToolResult(structured_content=_dialog_unanswered(plan))
             import mcp_types
             from fastmcp.tools.base import InputRequiredToolResult
 
@@ -385,11 +451,14 @@ async def confirm_in_dialog(context: Any, plan_id: str) -> Any | None:
                 )
             )
             state = json.dumps({"plan_id": plan.plan_id, "code": approval_code(plan)})
+            _mark_dialog(plan, True)
             return InputRequiredToolResult(
                 mcp_types.InputRequiredResult(
                     input_requests={DIALOG_KEY: request}, request_state=state
                 )
             )
+        if plan.dialog_requested_at:
+            _mark_dialog(plan, False)  # answered, whatever the answer is
         try:
             state = json.loads(context.request_state or "{}")
         except ValueError:

{adloop-0.33.0 → adloop-0.33.1}/src/adloop/safety/preview.py

@@ -25,6 +25,11 @@ class ChangePlan:
     # Ad platform the plan targets: "" (Google, the default so stored plans
     # from before the field existed still load) or "reddit".
     platform: str = ""
+    # When a confirmation dialog for this plan was last sent and not yet
+    # answered (ISO timestamp, "" when none is open). An app that receives
+    # the dialog but never answers it would otherwise leave every retry
+    # waiting until its own timeout; see approval.confirm_in_dialog.
+    dialog_requested_at: str = ""
 
     # Payload the applier needs but a preview must never show: an upload's rows
     # (the caller id cannot be hashed, so call uploads carry raw phone numbers),

{adloop-0.33.0 → adloop-0.33.1}/src/adloop/server.py

@@ -4482,6 +4482,11 @@ def confirm_and_apply(
     only the user's click on the card applies the change. Dry runs still
     work. The workspace owner can allow approval in chat as well.
 
+    Confirmation dialogs: in apps that show dialogs instead, dry_run=false
+    first asks the user in a dialog. A declined dialog returns NOT_CONFIRMED;
+    an app that receives the dialog but never answers it gets
+    CONFIRMATION_UNANSWERED on the next call, with the ways out.
+
     Args:
         plan_id: The plan_id returned by a prior draft_*, update_*, add_*,
             pause/enable/remove or other preview tool call. An unknown or
@@ -4490,13 +4495,17 @@ def confirm_and_apply(
             applies the change for real.
     """
     from adloop.ads.write import confirm_and_apply as _impl
-    from adloop.safety.approval import chat_apply_refusal
+    from adloop.safety.approval import DIALOG_NOTE, chat_apply_refusal, dialog_expected
 
     if not dry_run:
         refusal = chat_apply_refusal(plan_id)
         if refusal is not None:
             return refusal
-    return _impl(current_config(), plan_id=plan_id, dry_run=dry_run)
+    result = _impl(current_config(), plan_id=plan_id, dry_run=dry_run)
+    if (dry_run and isinstance(result, dict) and result.get("status") == "DRY_RUN_SUCCESS"
+            and dialog_expected(plan_id)):
+        result["next_step"] = DIALOG_NOTE
+    return result
 
 
 @_tool(