adloop 0.29.0__tar.gz → 0.29.2__tar.gz

{adloop-0.29.0 → adloop-0.29.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: adloop
-Version: 0.29.0
+Version: 0.29.2
 Summary: The AI command center for Google Ads, Reddit Ads, GA4, and tracking code.
 Keywords: mcp,google-ads,reddit-ads,google-analytics,ga4,cursor,marketing
 Author: Daniel Klose

{adloop-0.29.0 → adloop-0.29.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.29.0"
+version = "0.29.2"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 requires-python = ">=3.11"

{adloop-0.29.0 → adloop-0.29.2}/pyproject.toml.orig

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.29.0"
+version = "0.29.2"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 authors = [

{adloop-0.29.0 → adloop-0.29.2}/src/adloop/safety/approval.py

@@ -91,6 +91,41 @@ def code_matches(plan: ChangePlan, code: str) -> bool:
     return hmac.compare_digest(approval_code(plan), str(code or ""))
 
 
+UPLOAD_META_KEY = "adloop/upload"
+# The upload card's code is good for this long after upload_images opened it.
+_UPLOAD_CODE_SECONDS = 2 * 3600
+
+
+def upload_code(now: float | None = None) -> str:
+    """The code an upload card presents with each file: "<expiry>.<signature>".
+
+    Some apps send a card's own calls without declaring MCP Apps (the Claude
+    iOS app), so the upload tool cannot rely on that declaration. The code
+    goes to the card in the result's _meta, never into the model's context,
+    and is bound to the workspace and an expiry.
+    """
+    import time
+
+    from adloop.runtime import current_tenant
+
+    expiry = int((now if now is not None else time.time()) + _UPLOAD_CODE_SECONDS)
+    message = "\x00".join(("upload", current_tenant(), str(expiry)))
+    return f"{expiry}.{hmac.new(_secret, message.encode(), hashlib.sha256).hexdigest()[:32]}"
+
+
+def upload_code_valid(code: str, now: float | None = None) -> bool:
+    import time
+
+    from adloop.runtime import current_tenant
+
+    expiry, _, signature = str(code or "").partition(".")
+    if not expiry.isdigit() or int(expiry) < (now if now is not None else time.time()):
+        return False
+    message = "\x00".join(("upload", current_tenant(), expiry))
+    expected = hmac.new(_secret, message.encode(), hashlib.sha256).hexdigest()[:32]
+    return hmac.compare_digest(expected, signature)
+
+
 def card_click_active() -> bool:
     """True while ``approve_change`` runs a click from the card."""
     return _card_click.get()

{adloop-0.29.0 → adloop-0.29.2}/src/adloop/server.py

@@ -252,11 +252,18 @@ _APP_ONLY_TOOLS = {
 
 
 class _AppOnlyToolsForCardClients(Middleware):
-    """List and run app-only tools only for apps that render cards.
+    """List app-only tools only to apps that render cards.
 
     The MCP Apps spec makes a card-capable app hide app-only tools from its
     model. An app without the extension knows nothing about that rule and
     would hand them to its model, so they are not offered to it at all.
+
+    Calls are a different matter. Some apps send a card's own click without
+    the extension declaration (the Claude iOS app does), so refusing every
+    call from an "app without cards" breaks the card itself. approve_change
+    needs no such check: it only acts on the plan's one-time code, which
+    goes to the card and never into the model's context. The upload card's
+    tool passes with the declaration or its own code from upload_images.
     """
 
     async def on_list_tools(self, context, call_next):
@@ -267,7 +274,12 @@ class _AppOnlyToolsForCardClients(Middleware):
 
     async def on_call_tool(self, context, call_next):
         card = _APP_ONLY_TOOLS.get(context.message.name)
-        if card and not client_shows_cards():
+        if card and context.message.name == STORE_UPLOAD_TOOL:
+            from adloop.safety.approval import upload_code_valid
+
+            if upload_code_valid((context.message.arguments or {}).get("code", "")):
+                card = None
+        if card and context.message.name != APPROVE_TOOL and not client_shows_cards():
             from fastmcp.exceptions import ToolError
 
             raise ToolError(f"{context.message.name} can only be called from the {card}.")
@@ -4437,7 +4449,21 @@ def upload_images() -> dict:
     """
     from adloop.uploads import upload_instructions
 
-    return upload_instructions(client_shows_cards())
+    shows_cards = client_shows_cards()
+    result = upload_instructions(shows_cards)
+    if not shows_cards:
+        return result
+    from fastmcp.tools import ToolResult
+    from mcp.types import TextContent
+
+    from adloop.safety.approval import UPLOAD_META_KEY, upload_code
+
+    # The card sends this code with every file (see store_image_upload).
+    return ToolResult(
+        content=[TextContent(type="text", text=json.dumps(result, default=str))],
+        structured_content=result,
+        meta={UPLOAD_META_KEY: {"code": upload_code()}},
+    )
 
 
 @_tool(
@@ -4447,7 +4473,7 @@ def upload_images() -> dict:
     meta={"ui": {"resourceUri": UPLOAD_CARD_URI, "visibility": ["app"]}},
 )
 @_safe
-def store_image_upload(name: str, data_base64: str) -> dict:
+def store_image_upload(name: str, data_base64: str, code: str = "") -> dict:
     """Store an image dropped on the AdLoop upload card.
 
     Called only by the upload card; AI apps keep this tool out of the
@@ -4456,6 +4482,7 @@ def store_image_upload(name: str, data_base64: str) -> dict:
     Args:
         name: The file name, used for the asset name.
         data_base64: The file content, base64-encoded.
+        code: The upload card's code from upload_images.
     """
     import base64
     import binascii

{adloop-0.29.0 → adloop-0.29.2}/src/adloop/upload_card.html

@@ -77,6 +77,10 @@
 (() => {
   "use strict";
   const TOOL = "store_image_upload";
+  const META_KEY = "adloop/upload";
+  // From upload_images: some apps send the card's calls without declaring
+  // MCP Apps, so each file carries the card's code instead.
+  let code = "";
   const MAX_BYTES = 5120 * 1024;
   const TYPES = ["image/png", "image/jpeg", "image/gif"];
   const STRINGS = {
@@ -168,7 +172,7 @@
       if (file.size > MAX_BYTES) { row.state.textContent = t("tooBig"); row.state.classList.add("bad"); continue; }
       row.state.textContent = t("uploading");
       try {
-        const result = await request("tools/call", { name: TOOL, arguments: { name: file.name, data_base64: await readBase64(file) } });
+        const result = await request("tools/call", { name: TOOL, arguments: { name: file.name, data_base64: await readBase64(file), code } });
         const r = payloadOf(result);
         if ((result && result.isError) || r.error || !r.upload_id) throw new Error(r.error || "upload failed");
         row.meta.textContent = describe(r);
@@ -200,6 +204,8 @@
 
   let shownExisting = false;
   function onToolResult(result) {
+    const meta = result && result._meta && result._meta[META_KEY];
+    if (meta && meta.code) code = meta.code;
     if (shownExisting || !result) return;
     shownExisting = true;
     const r = payloadOf(result);