adloop 0.27.1__tar.gz → 0.27.2__tar.gz

{adloop-0.27.1 → adloop-0.27.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: adloop
-Version: 0.27.1
+Version: 0.27.2
 Summary: The AI command center for Google Ads, Reddit Ads, GA4, and tracking code.
 Keywords: mcp,google-ads,reddit-ads,google-analytics,ga4,cursor,marketing
 Author: Daniel Klose

{adloop-0.27.1 → adloop-0.27.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.27.1"
+version = "0.27.2"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 requires-python = ">=3.11"

{adloop-0.27.1 → adloop-0.27.2}/pyproject.toml.orig

@@ -1,6 +1,6 @@
 [project]
 name = "adloop"
-version = "0.27.1"
+version = "0.27.2"
 description = "The AI command center for Google Ads, Reddit Ads, GA4, and tracking code."
 readme = "README.md"
 authors = [

{adloop-0.27.1 → adloop-0.27.2}/src/adloop/ads/write.py

@@ -7,6 +7,7 @@ Every write tool returns a preview/plan. Nothing executes until
 from __future__ import annotations
 
 import hashlib
+import re
 import struct
 from pathlib import Path, PurePath, PurePosixPath
 from typing import TYPE_CHECKING
@@ -40,6 +41,31 @@ _VALID_IMAGE_MIME_TYPES = {
 _VALID_HEADLINE_PINS = {"HEADLINE_1", "HEADLINE_2", "HEADLINE_3"}
 _VALID_DESCRIPTION_PINS = {"DESCRIPTION_1", "DESCRIPTION_2"}
 
+# Insertion tags Google expands at serve time. Only the default text after
+# the colon counts toward the 30/90 character caps, e.g.
+# "{KeyWord:Clogged Drain Service}" is 21 characters, not 31. Written with
+# spaces ("{ KeyWord : x }") it is not a tag and counts as plain text.
+_INSERTION_TAG_RE = re.compile(r"\{(keyword|location\([a-z]+\)):([^{}]*)\}", re.IGNORECASE)
+_BARE_INSERTION_TAG_RE = re.compile(r"\{(keyword|location\([a-z]+\))\}", re.IGNORECASE)
+
+
+def _counted_length(text: str) -> int:
+    """Length Google checks against the cap: insertion tags count as their default text."""
+    return len(_INSERTION_TAG_RE.sub(lambda m: m.group(2), text))
+
+
+def _insertion_tag_errors(label: str, text: str) -> list[str]:
+    """RSA keyword/location insertion needs default text, e.g. {KeyWord:Drain Cleaning}."""
+    missing = _BARE_INSERTION_TAG_RE.search(text) or any(
+        not m.group(2).strip() for m in _INSERTION_TAG_RE.finditer(text)
+    )
+    if missing:
+        return [
+            f"{label} uses an insertion tag without default text: '{text}'. "
+            "Default text after a colon is required, e.g. {KeyWord:Drain Cleaning}"
+        ]
+    return []
+
 
 def _normalize_rsa_assets(items: list) -> list[dict]:
     """Accept str or {text, pinned_field?} dict entries; return list of dicts.
@@ -3435,9 +3461,10 @@ def _validate_rsa_assets(
     for i, h in enumerate(headlines):
         text = h["text"]
         pin = h["pinned_field"]
-        if len(text) > 30:
+        errors.extend(_insertion_tag_errors(f"Headline {i + 1}", text))
+        if _counted_length(text) > 30:
             errors.append(
-                f"Headline {i + 1} exceeds 30 chars ({len(text)}): '{text}'"
+                f"Headline {i + 1} exceeds 30 chars ({_counted_length(text)}): '{text}'"
             )
         if pin is not None:
             if pin not in _VALID_HEADLINE_PINS:
@@ -3455,9 +3482,10 @@ def _validate_rsa_assets(
     for i, d in enumerate(descriptions):
         text = d["text"]
         pin = d["pinned_field"]
-        if len(text) > 90:
+        errors.extend(_insertion_tag_errors(f"Description {i + 1}", text))
+        if _counted_length(text) > 90:
             errors.append(
-                f"Description {i + 1} exceeds 90 chars ({len(text)}): '{text}'"
+                f"Description {i + 1} exceeds 90 chars ({_counted_length(text)}): '{text}'"
             )
         if pin is not None:
             if pin not in _VALID_DESCRIPTION_PINS:

{adloop-0.27.1 → adloop-0.27.2}/src/adloop/server.py

@@ -3117,10 +3117,13 @@ def draft_responsive_search_ad(
         ad_group_id: Numeric ID of the ad group that gets the ad.
         headlines: 3-15 headlines, max 30 chars each. Each entry is a plain
             string (unpinned) or {"text": "...", "pinned_field": "HEADLINE_1"};
-            valid pins are HEADLINE_1, HEADLINE_2, HEADLINE_3.
+            valid pins are HEADLINE_1, HEADLINE_2, HEADLINE_3. Keyword or
+            location insertion such as {KeyWord:Drain Cleaning} counts as its
+            default text, which is required.
         descriptions: 2-4 descriptions, max 90 chars each. Each entry is a plain
             string (unpinned) or {"text": "...", "pinned_field": "DESCRIPTION_1"};
-            valid pins are DESCRIPTION_1, DESCRIPTION_2.
+            valid pins are DESCRIPTION_1, DESCRIPTION_2. Insertion tags count
+            as their default text, as for headlines.
         final_url: Landing page URL the ad links to; must be reachable.
         customer_id: Google Ads customer ID (digits, e.g. "1234567890"). Empty
             uses the configured default account.
@@ -3183,11 +3186,13 @@ def update_responsive_search_ad(
             fully swaps in for the existing headlines. Google's RSA constraints
             apply: 3-15 headlines, max 30 chars each, at most 2 per pin slot.
             Each entry is a plain string (unpinned) or {"text": "...",
-            "pinned_field": "HEADLINE_1"} (HEADLINE_1-3).
+            "pinned_field": "HEADLINE_1"} (HEADLINE_1-3). Insertion tags such as
+            {KeyWord:Clogged Drain Service} count as their default text, which
+            is required.
         descriptions: LIST-REPLACE: None or [] means no change; a non-empty list
             fully swaps in. 2-4 descriptions, max 90 chars each, at most 1 per
-            pin slot (DESCRIPTION_1, DESCRIPTION_2). Same entry format as
-            headlines.
+            pin slot (DESCRIPTION_1, DESCRIPTION_2). Same entry format and
+            insertion-tag counting as headlines.
         final_url: Empty means no change; non-empty replaces the final URL and
             is checked for reachability.
         path1: Empty means no change; non-empty sets the first display path