adcp 2.11.0__tar.gz → 2.11.1__tar.gz

{adcp-2.11.0/src/adcp.egg-info → adcp-2.11.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: adcp
-Version: 2.11.0
+Version: 2.11.1
 Summary: Official Python client for the Ad Context Protocol (AdCP)
 Author-email: AdCP Community <maintainers@adcontextprotocol.org>
 License: Apache-2.0

{adcp-2.11.0 → adcp-2.11.1}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "adcp"
-version = "2.11.0"
+version = "2.11.1"
 description = "Official Python client for the Ad Context Protocol (AdCP)"
 authors = [
     {name = "AdCP Community", email = "maintainers@adcontextprotocol.org"}

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/__init__.py

@@ -180,7 +180,7 @@ from adcp.validation import (
     validate_publisher_properties_item,
 )
 
-__version__ = "2.11.0"
+__version__ = "2.11.1"
 
 __all__ = [
     # Client classes

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/types/__init__.py

@@ -182,7 +182,6 @@ from adcp.types._generated import (
     StatusSummary,
     SyncCreativesRequest,
     SyncCreativesResponse,
-    Tag,
     Tags,
     TargetingOverlay,
     Task,
@@ -426,7 +425,6 @@ __all__ = [
     "Results",
     "Signal",
     "SignalFilters",
-    "Tag",
     "Tags",
     "TargetingOverlay",
     "VenueBreakdownItem",

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/types/_generated.py

@@ -10,7 +10,7 @@ Auto-generated by datamodel-code-generator from JSON schemas.
 DO NOT EDIT MANUALLY.
 
 Generated from: https://github.com/adcontextprotocol/adcp/tree/main/schemas
-Generation date: 2025-11-21 15:57:17 UTC
+Generation date: 2025-11-21 20:45:16 UTC
 """
 # ruff: noqa: E501, I001
 from __future__ import annotations
@@ -19,7 +19,7 @@ from __future__ import annotations
 from adcp.types.generated_poc.activate_signal_request import ActivateSignalRequest
 from adcp.types.generated_poc.activate_signal_response import ActivateSignalResponse, ActivateSignalResponse1, ActivateSignalResponse2
 from adcp.types.generated_poc.activation_key import ActivationKey1, ActivationKey2
-from adcp.types.generated_poc.adagents import AuthorizedAgents, AuthorizedAgents1, AuthorizedAgents2, AuthorizedAgents3, AuthorizedSalesAgents, Contact, PropertyId, PropertyTag, Tags
+from adcp.types.generated_poc.adagents import AuthorizedAgents, AuthorizedAgents1, AuthorizedAgents2, AuthorizedAgents3, AuthorizedSalesAgents, Contact, Tags
 from adcp.types.generated_poc.adcp_domain import AdcpDomain
 from adcp.types.generated_poc.asset_content_type import AssetContentType
 from adcp.types.generated_poc.audio_asset import AudioAsset
@@ -104,7 +104,9 @@ from adcp.types.generated_poc.product import DeliveryMeasurement, Product, Produ
 from adcp.types.generated_poc.product_filters import ProductFilters
 from adcp.types.generated_poc.promoted_offerings import AssetSelectors, AssetType, Offering, PromotedOfferings
 from adcp.types.generated_poc.promoted_products import PromotedProducts
-from adcp.types.generated_poc.property import Identifier, Property, Tag
+from adcp.types.generated_poc.property import Identifier, Property
+from adcp.types.generated_poc.property_id import PropertyId
+from adcp.types.generated_poc.property_tag import PropertyTag
 from adcp.types.generated_poc.property_type import PropertyType
 from adcp.types.generated_poc.protocol_envelope import ProtocolEnvelope
 from adcp.types.generated_poc.provide_performance_feedback_request import ProvidePerformanceFeedbackRequest, ProvidePerformanceFeedbackRequest1, ProvidePerformanceFeedbackRequest2
@@ -202,7 +204,7 @@ __all__ = [
     "SignalCatalogType", "SignalFilters", "Sort", "SortApplied", "SortDirection",
     "StandardFormatIds", "Status", "StatusSummary", "SubAsset1", "SubAsset2",
     "SyncCreativesRequest", "SyncCreativesResponse", "SyncCreativesResponse1",
-    "SyncCreativesResponse2", "Tag", "Tags", "TargetingOverlay", "Task", "TaskStatus", "TaskType",
+    "SyncCreativesResponse2", "Tags", "TargetingOverlay", "Task", "TaskStatus", "TaskType",
     "TasksGetRequest", "TasksGetResponse", "TasksListRequest", "TasksListResponse", "TextAsset",
     "Totals", "Type", "UpdateFrequency", "UpdateMediaBuyRequest", "UpdateMediaBuyRequest1",
     "UpdateMediaBuyRequest2", "UpdateMediaBuyResponse", "UpdateMediaBuyResponse1",

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/types/generated_poc/adagents.py

@@ -1,75 +1,15 @@
 # generated by datamodel-codegen:
 #   filename:  adagents.json
-#   timestamp: 2025-11-19T02:02:39+00:00
+#   timestamp: 2025-11-21T20:45:16+00:00
 
 from __future__ import annotations
 
 from typing import Annotated, Literal
 
 from adcp.types.base import AdCPBaseModel
-from pydantic import AnyUrl, AwareDatetime, ConfigDict, EmailStr, Field, RootModel
+from pydantic import AnyUrl, AwareDatetime, ConfigDict, EmailStr, Field
 
-from . import property, publisher_property_selector
-
-
-class PropertyId(RootModel[str]):
-    root: Annotated[str, Field(pattern='^[a-z0-9_]+$')]
-
-
-class AuthorizedAgents(AdCPBaseModel):
-    model_config = ConfigDict(
-        extra='forbid',
-    )
-    authorization_type: Annotated[
-        Literal['property_ids'],
-        Field(description='Discriminator indicating authorization by specific property IDs'),
-    ]
-    authorized_for: Annotated[
-        str,
-        Field(
-            description='Human-readable description of what this agent is authorized to sell',
-            max_length=500,
-            min_length=1,
-        ),
-    ]
-    property_ids: Annotated[
-        list[PropertyId],
-        Field(
-            description='Property IDs this agent is authorized for. Resolved against the top-level properties array in this file',
-            min_length=1,
-        ),
-    ]
-    url: Annotated[AnyUrl, Field(description="The authorized agent's API endpoint URL")]
-
-
-class PropertyTag(PropertyId):
-    pass
-
-
-class AuthorizedAgents1(AdCPBaseModel):
-    model_config = ConfigDict(
-        extra='forbid',
-    )
-    authorization_type: Annotated[
-        Literal['property_tags'],
-        Field(description='Discriminator indicating authorization by property tags'),
-    ]
-    authorized_for: Annotated[
-        str,
-        Field(
-            description='Human-readable description of what this agent is authorized to sell',
-            max_length=500,
-            min_length=1,
-        ),
-    ]
-    property_tags: Annotated[
-        list[PropertyTag],
-        Field(
-            description='Tags identifying which properties this agent is authorized for. Resolved against the top-level properties array in this file using tag matching',
-            min_length=1,
-        ),
-    ]
-    url: Annotated[AnyUrl, Field(description="The authorized agent's API endpoint URL")]
+from . import property, property_id, property_tag, publisher_property_selector
 
 
 class Contact(AdCPBaseModel):
@@ -125,6 +65,58 @@ class Tags(AdCPBaseModel):
     name: Annotated[str, Field(description='Human-readable name for this tag')]
 
 
+class AuthorizedAgents(AdCPBaseModel):
+    model_config = ConfigDict(
+        extra='forbid',
+    )
+    authorization_type: Annotated[
+        Literal['property_ids'],
+        Field(description='Discriminator indicating authorization by specific property IDs'),
+    ]
+    authorized_for: Annotated[
+        str,
+        Field(
+            description='Human-readable description of what this agent is authorized to sell',
+            max_length=500,
+            min_length=1,
+        ),
+    ]
+    property_ids: Annotated[
+        list[property_id.PropertyId],
+        Field(
+            description='Property IDs this agent is authorized for. Resolved against the top-level properties array in this file',
+            min_length=1,
+        ),
+    ]
+    url: Annotated[AnyUrl, Field(description="The authorized agent's API endpoint URL")]
+
+
+class AuthorizedAgents1(AdCPBaseModel):
+    model_config = ConfigDict(
+        extra='forbid',
+    )
+    authorization_type: Annotated[
+        Literal['property_tags'],
+        Field(description='Discriminator indicating authorization by property tags'),
+    ]
+    authorized_for: Annotated[
+        str,
+        Field(
+            description='Human-readable description of what this agent is authorized to sell',
+            max_length=500,
+            min_length=1,
+        ),
+    ]
+    property_tags: Annotated[
+        list[property_tag.PropertyTag],
+        Field(
+            description='Tags identifying which properties this agent is authorized for. Resolved against the top-level properties array in this file using tag matching',
+            min_length=1,
+        ),
+    ]
+    url: Annotated[AnyUrl, Field(description="The authorized agent's API endpoint URL")]
+
+
 class AuthorizedAgents2(AdCPBaseModel):
     model_config = ConfigDict(
         extra='forbid',

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/types/generated_poc/property.py

@@ -1,15 +1,15 @@
 # generated by datamodel-codegen:
 #   filename:  property.json
-#   timestamp: 2025-11-21T12:49:05+00:00
+#   timestamp: 2025-11-21T20:45:16+00:00
 
 from __future__ import annotations
 
 from typing import Annotated
 
 from adcp.types.base import AdCPBaseModel
-from pydantic import ConfigDict, Field, RootModel
+from pydantic import ConfigDict, Field
 
-from . import identifier_types
+from . import identifier_types, property_tag
 from . import property_type as property_type_1
 
 
@@ -29,16 +29,6 @@ class Identifier(AdCPBaseModel):
     ]
 
 
-class Tag(RootModel[str]):
-    root: Annotated[
-        str,
-        Field(
-            description="Lowercase tag with underscores (e.g., 'conde_nast_network', 'premium_content')",
-            pattern='^[a-z0-9_]+$',
-        ),
-    ]
-
-
 class Property(AdCPBaseModel):
     model_config = ConfigDict(
         extra='forbid',
@@ -50,8 +40,10 @@ class Property(AdCPBaseModel):
     property_id: Annotated[
         str | None,
         Field(
-            description="Unique identifier for this property (optional). Enables referencing properties by ID instead of repeating full objects. Recommended format: lowercase with underscores (e.g., 'cnn_ctv_app', 'instagram_mobile')",
+            description='Unique identifier for this property (optional). Enables referencing properties by ID instead of repeating full objects.',
+            examples=['cnn_ctv_app', 'homepage', 'mobile_ios', 'instagram'],
             pattern='^[a-z0-9_]+$',
+            title='Property ID',
         ),
     ] = None
     property_type: Annotated[
@@ -64,7 +56,7 @@ class Property(AdCPBaseModel):
         ),
     ] = None
     tags: Annotated[
-        list[Tag] | None,
+        list[property_tag.PropertyTag] | None,
         Field(
             description='Tags for categorization and grouping (e.g., network membership, content categories)'
         ),

adcp-2.11.1/src/adcp/types/generated_poc/property_id.py

@@ -0,0 +1,21 @@
+# generated by datamodel-codegen:
+#   filename:  property-id.json
+#   timestamp: 2025-11-21T20:45:16+00:00
+
+from __future__ import annotations
+
+from typing import Annotated
+
+from pydantic import Field, RootModel
+
+
+class PropertyId(RootModel[str]):
+    root: Annotated[
+        str,
+        Field(
+            description='Identifier for a publisher property. Must be lowercase alphanumeric with underscores only.',
+            examples=['cnn_ctv_app', 'homepage', 'mobile_ios', 'instagram'],
+            pattern='^[a-z0-9_]+$',
+            title='Property ID',
+        ),
+    ]

adcp-2.11.1/src/adcp/types/generated_poc/property_tag.py

@@ -0,0 +1,21 @@
+# generated by datamodel-codegen:
+#   filename:  property-tag.json
+#   timestamp: 2025-11-21T20:45:16+00:00
+
+from __future__ import annotations
+
+from typing import Annotated
+
+from pydantic import Field, RootModel
+
+
+class PropertyTag(RootModel[str]):
+    root: Annotated[
+        str,
+        Field(
+            description='Tag for categorizing publisher properties. Must be lowercase alphanumeric with underscores only.',
+            examples=['ctv', 'premium', 'news', 'sports', 'meta_network', 'social_media'],
+            pattern='^[a-z0-9_]+$',
+            title='Property Tag',
+        ),
+    ]

{adcp-2.11.0 → adcp-2.11.1}/src/adcp/types/generated_poc/publisher_property_selector.py

@@ -1,13 +1,15 @@
 # generated by datamodel-codegen:
 #   filename:  publisher-property-selector.json
-#   timestamp: 2025-11-19T02:02:39+00:00
+#   timestamp: 2025-11-21T20:45:16+00:00
 
 from __future__ import annotations
 
 from typing import Annotated, Literal
 
 from adcp.types.base import AdCPBaseModel
-from pydantic import ConfigDict, Field, RootModel
+from pydantic import ConfigDict, Field
+
+from . import property_id, property_tag
 
 
 class PublisherPropertySelector1(AdCPBaseModel):
@@ -29,16 +31,12 @@ class PublisherPropertySelector1(AdCPBaseModel):
     ]
 
 
-class PropertyId(RootModel[str]):
-    root: Annotated[str, Field(pattern='^[a-z0-9_]+$')]
-
-
 class PublisherPropertySelector2(AdCPBaseModel):
     model_config = ConfigDict(
         extra='forbid',
     )
     property_ids: Annotated[
-        list[PropertyId],
+        list[property_id.PropertyId],
         Field(description="Specific property IDs from the publisher's adagents.json", min_length=1),
     ]
     publisher_domain: Annotated[
@@ -54,16 +52,12 @@ class PublisherPropertySelector2(AdCPBaseModel):
     ]
 
 
-class PropertyTag(PropertyId):
-    pass
-
-
 class PublisherPropertySelector3(AdCPBaseModel):
     model_config = ConfigDict(
         extra='forbid',
     )
     property_tags: Annotated[
-        list[PropertyTag],
+        list[property_tag.PropertyTag],
         Field(
             description="Property tags from the publisher's adagents.json. Selector covers all properties with these tags",
             min_length=1,

{adcp-2.11.0 → adcp-2.11.1/src/adcp.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: adcp
-Version: 2.11.0
+Version: 2.11.1
 Summary: Official Python client for the Ad Context Protocol (AdCP)
 Author-email: AdCP Community <maintainers@adcontextprotocol.org>
 License: Apache-2.0

{adcp-2.11.0 → adcp-2.11.1}/src/adcp.egg-info/SOURCES.txt

@@ -120,6 +120,8 @@ src/adcp/types/generated_poc/product_filters.py
 src/adcp/types/generated_poc/promoted_offerings.py
 src/adcp/types/generated_poc/promoted_products.py
 src/adcp/types/generated_poc/property.py
+src/adcp/types/generated_poc/property_id.py
+src/adcp/types/generated_poc/property_tag.py
 src/adcp/types/generated_poc/property_type.py
 src/adcp/types/generated_poc/protocol_envelope.py
 src/adcp/types/generated_poc/provide_performance_feedback_request.py

{adcp-2.11.0 → adcp-2.11.1}/tests/test_discriminated_unions.py

@@ -769,3 +769,78 @@ class TestSemanticAliasDiscriminatorRoundtrips:
         parsed = TextSubAsset.model_validate_json(json_str)
         assert parsed.asset_kind == "text"
         assert parsed.content == original.content
+
+
+class TestPropertyTagSharedSchema:
+    """Test that PropertyTag uses shared schema definition.
+
+    As of AdCP v1.0.0, PropertyTag and PropertyId are defined in separate shared
+    schema files (property-tag.json and property-id.json) that are referenced by
+    both adagents.json and publisher-property-selector.json.
+
+    This eliminates the previous name collision where both files defined their own
+    identical PropertyTag types.
+    """
+
+    def test_public_property_tag_is_from_shared_schema(self):
+        """Public PropertyTag should be from the shared property_tag schema."""
+        from adcp import PropertyTag
+
+        # Should come from the shared schema, not embedded in another schema
+        assert PropertyTag.__module__ == "adcp.types.generated_poc.property_tag"
+
+    def test_property_id_is_from_shared_schema(self):
+        """Public PropertyId should be from the shared property_id schema."""
+        from adcp import PropertyId
+
+        # Should come from the shared schema
+        assert PropertyId.__module__ == "adcp.types.generated_poc.property_id"
+
+    def test_property_tag_works_with_publisher_properties_by_tag(self):
+        """PropertyTag should work correctly with PublisherPropertiesByTag."""
+        from adcp import PropertyTag, PublisherPropertiesByTag
+
+        props = PublisherPropertiesByTag(
+            publisher_domain="example.com",
+            selection_type="by_tag",
+            property_tags=[PropertyTag("premium"), PropertyTag("video")]
+        )
+
+        assert props.selection_type == "by_tag"
+        assert len(props.property_tags) == 2
+        assert str(props.property_tags[0].root) == "premium"
+        assert str(props.property_tags[1].root) == "video"
+
+    def test_shared_schema_prevents_collision(self):
+        """Verify that both adagents and publisher_property_selector import from shared schema."""
+        from adcp.types.generated_poc import property_tag
+        from adcp import PropertyTag
+
+        # The shared schema is the canonical definition
+        assert PropertyTag is property_tag.PropertyTag
+
+        # Both adagents.py and publisher_property_selector.py should import from property_tag module
+        # (not define their own)
+        import inspect
+        import adcp.types.generated_poc.adagents as adagents_module
+        import adcp.types.generated_poc.publisher_property_selector as selector_module
+
+        # Check that they import from property_tag, not define their own
+        adagents_source = inspect.getsource(adagents_module)
+        selector_source = inspect.getsource(selector_module)
+
+        # May be on same line as other imports or separate line
+        assert "property_tag" in adagents_source and "from . import" in adagents_source
+        assert "property_tag" in selector_source and "from . import" in selector_source
+
+    def test_property_tag_validation(self):
+        """PropertyTag should validate according to shared schema rules."""
+        from adcp import PropertyTag
+
+        # Valid tags: lowercase alphanumeric + underscores
+        valid = PropertyTag("premium_video")
+        assert str(valid.root) == "premium_video"
+
+        # Pattern validation should work
+        with pytest.raises(ValidationError):
+            PropertyTag("Invalid-Tag")  # Hyphens not allowed in property tags

{adcp-2.11.0 → adcp-2.11.1}/tests/test_type_aliases.py

@@ -430,8 +430,14 @@ def test_publisher_properties_aliases_in_exports():
 
 
 def test_property_id_and_tag_are_root_models():
-    """Test that PropertyId and PropertyTag are properly constrained string types."""
+    """Test that PropertyId and PropertyTag are properly constrained string types.
+
+    As of AdCP v1.0.0, PropertyId and PropertyTag are separate RootModel types
+    defined in their own schema files, not in an inheritance relationship.
+    Both use the same pattern constraint (^[a-z0-9_]+$) but are semantically distinct.
+    """
     from adcp import PropertyId, PropertyTag
+    from pydantic import RootModel
 
     # Create valid PropertyId and PropertyTag
     prop_id = PropertyId("my_property_id")
@@ -441,8 +447,14 @@ def test_property_id_and_tag_are_root_models():
     assert prop_id.root == "my_property_id"
     assert prop_tag.root == "premium"
 
-    # PropertyTag should be a subclass of PropertyId
-    assert issubclass(PropertyTag, PropertyId)
+    # Both should be RootModel subclasses (but not related to each other)
+    assert issubclass(PropertyId, RootModel)
+    assert issubclass(PropertyTag, RootModel)
+
+    # They are separate types, not in an inheritance relationship
+    assert PropertyId is not PropertyTag
+    assert not issubclass(PropertyTag, PropertyId)
+    assert not issubclass(PropertyId, PropertyTag)
 
 
 def test_deployment_aliases_imports():