acp-sdk 0.12.2__tar.gz → 0.12.3__tar.gz

{acp_sdk-0.12.2 → acp_sdk-0.12.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: acp-sdk
-Version: 0.12.2
+Version: 0.12.3
 Summary: Agent Communication Protocol SDK
 Author: IBM Corp.
 Maintainer-email: Tomas Pilar <thomas7pilar@gmail.com>

{acp_sdk-0.12.2 → acp_sdk-0.12.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "acp-sdk"
-version = "0.12.2"
+version = "0.12.3"
 description = "Agent Communication Protocol SDK"
 license = "Apache-2.0"
 readme = "README.md"

{acp_sdk-0.12.2 → acp_sdk-0.12.3}/src/acp_sdk/client/client.py

@@ -252,15 +252,10 @@ class Client:
                 base_url=base_url or self._session_last_refresh_base_url,
             )
 
-            try:
-                response = await self._client.get(url, timeout=timeout)
-                response = SessionReadResponse.model_validate(response.json())
-                self._session = Session(**response.model_dump())
-            except ACPError as e:
-                if e.error.code == ErrorCode.NOT_FOUND:
-                    pass
-                raise e
-
+            response = await self._client.get(url, timeout=timeout)
+            self._raise_error(response)
+            response = SessionReadResponse.model_validate(response.json())
+            self._session = Session(**response.model_dump())
             return self._session
 
     async def _validate_stream(
@@ -304,13 +299,11 @@ class Client:
 
         target_base_url = self._create_base_url(base_url=base_url)
         try:
-            if not self._session_last_refresh_base_url:
-                return {"session": self._session}
             if self._session_last_refresh_base_url == target_base_url:
                 # Same server, no need to forward session
                 return {"session_id": self._session.id}
 
-            session = await self.refresh_session()
+            session = await self.refresh_session(base_url=self._session_last_refresh_base_url or target_base_url)
             return {"session": session}
         except ACPError as e:
             if e.error.code == ErrorCode.NOT_FOUND:

{acp_sdk-0.12.2 → acp_sdk-0.12.3}/tests/e2e/test_suites/test_sessions.py

@@ -6,6 +6,7 @@ from acp_sdk.models import (
     Message,
     MessagePart,
 )
+from acp_sdk.models.models import Session
 from acp_sdk.server import Server
 
 agent = "history_echo"
@@ -31,6 +32,20 @@ async def test_session_refresh(server: Server, client: Client) -> None:
         assert len(sess.history) == len(input) * 2
 
 
+@pytest.mark.asyncio
+async def test_session_multi_client(server: Server, client: Client) -> None:
+    session = Session()
+
+    async with client.session(session) as session_client:
+        run = await session_client.run_sync(input, agent=agent)
+        assert run.output == output
+        print(run.session_id)
+
+    async with client.session(session) as session_client:
+        run = await session_client.run_sync(input, agent=agent)
+        assert run.output == output * 3
+
+
 @pytest.mark.asyncio
 async def test_distributed_session(multi_server: tuple[Server, Server]) -> None:
     one, two = multi_server

{acp_sdk-0.12.2 → acp_sdk-0.12.3}/tests/unit/client/test_client.py

@@ -176,23 +176,28 @@ async def test_run_events(httpx_mock: HTTPXMock) -> None:
 @pytest.mark.asyncio
 async def test_session(httpx_mock: HTTPXMock) -> None:
     httpx_mock.add_response(url="http://test/runs", method="POST", content=mock_run.model_dump_json(), is_reusable=True)
+    httpx_mock.add_response(
+        url=f"http://test/sessions/{mock_session.id}",
+        method="GET",
+        content=mock_session.model_dump_json(),
+        is_reusable=True,
+    )
 
-    async with Client(base_url="http://test") as client, client.session(Session(id=mock_run.session_id)) as session:
-        assert session._session.id == mock_run.session_id
+    async with Client(base_url="http://test") as client, client.session(mock_session) as session:
         await session.run_sync("Howdy!", agent=mock_run.agent_name)
         await session.run_sync("Howdy!", agent=mock_run.agent_name)
         await client.run_sync("Howdy!", agent=mock_run.agent_name)
 
     requests = httpx_mock.get_requests()
-    body = json.loads(requests[0].content)
+    body = json.loads(requests[1].content)
     # First request gets full session
     assert body["session"]["id"] == str(mock_run.session_id)
 
-    body = json.loads(requests[1].content)
+    body = json.loads(requests[2].content)
     # Second sends just the ID
     assert body["session_id"] == str(mock_run.session_id)
 
-    body = json.loads(requests[2].content)
+    body = json.loads(requests[3].content)
     assert body["session_id"] is None
     assert body["session"] is None