WuttaWeb 0.14.2__tar.gz → 0.16.0__tar.gz

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/CHANGELOG.md

@@ -5,6 +5,30 @@ All notable changes to wuttaweb will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## v0.16.0 (2024-12-05)
+
+### Feat
+
+- add `get_template_context()` method for master view
+
+### Fix
+
+- add option for People entry in the Admin menu
+- fix handling of `Upgrade.uuid`
+- improve support for random objects with grid, master view
+- hide CRUD header buttons if master view does not allow
+
+## v0.15.0 (2024-11-24)
+
+### Feat
+
+- add logic to prevent edit for some user accounts
+
+### Fix
+
+- fix default form value logic for bool checkbox fields
+- always use configured app dist for appinfo/index page
+
 ## v0.14.2 (2024-11-24)
 
 ### Fix

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/PKG-INFO

@@ -1,11 +1,12 @@
 Metadata-Version: 2.3
 Name: WuttaWeb
-Version: 0.14.2
+Version: 0.16.0
 Summary: Web App for Wutta Framework
 Project-URL: Homepage, https://wuttaproject.org/
 Project-URL: Repository, https://forgejo.wuttaproject.org/wutta/wuttaweb
+Project-URL: Issues, https://forgejo.wuttaproject.org/wutta/wuttaweb/issues
 Project-URL: Changelog, https://forgejo.wuttaproject.org/wutta/wuttaweb/src/branch/master/CHANGELOG.md
-Author-email: Lance Edgar <lance@edbob.org>
+Author-email: Lance Edgar <lance@wuttaproject.org>
 License: GNU GPL v3+
 Classifier: Development Status :: 4 - Beta
 Classifier: Environment :: Web Environment
@@ -35,7 +36,7 @@ Requires-Dist: pyramid-tm
 Requires-Dist: pyramid>=2
 Requires-Dist: waitress
 Requires-Dist: webhelpers2
-Requires-Dist: wuttjamaican[db]>=0.14.0
+Requires-Dist: wuttjamaican[db]>=0.16.1
 Requires-Dist: zope-sqlalchemy>=1.5
 Provides-Extra: continuum
 Requires-Dist: wutta-continuum; extra == 'continuum'

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/pyproject.toml

@@ -6,10 +6,10 @@ build-backend = "hatchling.build"
 
 [project]
 name = "WuttaWeb"
-version = "0.14.2"
+version = "0.16.0"
 description = "Web App for Wutta Framework"
 readme = "README.md"
-authors = [{name = "Lance Edgar", email = "lance@edbob.org"}]
+authors = [{name = "Lance Edgar", email = "lance@wuttaproject.org"}]
 license = {text = "GNU GPL v3+"}
 classifiers = [
         "Development Status :: 4 - Beta",
@@ -42,7 +42,7 @@ dependencies = [
         "pyramid_tm",
         "waitress",
         "WebHelpers2",
-        "WuttJamaican[db]>=0.14.0",
+        "WuttJamaican[db]>=0.16.1",
         "zope.sqlalchemy>=1.5",
 ]
 
@@ -68,6 +68,7 @@ wuttaweb = "wuttaweb.conf:WuttaWebConfigExtension"
 [project.urls]
 Homepage = "https://wuttaproject.org/"
 Repository = "https://forgejo.wuttaproject.org/wutta/wuttaweb"
+Issues = "https://forgejo.wuttaproject.org/wutta/wuttaweb/issues"
 Changelog = "https://forgejo.wuttaproject.org/wutta/wuttaweb/src/branch/master/CHANGELOG.md"
 
 

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/forms/base.py

@@ -1002,7 +1002,7 @@ class Form:
             # for now we explicitly translate here, ugh.  also
             # note this does not yet allow for null values.. :(
             if isinstance(field.typ, colander.Boolean):
-                value = True if field.typ.true_val else False
+                value = True if value == field.typ.true_val else False
 
             model_data[field.oid] = make_json_safe(value)
 

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/grids/base.py

@@ -1940,6 +1940,15 @@ class Grid:
             })
         return filters
 
+    def object_to_dict(self, obj):
+        """ """
+        try:
+            dct = dict(obj)
+        except TypeError:
+            dct = dict(obj.__dict__)
+            dct.pop('_sa_instance_state', None)
+        return dct
+
     def get_vue_context(self):
         """
         Returns a dict of context for the grid, for use with the Vue
@@ -1976,7 +1985,7 @@ class Grid:
             original_record = record
 
             # convert record to new dict
-            record = dict(record)
+            record = self.object_to_dict(record)
 
             # make all values safe for json
             record = make_json_safe(record, warn=False)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/menus.py

@@ -142,38 +142,54 @@ class MenuHandler(GenericHandler):
         The return value for this method should be a *single* dict,
         which will ultimately be one element of the final list of
         dicts as described in :class:`MenuHandler`.
+
+        :param include_people: You can pass this flag to indicate the
+           admin menu should contain an entry for the "People" view.
         """
+        items = []
+
+        if kwargs.get('include_people'):
+            items.extend([
+                {
+                    'title': "All People",
+                    'route': 'people',
+                    'perm': 'people.list',
+                },
+            ])
+
+        items.extend([
+            {
+                'title': "Users",
+                'route': 'users',
+                'perm': 'users.list',
+            },
+            {
+                'title': "Roles",
+                'route': 'roles',
+                'perm': 'roles.list',
+            },
+            {'type': 'sep'},
+            {
+                'title': "App Info",
+                'route': 'appinfo',
+                'perm': 'appinfo.list',
+            },
+            {
+                'title': "Raw Settings",
+                'route': 'settings',
+                'perm': 'settings.list',
+            },
+            {
+                'title': "Upgrades",
+                'route': 'upgrades',
+                'perm': 'upgrades.list',
+            },
+        ])
+
         return {
             'title': "Admin",
             'type': 'menu',
-            'items': [
-                {
-                    'title': "Users",
-                    'route': 'users',
-                    'perm': 'users.list',
-                },
-                {
-                    'title': "Roles",
-                    'route': 'roles',
-                    'perm': 'roles.list',
-                },
-                {'type': 'sep'},
-                {
-                    'title': "App Info",
-                    'route': 'appinfo',
-                    'perm': 'appinfo.list',
-                },
-                {
-                    'title': "Raw Settings",
-                    'route': 'settings',
-                    'perm': 'settings.list',
-                },
-                {
-                    'title': "Upgrades",
-                    'route': 'upgrades',
-                    'perm': 'upgrades.list',
-                },
-            ],
+            'items': items,
         }
 
     ##############################

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/templates/appinfo/index.mako

@@ -8,10 +8,10 @@
     <div class="panel-block">
       <div style="width: 100%;">
         <b-field horizontal label="Distribution">
-          <span>${app.get_distribution(obj=app.get_web_handler()) or f'?? - set config for `{app.appname}.app_dist`'}</span>
+          <span>${app.get_distribution() or f'?? - set config for `{app.appname}.app_dist`'}</span>
         </b-field>
         <b-field horizontal label="Version">
-          <span>${app.get_version(obj=app.get_web_handler()) or f'?? - set config for `{app.appname}.app_dist`'}</span>
+          <span>${app.get_version() or f'?? - set config for `{app.appname}.app_dist`'}</span>
         </b-field>
         <b-field horizontal label="App Title">
           <span>${app.get_title()}</span>

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/templates/base.mako

@@ -661,7 +661,9 @@
               </a>
               ${h.end_form()}
           % endif
-          ${h.link_to("Change Password", url('change_password'), class_='navbar-item')}
+          % if request.is_root or not request.user.prevent_edit:
+              ${h.link_to("Change Password", url('change_password'), class_='navbar-item')}
+          % endif
           ${h.link_to("Logout", url('logout'), class_='navbar-item')}
         </div>
       </div>
@@ -680,13 +682,13 @@
 <%def name="render_crud_header_buttons()">
   % if master:
       % if master.viewing:
-          % if instance_editable and master.has_perm('edit'):
+          % if master.editable and instance_editable and master.has_perm('edit'):
               <wutta-button once
                             tag="a" href="${master.get_action_url('edit', instance)}"
                             icon-left="edit"
                             label="Edit This" />
           % endif
-          % if instance_deletable and master.has_perm('delete'):
+          % if master.deletable and instance_deletable and master.has_perm('delete'):
               <wutta-button once type="is-danger"
                             tag="a" href="${master.get_action_url('delete', instance)}"
                             icon-left="trash"
@@ -699,7 +701,7 @@
                             icon-left="eye"
                             label="View This" />
           % endif
-          % if instance_deletable and master.has_perm('delete'):
+          % if master.deletable and instance_deletable and master.has_perm('delete'):
               <wutta-button once type="is-danger"
                             tag="a" href="${master.get_action_url('delete', instance)}"
                             icon-left="trash"
@@ -712,7 +714,7 @@
                             icon-left="eye"
                             label="View This" />
           % endif
-          % if instance_editable and master.has_perm('edit'):
+          % if master.editable and instance_editable and master.has_perm('edit'):
               <wutta-button once
                             tag="a" href="${master.get_action_url('edit', instance)}"
                             icon-left="edit"

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/views/auth.py

@@ -157,6 +157,9 @@ class AuthView(View):
         if not self.request.user:
             return self.redirect(self.request.route_url('home'))
 
+        if self.request.user.prevent_edit:
+            raise self.forbidden()
+
         form = self.make_form(schema=self.change_password_make_schema(),
                               show_button_cancel=False,
                               show_button_reset=True)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/views/master.py

@@ -1629,6 +1629,9 @@ class MasterView(View):
             if 'instance_deletable' not in context:
                 context['instance_deletable'] = self.is_deletable(instance)
 
+        # supplement context further if needed
+        context = self.get_template_context(context)
+
         # first try the template path most specific to this view
         template_prefix = self.get_template_prefix()
         mako_path = f'{template_prefix}/{template}.mako'
@@ -1648,6 +1651,26 @@ class MasterView(View):
             # let that error raise on up
             return render_to_response(mako_path, context, request=self.request)
 
+    def get_template_context(self, context):
+        """
+        This method should return the "complete" context for rendering
+        the current view template.
+
+        Default logic for this method returns the given context
+        unchanged.
+
+        You may wish to override to pass extra context to the view
+        template.  Check :attr:`viewing` and similar, or
+        ``request.current_route_name`` etc. in order to add extra
+        context only for certain view templates.
+
+        :params: context: The context dict we have so far,
+           auto-provided by the master view logic.
+
+        :returns: Final context dict for the template.
+        """
+        return context
+
     def get_fallback_templates(self, template):
         """
         Returns a list of "fallback" template paths which may be
@@ -1995,8 +2018,12 @@ class MasterView(View):
         :param obj: Model instance object.
         """
         route_prefix = self.get_route_prefix()
-        kw = dict([(key, obj[key])
-                   for key in self.get_model_key()])
+        try:
+            kw = dict([(key, obj[key])
+                       for key in self.get_model_key()])
+        except TypeError:
+            kw = dict([(key, getattr(obj, key))
+                       for key in self.get_model_key()])
         kw.update(kwargs)
         return self.request.route_url(f'{route_prefix}.{action}', **kw)
 

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/views/upgrades.py

@@ -217,7 +217,7 @@ class UpgradeView(MasterView):
 
     def get_upgrade_filepath(self, upgrade, filename=None, create=True):
         """ """
-        uuid = upgrade.uuid
+        uuid = str(upgrade.uuid)
         path = self.app.get_appdir('data', 'upgrades', uuid[:2], uuid[2:],
                                    create=create)
         if filename:

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/views/users.py

@@ -95,6 +95,15 @@ class UserView(MasterView):
         if not user.active:
             return 'has-background-warning'
 
+    def is_editable(self, user):
+        """ """
+
+        # only root can edit certain users
+        if user.prevent_edit and not self.request.is_root:
+            return False
+
+        return True
+
     def configure_form(self, f):
         """ """
         super().configure_form(f)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/grids/test_base.py

@@ -1373,6 +1373,25 @@ class TestGrid(WebTestCase):
         filters = grid.get_vue_filters()
         self.assertEqual(len(filters), 2)
 
+    def test_object_to_dict(self):
+        grid = self.make_grid()
+        setting = {'name': 'foo', 'value': 'bar'}
+
+        # new dict but with same values
+        dct = grid.object_to_dict(setting)
+        self.assertIsInstance(dct, dict)
+        self.assertIsNot(dct, setting)
+        self.assertEqual(dct, setting)
+
+        # random object, not iterable
+        class MockSetting:
+            def __init__(self, **kw):
+                self.__dict__.update(kw)
+        mock = MockSetting(**setting)
+        dct = grid.object_to_dict(mock)
+        self.assertIsInstance(dct, dict)
+        self.assertEqual(dct, setting)
+
     def test_get_vue_context(self):
 
         # empty if no columns defined

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/test_menus.py

@@ -14,8 +14,17 @@ class TestMenuHandler(WebTestCase):
         self.handler = mod.MenuHandler(self.config)
 
     def test_make_admin_menu(self):
-        menus = self.handler.make_admin_menu(self.request)
-        self.assertIsInstance(menus, dict)
+
+        # no people entry by default
+        menu = self.handler.make_admin_menu(self.request)
+        self.assertIsInstance(menu, dict)
+        routes = [item.get('route') for item in menu['items']]
+        self.assertNotIn('people', routes)
+
+        # but we can request it
+        menu = self.handler.make_admin_menu(self.request, include_people=True)
+        routes = [item.get('route') for item in menu['items']]
+        self.assertIn('people', routes)
 
     def test_make_menus(self):
         menus = self.handler.make_menus(self.request)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/views/test_auth.py

@@ -80,11 +80,18 @@ class TestAuthView(WebTestCase):
         redirect = view.change_password()
         self.assertIsInstance(redirect, HTTPFound)
 
-        # now "login" the user, and set initial password
-        self.request.user = barney
+        # set initial password
         auth.set_user_password(barney, 'foo')
         self.session.commit()
 
+        # forbidden if prevent_edit is set for user
+        self.request.user = barney
+        barney.prevent_edit = True
+        self.assertRaises(HTTPForbidden, view.change_password)
+
+        # okay let's test with edit allowed
+        barney.prevent_edit = False
+
         # view should now return context w/ form
         context = view.change_password()
         self.assertIn('form', context)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/views/test_master.py

@@ -734,6 +734,41 @@ class TestMasterView(WebTestCase):
             self.request.matchdict = {'name': 'blarg'}
             self.assertRaises(HTTPNotFound, view.get_instance, session=self.session)
 
+    def test_get_action_url_for_dict(self):
+        model = self.app.model
+        setting = {'name': 'foo', 'value': 'bar'}
+        with patch.multiple(mod.MasterView, create=True,
+                            model_class=model.Setting):
+            mod.MasterView.defaults(self.pyramid_config)
+            view = self.make_view()
+            url = view.get_action_url_view(setting, 0)
+            self.assertEqual(url, self.request.route_url('settings.view', name='foo'))
+
+    def test_get_action_url_for_orm_object(self):
+        model = self.app.model
+        setting = model.Setting(name='foo', value='bar')
+        self.session.add(setting)
+        self.session.commit()
+        with patch.multiple(mod.MasterView, create=True,
+                            model_class=model.Setting):
+            mod.MasterView.defaults(self.pyramid_config)
+            view = self.make_view()
+            url = view.get_action_url_view(setting, 0)
+            self.assertEqual(url, self.request.route_url('settings.view', name='foo'))
+
+    def test_get_action_url_for_adhoc_object(self):
+        model = self.app.model
+        class MockSetting:
+            def __init__(self, **kw):
+                self.__dict__.update(kw)
+        setting = MockSetting(name='foo', value='bar')
+        with patch.multiple(mod.MasterView, create=True,
+                            model_class=model.Setting):
+            mod.MasterView.defaults(self.pyramid_config)
+            view = self.make_view()
+            url = view.get_action_url_view(setting, 0)
+            self.assertEqual(url, self.request.route_url('settings.view', name='foo'))
+
     def test_get_action_url_view(self):
         model = self.app.model
         setting = model.Setting(name='foo', value='bar')

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/views/test_upgrades.py

@@ -127,7 +127,7 @@ class TestUpgradeView(WebTestCase):
         self.session.commit()
 
         view = self.make_view()
-        uuid = upgrade.uuid
+        uuid = str(upgrade.uuid)
 
         # no filename
         path = view.download_path(upgrade, None)
@@ -153,7 +153,7 @@ class TestUpgradeView(WebTestCase):
         self.session.commit()
 
         view = self.make_view()
-        uuid = upgrade.uuid
+        uuid = str(upgrade.uuid)
 
         # no filename
         path = view.get_upgrade_filepath(upgrade)

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/tests/views/test_users.py

@@ -42,6 +42,26 @@ class TestUserView(WebTestCase):
         user.active = False
         self.assertEqual(view.grid_row_class(user, data, 1), 'has-background-warning')
 
+    def test_is_editable(self):
+        model = self.app.model
+        view = self.make_view()
+
+        # active user is editable
+        user = model.User(username='barney', active=True)
+        self.assertTrue(view.is_editable(user))
+
+        # inactive also editable
+        user = model.User(username='barney', active=False)
+        self.assertTrue(view.is_editable(user))
+
+        # but not if prevent_edit flag is set
+        user = model.User(username='barney', prevent_edit=True)
+        self.assertFalse(view.is_editable(user))
+
+        # unless request user is root
+        self.request.is_root = True
+        self.assertTrue(view.is_editable(user))
+
     def test_configure_form(self):
         model = self.app.model
         barney = model.User(username='barney')

{wuttaweb-0.14.2 → wuttaweb-0.16.0}/src/wuttaweb/views/essential.py

@@ -29,8 +29,8 @@ Most apps should include this module::
 
 That will in turn include the following modules:
 
-* :mod:`wuttaweb.views.auth`
 * :mod:`wuttaweb.views.common`
+* :mod:`wuttaweb.views.auth`
 * :mod:`wuttaweb.views.settings`
 * :mod:`wuttaweb.views.progress`
 * :mod:`wuttaweb.views.people`
@@ -43,8 +43,8 @@ That will in turn include the following modules:
 def defaults(config, **kwargs):
     mod = lambda spec: kwargs.get(spec, spec)
 
-    config.include(mod('wuttaweb.views.auth'))
     config.include(mod('wuttaweb.views.common'))
+    config.include(mod('wuttaweb.views.auth'))
     config.include(mod('wuttaweb.views.settings'))
     config.include(mod('wuttaweb.views.progress'))
     config.include(mod('wuttaweb.views.people'))