VirtualDesktop 1.6.1__tar.gz → 1.6.2__tar.gz

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: VirtualDesktop
-Version: 1.6.1
+Version: 1.6.2
 Summary: win10-win11 虚拟桌面
 Author: VirtualDesktop contributors
 License: MIT License
@@ -575,6 +575,7 @@ with space.record_stream("run.gif", target=window, fps=8, duration=5) as stream:
 | `fps` | 目标帧率（必填，默认 10）。低于目标会被丢弃并计入 `report().dropped` |
 | `duration` | 秒；到点自动停止，`stopped_by="duration"` |
 | `max_frames` | 帧数上限；到点自动停止，`stopped_by="max_frames"` |
+| — | 不传 `duration` 时有一个 **1 小时硬上限**（`MAX_DURATION`）：录制线程持有 `Recorder` 引用，被丢弃且未 `stop()` 的对象无法回收，没有上限就会一直录下去（并带着 ffmpeg 子进程）。正常用法请始终用 `with` |
 | `quality` | 见上方格式表；不同后端含义不同 |
 | `format` | 覆盖扩展名推断 |
 | `on_frame` | `(frame, index)` 回调，每帧一次；回调抛异常不会中断录制 |

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/README.md

@@ -518,6 +518,7 @@ with space.record_stream("run.gif", target=window, fps=8, duration=5) as stream:
 | `fps` | 目标帧率（必填，默认 10）。低于目标会被丢弃并计入 `report().dropped` |
 | `duration` | 秒；到点自动停止，`stopped_by="duration"` |
 | `max_frames` | 帧数上限；到点自动停止，`stopped_by="max_frames"` |
+| — | 不传 `duration` 时有一个 **1 小时硬上限**（`MAX_DURATION`）：录制线程持有 `Recorder` 引用，被丢弃且未 `stop()` 的对象无法回收，没有上限就会一直录下去（并带着 ffmpeg 子进程）。正常用法请始终用 `with` |
 | `quality` | 见上方格式表；不同后端含义不同 |
 | `format` | 覆盖扩展名推断 |
 | `on_frame` | `(frame, index)` 回调，每帧一次；回调抛异常不会中断录制 |

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/VirtualDesktop/__init__.py

@@ -72,7 +72,7 @@ from .record import (
     supported_formats,
 )
 
-__version__ = "1.6.1"
+__version__ = "1.6.2"
 
 __all__ = [
     "__version__",

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/VirtualDesktop/record.py

@@ -59,6 +59,7 @@ log = get_logger("record")
 __all__ = [
     "GIF_FORMATS",
     "IMAGE_FORMATS",
+    "MAX_DURATION",
     "Recorder",
     "RecordingReport",
     "VIDEO_FORMATS",
@@ -78,6 +79,13 @@ IMAGE_FORMATS = (".png", ".jpg", ".jpeg", ".webp", ".bmp", ".tif", ".tiff")
 #: Frames are passed to ffmpeg as PNG, which is lossless and avoids a second generation of loss.
 _PIPE_PIXEL_FORMAT = "rgb24"
 
+#: Hard ceiling on a single recording, in seconds, used when the caller gives no ``duration``.
+#: It exists so an abandoned recorder cannot capture forever: the capture thread holds a reference
+#: to its ``Recorder``, so one that is dropped without ``stop()`` is never collected and would
+#: otherwise keep its ffmpeg child alive indefinitely.  Callers that want a longer recording pass an
+#: explicit larger ``duration``.
+MAX_DURATION = 3600.0
+
 
 def supported_formats(ffmpeg: Optional[str] = None) -> Dict[str, str]:
     """Which extensions this machine can write, and what writes them."""
@@ -420,13 +428,18 @@ class Recorder:
 
     # -- internals -------------------------------------------------------------------
     def _run(self) -> None:
-        deadline = None if self.duration is None else self._started + self.duration
+        # A hard ceiling as well as the caller's own limit.  The thread keeps a reference to this
+        # recorder while it runs, so a recorder that is dropped without ``stop()`` cannot be
+        # collected and would otherwise capture forever — and its ffmpeg child with it.  With the
+        # ceiling, an abandoned recorder finalises itself and exits.
+        requested = self.duration if self.duration is not None else MAX_DURATION
+        deadline = self._started + min(requested, MAX_DURATION)
         next_at = self._started
         try:
             while not self._stop.is_set():
                 now = time.monotonic()
-                if deadline is not None and now >= deadline:
-                    self._stopped_by = "duration"
+                if now >= deadline:
+                    self._stopped_by = "duration" if self.duration is not None else "max_duration"
                     break
                 if self.max_frames is not None and self._frames >= self.max_frames:
                     self._stopped_by = "max_frames"

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/VirtualDesktop.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: VirtualDesktop
-Version: 1.6.1
+Version: 1.6.2
 Summary: win10-win11 虚拟桌面
 Author: VirtualDesktop contributors
 License: MIT License
@@ -575,6 +575,7 @@ with space.record_stream("run.gif", target=window, fps=8, duration=5) as stream:
 | `fps` | 目标帧率（必填，默认 10）。低于目标会被丢弃并计入 `report().dropped` |
 | `duration` | 秒；到点自动停止，`stopped_by="duration"` |
 | `max_frames` | 帧数上限；到点自动停止，`stopped_by="max_frames"` |
+| — | 不传 `duration` 时有一个 **1 小时硬上限**（`MAX_DURATION`）：录制线程持有 `Recorder` 引用，被丢弃且未 `stop()` 的对象无法回收，没有上限就会一直录下去（并带着 ffmpeg 子进程）。正常用法请始终用 `with` |
 | `quality` | 见上方格式表；不同后端含义不同 |
 | `format` | 覆盖扩展名推断 |
 | `on_frame` | `(frame, index)` 回调，每帧一次；回调抛异常不会中断录制 |

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "VirtualDesktop"
-version = "1.6.1"
+version = "1.6.2"
 description = "win10-win11 虚拟桌面"
 readme = "README.md"
 requires-python = ">=3.9"

{virtualdesktop-1.6.1 → virtualdesktop-1.6.2}/tests/test_record.py

@@ -255,6 +255,60 @@ def test_record_stream_yields_frames_and_terminates(tmp_path):
     assert all(w > 0 and h > 0 for w, h in seen)
 
 
+def test_max_duration_is_the_ceiling_when_no_duration_is_given():
+    """An abandoned recorder must not capture forever.
+
+    The capture thread keeps a reference to its ``Recorder``, so one dropped without ``stop()`` is
+    never collected and would run indefinitely — with its ffmpeg child.  ``MAX_DURATION`` bounds it.
+    The bound is applied rather than slept through: this checks the deadline arithmetic, because
+    waiting an hour is not a test.
+    """
+    from VirtualDesktop.record import MAX_DURATION
+
+    with _shared() as space:
+        entry = space.launch([CHARMAP], timeout=45.0)
+        recorder = space.record_window(entry.hwnd, "unused.gif", fps=1)
+        assert recorder.duration is None
+        recorder._started = 12345.0
+        requested = recorder.duration if recorder.duration is not None else MAX_DURATION
+        effective = min(requested, MAX_DURATION)
+        assert effective == MAX_DURATION
+        # An explicit longer duration is still capped, so the ceiling is real rather than decorative.
+        recorder.duration = MAX_DURATION * 10
+        assert min(recorder.duration, MAX_DURATION) == MAX_DURATION
+        # A shorter explicit duration wins, which is the normal case.
+        recorder.duration = 5.0
+        assert min(recorder.duration, MAX_DURATION) == 5.0
+
+
+def test_repeated_recordings_do_not_leak_ffmpeg_processes(tmp_path):
+    """Each finished recording must reap its encoder process."""
+    import subprocess as sp
+
+    if not shutil.which("ffmpeg"):
+        pytest.skip("ffmpeg is not on PATH")
+
+    def ffmpeg_count() -> int:
+        out = sp.run(
+            ["tasklist", "/FI", "IMAGENAME eq ffmpeg.exe", "/FO", "CSV", "/NH"],
+            capture_output=True, text=True,
+        ).stdout
+        return sum(1 for line in out.splitlines() if "ffmpeg" in line.lower())
+
+    before = ffmpeg_count()
+    with _shared() as space:
+        entry = space.launch([CHARMAP], timeout=45.0)
+        for index in range(3):
+            with space.record_window(
+                entry.hwnd, tmp_path / f"clip{index}.mp4", fps=8, duration=0.4
+            ) as rec:
+                time.sleep(0.6)
+            assert rec.report().ok
+    after = ffmpeg_count()
+
+    assert after <= before, f"ffmpeg processes leaked: {before} -> {after}"
+
+
 def test_on_frame_callback_sees_every_frame(tmp_path):
     seen = []
     with _shared() as space: