VeraGrid 5.5.9__tar.gz → 5.5.17__tar.gz

{veragrid-5.5.9 → veragrid-5.5.17}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: VeraGrid
-Version: 5.5.9
+Version: 5.5.17
 Summary: VeraGrid is a Power Systems simulation program intended for professional use and research
 Home-page: https://github.com/SanPen/VeraGrid
 Author: Santiago Peñate Vera et. Al.

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/Editors/controllable_shunt_editor.py

@@ -126,7 +126,13 @@ class ControllableShuntEditor(QDialog):
 
     def accept_click(self):
         """
-
-        :return:
+        Modify and exit
         """
+        self.api_object.active_steps = self.get_active_steps()
+        self.api_object.g_steps = self.get_g_steps()
+        self.api_object.Gmax = self.api_object.g_steps.max()
+        self.api_object.Gmin = self.api_object.g_steps.min()
+        self.api_object.b_steps = self.get_b_steps()
+        self.api_object.Bmax = self.api_object.b_steps.max()
+        self.api_object.Bmin = self.api_object.b_steps.min()
         self.accept()

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/Editors/line_editor.py

@@ -12,6 +12,7 @@ from PySide6.QtWidgets import QPushButton, QVBoxLayout, QDialog, QLabel, QDouble
 from VeraGrid.Gui.gui_functions import get_list_model
 from VeraGrid.Gui.messages import error_msg, warning_msg, yes_no_question
 from VeraGridEngine.Devices.Branches.line import Line, SequenceLineType, OverheadLineType, UndergroundLineType
+from VeraGridEngine.Devices.multi_circuit import MultiCircuit
 
 
 class LineEditor(QDialog):
@@ -21,28 +22,32 @@ class LineEditor(QDialog):
 
     def __init__(self,
                  line: Line,
-                 Sbase=100,
-                 frequency=50,
-                 templates: Union[List[SequenceLineType | OverheadLineType | UndergroundLineType], None] = None,
-                 current_template: SequenceLineType | OverheadLineType | UndergroundLineType | None = None):
+                 grid: MultiCircuit):
         """
         Line Editor constructor
         :param line: Branch object to update
-        :param templates: List of templates
-        :param Sbase: Base power in MVA
+        :param grid: MultiCircuit
         """
         super(LineEditor, self).__init__()
 
         # keep pointer to the line object
         self.line = line
 
-        self.Sbase = Sbase
+        self.Sbase = grid.Sbase
 
-        self.frequency = frequency
+        self.frequency = grid.fBase
 
-        self.templates = templates
+        Vnom = line.get_max_bus_nominal_voltage()
+        self.templates = list()
 
-        self.current_template = current_template
+        for lst in [grid.sequence_line_types,
+                    grid.underground_cable_types,
+                    grid.overhead_line_types]:
+            for temp in lst:
+                if Vnom == temp.Vnom:
+                    self.templates.append(temp)
+
+        self.current_template = line.template
 
         self.selected_template = None
 
@@ -83,43 +88,42 @@ class LineEditor(QDialog):
 
         # catalogue
         self.catalogue_combo = QComboBox()
-        if self.templates is not None:
-            if len(self.templates) > 0:
-                self.catalogue_combo.setModel(get_list_model(self.templates))
-
-                if self.current_template is not None:
-                    try:
-                        idx = self.templates.index(self.current_template)
-                        self.catalogue_combo.setCurrentIndex(idx)
-
-                        if isinstance(self.current_template, SequenceLineType):
-                            I_KA = self.current_template.Imax
-                            r_ohm = self.current_template.R
-                            x_ohm = self.current_template.X
-                            b_us = self.current_template.B
-
-                        if isinstance(self.current_template, UndergroundLineType):
-                            I_KA = self.current_template.Imax
-                            r_ohm = self.current_template.R
-                            x_ohm = self.current_template.X
-                            b_us = self.current_template.B
-
-                        elif isinstance(self.current_template, OverheadLineType):
-
-                            if self.current_template.check():
-                                R1, X1, Bsh1, I_kA = self.current_template.get_sequence_values(
-                                    circuit_idx=self.line.circuit_idx,
-                                    seq=1
-                                )
-                                r_ohm = R1
-                                x_ohm = X1
-                                b_us = Bsh1
-                            else:
-                                warning_msg(text=f"The template {self.current_template.name} contains errors",
-                                            title="Load template")
-
-                    except ValueError:
-                        pass
+        if len(self.templates) > 0:
+            self.catalogue_combo.setModel(get_list_model(self.templates))
+
+            if self.current_template is not None:
+                try:
+                    idx = self.templates.index(self.current_template)
+                    self.catalogue_combo.setCurrentIndex(idx)
+
+                    if isinstance(self.current_template, SequenceLineType):
+                        I_KA = self.current_template.Imax
+                        r_ohm = self.current_template.R
+                        x_ohm = self.current_template.X
+                        b_us = self.current_template.B
+
+                    if isinstance(self.current_template, UndergroundLineType):
+                        I_KA = self.current_template.Imax
+                        r_ohm = self.current_template.R
+                        x_ohm = self.current_template.X
+                        b_us = self.current_template.B
+
+                    elif isinstance(self.current_template, OverheadLineType):
+
+                        if self.current_template.check():
+                            R1, X1, Bsh1, I_kA = self.current_template.get_sequence_values(
+                                circuit_idx=self.line.circuit_idx,
+                                seq=1
+                            )
+                            r_ohm = R1
+                            x_ohm = X1
+                            b_us = Bsh1
+                        else:
+                            warning_msg(text=f"The template {self.current_template.name} contains errors",
+                                        title="Load template")
+
+                except ValueError:
+                    pass
 
         # load template
         self.load_template_btn = QPushButton()
@@ -138,7 +142,7 @@ class LineEditor(QDialog):
         self.i_spinner = QDoubleSpinBox()
         self.i_spinner.setMinimum(0)
         self.i_spinner.setMaximum(9999999)
-        self.i_spinner.setDecimals(2)
+        self.i_spinner.setDecimals(6)
         self.i_spinner.setValue(I_KA)
         self.i_spinner.setSuffix(' KA')
 
@@ -189,14 +193,13 @@ class LineEditor(QDialog):
         self.accept_btn.clicked.connect(self.accept_click)
 
         # add all to the GUI
-        if templates is not None:
-            self.layout.addWidget(QLabel("Available templates"))
-            self.layout.addWidget(self.catalogue_combo)
-            self.catalogue_combo.currentIndexChanged.connect(self.update_max_circuits)
-            self.layout.addWidget((QLabel("Circuit index:")))
-            self.layout.addWidget(self.circuit_idx)
-            self.layout.addWidget(self.load_template_btn)
-            self.layout.addWidget(QLabel(""))
+        self.layout.addWidget(QLabel("Available templates"))
+        self.layout.addWidget(self.catalogue_combo)
+        self.catalogue_combo.currentIndexChanged.connect(self.update_max_circuits)
+        self.layout.addWidget((QLabel("Circuit index:")))
+        self.layout.addWidget(self.circuit_idx)
+        self.layout.addWidget(self.load_template_btn)
+        self.layout.addWidget(QLabel(""))
 
         self.layout.addWidget(QLabel("L: Line length"))
         self.layout.addWidget(self.l_spinner)

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/Editors/transformer_editor.py

@@ -8,7 +8,8 @@ from PySide6.QtCore import Qt
 from PySide6.QtWidgets import QPushButton, QVBoxLayout, QDialog, QLabel, QComboBox
 from VeraGrid.Gui.gui_functions import get_list_model, create_spinbox
 from VeraGridEngine.Devices.Branches.transformer import Transformer2W
-from VeraGridEngine.Devices.Branches.transformer_type import TransformerType, reverse_transformer_short_circuit_study
+from VeraGridEngine.Devices.Branches.transformer_type import TransformerType
+from VeraGridEngine.Devices.multi_circuit import MultiCircuit
 
 
 class TransformerEditor(QDialog):
@@ -16,24 +17,24 @@ class TransformerEditor(QDialog):
     TransformerEditor
     """
 
-    def __init__(self, branch: Transformer2W, Sbase=100, modify_on_accept=True, templates=None, current_template=None):
+    def __init__(self, branch: Transformer2W, grid: MultiCircuit, modify_on_accept=True):
         """
         Transformer
         :param branch:
-        :param Sbase:
+        :param grid: MultiCircuit
         """
         super(TransformerEditor, self).__init__()
 
         # keep pointer to the line object
         self.transformer_obj = branch
 
-        self.Sbase = Sbase
+        self.Sbase = grid.Sbase
 
         self.modify_on_accept = modify_on_accept
 
-        self.templates = self.filter_valid_templates(templates)
+        self.templates = self.filter_valid_templates(grid.transformer_types)
 
-        self.current_template = current_template
+        self.current_template = branch.template
 
         self.selected_template = None
 
@@ -49,33 +50,58 @@ class TransformerEditor(QDialog):
         self.Vf = self.transformer_obj.bus_from.Vnom
         self.Vt = self.transformer_obj.bus_to.Vnom
 
-        Pfe, Pcu, Vsc, I0, Sn = reverse_transformer_short_circuit_study(R=self.transformer_obj.R,
-                                                                        X=self.transformer_obj.X,
-                                                                        G=self.transformer_obj.G,
-                                                                        B=self.transformer_obj.B,
-                                                                        rate=self.transformer_obj.rate,
-                                                                        Sbase=Sbase)
+        # Pfe, Pcu, Vsc, I0, Sn = reverse_transformer_short_circuit_study(R=self.transformer_obj.R,
+        #                                                                 X=self.transformer_obj.X,
+        #                                                                 G=self.transformer_obj.G,
+        #                                                                 B=self.transformer_obj.B,
+        #                                                                 rate=self.transformer_obj.rate,
+        #                                                                 Sbase=self.Sbase)
 
         # ------------------------------------------------------------------------------------------
 
         # catalogue
         self.catalogue_combo = QComboBox()
-        if templates is not None:
-            if len(self.templates) > 0:
 
-                self.catalogue_combo.setModel(get_list_model(self.templates))
+        if len(self.templates) > 0:
 
-                if self.current_template is not None:
+            self.catalogue_combo.setModel(get_list_model(self.templates))
+
+            if self.current_template is not None:
+
+                try:
                     idx = self.templates.index(self.current_template)
-                    if idx > -1:
-                        self.catalogue_combo.setCurrentIndex(idx)
 
-                        # set the template parameters
-                        Sn = self.current_template.Sn  # MVA
-                        Pcu = self.current_template.Pcu  # kW
-                        Pfe = self.current_template.Pfe  # kW
-                        I0 = self.current_template.I0  # %
-                        Vsc = self.current_template.Vsc  # %
+                    self.catalogue_combo.setCurrentIndex(idx)
+
+                    # set the template parameters
+                    Sn = self.current_template.Sn  # MVA
+                    Pcu = self.current_template.Pcu  # kW
+                    Pfe = self.current_template.Pfe  # kW
+                    I0 = self.current_template.I0  # %
+                    Vsc = self.current_template.Vsc  # %
+
+                except ValueError as e:
+                    print(f"Template not found for {self.transformer_obj.name}")
+                    Sn = self.transformer_obj.Sn  # MVA
+                    Pcu = self.transformer_obj.Pcu  # kW
+                    Pfe = self.transformer_obj.Pfe  # kW
+                    I0 = self.transformer_obj.I0  # %
+                    Vsc = self.transformer_obj.Vsc  # %
+
+            else:
+                # set the template parameters
+                Sn = self.transformer_obj.Sn  # MVA
+                Pcu = self.transformer_obj.Pcu  # kW
+                Pfe = self.transformer_obj.Pfe  # kW
+                I0 = self.transformer_obj.I0  # %
+                Vsc = self.transformer_obj.Vsc  # %
+        else:
+            # set the template parameters
+            Sn = self.transformer_obj.Sn  # MVA
+            Pcu = self.transformer_obj.Pcu  # kW
+            Pfe = self.transformer_obj.Pfe  # kW
+            I0 = self.transformer_obj.I0  # %
+            Vsc = self.transformer_obj.Vsc  # %
 
         # load template
         self.load_template_btn = QPushButton()
@@ -105,13 +131,10 @@ class TransformerEditor(QDialog):
         # labels
 
         # add all to the GUI
-
-        # add all to the GUI
-        if templates is not None:
-            self.layout.addWidget(QLabel("Suitable templates"))
-            self.layout.addWidget(self.catalogue_combo)
-            self.layout.addWidget(self.load_template_btn)
-            self.layout.addWidget(QLabel(""))
+        self.layout.addWidget(QLabel("Suitable templates"))
+        self.layout.addWidget(self.catalogue_combo)
+        self.layout.addWidget(self.load_template_btn)
+        self.layout.addWidget(QLabel(""))
 
         self.layout.addWidget(QLabel("Sn: Nominal power [MVA]"))
         self.layout.addWidget(self.sn_spinner)

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/MapWidget/Branches/line_location_graphic_item.py

@@ -238,7 +238,7 @@ class LineLocationGraphicItem(QtWidgets.QGraphicsEllipseItem, NodeTemplate):
         Event handler for when the mouse enters the item.
         """
         self.hovered = True
-        self.setNodeColor(QColor(Qt.GlobalColor.red), QColor(Qt.GlobalColor.red))
+        self.set_node_color(QColor(Qt.GlobalColor.red), QColor(Qt.GlobalColor.red))
 
     def hoverLeaveEvent(self, event: QtWidgets.QGraphicsSceneHoverEvent) -> None:
         """
@@ -288,9 +288,9 @@ class LineLocationGraphicItem(QtWidgets.QGraphicsEllipseItem, NodeTemplate):
         """
         Remove
         """
-        self.line_container.removeNode(node=self)
+        self.line_container.remove_node(node=self)
 
-    def setNodeColor(self, inner_color: QColor, border_color: QColor = None) -> None:
+    def set_node_color(self, inner_color: QColor, border_color: QColor = None) -> None:
         """
 
         :param inner_color:
@@ -312,7 +312,7 @@ class LineLocationGraphicItem(QtWidgets.QGraphicsEllipseItem, NodeTemplate):
         :return:
         """
         # Example: color assignment
-        self.setNodeColor(self.colorInner, self.colorBorder)
+        self.set_node_color(self.colorInner, self.colorBorder)
 
     def get_pos(self) -> QPointF:
         """

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/MapWidget/Branches/map_line_container.py

@@ -174,7 +174,7 @@ class MapLineContainer(GenericDiagramWidget, QGraphicsItemGroup):
         # second pass: create the segments
         self.redraw_segments()
 
-    def removeNode(self, node: LineLocationGraphicItem):
+    def remove_node(self, node: LineLocationGraphicItem):
         """
 
         :param node:
@@ -411,11 +411,12 @@ class MapLineContainer(GenericDiagramWidget, QGraphicsItemGroup):
             # Return the newly created node
             return graphic_obj
 
-        # else:
-        #     logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(levelname)s - %(message)s')
-        #     logging.info("Invalid node index")
+        else:
+            #     logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(levelname)s - %(message)s')
+            #     logging.info("Invalid node index")
+            return None
 
-    def split_Line(self, index):
+    def split_line(self, index):
         """
         Split Line
         :param index:
@@ -461,6 +462,7 @@ class MapLineContainer(GenericDiagramWidget, QGraphicsItemGroup):
         else:
             # Handle invalid index
             error_msg("Index out of range or invalid", "split line")
+            return list(), list()
 
     def disable_line(self):
         """

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/MapWidget/Branches/map_line_segment.py

@@ -415,13 +415,7 @@ class MapLineSegment(QGraphicsLineItem):
                 if Vnom == temp.Vnom:
                     templates.append(temp)
 
-        dlg = LineEditor(
-            line=self.api_object,
-            Sbase=self.editor.circuit.Sbase,
-            frequency=self.editor.circuit.fBase,
-            templates=templates,
-            current_template=self.api_object.template
-        )
+        dlg = LineEditor(line=self.api_object, grid=self.editor.circuit)
         dlg.exec()
 
     def plot_profiles(self) -> None:

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/MapWidget/grid_map_widget.py

@@ -19,6 +19,7 @@ from PySide6.QtCore import (Qt, QMimeData, QIODevice, QByteArray, QDataStream, Q
 from PySide6.QtGui import (QIcon, QPixmap, QImage, QStandardItemModel, QStandardItem, QColor, QDropEvent)
 
 from VeraGrid.Gui.Diagrams.MapWidget.Branches.map_line_container import MapLineContainer
+from VeraGrid.Gui.Diagrams.SchematicWidget.Substation.bus_graphics import BusGraphicItem
 from VeraGrid.Gui.Diagrams.generic_graphics import GenericDiagramWidget
 from VeraGrid.Gui.SubstationDesigner.substation_designer import SubstationDesigner
 from VeraGrid.Gui.general_dialogues import InputNumberDialogue
@@ -272,15 +273,19 @@ class GridMapWidget(BaseDiagramWidget):
         """
         self.diagram = diagram
 
-    def delete_element_utility_function(self, device: ALL_DEV_TYPES, propagate: bool = True):
+    def delete_element_utility_function(self, device: ALL_DEV_TYPES, propagate: bool = True,
+                                        graphic_object: QGraphicsItem | None = None):
         """
 
         :param device:
         :param propagate: Propagate the action to other diagrams?
+        :param graphic_object: graphic_object
         :return:
         """
         self.diagram.delete_device(device=device)
-        graphic_object: ALL_MAP_GRAPHICS = self.graphics_manager.delete_device(device=device)
+
+        if graphic_object is None:
+            graphic_object: ALL_MAP_GRAPHICS = self.graphics_manager.delete_device(device=device)
 
         if graphic_object is not None:
             self._remove_from_scene(graphic_object)
@@ -522,6 +527,25 @@ class GridMapWidget(BaseDiagramWidget):
         """
         return [s for s in self.map.view.selected_items() if isinstance(s, SubstationGraphicItem)]
 
+    def get_selected_buses(self) -> List[Tuple[int, Bus, BusGraphicItem | None]]:
+        """
+        Get a list of buses from the selected substations
+        :return:
+        """
+        buses: List[Tuple[int, Bus, BusGraphicItem | None]] = list()
+        se_graphics = self.get_selected_substations()
+
+        se_api_set = set()
+        for se_graphic in se_graphics:
+            if se_graphic.api_object is not None:
+                se_api_set.add(se_graphic.api_object)
+
+        for i, bus in enumerate(self.circuit.buses):
+            if bus.substation in se_api_set:
+                buses.append((i, bus, None))
+
+        return buses
+
     def get_substations(self) -> List[Tuple[int, Substation, SubstationGraphicItem]]:
         """
         Get all the substations
@@ -627,57 +651,6 @@ class GridMapWidget(BaseDiagramWidget):
             # Delete the substation itself
             self.circuit.delete_substation(obj=api_object)
 
-    #
-    # def show_devices_to_disconnect_dialog(self,
-    #                                       devices: List[ALL_DEV_TYPES],
-    #                                       buses: List[Bus],
-    #                                       voltage_levels: List[VoltageLevel],
-    #                                       dialog_title: str):
-    #     """
-    #     Show a dialog with the list of all devices that will be disconnected
-    #
-    #     :param devices: List of devices to be disconnected
-    #     :param buses: List of buses associated with the substation
-    #     :param voltage_levels: List of voltage levels associated with the substation
-    #     :param dialog_title: Title for the dialog
-    #     """
-    #
-    #
-    #     # Combine all devices
-    #     all_devices = devices + buses + voltage_levels
-    #
-    #     if not all_devices:
-    #         info_msg('No devices to disconnect', dialog_title)
-    #         return
-    #
-    #     # Create custom properties for name, type, and ID tag
-    #     name_prop = GCProp(prop_name='name', tpe=str, units='', definition='Device name',
-    #                        display=True, editable=False)
-    #
-    #     type_prop = GCProp(prop_name='device_type', tpe=DeviceType, units='', definition='Device type',
-    #                        display=True, editable=False)
-    #
-    #     idtag_prop = GCProp(prop_name='idtag', tpe=str, units='', definition='ID tag',
-    #                         display=True, editable=False)
-    #
-    #     custom_props = [name_prop, type_prop, idtag_prop]
-    #
-    #     # Create and show the dialog
-    #     dialog = ElementsDialogue(name=dialog_title, elements=all_devices)
-    #
-    #     # Replace the model with our custom one that only shows name, type, and idtag
-    #     model = ObjectsModel(objects=all_devices,
-    #                          time_index=None,
-    #                          property_list=custom_props,
-    #                          parent=dialog.objects_table,
-    #                          editable=False)
-    #
-    #     dialog.objects_table.setModel(model)
-    #
-    #     # Make the dialog modal so the user must acknowledge it before continuing
-    #     dialog.setModal(True)
-    #     dialog.exec()
-
     def remove_branch_graphic(self, line: MAP_BRANCH_GRAPHIC_TYPES | MapLineContainer, delete_from_db: bool = False):
         """
         Removes line from diagram and scene
@@ -1086,10 +1059,19 @@ class GridMapWidget(BaseDiagramWidget):
         """
         lat = 0.0
         lon = 0.0
+        lat_max = -1e20
+        lat_min = 1e20
+        lon_max = -1e20
+        lon_min = 1e20
         n = 0
         for graphic_obj in self.graphics_manager.get_device_type_list(DeviceType.SubstationDevice):
             lat += graphic_obj.lat
             lon += graphic_obj.lon
+
+            lat_max = max(lat_max, graphic_obj.lat)
+            lat_min = min(lat_min, graphic_obj.lat)
+            lon_max = max(lon_max, graphic_obj.lon)
+            lon_min = min(lon_min, graphic_obj.lon)
             n += 1
 
         if n > 0:
@@ -1097,6 +1079,18 @@ class GridMapWidget(BaseDiagramWidget):
             lon /= n
             self.map.pan_position(latitude=lat, longitude=lon)
 
+            # this is to also move the diagram layer according to the map
+            # z = self.map.best_zoom_from_bbox(min_lat=lat_min,
+            #                                  max_lat=lat_max,
+            #                                  min_lon=lon_min,
+            #                                  max_lon=lon_max)
+
+            self.map.set_zoom_level(level=self.map.level)
+            # self.map.set_zoom_level(level=z)
+
+        else:
+            self.gui.show_warning_toast("No points to center :/")
+
     def colour_results(self,
                        Sbus: CxVec,
                        bus_active: IntVec,

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/MapWidget/map_widget.py

@@ -1521,14 +1521,14 @@ class MapWidget(QWidget):
         under the cursor.
         """
 
-        # if not given cursor coords, assume view centre
+        # if not given cursor coordinates, assume view centre
         if view_x is None:
             view_x = self.view_width // 4
 
         if view_y is None:
             view_y = self.view_height // 4
 
-        # get geo coords of view point
+        # get geo coordinates of view point
         longitude, latitude = self.view_to_geo_float(view_x, view_y)
 
         # get tile source to use the new level
@@ -1602,6 +1602,50 @@ class MapWidget(QWidget):
         # redraw the widget
         self.update()
 
+    def best_zoom_from_bbox(self,
+                            min_lat: float,
+                            max_lat: float,
+                            min_lon: float,
+                            max_lon: float) -> int:
+        """
+        Determine the most appropriate zoom level for the given lat/lon bounding box,
+        based on the MapWidget's tile source and viewport size.
+        :param min_lat: minimum latitude of bounding box
+        :param max_lat: maximum latitude of bounding box
+        :param min_lon: minimum longitude of bounding box
+        :param max_lon: maximum longitude of bounding box
+        :return: best zoom level (int)
+        """
+        tile_src = self.tile_src
+        view_width = self.view_width
+        view_height = self.view_height
+        tile_size_x = self.tile_width
+        tile_size_y = self.tile_height
+
+        # search from high zoom (more detail) to low zoom (zoomed out)
+        for z in range(tile_src.max_level, tile_src.min_level - 1, -1):
+            if not tile_src.set_level(z):
+                continue
+
+            # convert bbox corners to fractional tile coordinates at this zoom
+            tx_min, ty_min = tile_src.Geo2Tile(longitude=min_lon, latitude=min_lat)
+            tx_max, ty_max = tile_src.Geo2Tile(longitude=max_lon, latitude=max_lat)
+
+            # tile extents in X/Y
+            dx_tiles = abs(tx_max - tx_min)
+            dy_tiles = abs(ty_max - ty_min)
+
+            # pixel span at this zoom
+            width_px = dx_tiles * tile_size_x
+            height_px = dy_tiles * tile_size_y
+
+            # if fits in viewport, good zoom level
+            if width_px <= view_width and height_px <= view_height:
+                return z
+
+        # otherwise return the minimum zoom
+        return tile_src.min_level
+
     def rectify_key_tile(self) -> None:
         """
         Adjust state variables to ensure map centred if map is smaller than view.

{veragrid-5.5.9 → veragrid-5.5.17}/VeraGrid/Gui/Diagrams/SchematicWidget/Branches/line_graphics.py

@@ -20,7 +20,6 @@ from VeraGrid.Gui.Diagrams.Editors.RmsModelEditor.rms_model_editor_engine import
 from VeraGridEngine.Devices.Branches.line import Line, SequenceLineType
 from VeraGridEngine.enumerations import DeviceType
 
-
 if TYPE_CHECKING:  # Only imports the below statements during type checking
     from VeraGrid.Gui.Diagrams.SchematicWidget.schematic_widget import SchematicWidget
 
@@ -223,28 +222,19 @@ class LineGraphicItem(LineGraphicTemplateItem):
         Open the appropriate editor dialogue
         :return:
         """
-        Sbase = self.editor.circuit.Sbase
-        Vnom = self.api_object.get_max_bus_nominal_voltage()
-        templates = list()
-
-        for lst in [self.editor.circuit.sequence_line_types,
-                    self.editor.circuit.underground_cable_types,
-                    self.editor.circuit.overhead_line_types]:
-            for temp in lst:
-                if Vnom == temp.Vnom:
-                    templates.append(temp)
-
-        current_template = self.api_object.template
-        dlg = LineEditor(line=self.api_object, Sbase=Sbase, frequency=self.editor.circuit.fBase,
-                         templates=templates, current_template=current_template)
+        dlg = LineEditor(line=self.api_object, grid=self.editor.circuit)
         if dlg.exec():
             pass
 
     def edit_rms(self):
-        templates = [t.name for t in self.editor.circuit.sequence_line_types] # TODO: find where to build and save the templates
+        """
+
+        """
+        templates = [t.name for t in
+                     self.editor.circuit.sequence_line_types]  # TODO: find where to build and save the templates
 
         choice_dialog = RmsChoiceDialog(templates, parent=self.editor)
-        if choice_dialog.exec() == QtWidgets.QDialog.Accepted:
+        if choice_dialog.exec() == QtWidgets.QDialog.DialogCode.Accepted:
             if choice_dialog.choice == "template":
                 template_name = choice_dialog.selected_template
                 print(f"User chose template: {template_name}")