TypeDAL 5.1.0__tar.gz → 5.1.1__tar.gz

{typedal-5.1.0 → typedal-5.1.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: TypeDAL
-Version: 5.1.0
+Version: 5.1.1
 Summary: Typing support for PyDAL
 Keywords: 
 Author: Robin van der Noord

{typedal-5.1.0 → typedal-5.1.1}/pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "uv_build"
 name = "TypeDAL"
 description = "Typing support for PyDAL"
 readme = "README.md"
-version = "5.1.0"
+version = "5.1.1"
 requires-python = ">=3.12"
 license-expression = "MIT"
 keywords = []
@@ -164,7 +164,7 @@ badge = true
 mypy = "--disable-error-code misc"
 
 [tool.black]
-target-version = ["py314"]
+target-version = ["py312"]
 line-length = 120
 extend-exclude = '''
 # A regex preceded with ^/ will apply only to files and directories
@@ -199,7 +199,7 @@ exclude = [
 ]
 
 [tool.ruff]
-target-version = "py314"
+target-version = "py312"
 line-length = 120
 extend-exclude = [
     "*.bak/",

{typedal-5.1.0 → typedal-5.1.1}/pyproject.toml.orig

@@ -6,7 +6,7 @@ build-backend = "uv_build"
 name = "TypeDAL"
 description = 'Typing support for PyDAL'
 readme = "README.md"
-version = "5.1.0"
+version = "5.1.1"
 requires-python = ">=3.12"
 license-expression = "MIT"
 keywords = []
@@ -181,7 +181,7 @@ badge = true
 mypy = "--disable-error-code misc"
 
 [tool.black]
-target-version = ["py314"]
+target-version = ["py312"]
 line-length = 120
 # 'extend-exclude' excludes files or directories in addition to the defaults
 extend-exclude = '''
@@ -229,7 +229,7 @@ strict = true
 exclude = ["venv", ".bak"]
 
 [tool.ruff]
-target-version = "py314"
+target-version = "py312"
 line-length = 120
 
 extend-exclude = ["*.bak/", "venv*/", "tests/", "example_*.py"]

{typedal-5.1.0 → typedal-5.1.1}/src/typedal/query_builder.py

@@ -46,7 +46,19 @@ from .types import (
     merge_permissions,
     require_permission,
 )
-from .warnings import UnusedWindowWarning
+from .warnings import NoopQueryWarning, UnusedWindowWarning
+
+
+def warn_noop(method: str) -> None:
+    """
+    Warn that `method` was called without arguments, which has no effect.
+    """
+    # stacklevel: 1 = here, 2 = the query builder method, 3 = the caller.
+    warnings.warn(
+        f"`.{method}()` without arguments does nothing. You can remove this call.",
+        stacklevel=3,
+        category=NoopQueryWarning,
+    )
 
 
 class QueryBuilder[T_MetaInstance: _TypedTable](Select):
@@ -175,6 +187,10 @@ class QueryBuilder[T_MetaInstance: _TypedTable](Select):
         """
         Return a clone of this builder with permission overrides merged in.
         """
+        if not permissions and self:
+            warn_noop("permissions")
+            return self
+
         return self._extend(permissions=permissions)
 
     def _normalize_select_option(
@@ -216,8 +232,15 @@ class QueryBuilder[T_MetaInstance: _TypedTable](Select):
             join: othertable.on(query) - do an INNER JOIN. Using TypeDAL relationships with .join() is recommended!
             left: othertable.on(query) - do a LEFT JOIN. Using TypeDAL relationships with .join() is recommended!
             cache: cache the query result to speed up repeated queries; e.g. (cache=(cache.ram, 3600), cacheable=True)
+
+        Calling this without any fields or options on a builder that already has settings
+        does nothing and emits a NoopQueryWarning.
         """
 
+        if not fields and not options and self:
+            warn_noop("select")
+            return self
+
         for key in ("distinct",):
             if options.get(key):
                 options[key] = self._normalize_select_option(options[key])
@@ -282,7 +305,15 @@ class QueryBuilder[T_MetaInstance: _TypedTable](Select):
             .where(lambda table: table.id == 5).where(lambda table: table.id == 6) == (table.id == 5) & (table.id=6)
         When passing multiple queries to a single .where, they will be ORed:
             .where(lambda table: table.id == 5, lambda table: table.id == 6) == (table.id == 5) | (table.id=6)
+
+        Calling this without any arguments on a builder that already has settings
+        does nothing and emits a NoopQueryWarning.
+        Starting an empty builder (e.g. `Model.where()`) is allowed and stays silent.
         """
+        if not queries_or_lambdas and not filters and self:
+            warn_noop("where")
+            return self
+
         new_query = self.query
         table = self._ensure_table_defined()
 

{typedal-5.1.0 → typedal-5.1.1}/src/typedal/warnings.py

@@ -3,3 +3,7 @@
 
 class UnusedWindowWarning(RuntimeWarning):
     """Warn when a window size is configured but the query is collected directly."""
+
+
+class NoopQueryWarning(RuntimeWarning):
+    """Warn when a query builder method is called without arguments, so it does nothing."""