TypeDAL 3.8.3__tar.gz → 3.8.4__tar.gz

{typedal-3.8.3 → typedal-3.8.4}/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 <!--next-version-placeholder-->
 
+## v3.8.4 (2024-10-24)
+
+### Fix
+
+* Paginate with limit=0 will yield all rows instead of crashing pt2 ([`78f1ae7`](https://github.com/trialandsuccess/TypeDAL/commit/78f1ae7257af0ba90040a7356ad579d3c77aa231))
+
 ## v3.8.3 (2024-10-24)
 
 ### Fix

{typedal-3.8.3 → typedal-3.8.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: TypeDAL
-Version: 3.8.3
+Version: 3.8.4
 Summary: Typing support for PyDAL
 Project-URL: Documentation, https://typedal.readthedocs.io/
 Project-URL: Issues, https://github.com/trialandsuccess/TypeDAL/issues

{typedal-3.8.3 → typedal-3.8.4}/src/typedal/__about__.py

@@ -5,4 +5,4 @@ This file contains the Version info for this package.
 # SPDX-FileCopyrightText: 2023-present Robin van der Noord <robinvandernoord@gmail.com>
 #
 # SPDX-License-Identifier: MIT
-__version__ = "3.8.3"
+__version__ = "3.8.4"

{typedal-3.8.3 → typedal-3.8.4}/src/typedal/core.py

@@ -2744,11 +2744,11 @@ class QueryBuilder(typing.Generic[T_MetaInstance]):
         limit: int,
         page: int = 1,
     ) -> "QueryBuilder[T_MetaInstance]":
-        _from = limit * (page - 1)
-        _to = limit * page
-
         available = self.count()
 
+        _from = limit * (page - 1)
+        _to = (limit * page) if limit else available
+
         metadata: Metadata = {}
 
         metadata["pagination"] = {

{typedal-3.8.3 → typedal-3.8.4}/tests/test_query_builder.py

@@ -275,6 +275,7 @@ def test_paginate():
 
     # what if no limit?
     all_rows = TestQueryTable.join(method="left").paginate(limit=0, page=1)
+    assert len(all_rows) == 5
     assert all_rows.pagination["total_items"] == 5
     assert all_rows.pagination["total_pages"] == 1
     assert not all_rows.pagination["has_next_page"]