TypeDAL 3.8.2__tar.gz → 3.8.4__tar.gz

{typedal-3.8.2 → typedal-3.8.4}/CHANGELOG.md

@@ -2,9 +2,24 @@
 
 <!--next-version-placeholder-->
 
+## v3.8.4 (2024-10-24)
+
+### Fix
+
+* Paginate with limit=0 will yield all rows instead of crashing pt2 ([`78f1ae7`](https://github.com/trialandsuccess/TypeDAL/commit/78f1ae7257af0ba90040a7356ad579d3c77aa231))
+
+## v3.8.3 (2024-10-24)
+
+### Fix
+
+* Paginate with limit=0 will yield all rows instead of crashing ([`76813e6`](https://github.com/trialandsuccess/TypeDAL/commit/76813e63fc2a0915de2ae5aa3df5be0254678f8b))
+
 ## v3.8.2 (2024-10-23)
 
+### Fix
 
+* Improvements in relationship detection and multiple mixins
+* make Mixin base class define __settings__ so other mixins can use them without checking for existance
 
 ## v3.8.1 (2024-10-22)
 

{typedal-3.8.2 → typedal-3.8.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: TypeDAL
-Version: 3.8.2
+Version: 3.8.4
 Summary: Typing support for PyDAL
 Project-URL: Documentation, https://typedal.readthedocs.io/
 Project-URL: Issues, https://github.com/trialandsuccess/TypeDAL/issues

{typedal-3.8.2 → typedal-3.8.4}/src/typedal/__about__.py

@@ -5,4 +5,4 @@ This file contains the Version info for this package.
 # SPDX-FileCopyrightText: 2023-present Robin van der Noord <robinvandernoord@gmail.com>
 #
 # SPDX-License-Identifier: MIT
-__version__ = "3.8.2"
+__version__ = "3.8.4"

{typedal-3.8.2 → typedal-3.8.4}/src/typedal/core.py

@@ -2744,17 +2744,17 @@ class QueryBuilder(typing.Generic[T_MetaInstance]):
         limit: int,
         page: int = 1,
     ) -> "QueryBuilder[T_MetaInstance]":
-        _from = limit * (page - 1)
-        _to = limit * page
-
         available = self.count()
 
+        _from = limit * (page - 1)
+        _to = (limit * page) if limit else available
+
         metadata: Metadata = {}
 
         metadata["pagination"] = {
             "limit": limit,
             "current_page": page,
-            "max_page": math.ceil(available / limit),
+            "max_page": math.ceil(available / limit) if limit else 1,
             "rows": available,
             "min_max": (_from, _to),
         }

{typedal-3.8.2 → typedal-3.8.4}/tests/test_query_builder.py

@@ -273,6 +273,13 @@ def test_paginate():
     assert page_dict["next_page"] is None
     assert page_dict["prev_page"] is None
 
+    # what if no limit?
+    all_rows = TestQueryTable.join(method="left").paginate(limit=0, page=1)
+    assert len(all_rows) == 5
+    assert all_rows.pagination["total_items"] == 5
+    assert all_rows.pagination["total_pages"] == 1
+    assert not all_rows.pagination["has_next_page"]
+
 
 def test_chunking():
     _setup_data()