SuperModelingFactory 0.6.1__tar.gz → 0.6.3__tar.gz

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/Modeling_Tool/Pipeline/feature_validation.py

@@ -1243,11 +1243,28 @@ class FeatureValidationPipeline:
                         engine.plot_woe_graph(str(base_dir / f"by_{group}"), group_name=group, _df_for_group=train)
             elif hasattr(engine, "plot_bivar_graph"):
                 transformed = engine.transform(train)
-                engine.plot_bivar_graph(transformed, dirname=str(base_dir))
+                # Explicit group=None: WOE_Master.plot_bivar_graph made `group`
+                # optional in 0.6.2; passing it explicitly documents intent and
+                # keeps the call correct even on older WOE_Master builds where
+                # `group` was positional (would raise TypeError there — which
+                # is what the 0.6.2 logger.warning below now surfaces instead
+                # of the pre-0.6.2 silent swallow).
+                engine.plot_bivar_graph(transformed, group=None, dirname=str(base_dir))
                 for group in cfg.woe_plot_groups:
                     if group in transformed.columns:
                         engine.plot_bivar_graph(transformed, group=group, dirname=str(base_dir / f"by_{group}"))
-        except Exception:
+        except Exception as exc:
+            # Never silently swallow: pre-0.6.2 a bare `except: return` here
+            # hid the equal_freq blind-spot for the entire 0.5.x/0.6.0 line.
+            engine_name = adapter.get_engine_name() if adapter is not None else "<unknown>"
+            _logger.warning(
+                "WOE plot generation failed and was skipped. "
+                "engine=%s target=%s output_dir=%s error=%r",
+                engine_name,
+                target,
+                str(base_dir),
+                exc,
+            )
             return
 
     def _build_selection_config(self) -> Any:

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/Modeling_Tool/WOE/WOE_Master.py

@@ -426,26 +426,49 @@ class WOE_Master(object):
 
         self.woe_dict.update(new_woe_dict)
 
-    def plot_bivar_graph(self, data, group, dirname, varlist=None):
+    def plot_bivar_graph(self, data, group=None, dirname=None, varlist=None):
         """Plot bivariate WOE comparison graph.
 
         Args:
             data: pandas.DataFrame, data for plotting
-            group: str, grouping variable name for distinguishing curves
-            dirname: str, subdirectory name for saving (under graph_save_dir)
+            group: str or None, grouping variable name for distinguishing curves.
+                When ``None`` a single ungrouped curve per variable is drawn
+                and no ``by_<group>`` output is produced. Prior to 0.6.2 this
+                was a required positional argument, which silently broke
+                ungrouped callers (see `_plot_woe` in
+                `Modeling_Tool.Pipeline.feature_validation`). 0.6.3 also
+                fixes ``WOE_Plot_Tool.get_bivar_graph``: the ``if group:``
+                guard there was moved up to wrap the summary/align/plot
+                triplet — the guard used to sit *after* an unconditional
+                ``data.groupby([None])`` that raised TypeError on ungrouped
+                calls.
+            dirname: str, subdirectory name for saving (under graph_save_dir).
+                Required in practice; kept keyword-only-in-practice by keeping
+                the ``group`` slot second for backward compatibility with any
+                pre-0.6.2 positional caller.
             varlist: list, variables to plot (default: self.varlist)
         Returns:
             None, saves images directly
         """
+        if dirname is None:
+            raise TypeError("plot_bivar_graph() missing required argument: 'dirname'")
         if varlist is None:
             varlist = self.varlist
 
+        save_dir = os.path.join(self.graph_save_dir, dirname)
+        # matplotlib does not create parent directories on save. Historically
+        # callers were expected to `make_dirs(save_dir)` first; feature_validation
+        # only creates the base `figs/woe/<target>` and misses per-subdirectory
+        # nesting. Since this method already owns the composed path, own the
+        # `mkdir` too — avoids FileNotFoundError on the very first PNG write.
+        os.makedirs(save_dir, exist_ok=True)
+
         get_bivar_graph(data=data,
                         varlist=varlist,
                         sep=self.dep,
                         ref_woe_table=self.get_mapping_table(),
                         group=group,
-                        save_dir=os.path.join(self.graph_save_dir, dirname))
+                        save_dir=save_dir)
 
 
 # =============================================================================

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/Modeling_Tool/WOE/WOE_Master.pyi

@@ -32,7 +32,7 @@ class WOE_Master(object):
     def save_mapping_table(self, save_dir): ...
     def transform(self, data = None, varlist = None): ...
     def update_woe(self, varlist, nbins = 10, equal_freq = True, tree_binning_seed = None, chi2_config = None, precision = 5, min_bin_prop = 0.05, include_missing = True, fillna = None, spec_values = []): ...
-    def plot_bivar_graph(self, data, group, dirname, varlist = None): ...
+    def plot_bivar_graph(self, data, group = None, dirname = None, varlist = None): ...
 def load_mapping_table(mapping_table_csv): ...
 def get_mapping_table(woe_dict): ...
 def save_mapping_table(woe_dict, save_dir): ...

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/Modeling_Tool/WOE/WOE_Plot_Tool.py

@@ -548,15 +548,25 @@ def get_bivar_graph(data, varlist, sep, ref_woe_table, save_dir, group=None, woe
         plot_woe(woe_df, to_show=False, save_dir=save_dir, fig_name = f"{var}.png")
 
     ################ Group WOE Table Plot ##########################
-    grp_woe_res = get_mapped_woe_summary(data = data,
-                                         ref_woe_table = ref_woe_table,
-                                         tgt_name = sep,
-                                         varlist = varlist,
-                                         grp_name=[group])
-
-    grp_woe_res = align_bin_num(woe_table = ref_woe_table, grp_woe_df = grp_woe_res, grp_name = [group])
-
+    # 0.6.3: the `if group:` guard was moved UP to wrap the summary + align
+    # + plot triplet. Pre-0.6.3 the get_mapped_woe_summary / align_bin_num
+    # calls executed unconditionally with grp_name=[None], causing
+    # data.groupby([None]) → TypeError: 'NoneType' object is not callable
+    # inside get_mapped_woe_summary. The old `if group:` guard only wrapped
+    # the plot loop, so it never got a chance to gate the crash.
+    #
+    # Symptom in 0.6.2 pipelines: equal_freq WOE plot base-call raised
+    # TypeError, the caller's try/except turned it into a logger.warning,
+    # and the subsequent `for group in cfg.woe_plot_groups` loop was
+    # skipped — so by_<group>/*.png was never emitted for equal_freq.
     if group:
+        grp_woe_res = get_mapped_woe_summary(data = data,
+                                             ref_woe_table = ref_woe_table,
+                                             tgt_name = sep,
+                                             varlist = varlist,
+                                             grp_name=[group])
+
+        grp_woe_res = align_bin_num(woe_table = ref_woe_table, grp_woe_df = grp_woe_res, grp_name = [group])
 
         for var in varlist:
             var = var.replace(woe_suffix, "")

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/Modeling_Tool/__init__.py

@@ -1,7 +1,7 @@
 # encoding: utf-8
 
 __author__ = "Jingkai Sun"
-__version__ = "0.6.1"
+__version__ = "0.6.3"
 
 from ._utils import SMF_MISSING_BIN
 

{supermodelingfactory-0.6.1/SuperModelingFactory.egg-info → supermodelingfactory-0.6.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: SuperModelingFactory
-Version: 0.6.1
+Version: 0.6.3
 Summary: Credit risk modeling factory: WOE binning, scorecards, LightGBM, Excel reporting.
 Home-page: https://github.com/Kyle-J-Sun/SuperModelingFactory
 Author: Kyle Sun
@@ -265,7 +265,7 @@ em.close_workbook()
 
 ## 版本
 
-- **Version**: 0.6.1
+- **Version**: 0.6.3
 - **Author**: Jingkai Sun
 
 ## 许可证

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/README.md

@@ -208,7 +208,7 @@ em.close_workbook()
 
 ## 版本
 
-- **Version**: 0.6.1
+- **Version**: 0.6.3
 - **Author**: Jingkai Sun
 
 ## 许可证

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3/SuperModelingFactory.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: SuperModelingFactory
-Version: 0.6.1
+Version: 0.6.3
 Summary: Credit risk modeling factory: WOE binning, scorecards, LightGBM, Excel reporting.
 Home-page: https://github.com/Kyle-J-Sun/SuperModelingFactory
 Author: Kyle Sun
@@ -265,7 +265,7 @@ em.close_workbook()
 
 ## 版本
 
-- **Version**: 0.6.1
+- **Version**: 0.6.3
 - **Author**: Jingkai Sun
 
 ## 许可证

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/pyproject.toml

@@ -12,7 +12,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "SuperModelingFactory"
-version = "0.6.1"
+version = "0.6.3"
 description = "Credit risk modeling factory: WOE binning, scorecards, LightGBM, Excel reporting."
 readme = "README.md"
 requires-python = ">=3.10"

{supermodelingfactory-0.6.1 → supermodelingfactory-0.6.3}/setup.py

@@ -15,7 +15,7 @@ def _read(path: str) -> str:
 
 setup(
     name="SuperModelingFactory",
-    version=os.environ.get("SMF_VERSION", "0.6.1"),
+    version=os.environ.get("SMF_VERSION", "0.6.3"),
     description="Credit risk modeling factory: WOE binning, scorecards, LightGBM, Excel reporting.",
     long_description=_read("README.md"),
     long_description_content_type="text/markdown",