PyPtt 2.3.0__tar.gz → 2.3.1__tar.gz

{pyptt-2.3.0 → pyptt-2.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: PyPtt
-Version: 2.3.0
+Version: 2.3.1
 Summary: PyPtt github: https://github.com/PyPtt/PyPtt
 Author-email: CodingMan <pttcodingman@gmail.com>
 License: GNU Lesser General Public License v3 (LGPLv3)

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt/PTT.py

@@ -665,7 +665,7 @@ class API:
         return _api_get_board_list.get_board_list(self)
 
     def reply_post(self, reply_to: data_type.ReplyTo, board: str, content: str, sign_file: [str | int] = 0,
-                   aid: Optional[str] = None, index: int = 0) -> None:
+                   aid: Optional[str] = None, index: int = 0, backup: bool = True) -> None:
 
         """
         回覆文章。
@@ -677,6 +677,7 @@ class API:
             sign_file (str | int): 編號或隨機簽名檔 (x)，預設為 **0** (不選)。
             aid: 文章編號。
             index: 文章編號。
+            backup (bool): 回信給作者時是否自存底稿，預設為 True。僅在回覆類型含站內信時有作用。
 
         Returns:
             None
@@ -703,7 +704,7 @@ class API:
         參考 :ref:`回覆類型 <reply-to>`、:ref:`取得最新文章編號 <api-get-newest-index>`
         """
 
-        _api_reply_post.reply_post(self, reply_to, board, content, sign_file, aid, index)
+        _api_reply_post.reply_post(self, reply_to, board, content, sign_file, aid, index, backup)
 
     def set_board_title(self, board: str, new_title: str) -> None:
         """

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '2.3.0'
+__version__ = '2.3.1'
 __author__ = 'CodingMan'
 __email__ = 'pttcodingman@gmail.com'
 

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt/_api_mail.py

@@ -34,6 +34,8 @@ def mail(api,
     check_value.check_type(ptt_id, str, 'ptt_id')
     check_value.check_type(title, str, 'title')
     check_value.check_type(content, str, 'content')
+    # 沒擋型別的話，backup='False' 這種字串是 truthy，會靜靜地存底稿。
+    check_value.check_type(backup, bool, 'backup')
 
     _api_util.check_user_exist(api, ptt_id)
 

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt/_api_reply_post.py

@@ -10,7 +10,7 @@ from . import log
 
 
 def reply_post(api, reply_to: data_type.ReplyTo, board: str, content: str, sign_file, post_aid: str,
-               post_index: int) -> None:
+               post_index: int, backup: bool = True) -> None:
     _api_util.one_thread(api)
 
     if not api._is_login:
@@ -21,6 +21,8 @@ def reply_post(api, reply_to: data_type.ReplyTo, board: str, content: str, sign_
 
     check_value.check_type(board, str, 'board')
     check_value.check_type(content, str, 'content')
+    # 沒擋型別的話，backup='False' 這種字串是 truthy，會靜靜地存底稿。
+    check_value.check_type(backup, bool, 'backup')
     if post_aid is not None:
         check_value.check_type(post_aid, str, 'PostAID')
 
@@ -85,7 +87,8 @@ def reply_post(api, reply_to: data_type.ReplyTo, board: str, content: str, sign_
         connect_core.TargetUnit('請問要引用原文嗎', log_level=log.DEBUG, response='Y' + command.enter),
         connect_core.TargetUnit('採用原標題[Y/n]?', log_level=log.DEBUG, response='Y' + command.enter),
         reply_target_unit,
-        connect_core.TargetUnit('已順利寄出，是否自存底稿', log_level=log.DEBUG, response='Y' + command.enter),
+        connect_core.TargetUnit('已順利寄出，是否自存底稿', log_level=log.DEBUG,
+                                response=('Y' if backup else 'N') + command.enter),
     ]
 
     api.connect_core.send(

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: PyPtt
-Version: 2.3.0
+Version: 2.3.1
 Summary: PyPtt github: https://github.com/PyPtt/PyPtt
 Author-email: CodingMan <pttcodingman@gmail.com>
 License: GNU Lesser General Public License v3 (LGPLv3)

{pyptt-2.3.0 → pyptt-2.3.1}/PyPtt.egg-info/SOURCES.txt

@@ -55,6 +55,7 @@ PyPtt/_uao/LICENSE
 PyPtt/_uao/__init__.py
 PyPtt/_uao/b2u.py
 PyPtt/_uao/u2b.py
+tests/test_backup_param.py
 tests/test_bucket.py
 tests/test_change_pw.py
 tests/test_comment.py

pyptt-2.3.1/tests/test_backup_param.py

@@ -0,0 +1,41 @@
+"""
+No-network unit tests for the `backup` parameter of mail / reply_post.
+
+Regression guard: `backup` used to skip check_type, so a truthy non-bool
+like the string 'False' silently answered 是否自存底稿 with 'y' and left a
+backup in the sender's mailbox. `reply_post` had no `backup` parameter at
+all and always answered 'Y'.
+"""
+import threading
+
+import pytest
+
+import PyPtt
+from PyPtt import _api_mail, _api_reply_post
+
+NON_BOOLS = ['False', 'false', '0', 0, 1, None]
+
+
+class _StubAPI:
+    """Just enough of PyPtt.API to reach the parameter checks."""
+    _thread_id = threading.get_ident()
+    _is_login = True
+    is_registered_user = True
+
+
+@pytest.mark.parametrize('backup', NON_BOOLS)
+def test_mail_non_bool_backup_raises(backup):
+    with pytest.raises(TypeError):
+        _api_mail.mail(_StubAPI(), 'someone', 'title', 'content', 0, backup)
+
+
+@pytest.mark.parametrize('backup', NON_BOOLS)
+def test_reply_post_non_bool_backup_raises(backup):
+    with pytest.raises(TypeError):
+        _api_reply_post.reply_post(_StubAPI(), PyPtt.ReplyTo.BOARD, 'Test', 'content', 0, None, 1, backup)
+
+
+def test_reply_post_exposes_backup():
+    """回信給作者時的自存底稿以前寫死 'Y'，關不掉。"""
+    import inspect
+    assert inspect.signature(PyPtt.API.reply_post).parameters['backup'].default is True