OctoBot-Trading 2.4.69__tar.gz → 2.4.71__tar.gz

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.4.71] - 2024-04-03
+### Added
+- [API] is_api_permission_error
+
+## [2.4.70] - 2024-03-28
+### Added
+- [API] get_minimal_order_cost
+
 ## [2.4.69] - 2024-03-26
 ### Added
 - [TradingMode] update activity from consumer

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71/OctoBot_Trading.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.69
+Version: 2.4.71
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.69](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.71](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.69/OctoBot_Trading.egg-info → OctoBot-Trading-2.4.71}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.69
+Version: 2.4.71
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.69](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.71](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/README.md

@@ -1,4 +1,4 @@
-# OctoBot-Trading [2.4.69](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.71](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/__init__.py

@@ -15,4 +15,4 @@
 #  License along with this library.
 
 PROJECT_NAME = "OctoBot-Trading"
-VERSION = "2.4.69"  # major.minor.revision
+VERSION = "2.4.71"  # major.minor.revision

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/api/__init__.py

@@ -120,6 +120,7 @@ from octobot_trading.api.exchange import (
     get_enabled_exchanges_names,
     get_auto_filled_exchange_names,
     get_exchange_details,
+    is_api_permission_error,
     cancel_ccxt_throttle_task,
     stop_exchange,
 )
@@ -182,6 +183,7 @@ from octobot_trading.api.orders import (
     parse_order_type,
     parse_order_status,
     get_order_profitability,
+    get_minimal_order_cost,
     create_order,
     cancel_all_open_orders,
     cancel_all_open_orders_with_currency,
@@ -298,6 +300,7 @@ __all__ = [
     "get_enabled_exchanges_names",
     "get_auto_filled_exchange_names",
     "get_exchange_details",
+    "is_api_permission_error",
     "cancel_ccxt_throttle_task",
     "stop_exchange",
     "get_trading_modes",
@@ -350,6 +353,7 @@ __all__ = [
     "parse_order_type",
     "parse_order_status",
     "get_order_profitability",
+    "get_minimal_order_cost",
     "create_order",
     "cancel_all_open_orders",
     "cancel_all_open_orders_with_currency",

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/api/exchange.py

@@ -322,6 +322,10 @@ async def get_exchange_details(
     )
 
 
+def is_api_permission_error(error: BaseException) -> bool:
+    return exchanges.is_api_permission_error(error)
+
+
 def cancel_ccxt_throttle_task():
     for task in asyncio.all_tasks():
         # manually cancel ccxt async throttle task since it apparently can't be cancelled otherwise

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/api/orders.py

@@ -80,3 +80,9 @@ def get_order_profitability(exchange_manager, order_id) -> float:
     except KeyError:
         # try in trades (order might be filled and stored in trades)
         return exchange_manager.exchange_personal_data.trades_manager.get_trade(order_id).trade_profitability
+
+
+def get_minimal_order_cost(exchange_manager, symbol) -> float:
+    return personal_data.get_minimal_order_cost(
+        exchange_manager.exchange.get_market_status(symbol, with_fixer=False)
+    )

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/constants.py

@@ -15,6 +15,7 @@
 #  License along with this library
 import decimal
 import os
+import typing
 
 import octobot_trading.enums as enums
 import octobot_commons.enums as commons_enums
@@ -120,6 +121,16 @@ SIMULATOR_TESTED_EXCHANGES = sorted(["bitfinex2", "bithumb", "bitstamp", "bittre
                               "hitbtc", "kraken", "poloniex", "bitso", "ndax", "upbit",
                               "wavesexchange"])
 
+# when ccxt is raising ccxt.ExchangeError instead of ccxt.AuthenticationError on api key permissions issue
+EXCHANGE_PERMISSION_ERRORS: typing.List[typing.Iterable[str]] = [
+    # OKX ex: okx {"msg":"API key doesn't exist","code":"50119"}
+    ("api", "key"),
+
+    # coinbase ex: coinbase {"error":"PERMISSION_DENIED",
+    # "error_details":"Missing required scopes","message":"Missing required scopes"}
+    ("permission_denied", )
+]
+
 CONFIG_DEFAULT_FEES = 0.001
 CONFIG_DEFAULT_SIMULATOR_FEES = 0
 

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/exchanges/__init__.py

@@ -76,6 +76,7 @@ from octobot_trading.exchanges.util import (
     get_local_exchange_manager,
     get_auto_filled_exchange_names,
     get_exchange_details,
+    is_api_permission_error,
     force_disable_web_socket,
     check_web_socket_config,
     search_websocket_class,
@@ -160,6 +161,7 @@ __all__ = [
     "get_local_exchange_manager",
     "get_auto_filled_exchange_names",
     "get_exchange_details",
+    "is_api_permission_error",
     "AbstractExchange",
     "is_channel_managed_by_websocket",
     "is_channel_fully_managed_by_websocket",

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/exchanges/types/rest_exchange.py

@@ -203,6 +203,11 @@ class RestExchange(abstract_exchange.AbstractExchange):
                 self.connector.log_ddos_error(e)
             raise errors.FailedRequest(f"Failed to order operation: {e.__class__.__name__} {e}") from e
         except Exception as e:
+            if exchanges_util.is_api_permission_error(e):
+                # invalid api key or missing trading rights
+                raise errors.AuthenticationError(
+                    f"Error when handling order {e}. Please make sure that trading permissions are on for this API key."
+                )
             self.log_order_creation_error(e, order_type, symbol, quantity, price, stop_price)
             print(traceback.format_exc(), file=sys.stderr)
             self.logger.exception(e, False, f"Unexpected error during order operation: {e}")

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/exchanges/util/__init__.py

@@ -44,6 +44,7 @@ from octobot_trading.exchanges.util.exchange_util import (
     get_exchange_class_from_name,
     get_auto_filled_exchange_names,
     get_exchange_details,
+    is_api_permission_error,
 )
 from octobot_trading.exchanges.util import websockets_util
 from octobot_trading.exchanges.util.websockets_util import (
@@ -76,6 +77,7 @@ __all__ = [
     "get_exchange_class_from_name",
     "get_auto_filled_exchange_names",
     "get_exchange_details",
+    "is_api_permission_error",
     "force_disable_web_socket",
     "check_web_socket_config",
     "search_websocket_class",

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/exchanges/util/exchange_util.py

@@ -426,3 +426,11 @@ def get_associated_symbol(exchange_manager, asset: str, target_asset: str) -> (t
         symbol = reversed_symbol
         is_reversed_symbol = True
     return symbol, is_reversed_symbol
+
+
+def is_api_permission_error(error: BaseException) -> bool:
+    lower_error = str(error).lower()
+    for identifiers in constants.EXCHANGE_PERMISSION_ERRORS:
+        if all(identifier in lower_error for identifier in identifiers):
+            return True
+    return False

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/personal_data/__init__.py

@@ -64,6 +64,7 @@ from octobot_trading.personal_data.orders import (
     OrdersUpdater,
     adapt_price,
     get_minimal_order_amount,
+    get_minimal_order_cost,
     decimal_adapt_price,
     adapt_quantity,
     decimal_adapt_quantity,
@@ -278,6 +279,7 @@ __all__ = [
     "OrdersUpdater",
     "adapt_price",
     "get_minimal_order_amount",
+    "get_minimal_order_cost",
     "decimal_adapt_price",
     "adapt_quantity",
     "decimal_adapt_quantity",

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/personal_data/orders/__init__.py

@@ -122,6 +122,7 @@ from octobot_trading.personal_data.orders.order_adapter import (
 )
 from octobot_trading.personal_data.orders.decimal_order_adapter import (
     get_minimal_order_amount,
+    get_minimal_order_cost,
     decimal_adapt_price,
     decimal_adapt_quantity,
     decimal_trunc_with_n_decimal_digits,
@@ -181,6 +182,7 @@ __all__ = [
     "OrdersUpdater",
     "adapt_price",
     "get_minimal_order_amount",
+    "get_minimal_order_cost",
     "decimal_adapt_price",
     "adapt_quantity",
     "decimal_adapt_quantity",

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/octobot_trading/personal_data/orders/decimal_order_adapter.py

@@ -40,6 +40,25 @@ def get_minimal_order_amount(symbol_market):
         raise errors.NotSupported("Impossible to get the minimal order size for the this exchange")
 
 
+def get_minimal_order_cost(symbol_market) -> float:
+    try:
+        min_cost = symbol_market[Ecmsc.LIMITS.value][Ecmsc.LIMITS_COST.value].get(Ecmsc.LIMITS_COST_MIN.value, None)
+        if min_cost:
+            return min_cost
+
+        min_amount = symbol_market[Ecmsc.LIMITS.value][Ecmsc.LIMITS_AMOUNT.value].get(
+            Ecmsc.LIMITS_AMOUNT_MIN.value, None
+        )
+        min_price = symbol_market[Ecmsc.LIMITS.value][Ecmsc.LIMITS_PRICE.value].get(
+            Ecmsc.LIMITS_PRICE_MIN.value, None
+        )
+        if min_amount and min_price:
+            return min_amount * min_price
+    except KeyError:
+        pass
+    raise errors.NotSupported("Impossible to get the minimal order size for the this exchange")
+
+
 def decimal_adapt_price(symbol_market, price, truncate=True):
     maximal_price_digits = symbol_market[Ecmsc.PRECISION.value].get(
                                                 Ecmsc.PRECISION_PRICE.value,

{OctoBot-Trading-2.4.69 → OctoBot-Trading-2.4.71}/tests_additional/real_exchanges/test_coinbase.py

@@ -32,7 +32,7 @@ class TestCoinbaseRealExchangeTester(RealExchangeTester):
     # ALL require authentication ?
     # https://github.com/ccxt/ccxt/issues/16719
     EXCHANGE_NAME = "coinbase"
-    SYMBOL = "BTC/USD"
+    SYMBOL = "BTC/USDT"
     SYMBOL_2 = "ETH/BTC"
     SYMBOL_3 = "ADA/BTC"
     REQUIRES_AUTH = True    # set True when even normally public apis require authentication