OctoBot-Trading 2.4.17__tar.gz → 2.4.18__tar.gz

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.4.18] - 2023-08-17
+### Updated
+- [CCXT] to version 4.0.65
+### Fixed
+- [Storage] handle corrupted db files auto fix
+
 ## [2.4.17] - 2023-08-16
 ### Added
 - [Orders] %s and %t amounts

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18/OctoBot_Trading.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.17
+Version: 2.4.18
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.17](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.18](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/OctoBot_Trading.egg-info/SOURCES.txt

@@ -435,6 +435,7 @@ tests_additional/real_exchanges/real_futures_exchange_tester.py
 tests_additional/real_exchanges/test_ascendex.py
 tests_additional/real_exchanges/test_binance.py
 tests_additional/real_exchanges/test_binance_futures.py
+tests_additional/real_exchanges/test_bingx.py
 tests_additional/real_exchanges/test_bitfinex.py
 tests_additional/real_exchanges/test_bitget.py
 tests_additional/real_exchanges/test_bithumb.py

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/OctoBot_Trading.egg-info/requires.txt

@@ -4,7 +4,7 @@ Async-Channel<2.3,>=2.2
 OctoBot-Commons<1.10,>=1.9
 OctoBot-Tentacles-Manager<2.10,>=2.9
 trading-backend>=1.2.7
-ccxt==3.1.52
+ccxt==4.0.65
 cryptography
 sortedcontainers==2.4.0
 tinydb==4.5.2

{OctoBot-Trading-2.4.17/OctoBot_Trading.egg-info → OctoBot-Trading-2.4.18}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.17
+Version: 2.4.18
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.17](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.18](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/README.md

@@ -1,4 +1,4 @@
-# OctoBot-Trading [2.4.17](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.18](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/__init__.py

@@ -15,4 +15,4 @@
 #  License along with this library.
 
 PROJECT_NAME = "OctoBot-Trading"
-VERSION = "2.4.17"  # major.minor.revision
+VERSION = "2.4.18"  # major.minor.revision

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/constants.py

@@ -78,7 +78,7 @@ FULL_CANDLE_HISTORY_EXCHANGES = [
     "bitstamp",
     "bybit",
     "gateio",
-    "hitbtc",
+    "bingx",
     "hollaex",
     "huobi",
     "huobipro",
@@ -103,8 +103,8 @@ TESTED_EXCHANGES = [
     "hollaex",
     "mexc",
 ]
-DEFAULT_FUTURE_EXCHANGES = ["binanceusdm", "bybit"]
-SIMULATOR_TESTED_EXCHANGES = ["bitfinex2", "bithumb", "bitstamp", "bittrex", "coinex",
+DEFAULT_FUTURE_EXCHANGES = ["bybit"]
+SIMULATOR_TESTED_EXCHANGES = ["bingx", "bitfinex2", "bithumb", "bitstamp", "bittrex", "coinex",
                               "hitbtc", "kraken", "poloniex", "bitso", "ndax", "upbit",
                               "wavesexchange"]
 

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/exchanges/adapters/abstract_adapter.py

@@ -69,6 +69,11 @@ class AbstractAdapter:
         fixed = self.fix_ticker(raw, **kwargs)
         return self.parse_ticker(fixed, **kwargs)
 
+    @_adapter
+    def adapt_ticker_from_kline(self, raw, symbol, **kwargs):
+        fixed = self.create_ticker_from_kline(raw, symbol, **kwargs)
+        return self.parse_ticker(fixed, **kwargs)
+
     @_adapter
     def adapt_balance(self, raw, **kwargs):
         fixed = self.fix_balance(raw, **kwargs)
@@ -166,6 +171,9 @@ class AbstractAdapter:
     def parse_ticker(self, fixed, **kwargs):
         raise NotImplementedError("parse_ticker is not implemented")
 
+    def create_ticker_from_kline(self, kline, symbol, **kwargs):
+        raise NotImplementedError("create_ticker_from_kline is not implemented")
+
     def fix_balance(self, raw, **kwargs):
         # add generic logic if necessary
         return raw

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/exchanges/connectors/ccxt/ccxt_adapter.py

@@ -109,6 +109,23 @@ class CCXTAdapter(adapters.AbstractAdapter):
         # CCXT standard ticker parsing logic
         return fixed
 
+    def create_ticker_from_kline(self, kline, symbol, **kwargs):
+        return {
+            enums.ExchangeConstantsTickersColumns.SYMBOL.value: symbol,
+            enums.ExchangeConstantsTickersColumns.TIMESTAMP.value: kline[common_enums.PriceIndexes.IND_PRICE_TIME.value],
+            enums.ExchangeConstantsTickersColumns.OPEN.value: kline[common_enums.PriceIndexes.IND_PRICE_OPEN.value],
+            enums.ExchangeConstantsTickersColumns.HIGH.value: kline[common_enums.PriceIndexes.IND_PRICE_HIGH.value],
+            enums.ExchangeConstantsTickersColumns.LOW.value: kline[common_enums.PriceIndexes.IND_PRICE_LOW.value],
+            enums.ExchangeConstantsTickersColumns.CLOSE.value: kline[common_enums.PriceIndexes.IND_PRICE_CLOSE.value],
+            enums.ExchangeConstantsTickersColumns.BASE_VOLUME.value: kline[common_enums.PriceIndexes.IND_PRICE_VOL.value],
+            enums.ExchangeConstantsTickersColumns.LAST.value: kline[common_enums.PriceIndexes.IND_PRICE_CLOSE.value],
+            enums.ExchangeConstantsTickersColumns.BID.value: None,
+            enums.ExchangeConstantsTickersColumns.BID_VOLUME.value: None,
+            enums.ExchangeConstantsTickersColumns.ASK.value: None,
+            enums.ExchangeConstantsTickersColumns.ASK_VOLUME.value: None,
+            enums.ExchangeConstantsTickersColumns.PREVIOUS_CLOSE.value: None,
+        }
+
     def fix_balance(self, raw, **kwargs):
         fixed = super().fix_balance(raw, **kwargs)
         # remove not currency specific keys
@@ -237,7 +254,7 @@ class CCXTAdapter(adapters.AbstractAdapter):
                     f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.UNREALISED_PNL.value, 0)}"),
                 enums.ExchangeConstantsPositionColumns.REALISED_PNL.value: constants.ZERO if is_empty else
                 decimal.Decimal(
-                    f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.REALISED_PNL.value, 0)}"),
+                    f"{fixed.get(ccxt_enums.ExchangePositionCCXTColumns.REALISED_PNL.value, 0) or 0}"),
                 enums.ExchangeConstantsPositionColumns.LIQUIDATION_PRICE.value: liquidation_price,
                 enums.ExchangeConstantsPositionColumns.MARK_PRICE.value: constants.ZERO if is_empty else
                 decimal.Decimal(

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/abstract_storage.py

@@ -169,3 +169,23 @@ class AbstractStorage:
             elif isinstance(val, types.FunctionType):
                 raise ValueError(f"{val.__name__} is a function, it can't be serialized")
         return sanitized
+
+    @staticmethod
+    def hard_reset_and_retry_if_necessary(fn):
+        """
+        Will retry the given function if a database hard reset error is raised
+        Warning: when it happens, will also completely reset the database
+        """
+        async def wrapper(*args, **kwargs):
+            try:
+                return await fn(*args, **kwargs)
+            except Exception as err:
+                database = args[0]._get_db()    # pylint: disable=protected-access
+                if database.is_hard_reset_error(err):
+                    logging.get_logger(args[0].__class__.__name__).warning(
+                        f"Resetting database due to [{err}] error"
+                    )
+                    await database.hard_reset()
+                    return await fn(*args, **kwargs)
+                raise
+        return wrapper

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/candles_storage.py

@@ -51,6 +51,7 @@ class CandlesStorage(abstract_storage.AbstractStorage):
                                        commons_enums.InitializationEventExchangeTopics.CANDLES.value)
         await self.store_candles()
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def store_candles(self):
         if not self.enabled:
             return

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/orders_storage.py

@@ -66,6 +66,7 @@ class OrdersStorage(abstract_storage.AbstractStorage):
             await self._add_historical_open_orders(order, update_type)
         await self.trigger_debounced_flush()
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def _update_history(self):
         await self._get_db().replace_all(
             self.HISTORY_TABLE,

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/portfolio_storage.py

@@ -29,6 +29,7 @@ class PortfolioStorage(abstract_storage.AbstractStorage):
     PRICE_INIT_TIMEOUT = 30
     HISTORY_TABLE = commons_enums.RunDatabases.HISTORICAL_PORTFOLIO_VALUE.value
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def store_history(self, reset=False):
         if not self.enabled:
             return

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/trades_storage.py

@@ -28,6 +28,7 @@ class TradesStorage(abstract_storage.AbstractStorage):
     LIVE_CHANNEL = channels_name.OctoBotTradingChannelsName.TRADES_CHANNEL.value
     HISTORY_TABLE = commons_enums.DBTables.TRADES.value
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def _live_callback(
         self,
         exchange: str,
@@ -65,6 +66,7 @@ class TradesStorage(abstract_storage.AbstractStorage):
             await authenticator.update_trades(history, self.exchange_manager.exchange_name, reset)
             self._to_update_auth_data_ids_buffer.clear()
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def _store_history(self):
         database = self._get_db()
         await database.replace_all(

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/octobot_trading/storage/transactions_storage.py

@@ -24,6 +24,7 @@ class TransactionsStorage(abstract_storage.AbstractStorage):
     IS_LIVE_CONSUMER = False
     HISTORY_TABLE = commons_enums.DBTables.TRANSACTIONS.value
 
+    @abstract_storage.AbstractStorage.hard_reset_and_retry_if_necessary
     async def _store_history(self):
         transactions = [
             transaction

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/requirements.txt

@@ -8,7 +8,7 @@ OctoBot-Tentacles-Manager>=2.9, <2.10
 trading-backend>=1.2.7
 
 # Exchange connection requirements
-ccxt==3.1.52 # always ensure real exchanges tests (in tests_additional and authenticated exchange tests) are passing before changing the ccxt version
+ccxt==4.0.65 # always ensure real exchanges tests (in tests_additional and authenticated exchange tests) are passing before changing the ccxt version
 
 cryptography # Never specify a version (managed by https://github.com/Drakkar-Software/OctoBot-PyPi-Linux-Deployer)
 

OctoBot-Trading-2.4.18/tests_additional/real_exchanges/test_bingx.py

@@ -0,0 +1,171 @@
+#  Drakkar-Software OctoBot-Trading
+#  Copyright (c) Drakkar-Software, All rights reserved.
+#
+#  This library is free software; you can redistribute it and/or
+#  modify it under the terms of the GNU Lesser General Public
+#  License as published by the Free Software Foundation; either
+#  version 3.0 of the License, or (at your option) any later version.
+#
+#  This library is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+#  Lesser General Public License for more details.
+#
+#  You should have received a copy of the GNU Lesser General Public
+#  License along with this library.
+import pytest
+
+from octobot_commons.enums import TimeFrames, PriceIndexes
+from octobot_trading.enums import ExchangeConstantsMarketStatusColumns as Ecmsc, \
+    ExchangeConstantsOrderBookInfoColumns as Ecobic, ExchangeConstantsOrderColumns as Ecoc, \
+    ExchangeConstantsTickersColumns as Ectc
+import octobot_trading.errors
+from tests_additional.real_exchanges.real_exchange_tester import RealExchangeTester
+# required to catch async loop context exceptions
+from tests import event_loop
+
+# All test coroutines will be treated as marked.
+pytestmark = pytest.mark.asyncio
+
+
+class TestBingxRealExchangeTester(RealExchangeTester):
+    EXCHANGE_NAME = "bingx"
+    SYMBOL = "BTC/USDT"
+    SYMBOL_2 = "ETH/BTC"
+    SYMBOL_3 = "SHIB/USDT"
+
+    async def _test_time_frames(self):
+        time_frames = await self.time_frames()
+        assert all(time_frame in time_frames for time_frame in (
+            TimeFrames.ONE_MINUTE.value,
+            TimeFrames.THREE_MINUTES.value,
+            TimeFrames.FIVE_MINUTES.value,
+            TimeFrames.FIFTEEN_MINUTES.value,
+            TimeFrames.THIRTY_MINUTES.value,
+            TimeFrames.ONE_HOUR.value,
+            TimeFrames.TWO_HOURS.value,
+            TimeFrames.FOUR_HOURS.value,
+            TimeFrames.SIX_HOURS.value,
+            TimeFrames.TWELVE_HOURS.value,
+            TimeFrames.ONE_DAY.value,
+            TimeFrames.THREE_DAYS.value,
+            TimeFrames.ONE_WEEK.value,
+            TimeFrames.ONE_MONTH.value
+        ))
+
+    async def test_get_market_status(self):
+        for market_status in await self.get_market_statuses():
+            assert market_status
+            assert market_status[Ecmsc.SYMBOL.value] in (self.SYMBOL, self.SYMBOL_2, self.SYMBOL_3)
+            assert market_status[Ecmsc.PRECISION.value]
+            assert int(market_status[Ecmsc.PRECISION.value][Ecmsc.PRECISION_AMOUNT.value]) == \
+                   market_status[Ecmsc.PRECISION.value][Ecmsc.PRECISION_AMOUNT.value]
+            assert int(market_status[Ecmsc.PRECISION.value][Ecmsc.PRECISION_PRICE.value]) == \
+                   market_status[Ecmsc.PRECISION.value][Ecmsc.PRECISION_PRICE.value]
+            assert all(elem in market_status[Ecmsc.LIMITS.value]
+                       for elem in (Ecmsc.LIMITS_AMOUNT.value,
+                                    Ecmsc.LIMITS_PRICE.value,
+                                    Ecmsc.LIMITS_COST.value))
+            self.check_market_status_limits(
+                market_status,
+                low_cost_max=10, low_cost_min=1,    # no suitable /BTC pair for now
+                has_price_limits=False
+            )
+
+    async def test_get_symbol_prices(self):
+        # without limit
+        symbol_prices = await self.get_symbol_prices()
+        assert len(symbol_prices) == 50
+        # check candles order (oldest first)
+        self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
+        # check last candle is the current candle
+        assert symbol_prices[-1][PriceIndexes.IND_PRICE_TIME.value] >= self.get_time() - self.get_allowed_time_delta()
+
+        # try with candles limit (used in candled updater)
+        symbol_prices = await self.get_symbol_prices(limit=1500)
+        # max candles is 1000
+        assert len(symbol_prices) == 1000
+        # check candles order (oldest first)
+        self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
+        # check last candle is the current candle
+        assert symbol_prices[-1][PriceIndexes.IND_PRICE_TIME.value] >= self.get_time() - self.get_allowed_time_delta()
+
+    async def test_get_historical_symbol_prices(self):
+        # try with since and limit (used in data collector)
+        for limit in (50, None):
+            symbol_prices = await self.get_symbol_prices(since=self.CANDLE_SINCE, limit=limit)
+            if limit:
+                assert len(symbol_prices) == limit
+            else:
+                assert len(symbol_prices) > 5
+            # check candles order (oldest first)
+            self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
+            # check that fetched candles are historical candles
+            max_candle_time = self.get_time_after_time_frames(self.CANDLE_SINCE_SEC, len(symbol_prices))
+            assert max_candle_time <= self.get_time()
+            for candle in symbol_prices:
+                assert self.CANDLE_SINCE_SEC <= candle[PriceIndexes.IND_PRICE_TIME.value] <= max_candle_time
+
+    async def test_get_kline_price(self):
+        kline_price = await self.get_kline_price()
+        assert len(kline_price) == 1
+        assert len(kline_price[0]) == 6
+        kline_start_time = kline_price[0][PriceIndexes.IND_PRICE_TIME.value]
+        # assert kline is the current candle
+        assert kline_start_time >= self.get_time() - self.get_allowed_time_delta()
+
+    async def test_get_order_book(self):
+        order_book = await self.get_order_book()
+        assert len(order_book[Ecobic.ASKS.value]) == 5
+        assert len(order_book[Ecobic.ASKS.value][0]) == 2
+        assert len(order_book[Ecobic.BIDS.value]) == 5
+        assert len(order_book[Ecobic.BIDS.value][0]) == 2
+
+    async def test_get_recent_trades(self):
+        recent_trades = await self.get_recent_trades()
+        assert len(recent_trades) == 50
+        # check trades order (oldest first)
+        self.ensure_elements_order(recent_trades, Ecoc.TIMESTAMP.value)
+
+    async def test_get_price_ticker(self):
+        # get_price_ticker is not support on spot market :
+        # to be fixed in this exchange tentacle using create_ticker_from_kline
+        with pytest.raises(octobot_trading.errors.FailedRequest):
+            ticker = await self.get_price_ticker()
+            # self._check_ticker(ticker, self.SYMBOL, check_content=True)
+
+    async def test_get_all_currencies_price_ticker(self):
+        # warning: fetches swap tickers
+        tickers = await self.get_all_currencies_price_ticker()
+        for symbol, ticker in tickers.items():
+            self._check_ticker(ticker, symbol)
+
+    @staticmethod
+    def _check_ticker(ticker, symbol, check_content=False):
+        assert ticker[Ectc.SYMBOL.value] == symbol
+        assert all(key in ticker for key in (
+            Ectc.HIGH.value,
+            Ectc.LOW.value,
+            Ectc.BID.value,
+            Ectc.BID_VOLUME.value,
+            Ectc.ASK.value,
+            Ectc.ASK_VOLUME.value,
+            Ectc.OPEN.value,
+            Ectc.CLOSE.value,
+            Ectc.LAST.value,
+            Ectc.PREVIOUS_CLOSE.value
+        ))
+        if check_content:
+            assert ticker[Ectc.HIGH.value]
+            assert ticker[Ectc.LOW.value]
+            assert ticker[Ectc.BID.value]
+            assert ticker[Ectc.BID_VOLUME.value]
+            assert ticker[Ectc.ASK.value]
+            assert ticker[Ectc.ASK_VOLUME.value]
+            assert ticker[Ectc.OPEN.value]
+            assert ticker[Ectc.CLOSE.value]
+            assert ticker[Ectc.LAST.value]
+            assert ticker[Ectc.PREVIOUS_CLOSE.value]
+            assert ticker[Ectc.BASE_VOLUME.value]
+            assert ticker[Ectc.TIMESTAMP.value]
+            RealExchangeTester.check_ticker_typing(ticker)

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_bybit.py

@@ -77,9 +77,9 @@ class TestBybitRealExchangeTester(RealExchangeTester):
         # check last candle is the current candle
         assert symbol_prices[-1][PriceIndexes.IND_PRICE_TIME.value] >= self.get_time() - self.get_allowed_time_delta()
 
-        # can't fetch more than 200 candles
+        # can't fetch more than 1000 candles
         symbol_prices = await self.get_symbol_prices(limit=1500)
-        assert len(symbol_prices) == 200
+        assert len(symbol_prices) == 1000
         # check candles order (oldest first)
         self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
         # check last candle is the current candle

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_bybit_futures.py

@@ -76,7 +76,7 @@ class TestBybitRealExchangeTester(RealFuturesExchangeTester):
         # without limit
         symbol_prices = await self.get_symbol_prices()
         assert len(symbol_prices) == 200
-        # max is 200 on Bybit
+        # max is 1000 on Bybit
         symbol_prices = await self.get_symbol_prices(limit=200)
         assert len(symbol_prices) == 200
         # check candles order (oldest first)
@@ -85,8 +85,8 @@ class TestBybitRealExchangeTester(RealFuturesExchangeTester):
         assert symbol_prices[-1][PriceIndexes.IND_PRICE_TIME.value] >= self.get_time() - self.get_allowed_time_delta()
 
         # fetching more than 200 candles is fetching candles from the past
-        symbol_prices = await self.get_symbol_prices(limit=500)
-        assert len(symbol_prices) == 200
+        symbol_prices = await self.get_symbol_prices(limit=1500)
+        assert len(symbol_prices) == 1000
         # check candles order (oldest first)
         self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
         # check last candle is the current candle

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_coinbase.py

@@ -18,7 +18,7 @@ import pytest
 import octobot_trading.errors
 from octobot_commons.enums import TimeFrames, PriceIndexes
 from octobot_trading.enums import ExchangeConstantsMarketStatusColumns as Ecmsc, \
-    ExchangeConstantsOrderColumns as Ecoc, \
+    ExchangeConstantsOrderBookInfoColumns as Ecobic, ExchangeConstantsOrderColumns as Ecoc, \
     ExchangeConstantsTickersColumns as Ectc
 from tests_additional.real_exchanges.real_exchange_tester import RealExchangeTester
 # required to catch async loop context exceptions
@@ -106,8 +106,11 @@ class TestCoinbaseRealExchangeTester(RealExchangeTester):
         assert kline_start_time >= self.get_time() - self.get_allowed_time_delta()
 
     async def test_get_order_book(self):
-        with pytest.raises(octobot_trading.errors.NotSupported):
-            await self.get_order_book()
+        order_book = await self.get_order_book()
+        assert len(order_book[Ecobic.ASKS.value]) == 5
+        assert len(order_book[Ecobic.ASKS.value][0]) == 2
+        assert len(order_book[Ecobic.BIDS.value]) == 5
+        assert len(order_book[Ecobic.BIDS.value][0]) == 2
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()
@@ -151,8 +154,8 @@ class TestCoinbaseRealExchangeTester(RealExchangeTester):
             assert ticker[Ectc.LAST.value]
             assert ticker[Ectc.PREVIOUS_CLOSE.value] is None
             assert ticker[Ectc.BASE_VOLUME.value] is None
-            assert ticker[Ectc.TIMESTAMP.value] is None  # will trigger an 'Ignored incomplete ticker'
+            assert ticker[Ectc.TIMESTAMP.value]
             RealExchangeTester.check_ticker_typing(
                 ticker,
-                check_open=False, check_high=False, check_low=False, check_timestamp=False, check_base_volume=False
+                check_open=False, check_high=False, check_low=False, check_base_volume=False
             )

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_hitbtc.py

@@ -71,7 +71,7 @@ class TestHitBtcRealExchangeTester(RealExchangeTester):
     async def test_get_symbol_prices(self):
         # without limit
         symbol_prices = await self.get_symbol_prices(sort='DESC')
-        assert len(symbol_prices) == 100
+        assert len(symbol_prices) == 10
         # check candles order (oldest first)
         self.ensure_elements_order(symbol_prices, PriceIndexes.IND_PRICE_TIME.value)
         # check last candle is the current candle
@@ -99,7 +99,9 @@ class TestHitBtcRealExchangeTester(RealExchangeTester):
             max_candle_time = self.get_time_after_time_frames(self.CANDLE_SINCE_SEC, len(symbol_prices))
             assert max_candle_time <= self.get_time()
             for candle in symbol_prices:
-                assert self.CANDLE_SINCE_SEC <= candle[PriceIndexes.IND_PRICE_TIME.value] <= max_candle_time
+                assert self.CANDLE_SINCE_SEC <= candle[PriceIndexes.IND_PRICE_TIME.value]
+                # invalid max time: history is not supported
+                assert max_candle_time <= candle[PriceIndexes.IND_PRICE_TIME.value]
 
     async def test_get_kline_price(self):
         kline_price = await self.get_kline_price(sort='DESC')  # to be fixed in hitbtc tentacle

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_okx.py

@@ -68,7 +68,8 @@ class TestOkxRealExchangeTester(RealExchangeTester):
                                             normal_cost_min=1e-09,
                                             low_cost_min=1e-08,
                                             expect_invalid_price_limit_values=False,
-                                            enable_price_and_cost_comparison=False)
+                                            enable_price_and_cost_comparison=False,
+                                            has_price_limits=False)
 
     async def test_get_symbol_prices(self):
         # without limit

{OctoBot-Trading-2.4.17 → OctoBot-Trading-2.4.18}/tests_additional/real_exchanges/test_okx_futures.py

@@ -67,7 +67,8 @@ class TestOkxFuturesRealExchangeTester(RealFuturesExchangeTester):
             self.check_market_status_limits(market_status,
                                             low_price_max=1e-05,
                                             expect_invalid_price_limit_values=False,
-                                            enable_price_and_cost_comparison=True)
+                                            enable_price_and_cost_comparison=True,
+                                            has_price_limits=False)
 
     async def test_get_symbol_prices(self):
         # without limit