OctoBot-Trading 2.4.177__tar.gz → 2.4.179__tar.gz

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.4.179] - 2025-05-24
+### Added 
+[Amounts] "p" as position percent alias
+### Fixed
+[Orders] rare simulated available order locked funds issue 
+
+## [2.4.178] - 2025-05-23
+### Updated
+[CCXT] update ccxt to 4.4.85
+
 ## [2.4.177] - 2025-05-20
 ### Added 
 [Orders] add inactive orders to handle simultaneous stop & Take profit spot orders

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179/OctoBot_Trading.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.177
+Version: 2.4.179
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.177](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.179](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/OctoBot_Trading.egg-info/requires.txt

@@ -4,7 +4,7 @@ Async-Channel<2.3,>=2.2
 OctoBot-Commons<1.10,>=1.9.64
 OctoBot-Tentacles-Manager<2.10,>=2.9
 trading-backend>=1.2.35
-ccxt==4.4.72
+ccxt==4.4.85
 aiohttp_socks==0.10.1
 cryptography
 sortedcontainers==2.4.0

{OctoBot-Trading-2.4.177/OctoBot_Trading.egg-info → OctoBot-Trading-2.4.179}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.177
+Version: 2.4.179
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.177](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.179](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/README.md

@@ -1,4 +1,4 @@
-# OctoBot-Trading [2.4.177](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.179](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/__init__.py

@@ -15,4 +15,4 @@
 #  License along with this library.
 
 PROJECT_NAME = "OctoBot-Trading"
-VERSION = "2.4.177"  # major.minor.revision
+VERSION = "2.4.179"  # major.minor.revision

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/constants.py

@@ -109,7 +109,7 @@ NaN = decimal.Decimal("nan")
 
 # exchanges where test_get_historical_symbol_prices is successful can be listed here
 FULL_CANDLE_HISTORY_EXCHANGES = [
-    "ascendex",
+    # "ascendex",   broken since ccxt==4.4.85
     "binance",
     "bitfinex",
     "bitstamp",

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/exchanges/types/rest_exchange.py

@@ -995,7 +995,16 @@ class RestExchange(abstract_exchange.AbstractExchange):
         :return: the update result
         """
         if self.SUPPORTS_SET_MARGIN_TYPE:
-            return await self.connector.set_symbol_margin_type(symbol=symbol, isolated=isolated, **kwargs)
+            try:
+                return await self.connector.set_symbol_margin_type(symbol=symbol, isolated=isolated, **kwargs)
+            except Exception as e:
+                if self.is_api_permission_error(e):
+                    # invalid api key or missing trading rights
+                    raise errors.AuthenticationError(
+                        f"Error when handling order {html_util.get_html_summary_if_relevant(e)}. "
+                        f"Please make sure that trading permissions are on for this API key."
+                    ) from e
+                raise
         raise errors.NotSupported(f"set_symbol_margin_type is not supported on {self.get_name()}")
 
     async def set_symbol_position_mode(self, symbol: str, one_way: bool):

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/modes/mode_config.py

@@ -38,8 +38,8 @@ def get_activated_trading_mode(tentacles_setup_config):
 
             if len(trading_modes) > 1:
                 raise errors.ConfigTradingError(
-                    f"More than one activated trading mode found in your tentacle configuration, "
-                    f"please activate only one")
+                    f"More than one activated trading mode found in your tentacle configuration: "
+                    f"{', '.join(trading_modes)}, please activate only one.")
 
             elif trading_modes:
                 trading_mode_class = class_inspector.get_deep_class_from_parent_subclasses(trading_modes[0],

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/modes/script_keywords/basic_keywords/amount.py

@@ -77,7 +77,7 @@ async def get_amount_from_input_amount(
                 assets, commons_symbols.parse_symbol(context.symbol).base
             )
         amount_value = total_symbol_assets_holdings_value * amount_value / trading_constants.ONE_HUNDRED
-    elif amount_type is dsl.QuantityType.POSITION_PERCENT:
+    elif amount_type in (dsl.QuantityType.POSITION_PERCENT, dsl.QuantityType.POSITION_PERCENT_ALIAS):
         if context.exchange_manager.is_future:
             if position_kw.is_in_one_way_position_mode(context):
                 # use abs() since short positions have negative size

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/modes/script_keywords/dsl/values.py

@@ -24,10 +24,10 @@ class QuantityType(enum.Enum):
     DELTA_BASE = "b"
     PERCENT = "%"
     AVAILABLE = "a"
-    POSITION = "p"
     ENTRY = "e"
     AVAILABLE_PERCENT = "a%"
     POSITION_PERCENT = "p%"
+    POSITION_PERCENT_ALIAS = "p"
     ENTRY_PERCENT = "e%"
     CURRENT_SYMBOL_ASSETS_PERCENT = "s%"
     TRADED_SYMBOLS_ASSETS_PERCENT = "t%"

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/octobot_channel_consumer.py

@@ -76,7 +76,7 @@ async def _handle_creation(bot_id, action, data):
                 modes.get_activated_trading_mode(data[OctoBotChannelTradingDataKeys.TENTACLES_SETUP_CONFIG.value])
             except commons_errors.ConfigTradingError:
                 logging.get_logger(OCTOBOT_CHANNEL_TRADING_CONSUMER_LOGGER_TAG).error(
-                    f"No configured trading mode. in order to trade, selected a profile with a trading mode."
+                    f"No configured trading mode. In order to trade, selected a profile with a trading mode."
                 )
                 # do not raise on missing trading mode
                 exchange_builder.disable_trading_mode()

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/personal_data/orders/order_util.py

@@ -406,10 +406,11 @@ def get_fees_for_currency(fee, currency):
     return constants.ZERO
 
 
-def get_order_locked_amount(order: order_import.Order) -> decimal.Decimal:
+def get_order_locked_amount(order: order_import.Order, force_use_origin_quantity_and_price=False) -> decimal.Decimal:
     # take fees into account when in locked asset
     # ( a BTC/USDT order with USDT fees need to lock USDT fees to be able to pay them)
-    forecasted_fees = order.get_computed_fee(use_origin_quantity_and_price=not order.is_filled())
+    use_origin_quantity_and_price = force_use_origin_quantity_and_price or not order.is_filled()
+    forecasted_fees = order.get_computed_fee(use_origin_quantity_and_price=use_origin_quantity_and_price)
     base, quote = symbol_util.parse_symbol(order.symbol).base_and_quote()
     # when buy order
     if order.side == enums.TradeOrderSide.BUY:

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/octobot_trading/personal_data/portfolios/types/spot_portfolio.py

@@ -65,22 +65,14 @@ class SpotPortfolio(portfolio_class.Portfolio):
 
     def update_portfolio_available_from_order(self, order, is_new_order=True):
         """
-        Realise portfolio availability update
+        Realize portfolio availability update
         :param order: the order that triggers the portfolio update
-        :param is_new_order: True when the order is being created, False when cancelled
+        :param is_new_order: True when the order is being created, False when canceled
         """
         multiplier = constants.ONE if is_new_order else -constants.ONE
 
-        # when buy order
-        if order.side == enums.TradeOrderSide.BUY:
-            new_quantity = - order_util.get_order_locked_amount(order) * multiplier
-            self._update_portfolio_data(order.market,
-                                        available_value=new_quantity,
-                                        total_value=constants.ZERO)
-
-        # when sell order
-        else:
-            new_quantity = - order_util.get_order_locked_amount(order) * multiplier
-            self._update_portfolio_data(order.currency,
-                                        available_value=new_quantity,
-                                        total_value=constants.ZERO)
+        # force_use_origin_quantity_and_price is True here to ensure symetry between funds locked to open orders and
+        # funds released orders are not open anymore
+        new_quantity = -order_util.get_order_locked_amount(order, force_use_origin_quantity_and_price=True) * multiplier
+        unit = order.market if order.side == enums.TradeOrderSide.BUY else order.currency
+        self._update_portfolio_data(unit, available_value=new_quantity, total_value=constants.ZERO)

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/requirements.txt

@@ -8,7 +8,7 @@ OctoBot-Tentacles-Manager>=2.9, <2.10
 trading-backend>=1.2.35
 
 # Exchange connection requirements
-ccxt==4.4.72 # always ensure real exchanges tests (in tests_additional and authenticated exchange tests) are passing before changing the ccxt version
+ccxt==4.4.85 # always ensure real exchanges tests (in tests_additional and authenticated exchange tests) are passing before changing the ccxt version
 aiohttp_socks==0.10.1   # used by ccxt socks proxy aiohttp connectors
 
 cryptography # Never specify a version (managed by https://github.com/Drakkar-Software/OctoBot-PyPi-Linux-Deployer)

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests/modes/script_keywords/basic_keywords/test_amount.py

@@ -265,7 +265,7 @@ async def test_get_amount_from_input_amount_for_position(null_context):
     ) as is_in_one_way_position_mode_mock:
         with pytest.raises(NotImplementedError):
             await script_keywords.get_amount_from_input_amount(
-                null_context, f"1{script_keywords.QuantityType.POSITION_PERCENT.value}"
+                null_context, f"1{script_keywords.QuantityType.POSITION_PERCENT_ALIAS.value}"
             )
         is_in_one_way_position_mode_mock.assert_called_once_with(null_context)
 
@@ -276,7 +276,7 @@ async def test_get_amount_from_input_amount_for_position(null_context):
             as get_position_mock, mock.patch.object(account_balance, "adapt_amount_to_holdings",
           mock.AsyncMock(return_value=decimal.Decimal(1))) as adapt_amount_to_holdings_mock):
         assert await script_keywords.get_amount_from_input_amount(
-            null_context, f"1{script_keywords.QuantityType.POSITION_PERCENT.value}"
+            null_context, f"1{script_keywords.QuantityType.POSITION_PERCENT_ALIAS.value}"
         ) == decimal.Decimal(1)
         is_in_one_way_position_mode_mock.assert_called_once_with(null_context)
         get_position_mock.assert_called_once()

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests/modes/script_keywords/dsl/test_quantity.py

@@ -75,16 +75,16 @@ def test_parse_quantity_types():
     assert script_keywords.parse_quantity("%p") == (script_keywords.QuantityType.POSITION_PERCENT, None)
     assert script_keywords.parse_quantity("-0.11p%") == (
         script_keywords.QuantityType.POSITION_PERCENT, decimal.Decimal("-0.11"))
-    assert script_keywords.parse_quantity("-0.11%p") == (
-        script_keywords.QuantityType.POSITION_PERCENT, decimal.Decimal("-0.11"))
+    assert script_keywords.parse_quantity("-0.11p") == (
+        script_keywords.QuantityType.POSITION_PERCENT_ALIAS, decimal.Decimal("-0.11"))
     assert script_keywords.parse_quantity("%p-0.11") == (
         script_keywords.QuantityType.POSITION_PERCENT, decimal.Decimal("-0.11"))
 
-    assert script_keywords.parse_quantity("p") == (script_keywords.QuantityType.POSITION, None)
+    assert script_keywords.parse_quantity("p") == (script_keywords.QuantityType.POSITION_PERCENT_ALIAS, None)
     assert script_keywords.parse_quantity("-0.11p") == (
-        script_keywords.QuantityType.POSITION, decimal.Decimal("-0.11"))
+        script_keywords.QuantityType.POSITION_PERCENT_ALIAS, decimal.Decimal("-0.11"))
     assert script_keywords.parse_quantity("p-0.11") == (
-        script_keywords.QuantityType.POSITION, decimal.Decimal("-0.11"))
+        script_keywords.QuantityType.POSITION_PERCENT_ALIAS, decimal.Decimal("-0.11"))
 
     assert script_keywords.parse_quantity("@") == (script_keywords.QuantityType.FLAT, None)
     assert script_keywords.parse_quantity("-0.11@") == (script_keywords.QuantityType.FLAT, decimal.Decimal("-0.11"))

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests/personal_data/portfolios/types/test_spot_portfolio.py

@@ -14,14 +14,11 @@
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
 import decimal
-
+import mock
 import pytest
-from octobot_commons.constants import PORTFOLIO_TOTAL, PORTFOLIO_AVAILABLE
 
-from octobot_trading.enums import TraderOrderType
-from octobot_trading.personal_data.orders.types.limit.sell_limit_order import SellLimitOrder
-from octobot_trading.personal_data.orders.types.market.buy_market_order import BuyMarketOrder
-from octobot_trading.personal_data.portfolios.types.spot_portfolio import SpotPortfolio
+import octobot_trading.enums
+import octobot_trading.personal_data as personal_data
 from tests.exchanges import backtesting_trader, backtesting_config, backtesting_exchange_manager, fake_backtesting
 
 # All test coroutines will be treated as marked.
@@ -32,7 +29,7 @@ async def test_initial_portfolio(backtesting_trader):
     config, exchange_manager, trader = backtesting_trader
     portfolio_manager = exchange_manager.exchange_personal_data.portfolio_manager
 
-    assert isinstance(portfolio_manager.portfolio, SpotPortfolio)
+    assert isinstance(portfolio_manager.portfolio, personal_data.SpotPortfolio)
 
 
 async def test_update_portfolio_data_from_order(backtesting_trader):
@@ -46,8 +43,8 @@ async def test_update_portfolio_available_from_order(backtesting_trader):
     portfolio_manager = exchange_manager.exchange_personal_data.portfolio_manager
 
     # Test buy order
-    market_buy = BuyMarketOrder(trader)
-    market_buy.update(order_type=TraderOrderType.BUY_MARKET,
+    market_buy = personal_data.BuyMarketOrder(trader)
+    market_buy.update(order_type=octobot_trading.enums.TraderOrderType.BUY_MARKET,
                       symbol="BTC/USDT",
                       current_price=70,
                       quantity=10,
@@ -68,8 +65,8 @@ async def test_update_portfolio_available_from_order(backtesting_trader):
     assert portfolio_manager.portfolio.get_currency_portfolio("USDT").total == decimal.Decimal('1000')
 
     # Test sell order
-    limit_sell = SellLimitOrder(trader)
-    limit_sell.update(order_type=TraderOrderType.SELL_LIMIT,
+    limit_sell = personal_data.SellLimitOrder(trader)
+    limit_sell.update(order_type=octobot_trading.enums.TraderOrderType.SELL_LIMIT,
                       symbol="BTC/USDT",
                       current_price=60,
                       quantity=8,
@@ -88,3 +85,49 @@ async def test_update_portfolio_available_from_order(backtesting_trader):
     assert portfolio_manager.portfolio.get_currency_portfolio("USDT").available == decimal.Decimal('1000')
     assert portfolio_manager.portfolio.get_currency_portfolio("BTC").total == decimal.Decimal('10')
     assert portfolio_manager.portfolio.get_currency_portfolio("USDT").total == decimal.Decimal('1000')
+
+    # Test buy order with large USDT fee
+    limit_buy = personal_data.BuyLimitOrder(trader)
+    limit_buy.update(order_type=octobot_trading.enums.TraderOrderType.BUY_LIMIT,
+                      symbol="BTC/USDT",
+                      current_price=60,
+                      quantity=8,
+                      price=60)
+    fee = {
+        octobot_trading.enums.FeePropertyColumns.IS_FROM_EXCHANGE.value: True,
+        octobot_trading.enums.FeePropertyColumns.COST.value: 54.111111,
+        octobot_trading.enums.FeePropertyColumns.CURRENCY.value: "USDT",
+    }
+
+    # even if order is filled, always update available funds with use_origin_quantity_and_price and taker fees
+    with (mock.patch.object(limit_buy, "is_filled", mock.Mock(return_value=True)) as is_filled_value_mock,
+          mock.patch.object(limit_buy.exchange_manager.exchange, "get_trade_fee", mock.Mock(return_value=fee)) as get_trade_fee_mock):
+        # test buy order creation
+        portfolio_manager.portfolio.update_portfolio_available(limit_buy, True)
+        get_trade_fee_mock.assert_called_once_with(
+            limit_buy.symbol, limit_buy.order_type, limit_buy.origin_quantity, limit_buy.origin_price,
+            octobot_trading.enums.ExchangeConstantsOrderColumns.TAKER.value,
+        )
+        get_trade_fee_mock.reset_mock()
+        is_filled_value_mock.assert_not_called()
+        assert portfolio_manager.portfolio.get_currency_portfolio("BTC").available == decimal.Decimal('10')
+        # cost with fees = 60 * 8 + 54.111111 = 534.111111
+        assert portfolio_manager.portfolio.get_currency_portfolio("USDT").available == (
+            decimal.Decimal('1000') - decimal.Decimal('534.111111')
+        )
+        assert portfolio_manager.portfolio.get_currency_portfolio("BTC").total == decimal.Decimal('10')
+        assert portfolio_manager.portfolio.get_currency_portfolio("USDT").total == decimal.Decimal('1000')
+
+        # test buy order canceled --> return to init state and the update_portfolio will sync TOTAL with AVAILABLE
+        portfolio_manager.portfolio.update_portfolio_available(limit_buy, False)
+        get_trade_fee_mock.assert_called_once_with(
+            limit_buy.symbol, limit_buy.order_type, limit_buy.origin_quantity, limit_buy.origin_price,
+            octobot_trading.enums.ExchangeConstantsOrderColumns.TAKER.value,
+        )
+        get_trade_fee_mock.reset_mock()
+        is_filled_value_mock.assert_not_called()
+        assert portfolio_manager.portfolio.get_currency_portfolio("BTC").available == decimal.Decimal('10')
+        assert portfolio_manager.portfolio.get_currency_portfolio("USDT").available == decimal.Decimal('1000')
+        assert portfolio_manager.portfolio.get_currency_portfolio("BTC").total == decimal.Decimal('10')
+        assert portfolio_manager.portfolio.get_currency_portfolio("USDT").total == decimal.Decimal('1000')
+

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_ascendex.py

@@ -13,6 +13,9 @@
 #
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
+import time
+import datetime
+
 import pytest
 
 from octobot_commons.enums import TimeFrames, PriceIndexes
@@ -32,6 +35,7 @@ class TestAscendExRealExchangeTester(RealExchangeTester):
     SYMBOL = "BTC/USDT"
     SYMBOL_2 = "ETH/BTC"
     SYMBOL_3 = "KAI/USDT"
+    # CANDLE_SINCE = round(time.time() - datetime.timedelta(days = 30.5*6).total_seconds())  # now - 6 months
 
     async def test_time_frames(self):
         time_frames = await self.time_frames()
@@ -89,8 +93,11 @@ class TestAscendExRealExchangeTester(RealExchangeTester):
 
     async def test_get_historical_symbol_prices(self):
         # try with since and limit (used in data collector)
-        for limit in (50, None):
+        for limit in (500, None):
             symbol_prices = await self.get_symbol_prices(since=self.CANDLE_SINCE, limit=limit)
+            # broken since ccxt==4.4.85
+            assert symbol_prices == []
+            continue
             if limit:
                 assert len(symbol_prices) == limit
             else:
@@ -104,7 +111,8 @@ class TestAscendExRealExchangeTester(RealExchangeTester):
                 assert self.CANDLE_SINCE_SEC <= candle[PriceIndexes.IND_PRICE_TIME.value] <= max_candle_time
 
     async def test_get_historical_ohlcv(self):
-        await super().test_get_historical_ohlcv()
+        # broken since ccxt==4.4.85
+        assert await self.get_historical_ohlcv() == []
 
     async def test_get_kline_price(self):
         kline_price = await self.get_kline_price()

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_bitfinex.py

@@ -184,9 +184,9 @@ class TestBitfinexRealExchangeTester(RealExchangeTester):
             assert ticker[Ectc.HIGH.value]
             assert ticker[Ectc.LOW.value]
             assert ticker[Ectc.BID.value]
-            assert ticker[Ectc.BID_VOLUME.value]
+            assert ticker[Ectc.BID_VOLUME.value] is None
             assert ticker[Ectc.ASK.value]
-            assert ticker[Ectc.ASK_VOLUME.value]
+            assert ticker[Ectc.ASK_VOLUME.value] is None
             assert ticker[Ectc.OPEN.value]
             assert ticker[Ectc.CLOSE.value]
             assert ticker[Ectc.LAST.value]

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_coinbase.py

@@ -49,7 +49,7 @@ class TestCoinbaseRealExchangeTester(RealExchangeTester):
         ))
 
     async def test_active_symbols(self):
-        await self.inner_test_active_symbols(800, 900)
+        await self.inner_test_active_symbols(700, 700)
 
     async def test_get_market_status(self):
         for market_status in await self.get_market_statuses():

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_phemex.py

@@ -55,7 +55,7 @@ class TestPhemexRealExchangeTester(RealExchangeTester):
         ))
 
     async def test_active_symbols(self):
-        await self.inner_test_active_symbols(600, 900)
+        await self.inner_test_active_symbols(900, 1100)
 
     async def test_get_market_status(self):
         for market_status in await self.get_market_statuses():

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_upbit.py

@@ -114,16 +114,16 @@ class TestUpbitRealExchangeTester(RealExchangeTester):
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
         assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
-        assert len(order_book[Ecobic.ASKS.value]) == 15
+        assert len(order_book[Ecobic.ASKS.value]) == 30
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
-        assert len(order_book[Ecobic.BIDS.value]) == 15
+        assert len(order_book[Ecobic.BIDS.value]) == 30
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
         
     async def test_get_order_books(self):
         await self.inner_test_get_order_books(
             True,
             400, # asked symbols
-            15, # up to 15 orders
+            30, # up to 15 orders
             0, # up to 15 orders
             False,
             10,

{OctoBot-Trading-2.4.177 → OctoBot-Trading-2.4.179}/tests_additional/real_exchanges/test_wavesexchange.py

@@ -54,7 +54,7 @@ class TestWavesExchangeRealExchangeTester(RealExchangeTester):
         ))
 
     async def test_active_symbols(self):
-        await self.inner_test_active_symbols(20, 20)
+        await self.inner_test_active_symbols(30, 30)
 
     async def test_get_market_status(self):
         for market_status in await self.get_market_statuses():