OctoBot-Trading 2.4.101__tar.gz → 2.4.103__tar.gz

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.4.103] - 2024-08-25
+### Added
+- [API] add supports_custom_limit_order_book_fetch
+
+## [2.4.102] - 2024-08-24
+### Added
+- [Exchanges] add get_order_books
+- [API] add get_daily_base_and_quote_volume_from_ticker
+
 ## [2.4.101] - 2024-08-22
 ### Added
 - [Leverage] add ccxt leverage

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103/OctoBot_Trading.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.101
+Version: 2.4.103
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.101](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.103](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.101/OctoBot_Trading.egg-info → OctoBot-Trading-2.4.103}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: OctoBot-Trading
-Version: 2.4.101
+Version: 2.4.103
 Summary: OctoBot project trading package
 Home-page: https://github.com/Drakkar-Software/OctoBot-Trading
 Author: Drakkar-Software
@@ -16,7 +16,7 @@ Classifier: Operating System :: POSIX
 Requires-Python: >=3.8
 License-File: LICENSE
 
-# OctoBot-Trading [2.4.101](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.103](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/README.md

@@ -1,4 +1,4 @@
-# OctoBot-Trading [2.4.101](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
+# OctoBot-Trading [2.4.103](https://github.com/Drakkar-Software/OctoBot-Trading/blob/master/CHANGELOG.md)
 [![Codacy Badge](https://api.codacy.com/project/badge/Grade/903b6b22bceb4661b608a86fea655f69)](https://app.codacy.com/gh/Drakkar-Software/OctoBot-Trading?utm_source=github.com&utm_medium=referral&utm_content=Drakkar-Software/OctoBot-Trading&utm_campaign=Badge_Grade_Dashboard)
 [![PyPI](https://img.shields.io/pypi/v/OctoBot-Trading.svg)](https://pypi.python.org/pypi/OctoBot-Trading/)
 [![Coverage Status](https://coveralls.io/repos/github/Drakkar-Software/OctoBot-Trading/badge.svg?branch=master)](https://coveralls.io/github/Drakkar-Software/OctoBot-Trading?branch=master)

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/__init__.py

@@ -15,4 +15,4 @@
 #  License along with this library.
 
 PROJECT_NAME = "OctoBot-Trading"
-VERSION = "2.4.101"  # major.minor.revision
+VERSION = "2.4.103"  # major.minor.revision

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/api/__init__.py

@@ -43,6 +43,7 @@ from octobot_trading.api.symbol_data import (
     get_symbol_low_candles,
     get_symbol_volume_candles,
     get_daily_base_and_quote_volume,
+    get_daily_base_and_quote_volume_from_ticker,
     get_symbol_time_candles,
     create_new_candles_manager,
     force_set_mark_price,
@@ -122,6 +123,7 @@ from octobot_trading.api.exchange import (
     store_history_in_run_storage,
     get_enabled_exchanges_names,
     get_auto_filled_exchange_names,
+    supports_custom_limit_order_book_fetch,
     get_exchange_details,
     cancel_ccxt_throttle_task,
     stop_exchange,
@@ -234,6 +236,7 @@ __all__ = [
     "get_symbol_low_candles",
     "get_symbol_volume_candles",
     "get_daily_base_and_quote_volume",
+    "get_daily_base_and_quote_volume_from_ticker",
     "get_symbol_time_candles",
     "create_new_candles_manager",
     "force_set_mark_price",
@@ -307,6 +310,7 @@ __all__ = [
     "store_history_in_run_storage",
     "get_enabled_exchanges_names",
     "get_auto_filled_exchange_names",
+    "supports_custom_limit_order_book_fetch",
     "get_exchange_details",
     "cancel_ccxt_throttle_task",
     "stop_exchange",

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/api/exchange.py

@@ -324,6 +324,10 @@ def get_auto_filled_exchange_names(tentacles_setup_config) -> list:
     return exchanges.get_auto_filled_exchange_names(tentacles_setup_config)
 
 
+def supports_custom_limit_order_book_fetch(exchange_manager) -> bool:
+    return exchange_manager.exchange.SUPPORTS_CUSTOM_LIMIT_ORDER_BOOK_FETCH
+
+
 async def get_exchange_details(
     exchange_name, is_autofilled, tentacles_setup_config, aiohttp_session
 ) -> exchanges.ExchangeDetails:

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/api/symbol_data.py

@@ -14,6 +14,7 @@
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
 import decimal
+import typing
 
 import octobot_commons.enums
 
@@ -95,14 +96,25 @@ def get_symbol_volume_candles(symbol_data, time_frame, limit=-1, include_in_cons
 
 
 def get_daily_base_and_quote_volume(symbol_data, reference_price: decimal.Decimal) -> (decimal.Decimal, decimal.Decimal):
-    base_volume = symbol_data.ticker_manager.ticker.get(
+    return get_daily_base_and_quote_volume_from_ticker(
+        symbol_data.ticker_manager.ticker, reference_price=reference_price
+    )
+
+
+def get_daily_base_and_quote_volume_from_ticker(
+    ticker: dict, reference_price: typing.Optional[decimal.Decimal] = None
+) -> (decimal.Decimal, decimal.Decimal):
+    base_volume = ticker.get(
         octobot_trading.enums.ExchangeConstantsTickersColumns.BASE_VOLUME.value,
         "nan"
     )
-    quote_volume = symbol_data.ticker_manager.ticker.get(
+    quote_volume = ticker.get(
         octobot_trading.enums.ExchangeConstantsTickersColumns.QUOTE_VOLUME.value,
         "nan"
     )
+    reference_price = reference_price or decimal.Decimal(str(
+        ticker[octobot_trading.enums.ExchangeConstantsTickersColumns.CLOSE.value]
+    ))
     if base_volume:
         base_volume = decimal.Decimal(str(base_volume))
         if not quote_volume or decimal.Decimal(str(quote_volume)).is_nan():

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/exchanges/connectors/ccxt/ccxt_adapter.py

@@ -14,6 +14,7 @@
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
 import decimal
+import time
 
 import octobot_trading.exchanges.adapters as adapters
 import octobot_trading.exchanges.connectors.ccxt.enums as ccxt_enums
@@ -199,6 +200,17 @@ class CCXTAdapter(adapters.AbstractAdapter):
     def fix_order_book(self, raw, **kwargs):
         fixed = super().fix_order_book(raw, **kwargs)
         # CCXT standard order_book fixing logic
+        try:
+            exchange_timestamp = fixed[enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value]
+            if exchange_timestamp is None:
+                # force current time
+                fixed[enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value] =  time.time()
+            else:
+                fixed[enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value] = self.get_uniformized_timestamp(
+                    exchange_timestamp
+                )
+        except KeyError as e:
+            self.logger.error(f"Fail to convert order book timestamp ({e})")
         return fixed
 
     def parse_order_book(self, fixed, **kwargs):

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/exchanges/connectors/ccxt/ccxt_connector.py

@@ -311,6 +311,28 @@ class CCXTConnector(abstract_exchange.AbstractExchange):
         except ccxt.BaseError as e:
             raise octobot_trading.errors.FailedRequest(f"Failed to get_order_book {e}")
 
+    # return bidasks on each side of the order book stack for each given symbol
+    @ccxt_client_util.converted_ccxt_common_errors
+    async def get_order_books(
+        self, symbols: typing.Optional[list[str]], limit: int = 5, **kwargs: dict
+    ) -> typing.Optional[dict]:
+        """
+        WARNING: not always supported by exchanges.
+        Raises octobot_trading.errors.NotSupported when not supported
+        :return: a dict of order book by symbol
+        """
+        try:
+            with self.error_describer():
+                book_by_symbol = await self.client.fetch_order_books(symbols=symbols, limit=limit, params=kwargs)
+                return {
+                    symbol: self.adapter.adapt_order_book(book)
+                    for symbol, book in book_by_symbol.items()
+                }
+        except ccxt.NotSupported:
+            raise octobot_trading.errors.NotSupported
+        except ccxt.BaseError as e:
+            raise octobot_trading.errors.FailedRequest(f"Failed to get_order_books {e}")
+
     @ccxt_client_util.converted_ccxt_common_errors
     async def get_recent_trades(self, symbol: str, limit: int = 50, **kwargs: dict) -> typing.Optional[list]:
         try:

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/octobot_trading/exchanges/types/rest_exchange.py

@@ -94,6 +94,8 @@ class RestExchange(abstract_exchange.AbstractExchange):
     CAN_HAVE_DELAYED_OPEN_ORDERS = False
     # Set True when get_cancelled_order() can return outdated open orders
     CAN_HAVE_DELAYED_CANCELLED_ORDERS = False
+    # Set True when the "limit" param when fetching order books is taken into account
+    SUPPORTS_CUSTOM_LIMIT_ORDER_BOOK_FETCH = False
 
     # text content of errors due to orders not found errors
     EXCHANGE_ORDER_NOT_FOUND_ERRORS: typing.List[typing.Iterable[str]] = []
@@ -502,6 +504,11 @@ class RestExchange(abstract_exchange.AbstractExchange):
     async def get_order_book(self, symbol: str, limit: int = 5, **kwargs: dict) -> typing.Optional[dict]:
         return await self.connector.get_order_book(symbol=symbol, limit=limit, **kwargs)
 
+    async def get_order_books(
+        self, symbols: typing.Optional[list[str]], limit: int = 5, **kwargs: dict
+    ) -> typing.Optional[dict]:
+        return await self.connector.get_order_books(symbols=symbols, limit=limit, **kwargs)
+
     async def get_recent_trades(self, symbol: str, limit: int = 50, **kwargs: dict) -> typing.Optional[list]:
         return await self.connector.get_recent_trades(symbol=symbol, limit=limit, **kwargs)
 

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/real_exchange_tester.py

@@ -14,13 +14,17 @@
 #  You should have received a copy of the GNU Lesser General Public
 #  License along with this library.
 import contextlib
+import time
+import typing
 
 import ccxt.async_support
+import pytest
 from ccxt import Exchange
 
 import octobot_commons.constants as constants
 import octobot_commons.enums as commons_enums
 import octobot_trading.enums as trading_enums
+import octobot_trading.errors as trading_errors
 import octobot_trading.exchanges.connectors.ccxt.ccxt_client_util as ccxt_client_util
 import octobot_trading.exchanges.util as exchanges_util
 from octobot_trading.enums import ExchangeConstantsTickersColumns as Ectc, \
@@ -44,6 +48,7 @@ class RealExchangeTester:
     REQUIRES_AUTH = False  # set True when even normally public apis require authentication
     MARKET_STATUS_TYPE = trading_enums.ExchangeTypes.SPOT.value
     HISTORICAL_CANDLES_TO_FETCH_COUNT = 650
+    DEFAULT_CUSTOM_BOOK_LIMIT = 50
 
     # Public methods: to be implemented as tests
     # Use await self._[method_name] to get the test request result
@@ -68,6 +73,15 @@ class RealExchangeTester:
     async def test_get_order_book(self):
         pass
 
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
+
     async def test_get_recent_trades(self):
         pass
 
@@ -139,6 +153,113 @@ class RealExchangeTester:
             }
         }
 
+    def _get_ref_order_book_timestamp(self):
+        return time.time() + 30 # allow 30s desync
+
+    async def inner_test_unsupported_get_order_books(self):
+        async with (self.get_exchange_manager() as exchange_manager):
+            with pytest.raises(trading_errors.NotSupported):
+                # with symbols filter
+                symbols = [self.SYMBOL, self.SYMBOL_2, self.SYMBOL_3]
+                await exchange_manager.exchange.get_order_books(symbols=symbols)
+
+            with pytest.raises(trading_errors.NotSupported):
+                # without symbols filter
+                await exchange_manager.exchange.get_order_books(symbols=None)
+
+    async def inner_test_get_order_books(
+        self,
+        expected_symbol_filter: bool,
+        expected_missing_symbol_filter_books_min_count: int,
+        expected_max_orders_by_side: int,
+        min_book_orders_count: int,
+        supports_custom_limit: bool,
+        custom_limit: typing.Optional[int],
+        max_empty_book_sides: int,
+    ):
+        async with (self.get_exchange_manager() as exchange_manager):
+            # with symbols filter
+            symbols = [self.SYMBOL, self.SYMBOL_2, self.SYMBOL_3]
+            books_by_symbol = await exchange_manager.exchange.get_order_books(symbols=symbols)
+            ref_time = self._get_ref_order_book_timestamp()
+            empty_book_sides = []
+            if expected_symbol_filter:
+                assert len(books_by_symbol) == len(symbols)
+            else:
+                assert len(books_by_symbol) >= expected_missing_symbol_filter_books_min_count
+            for symbol, book in books_by_symbol.items():
+                assert 0 < book[trading_enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value] < ref_time, (
+                    f"Invalid {symbol} book timestamp value: "
+                    f"{book[trading_enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value]}, {ref_time=}"
+                )
+                for side in [
+                    trading_enums.ExchangeConstantsOrderBookInfoColumns.BIDS,
+                    trading_enums.ExchangeConstantsOrderBookInfoColumns.ASKS
+                ]:
+                    if len(book[side.value]) == 0:
+                        empty_book_sides.append((symbol, side))
+                    else:
+                        assert min_book_orders_count < len(book[side.value]) <= expected_max_orders_by_side, (
+                            f"Unexpected {symbol} {side.value} orders count: {len(book[side.value])}. Expected: "
+                            f"[{min_book_orders_count}: {expected_max_orders_by_side}]"
+                        )
+            if len(empty_book_sides) > max_empty_book_sides:
+                raise AssertionError(
+                    f"More empty book sides than expected: {max_empty_book_sides=} {empty_book_sides=}"
+                )
+            # without symbols filter
+            books_by_symbol = await exchange_manager.exchange.get_order_books(symbols=None)
+            empty_book_sides = []
+            assert len(books_by_symbol) >= expected_missing_symbol_filter_books_min_count, (
+                f"{len(books_by_symbol)=} NOT >= {expected_missing_symbol_filter_books_min_count=}"
+            )
+            for symbol, book in books_by_symbol.items():
+                assert 0 < book[trading_enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value] < ref_time, (
+                    f"Invalid {symbol} book timestamp value: "
+                    f"{book[trading_enums.ExchangeConstantsOrderBookInfoColumns.TIMESTAMP.value]}, {ref_time=}"
+                )
+                for side in [
+                    trading_enums.ExchangeConstantsOrderBookInfoColumns.BIDS,
+                    trading_enums.ExchangeConstantsOrderBookInfoColumns.ASKS
+                ]:
+                    if len(book[side.value]) == 0:
+                        empty_book_sides.append((symbol, side))
+                    else:
+                        assert min_book_orders_count < len(book[side.value]) <= expected_max_orders_by_side, (
+                            f"Unexpected {symbol} {side.value} orders count: {len(book[side.value])}. Expected: "
+                            f"[{min_book_orders_count}: {expected_max_orders_by_side}]"
+                        )
+            if len(empty_book_sides) > max_empty_book_sides:
+                raise AssertionError(
+                    f"More empty book sides than expected: {max_empty_book_sides=} {empty_book_sides=}"
+                )
+            # with custom limit
+            books_by_symbol = await exchange_manager.exchange.get_order_books(symbols=None, limit=custom_limit)
+            self._ensure_book_custom_limit(
+                books_by_symbol, supports_custom_limit, expected_max_orders_by_side, custom_limit
+            )
+
+    def _ensure_book_custom_limit(
+        self,
+        books_by_symbol: dict,
+        supports_custom_limit: bool,
+        no_limit_default_size: int,
+        custom_limit: typing.Optional[int],
+    ):
+        has_taken_limit_into_account = False
+        custom_limit = custom_limit or self.DEFAULT_CUSTOM_BOOK_LIMIT
+        for symbol, book in books_by_symbol.items():
+            for side in [
+                trading_enums.ExchangeConstantsOrderBookInfoColumns.BIDS,
+                trading_enums.ExchangeConstantsOrderBookInfoColumns.ASKS
+            ]:
+                if no_limit_default_size < len(book[side.value]) <= custom_limit:
+                    has_taken_limit_into_account = True
+        if supports_custom_limit:
+            assert has_taken_limit_into_account
+        else:
+            assert not supports_custom_limit
+
     @contextlib.asynccontextmanager
     async def get_exchange_manager(self, market_filter=None):
         async with get_exchange_manager(

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_ascendex.py

@@ -116,10 +116,15 @@ class TestAscendExRealExchangeTester(RealExchangeTester):
     async def test_get_order_book(self):
         # limit param is not yet handled on AscendEx, consider orderbook with a least 6 bids and asks
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) > 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) > 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_binance.py

@@ -122,11 +122,23 @@ class TestBinanceRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
 
+        custom_limit_order_book = await self.get_order_book(limit=450)
+        # limit param is supported
+        # SUPPORTS_CUSTOM_LIMIT_ORDER_BOOK_FETCH = True in tentacle
+        self._ensure_book_custom_limit(
+            {self.SYMBOL: custom_limit_order_book}, True, 20, 450
+        )
+
+    async def test_get_order_books(self):
+        # not supported
+        await self.inner_test_unsupported_get_order_books()
+
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()
         assert len(recent_trades) == 50

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_binance_futures.py

@@ -126,10 +126,15 @@ class TestBinanceFuturesRealExchangeTester(RealFuturesExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bingx.py

@@ -149,10 +149,15 @@ class TestBingxRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bitfinex.py

@@ -140,10 +140,15 @@ class TestBitfinexRealExchangeTester(RealExchangeTester):
         # bitfinex2 only supports 1, 25 and 100 size
         # https://docs.bitfinex.com/reference#rest-public-book
         order_book = await self.get_order_book(limit=25)
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 25
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 25
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bitget.py

@@ -126,10 +126,15 @@ class TestBitgetRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 150
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 150
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bithumb.py

@@ -117,10 +117,15 @@ class TestBithumbRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bitmart.py

@@ -116,10 +116,15 @@ class TestBitMartRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bitso.py

@@ -116,10 +116,15 @@ class TestBitsoRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 50
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 50
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bitstamp.py

@@ -114,10 +114,15 @@ class TestBitstampRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) >= 1000
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) >= 1000
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bybit.py

@@ -123,10 +123,15 @@ class TestBybitRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_bybit_futures.py

@@ -136,10 +136,15 @@ class TestBybitRealExchangeTester(RealFuturesExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_coinbase.py

@@ -125,10 +125,15 @@ class TestCoinbaseRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_coinex.py

@@ -119,10 +119,15 @@ class TestCoinexRealExchangeTester(RealExchangeTester):
     async def test_get_order_book(self):
         # fetchOrderBook() limit argument must be None, 5/10/20/50. Default is 20
         order_book = await self.get_order_book(limit=10)
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 10
         assert len(order_book[Ecobic.ASKS.value][0]) == 2
         assert len(order_book[Ecobic.BIDS.value]) == 10
         assert len(order_book[Ecobic.BIDS.value][0]) == 2
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()

{OctoBot-Trading-2.4.101 → OctoBot-Trading-2.4.103}/tests_additional/real_exchanges/test_cryptocom.py

@@ -123,10 +123,15 @@ class TestCryptoComRealExchangeTester(RealExchangeTester):
 
     async def test_get_order_book(self):
         order_book = await self.get_order_book()
+        assert 0 < order_book[Ecobic.TIMESTAMP.value] < self._get_ref_order_book_timestamp()
         assert len(order_book[Ecobic.ASKS.value]) == 5
         assert len(order_book[Ecobic.ASKS.value][0]) == 3
         assert len(order_book[Ecobic.BIDS.value]) == 5
         assert len(order_book[Ecobic.BIDS.value][0]) == 3
+        
+    async def test_get_order_books(self):
+        # implement if necessary
+        pass
 
     async def test_get_recent_trades(self):
         recent_trades = await self.get_recent_trades()