NGPIris 5.4.2.dev4__tar.gz → 5.4.2.dev6__tar.gz

{ngpiris-5.4.2.dev4 → ngpiris-5.4.2.dev6}/NGPIris/cli/__init__.py

@@ -78,8 +78,25 @@ def cli(context : Context, credentials : str, debug : bool, transfer_config : st
     help = "Simulate the command execution without making actual changes. Useful for testing and verification", 
     is_flag = True
 )
+@click.option(
+    "-um", 
+    "--upload_mode", 
+    help = "Choose an upload method. Default upload mode is STANDARD which uses a basic multipart upload. Use another mode than STANDARD if that mode misbehaves",
+    type = click.Choice(
+        ["STANDARD", "SIMPLE", "EQUAL_PARTS"],
+        case_sensitive = False
+    ),
+    default = "STANDARD"
+)
+@click.option(
+    "-ep", 
+    "--equal_parts", 
+    help = "Supplementary option when using the EQUAL_PARTS upload mode. Splits each file into a given number of parts. Must be a positive integer", 
+    type = int,
+    default = 5
+)
 @click.pass_context
-def upload(context : Context, bucket : str, source : str, destination : str, dry_run : bool):
+def upload(context : Context, bucket : str, source : str, destination : str, dry_run : bool, upload_mode : str, equal_parts : int):
     """
     Upload files to an HCP bucket/namespace. 
     
@@ -89,6 +106,12 @@ def upload(context : Context, bucket : str, source : str, destination : str, dry
     
     DESTINATION is the destination path on the HCP. 
     """
+
+    if equal_parts <= 0:
+        exit("Error: --equal_parts value must be a positive integer")
+    
+    upload_mode_choice = HCPHandler.UploadMode(upload_mode.lower())
+
     hcph : HCPHandler = get_HCPHandler(context)
     hcph.mount_bucket(bucket)
     destination = add_trailing_slash(destination)
@@ -97,14 +120,14 @@ def upload(context : Context, bucket : str, source : str, destination : str, dry
         if dry_run:
             click.echo("This command would have uploaded the folder \"" + source + "\" to \"" + destination + "\"")
         else:
-            hcph.upload_folder(source, destination)
+            hcph.upload_folder(source, destination, upload_mode = upload_mode_choice, equal_parts = equal_parts)
     else:
         file_name = Path(source).name
         destination += file_name
         if dry_run:
             click.echo("This command would have uploaded the file \"" + source + "\" to \"" + destination + "\"")
         else:
-            hcph.upload_file(source, destination)
+            hcph.upload_file(source, destination, upload_mode = upload_mode_choice, equal_parts = equal_parts)
 
 @cli.command()
 @click.argument("bucket")

{ngpiris-5.4.2.dev4 → ngpiris-5.4.2.dev6}/NGPIris/hcp/hcp.py

@@ -42,6 +42,7 @@ from urllib3 import disable_warnings
 from tqdm import tqdm
 from bitmath import TiB, Byte
 
+from enum import Enum
 from typing import Generator
 
 _KB = 1024
@@ -468,9 +469,14 @@ class HCPHandler:
                     self.download_file(object["Key"], p.as_posix(), show_progress_bar = show_progress_bar)
         else:
             raise NotADirectory(local_folder_path + " is not a directory")
+    
+    class UploadMode(Enum):
+        STANDARD = "standard"
+        SIMPLE = "simple"
+        EQUAL_PARTS = "equal_parts"
 
     @check_mounted
-    def upload_file(self, local_file_path : str, key : str = "", show_progress_bar : bool = True) -> None:
+    def upload_file(self, local_file_path : str, key : str = "", show_progress_bar : bool = True, upload_mode : UploadMode = UploadMode.STANDARD, equal_parts : int = 5) -> None:
         """
         Upload one file to the mounted bucket
 
@@ -483,6 +489,16 @@ class HCPHandler:
         :param show_progress_bar: Boolean choice of displaying a progress bar. Defaults to True
         :type show_progress_bar: bool, optional
 
+        :param upload_mode: 
+            The upload mode of the transfer is any of the following:
+                HCPHandler.UploadMode.STANDARD,
+                HCPHandler.UploadMode.SIMPLE,
+                HCPHandler.UploadMode.EQUAL_PARTS\n
+        :type upload_mode: UploadMode, optional
+
+        :param equal_parts: The number of equal parts that each file should be divided into when using the HCPHandler.UploadMode.EQUAL_PARTS mode. Default is 5
+        :type equal_parts: int, optional
+
         :raises RuntimeError: If the \"\\\" is used in the file path 
         
         :raises ObjectAlreadyExist: If the object already exist on the mounted bucket
@@ -496,13 +512,20 @@ class HCPHandler:
         if "\\" in local_file_path:
             raise RuntimeError("The \"\\\" character is not allowed in the file path")
 
-        #if self.object_exists(key):
-        #    raise ObjectAlreadyExist("The object \"" + key + "\" already exist in the mounted bucket")
-        if False:
-            pass
+        if self.object_exists(key):
+            raise ObjectAlreadyExist("The object \"" + key + "\" already exist in the mounted bucket")
         else:
+            file_size : int = stat(local_file_path).st_size
+
+            match upload_mode:
+                case HCPHandler.UploadMode.STANDARD:
+                    config = self.transfer_config
+                case HCPHandler.UploadMode.SIMPLE:
+                    config = TransferConfig(multipart_chunksize = file_size)
+                case HCPHandler.UploadMode.EQUAL_PARTS:
+                    config = TransferConfig(multipart_chunksize = round(file_size / equal_parts))
+
             if show_progress_bar:
-                file_size : int = stat(local_file_path).st_size
                 with tqdm(
                     total = file_size, 
                     unit = "B", 
@@ -513,7 +536,7 @@ class HCPHandler:
                         Filename = local_file_path, 
                         Bucket = self.bucket_name, 
                         Key = key,
-                        Config = self.transfer_config,
+                        Config = config,
                         Callback = lambda bytes_transferred : pbar.update(bytes_transferred)
                     )
             else:
@@ -521,12 +544,11 @@ class HCPHandler:
                     Filename = local_file_path, 
                     Bucket = self.bucket_name, 
                     Key = key,
-                    Config = self.transfer_config,
+                    Config = config,
                 )
 
-
     @check_mounted
-    def upload_folder(self, local_folder_path : str, key : str = "", show_progress_bar : bool = True) -> None:
+    def upload_folder(self, local_folder_path : str, key : str = "", show_progress_bar : bool = True, upload_mode : UploadMode = UploadMode.STANDARD, equal_parts : int = 5) -> None:
         """
         Upload the contents of a folder to the mounted bucket
 
@@ -538,6 +560,16 @@ class HCPHandler:
 
         :param show_progress_bar: Boolean choice of displaying a progress bar. Defaults to True
         :type show_progress_bar: bool, optional
+
+        :param upload_mode: 
+            The upload mode of the transfer is any of the following:
+                HCPHandler.UploadMode.STANDARD,
+                HCPHandler.UploadMode.SIMPLE,
+                HCPHandler.UploadMode.EQUAL_PARTS\n
+        :type upload_mode: UploadMode, optional
+
+        :param equal_parts: The number of equal parts that each file should be divided into when using the HCPHandler.UploadMode.EQUAL_PARTS mode. Default is 5
+        :type equal_parts: int, optional
         """
         raise_path_error(local_folder_path)
 
@@ -546,7 +578,13 @@ class HCPHandler:
         filenames = listdir(local_folder_path)
 
         for filename in filenames:
-            self.upload_file(local_folder_path + filename, key + filename, show_progress_bar = show_progress_bar)
+            self.upload_file(
+                local_folder_path + filename, 
+                key + filename, 
+                show_progress_bar = show_progress_bar, 
+                upload_mode = upload_mode,
+                equal_parts = equal_parts
+            )
 
     @check_mounted
     def delete_objects(self, keys : list[str], verbose : bool = True) -> None:

{ngpiris-5.4.2.dev4 → ngpiris-5.4.2.dev6/NGPIris.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: NGPIris
-Version: 5.4.2.dev4
+Version: 5.4.2.dev6
 Author-email: Erik Brink <erik.brink@gu.se>, Isak Sylvin <isak.sylvin@gu.se>
 Description-Content-Type: text/markdown
 License-File: LICENSE

{ngpiris-5.4.2.dev4/NGPIris.egg-info → ngpiris-5.4.2.dev6}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: NGPIris
-Version: 5.4.2.dev4
+Version: 5.4.2.dev6
 Author-email: Erik Brink <erik.brink@gu.se>, Isak Sylvin <isak.sylvin@gu.se>
 Description-Content-Type: text/markdown
 License-File: LICENSE

{ngpiris-5.4.2.dev4 → ngpiris-5.4.2.dev6}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "NGPIris"
-version = "5.4.2.dev4"
+version = "5.4.2.dev6"
 readme = "README.md"
 dependencies = [
     "requests >= 2.31.0",

{ngpiris-5.4.2.dev4 → ngpiris-5.4.2.dev6}/tests/test_hcp.py

@@ -1,12 +1,10 @@
 
-
 from pathlib import Path
 from filecmp import cmp
 from typing import Any, Callable
-
 from conftest import CustomConfig
-
 from NGPIris.hcp import HCPHandler
+from icecream import ic
 
 # --------------------------- Helper fucntions ---------------------------------
 
@@ -70,6 +68,15 @@ def test_upload_file(custom_config : CustomConfig) -> None:
         show_progress_bar = False
     )
 
+    # Test every upload mode
+    for mode in HCPHandler.UploadMode:
+        ic(mode, custom_config.test_file_path + "_" + str(mode).replace(".", "_"))
+        custom_config.hcp_h.upload_file(
+            custom_config.test_file_path, 
+            custom_config.test_file_path + "_" + str(mode).replace(".", "_"),
+            upload_mode = mode
+        )
+
 def test_upload_file_without_mounting(custom_config : CustomConfig) -> None:
     _hcp_h = custom_config.hcp_h 
     _without_mounting(_hcp_h, HCPHandler.upload_file)
@@ -119,8 +126,6 @@ def test_get_file_in_sub_directory(custom_config : CustomConfig) -> None:
     assert custom_config.hcp_h.object_exists(custom_config.test_file_path) 
     assert custom_config.hcp_h.get_object(custom_config.test_file_path) 
 
-from icecream import ic
-
 def test_download_file(custom_config : CustomConfig) -> None:
     test_mount_bucket(custom_config)
     Path(custom_config.result_path).mkdir()
@@ -215,6 +220,8 @@ def test_delete_file(custom_config : CustomConfig) -> None:
     test_mount_bucket(custom_config)
     custom_config.hcp_h.delete_object(custom_config.test_file_path) 
     custom_config.hcp_h.delete_object(custom_config.test_file_path + "_no_progress_bar")
+    for mode in HCPHandler.UploadMode:
+        custom_config.hcp_h.delete_object(custom_config.test_file_path + "_" + str(mode).replace(".", "_"))
     custom_config.hcp_h.delete_object("a_sub_directory/a_file") 
     custom_config.hcp_h.delete_object("a_sub_directory")