LoopStructural 1.8.0__tar.gz → 1.8.4__tar.gz

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/core/_model_exporter.py

@@ -8,17 +8,23 @@ of the CI-checked stable API surface -- and delegate to the staticmethods
 here.
 """
 
+from __future__ import annotations
+
 import pathlib
+from typing import TYPE_CHECKING
 
 from ...geometry import StructuredGrid
-from ...utils import getLogger
+from ...utils import getLogger, surface_list
+
+if TYPE_CHECKING:
+    from .geological_model import GeologicalModel
 
 logger = getLogger(__name__)
 
 
 class ModelExporter:
     @staticmethod
-    def get_fault_surfaces(model, faults=None):
+    def get_fault_surfaces(model: GeologicalModel, faults: list[str] | None = None) -> surface_list:
         if faults is None:
             faults = []
         surfaces = []
@@ -30,7 +36,9 @@ class ModelExporter:
         return surfaces
 
     @staticmethod
-    def get_stratigraphic_surfaces(model, units=None, bottoms=True):
+    def get_stratigraphic_surfaces(
+        model: GeologicalModel, units: list[str] | None = None, bottoms: bool = True
+    ) -> surface_list:
         if units is None:
             units = []
         ## TODO change the stratigraphic column to its own class and have methods to get the relevant surfaces
@@ -38,7 +46,7 @@ class ModelExporter:
         units = []
         if model.stratigraphic_column is None:
             return []
-        units = model.stratigraphic_column.get_isovalues()
+        units = model.stratigraphic_column.get_isovalues(where='bottom' if bottoms else 'top')
         units_for_group = {}
         for name, u in units.items():
             if u['group'] not in model:
@@ -60,7 +68,9 @@ class ModelExporter:
         return surfaces
 
     @staticmethod
-    def get_block_model(model, name='block model'):
+    def get_block_model(
+        model: GeologicalModel, name: str = 'block model'
+    ) -> tuple[StructuredGrid, list]:
         # NOTE: bounding_box.structured_grid() returns loop_common's
         # interpolation-support StructuredGrid (no properties dict); use
         # LoopStructural's own geometry StructuredGrid for storing values.
@@ -78,14 +88,14 @@ class ModelExporter:
 
     @staticmethod
     def save(
-        model,
+        model: GeologicalModel,
         filename: str,
         block_model: bool = True,
-        stratigraphic_surfaces=True,
-        fault_surfaces=True,
-        stratigraphic_data=True,
-        fault_data=True,
-    ):
+        stratigraphic_surfaces: bool = True,
+        fault_surfaces: bool = True,
+        stratigraphic_data: bool = True,
+        fault_data: bool = True,
+    ) -> None:
         path = pathlib.Path(filename)
         extension = path.suffix
         parent = path.parent

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/core/_model_feature_factory.py

@@ -31,6 +31,9 @@ from ...utils import getLogger
 
 logger = getLogger(__name__)
 
+# interpolator types that implement fold constraints
+FOLD_INTERPOLATOR_TYPES = ("DFI", "P2Fold")
+
 
 class ModelFeatureFactory:
     @staticmethod
@@ -216,6 +219,13 @@ class ModelFeatureFactory:
         fold_frame :  FoldFrame
         svario  : Boolean
             whether to calculate svariograms, saves time if avoided
+        interpolatortype : str
+            ``"DFI"`` (default, piecewise linear) or ``"P2Fold"`` (piecewise quadratic).
+            Other values are replaced by ``"DFI"`` with a warning.
+        nelements : int
+            requested structured-grid cell budget. Each cell splits into five
+            tetrahedra. For ``"P2Fold"``, a request of 1e4 gave about 56k tets
+            and 86k unknowns in the Bermagui validation; inspect the actual counts
         kwargs
             additional kwargs to be passed through to other functions
 
@@ -227,6 +237,7 @@ class ModelFeatureFactory:
         Notes
         -----
 
+        - The P2 mesh is larger than the model box because of ``buffer``.
         - Building a folded foliation uses the fold interpolation code from Laurent et al., 2016
         and fold profile fitting from Grose et al., 2017. For more information about the fold modelling
         see :class:`LoopStructural.modelling.features.fold.FoldEvent`,
@@ -245,8 +256,11 @@ class ModelFeatureFactory:
 
         fold = FoldEvent(fold_frame, name=f"Fold_{foliation_name}", invert_norm=invert_fold_norm)
 
-        if interpolatortype != "DFI":
-            logger.warning("Folded foliation only supports DFI interpolator, changing to DFI")
+        if interpolatortype not in FOLD_INTERPOLATOR_TYPES:
+            logger.warning(
+                f"Folded foliation only supports {FOLD_INTERPOLATOR_TYPES} interpolators, "
+                f"changing {interpolatortype} to DFI"
+            )
             interpolatortype = "DFI"
         series_builder = FoldedFeatureBuilder(
             interpolatortype=interpolatortype,
@@ -300,7 +314,10 @@ class ModelFeatureFactory:
         fold_frame_data : pandas data frame, optional
             data frame containing the fold frame data, if not specified uses the model data
         interpolatortype : str
-            the type of interpolator to use, default is 'FDI' (unused) 5/6/2025
+            ``"DFI"`` or ``"P2Fold"`` sets the interpolator of the first (fold) coordinate.
+            Any other value gives ``"DFI"``. The other two coordinates always use FDI.
+            ``nelements`` is a structured-grid cell budget, not a literal
+            tetrahedron count. P2 adds edge nodes; inspect the actual dof.
         fold_frame : StructuralFrame, optional
             the fold frame for the fold if not specified uses last feature added
         nelements : int
@@ -342,8 +359,9 @@ class ModelFeatureFactory:
             raise TypeError("Please specify a FoldFrame")
         fold = FoldEvent(fold_frame, name=f"Fold_{fold_frame_name}")
 
+        # the first coordinate carries the fold constraints, the others are plain FDI
         interpolatortypes = [
-            "DFI",
+            interpolatortype if interpolatortype in FOLD_INTERPOLATOR_TYPES else "DFI",
             "FDI",
             "FDI",
         ]

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/core/_model_relationships.py

@@ -52,15 +52,22 @@ class FeatureRelationshipManager:
         for f in reversed(model.features):
             if f.name == feature.name:
                 continue
-            if f.type == "domain_fault":
-                feature.add_region(lambda pos, fault=f: fault.evaluate_value(pos) < 0)
+            if f.type == FeatureType.DOMAINFAULT:
+                # A proper Feature-like region (name/parent), not a bare
+                # lambda -- code that walks `self.regions` expecting
+                # Feature-like objects (e.g. BaseFeature.surfaces) would
+                # otherwise raise AttributeError on this region and
+                # silently produce no surfaces for anything a domain fault
+                # crops.
+                feature.add_region(UnconformityFeature(f, 0, sign=True))
                 break
 
     @staticmethod
     def add_domain_fault_below(model, domain_fault):
         """
         Looks through the feature list and adds any the domain_fault to the features
-        that already exist in the stack until an unconformity is reached. domain faults
+        that already exist in the stack until an unconformity or another domain
+        fault is reached (that boundary is not cropped). domain faults
         to the feature. The domain fault masks everything where the fault scalar field
          is < 0 as being active when added to feature.
 
@@ -70,12 +77,19 @@ class FeatureRelationshipManager:
         domain_fault : GeologicalFeatureBuilder
             the feature being added to the model where domain faults should be added
         """
+        region = UnconformityFeature(domain_fault, 0, sign=False)
         for f in reversed(model.features):
             if f.name == domain_fault.name:
                 continue
-            f.add_region(lambda pos: domain_fault.evaluate_value(pos) > 0)
-            if f.type == FeatureType.UNCONFORMITY:
+            if f.type == FeatureType.UNCONFORMITY or f.type == FeatureType.DOMAINFAULT:
+                # An unconformity or domain fault added before this one is
+                # the boundary above the features this domain fault crops.
+                # It is a stopping point and is not itself cropped, else the
+                # boundary surface is removed on one side of this fault.
+                # This matches add_unconformity, which also stops before it
+                # crops.
                 break
+            f.add_region(region)
 
     @staticmethod
     def add_unconformity_above(model, feature):
@@ -129,8 +143,13 @@ class FeatureRelationshipManager:
         uc_feature = UnconformityFeature(feature, value)
         feature.add_region(uc_feature.inverse())
         for f in reversed(model.features):
-            if f.type == FeatureType.UNCONFORMITY:
-                logger.debug(f"Reached unconformity {f.name}")
+            if f.type == FeatureType.UNCONFORMITY or f.type == FeatureType.DOMAINFAULT:
+                # A domain fault is itself a boundary that already separates
+                # everything below it from what's built afterwards (see
+                # add_domain_fault_below/above) -- so it's a stopping point
+                # here too, the same as an unconformity, rather than
+                # something this unrelated unconformity should crop.
+                logger.debug(f"Reached unconformity/domain fault {f.name}")
                 break
             logger.debug(f"Adding {uc_feature.name} as unconformity to {f.name}")
             if f.type == FeatureType.FAULT or f.type == FeatureType.INACTIVEFAULT:
@@ -165,7 +184,11 @@ class FeatureRelationshipManager:
         uc_feature = UnconformityFeature(feature, value, False, onlap=True)
         feature.add_region(uc_feature.inverse())
         for f in reversed(model.features):
-            if f.type in (FeatureType.UNCONFORMITY, FeatureType.ONLAPUNCONFORMITY):
+            if f.type in (
+                FeatureType.UNCONFORMITY,
+                FeatureType.ONLAPUNCONFORMITY,
+                FeatureType.DOMAINFAULT,
+            ):
                 logger.debug(f"Reached unconformity {f.name}")
                 break
             if f.type == FeatureType.FAULT or f.type == FeatureType.INACTIVEFAULT:

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/core/geological_model.py

@@ -793,7 +793,8 @@ class GeologicalModel:
         """Create a folded foliation and add it to the model.
 
         See :meth:`~._model_feature_factory.ModelFeatureFactory.build_folded_foliation`
-        for parameter documentation.
+        for parameter documentation. ``interpolatortype`` is ``"DFI"`` (default)
+        or ``"P2Fold"``.
         Thin wrapper around :meth:`create_and_add_feature` (see
         ``API.md``); kept as a stable, unchanged entry point.
         """

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/core/stratigraphic_column.py

@@ -9,9 +9,11 @@ from LoopStructural.utils._api_registry import public_api
 
 logger = getLogger(__name__)
 logger.info("Imported LoopStructural Stratigraphic Column module")
+
+
 class UnconformityType(enum.Enum):
     """Enumeration for different types of unconformities in a stratigraphic column.
-    
+
     Attributes
     ----------
     ERODE : str
@@ -26,7 +28,7 @@ class UnconformityType(enum.Enum):
 
 class StratigraphicColumnElementType(enum.Enum):
     """Enumeration for different types of elements in a stratigraphic column.
-    
+
     Attributes
     ----------
     UNIT : str
@@ -41,8 +43,8 @@ class StratigraphicColumnElementType(enum.Enum):
 
 class StratigraphicColumnElement:
     """Base class for elements in a stratigraphic column.
-    
-    This class represents a generic element that can be either a stratigraphic unit 
+
+    This class represents a generic element that can be either a stratigraphic unit
     or a topological object such as an unconformity.
 
     Parameters
@@ -132,6 +134,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
         self.id = id
         self.min_value = None  # Minimum scalar field value for the unit
         self.max_value = None  # Maximum scalar field value for the unit
+
     @property
     def id(self):
         """Get the numeric identifier of the unit.
@@ -142,7 +145,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
             The numeric identifier
         """
         return self._id
-    
+
     @property
     def thickness(self):
         """Get the thickness of the unit.
@@ -153,7 +156,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
             The thickness value
         """
         return self._thickness
-    
+
     @thickness.setter
     def thickness(self, value):
         """Set the thickness of the unit and notify observers.
@@ -165,7 +168,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
         """
         self._thickness = value
         self.notify('unit/thickness_updated', unit=self)
-    
+
     @id.setter
     def id(self, value):
         """Set the ID of the unit and notify observers.
@@ -179,6 +182,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
             raise TypeError("ID must be an integer")
         self._id = value
         self.notify('unit/id_updated', unit=self)
+
     def min(self):
         """Return the minimum scalar field value of the unit.
 
@@ -188,7 +192,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
             Minimum value, or 0 if not set
         """
         return self.min_value if self.min_value is not None else 0
-    
+
     def max(self):
         """Return the maximum scalar field value of the unit.
 
@@ -198,7 +202,7 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
             Maximum value, or infinity if not set
         """
         return self.max_value if self.max_value is not None else np.inf
-    
+
     def to_dict(self):
         """Convert the stratigraphic unit to a dictionary representation.
 
@@ -210,7 +214,13 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
         colour = self.colour
         if isinstance(colour, np.ndarray):
             colour = colour.astype(float).tolist()
-        return {"name": self.name, "colour": colour, "thickness": self.thickness, 'uuid': self.uuid, 'id': self.id}
+        return {
+            "name": self.name,
+            "colour": colour,
+            "thickness": self.thickness,
+            'uuid': self.uuid,
+            'id': self.id,
+        }
 
     @classmethod
     def from_dict(cls, data):
@@ -237,7 +247,9 @@ class StratigraphicUnit(StratigraphicColumnElement, Observable['StratigraphicUni
         colour = data.get("colour")
         thickness = data.get("thickness", None)
         uuid = data.get("uuid", None)
-        return cls(uuid=uuid, name=name, colour=colour, thickness=thickness, id=data.get("id", None))
+        return cls(
+            uuid=uuid, name=name, colour=colour, thickness=thickness, id=data.get("id", None)
+        )
 
     def __str__(self):
         """Return a string representation of the stratigraphic unit.
@@ -303,9 +315,11 @@ class StratigraphicUnconformity(StratigraphicColumnElement):
         )
         uuid = data.get("uuid", None)
         return cls(uuid=uuid, name=name, unconformity_type=unconformity_type)
+
+
 class StratigraphicGroup:
     """A class representing a group of stratigraphic units.
-    
+
     This class serves as a container for related stratigraphic units and provides
     a placeholder for future group-level functionality.
 
@@ -340,9 +354,9 @@ class StratigraphicGroup:
 
 class StratigraphicColumn(Observable['StratigraphicColumn']):
     """A class representing a stratigraphic column.
-    
-    The stratigraphic column represents a vertical section of the Earth's crust 
-    showing the sequence of rock layers and their relationships, including 
+
+    The stratigraphic column represents a vertical section of the Earth's crust
+    showing the sequence of rock layers and their relationships, including
     unconformities and basement rock.
 
     Attributes
@@ -372,18 +386,16 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
         if not self.order:
             return 0
         return max([u.id for u in self.order if isinstance(u, StratigraphicUnit)], default=0) + 1
-    
+
     def add_basement(self):
         """Add basement unit and base unconformity to the stratigraphic column.
-        
+
         This method adds the fundamental basement unit with infinite thickness
         and an erosional unconformity at the base of the column.
         """
         self.add_unit(name='Basement', colour='grey', thickness=np.inf)
-        self.add_unconformity(
-            name='Base Unconformity', unconformity_type=UnconformityType.ERODE
-        )
-    
+        self.add_unconformity(name='Base Unconformity', unconformity_type=UnconformityType.ERODE)
+
     def clear(self, basement=True):
         """Clear the stratigraphic column, removing all elements.
 
@@ -397,7 +409,8 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
         if basement:
             self.add_basement()
         self.notify('column_cleared')
-    def add_unit(self, name,*, colour=None, thickness=None, where='top',id=None):
+
+    def add_unit(self, name, *, colour=None, thickness=None, where='top', id=None):
         if id is None:
             id = self.get_new_id()
         unit = StratigraphicUnit(name=name, colour=colour, thickness=thickness, id=id)
@@ -425,7 +438,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
 
         return False
 
-    def add_unconformity(self, name, *, unconformity_type=UnconformityType.ERODE, where='top' ):
+    def add_unconformity(self, name, *, unconformity_type=UnconformityType.ERODE, where='top'):
         unconformity = StratigraphicUnconformity(
             uuid=None, name=name, unconformity_type=unconformity_type
         )
@@ -466,6 +479,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
                 return unconformity
 
         return None
+
     def get_element_by_uuid(self, uuid):
         """
         Retrieves an element by its uuid from the stratigraphic column.
@@ -475,7 +489,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
                 return element
         raise KeyError(f"No element found with uuid: {uuid}")
 
-    def get_group_for_unit_name(self, unit_name:str) -> StratigraphicGroup | None:
+    def get_group_for_unit_name(self, unit_name: str) -> StratigraphicGroup | None:
         """
         Retrieves the group for a given unit name.
         """
@@ -483,6 +497,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
             if any(unit.name == unit_name for unit in group.units):
                 return group
         return None
+
     def add_element(self, element):
         """
         Adds a StratigraphicColumnElement to the stratigraphic column.
@@ -500,27 +515,22 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
 
     def get_groups(self):
         groups = []
-        i=0
-        group = StratigraphicGroup(
-            name=(
-                self.group_mapping.get(f'Group_{i}', f'Group_{i}')
-            )
-        )
+        i = 0
+        group = StratigraphicGroup(name=(self.group_mapping.get(f'Group_{i}', f'Group_{i}')))
         for e in reversed(self.order):
             if isinstance(e, StratigraphicUnit):
                 group.units.append(e)
             else:
                 if group.units:
                     groups.append(group)
-                    i+=1
+                    i += 1
                     group = StratigraphicGroup(
-                        name=(
-                            self.group_mapping.get(f'Group_{i}', f'Group_{i}')
-                        )
+                        name=(self.group_mapping.get(f'Group_{i}', f'Group_{i}'))
                     )
         if group:
             groups.append(group)
         return groups
+
     def get_stratigraphic_ids(self) -> list[list[str]]:
         ids = []
         for group in self.get_groups():
@@ -530,6 +540,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
             for unit in group.units:
                 ids.append([unit.id, group, unit.name, unit.min(), unit.max()])
         return ids
+
     def get_unitname_groups(self):
         groups = self.get_groups()
         groups_list = []
@@ -539,7 +550,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
             groups_list.append(group)
         return groups_list
 
-    def get_group_unit_pairs(self) -> list[tuple[str,str]]:
+    def get_group_unit_pairs(self) -> list[tuple[str, str]]:
         """
         Returns a list of tuples containing group names and unit names.
         """
@@ -571,7 +582,10 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
         ]
         self.notify('order_updated', new_order=self.order)
         self.update_unit_values()  # Update min and max values after updating the order
-    def update_unit_values(self, observable: Observable | None = None, event: str | None = None, **kwargs):
+
+    def update_unit_values(
+        self, observable: Observable | None = None, event: str | None = None, **kwargs
+    ):
         """
         Updates the min and max values for each unit based on their position in the column.
 
@@ -628,6 +642,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
         return {
             "elements": [element.to_dict() for element in self.order],
         }
+
     def update_from_dict(self, data):
         """
         Updates the stratigraphic column from a dictionary representation.
@@ -643,6 +658,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
                 else:
                     element = StratigraphicUnit.from_dict(element_data)
                 self.add_element(element)
+
     @classmethod
     def from_dict(cls, data):
         """
@@ -661,23 +677,37 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
             column.add_element(element)
         return column
 
-    def get_isovalues(self) -> dict[str, float]:
+    def get_isovalues(self, where: str = 'bottom') -> dict[str, float]:
         """
         Returns a dictionary of isovalues for the stratigraphic units in the column.
+
+        Parameters
+        ----------
+        where : str, optional
+            'bottom' (default) returns the value at the base of each unit.
+            'top' returns the value at the top of each unit.
         """
+        if where not in ('top', 'bottom'):
+            raise ValueError("Invalid 'where' argument. Use 'top' or 'bottom'.")
         surface_values = {}
         for g in reversed(self.get_groups()):
             v = 0
-            for u in g.units:
-                surface_values[u.name] = {'value':v,'group':g.name,'colour':u.colour}
+            for u in reversed(g.units):
+                base = v
                 v += u.thickness
+                surface_values[u.name] = {
+                    'value': v if where == 'top' else base,
+                    'group': g.name,
+                    'colour': u.colour,
+                }
         return surface_values
 
-    def plot(self,*, ax=None, **kwargs):
+    def plot(self, *, ax=None, **kwargs):
         import matplotlib.pyplot as plt
         from matplotlib import cm
         from matplotlib.collections import PatchCollection
         from matplotlib.patches import Polygon
+
         n_units = 0  # count how many discrete colours (number of stratigraphic units)
         xmin = 0
         ymin = 0
@@ -712,7 +742,17 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
                 n_units += 1
 
                 ymax = total_height
-                ymin = ymax - (getattr(u, 'thickness', np.nan) if not np.isinf(getattr(u, 'thickness', np.nan)) else np.nanmean([getattr(e, 'thickness', np.nan) for e in self.order if not np.isinf(getattr(e, 'thickness', np.nan))]))
+                ymin = ymax - (
+                    getattr(u, 'thickness', np.nan)
+                    if not np.isinf(getattr(u, 'thickness', np.nan))
+                    else np.nanmean(
+                        [
+                            getattr(e, 'thickness', np.nan)
+                            for e in self.order
+                            if not np.isinf(getattr(e, 'thickness', np.nan))
+                        ]
+                    )
+                )
 
                 if not np.isfinite(ymin):
                     ymin = prev_coords[1] - (prev_coords[1] - prev_coords[0]) * (1 + rng.random())
@@ -723,7 +763,12 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
 
                 polygon_points = np.array([[xmin, ymin], [xmax, ymin], [xmax, ymax], [xmin, ymax]])
                 patches.append(Polygon(polygon_points))
-                ax.annotate(getattr(u, 'name', 'Unknown'), xy=(xmin+(xmax-xmin)/2, (ymax-ymin)/2+ymin), fontsize=8, ha='left')
+                ax.annotate(
+                    getattr(u, 'name', 'Unknown'),
+                    xy=(xmin + (xmax - xmin) / 2, (ymax - ymin) / 2 + ymin),
+                    fontsize=8,
+                    ha='left',
+                )
 
         if 'cmap' not in kwargs:
             from matplotlib import colors
@@ -752,7 +797,7 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
         ax.axis("off")
 
         return fig
-    
+
     def cmap(self):
         try:
             from matplotlib import colors
@@ -772,9 +817,9 @@ class StratigraphicColumn(Observable['StratigraphicColumn']):
                     data.append((u.id, u.colour))
                     colours.append(u.colour)
                     boundaries.append(u.id)
-             # print(u,v)
+            # print(u,v)
             cmap = colors.ListedColormap(colours)
         except ImportError:
             logger.warning("Cannot use predefined colours as I can't import matplotlib")
             cmap = "tab20"
-        return cmap
+        return cmap

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/features/_base_geological_feature.py

@@ -340,8 +340,17 @@ class BaseFeature(metaclass=ABCMeta):
         regions = self.regions
         
         try:
+            # A region can also be a plain callable (e.g. the lambdas
+            # add_domain_fault_below/above attach for a domain-fault crop),
+            # not just another BaseFeature -- those have no .name/.parent,
+            # so getattr(..., None) rather than direct attribute access,
+            # or this raises AttributeError and silently drops every
+            # surface for any feature cropped by a domain fault.
             self.regions = [
-                r for r in self.regions if r.name != self.name and r.parent.name != self.name
+                r
+                for r in self.regions
+                if getattr(r, 'name', None) != self.name
+                and getattr(getattr(r, 'parent', None), 'name', None) != self.name
             ]
 
             callable = lambda xyz: self.evaluate_value(xyz)

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/features/builders/_folded_feature_builder.py

@@ -1,6 +1,7 @@
 import numpy as np
 
 from ....geometry import BoundingBox
+from ....interpolators import InterpolatorType
 from ....modelling.features import FeatureType
 from ._geological_feature_builder import GeologicalFeatureBuilder
 from ....modelling.features.fold.fold_function import FoldRotationType, get_fold_rotation_profile
@@ -71,8 +72,13 @@ class FoldedFeatureBuilder(GeologicalFeatureBuilder):
         if not isinstance(feature_builder, GeologicalFeatureBuilder):
             logger.error(f'Feature builder is {type(feature_builder)} not GeologicalFeatureBuilder')
             raise TypeError("feature_builder must be an instance of GeologicalFeatureBuilder")
+        # keep the fold type of the source builder, DFI otherwise
+        source_type = getattr(feature_builder.interpolator, "type", None)
+        interpolatortype = (
+            'P2Fold' if source_type == InterpolatorType.PIECEWISE_QUADRATIC_FOLD else 'DFI'
+        )
         builder = cls(
-            interpolatortype='DFI',
+            interpolatortype=interpolatortype,
             bounding_box=feature_builder.model.bounding_box,
             fold=fold,
             nelements=feature_builder.interpolator.n_elements,

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural/modelling/features/fold/_fold.py

@@ -104,22 +104,11 @@ class FoldEvent:
         dgz[mask, :] /= np.linalg.norm(dgz[mask, :], axis=1)[:, None]
         R2 = self.rot_mat(fold_axis, self.fold_limb_rotation(gx))
         fold_direction = np.einsum("ijk,ki->kj", R2, dgx)
-        fold_direction /= np.sum(fold_direction, axis=1)[:, None]
-        # calculate dot product between fold_direction and axis
-        # if its less than 0 then inverse dgz
-        d = np.einsum("ij,ik->i", fold_direction, fold_axis)
+        fold_direction /= np.linalg.norm(fold_direction, axis=1)[:, None]
 
         if self.invert_norm:
-            new_dgz = -dgz[mask][d[mask] < 0]
-            return fold_direction, fold_axis, new_dgz
-
-        elif not self.invert_norm:
-            return fold_direction, fold_axis, dgz
-        else:
-            logger.warning("invert fold frame param not valid. Defaulting to false.")
-            return fold_direction, fold_axis, dgz
-
-        # return fold_direction, fold_axis, dgz
+            dgz = -dgz
+        return fold_direction, fold_axis, dgz
 
     # def get_regularisation_direction(self, points):
     #     self.foldframe.features[2].evaluate_gradient(points)

{loopstructural-1.8.0 → loopstructural-1.8.4}/LoopStructural.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: LoopStructural
-Version: 1.8.0
+Version: 1.8.4
 Summary: 3D geological modelling
 Author-email: Lachlan Grose <lachlan.grose@monash.edu>
 License: MIT

{loopstructural-1.8.0 → loopstructural-1.8.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: LoopStructural
-Version: 1.8.0
+Version: 1.8.4
 Summary: 3D geological modelling
 Author-email: Lachlan Grose <lachlan.grose@monash.edu>
 License: MIT

{loopstructural-1.8.0 → loopstructural-1.8.4}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = 'setuptools.build_meta'
 
 [project]
 name = 'LoopStructural'
-version = "1.8.0"
+version = "1.8.4"
 description = '3D geological modelling'
 authors = [{ name = 'Lachlan Grose', email = 'lachlan.grose@monash.edu' }]
 readme = 'README.md'
@@ -97,6 +97,7 @@ LoopStructural = { workspace = true }
 [tool.pytest.ini_options]
 addopts = "--import-mode=importlib"
 testpaths = ["tests"]
+pythonpath = ["."]
 
 [tool.isort]
 profile = 'black'