GridCal 5.1.52__tar.gz → 5.1.53__tar.gz

GridCal-5.1.52/GridCal/Gui/Diagrams/MapWidget/Substation/node_graphic_item.py → GridCal-5.1.53/GridCal/Gui/Diagrams/MapWidget/Branches/line_location_graphic_item.py

@@ -16,11 +16,11 @@
 # Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 from __future__ import annotations
 from typing import Tuple, TYPE_CHECKING
-from PySide6.QtWidgets import QApplication, QMenu, QGraphicsSceneContextMenuEvent
+from PySide6.QtWidgets import QMenu, QGraphicsSceneContextMenuEvent
 from GridCal.Gui.gui_functions import add_menu_entry
 from PySide6 import QtWidgets
 from PySide6.QtCore import Qt, QPointF
-from PySide6.QtGui import QBrush, QColor, QCursor
+from PySide6.QtGui import QBrush, QColor
 
 from GridCalEngine.Devices.Branches.line_locations import LineLocation
 from GridCal.Gui.Diagrams.MapWidget.Branches.map_line_container import MapLineContainer
@@ -30,7 +30,7 @@ if TYPE_CHECKING:  # Only imports the below statements during type checking
     from GridCal.Gui.Diagrams.MapWidget.grid_map_widget import GridMapWidget
 
 
-class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
+class LineLocationGraphicItem(QtWidgets.QGraphicsEllipseItem, NodeTemplate):
     """
       Represents a block in the diagram
       Has an x and y and width and height
@@ -60,7 +60,7 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         :param r:
         :param draw_labels:
         """
-        QtWidgets.QGraphicsRectItem.__init__(self)
+        QtWidgets.QGraphicsEllipseItem.__init__(self)
         NodeTemplate.__init__(self,
                               api_object=api_object,
                               editor=editor,
@@ -74,9 +74,8 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         self.radius = r
         self.draw_labels = True
 
-        # self.editor: GridMapWidget = editor
         self.line_container: MapLineContainer = line_container
-        # self.api_object: LineLocation = api_object
+
         self.index = index
 
         self.resize(r * 10)
@@ -84,23 +83,20 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         self.setFlag(QtWidgets.QGraphicsItem.GraphicsItemFlag.ItemIsMovable)  # Allow moving the node
         self.setFlag(QtWidgets.QGraphicsItem.GraphicsItemFlag.ItemIsSelectable)  # Allow selecting the node
 
-        self.setCursor(QCursor(Qt.PointingHandCursor))
+        # self.setCursor(QCursor(Qt.CursorShape.PointingHandCursor))
+        self.setCursor(Qt.CursorShape.PointingHandCursor)
 
         self.hovered = False
         self.enabled = True
 
         # Create a pen with reduced line width
-        self.change_pen_width(0.001)
-
-        # self.colorInner = QColor(100, random.randint(0, 255), random.randint(0, 255), random.randint(0, 255))
-        # self.colorBorder = QColor(100, random.randint(0, 255), random.randint(0, 255), random.randint(0, 255))
-
-        self.colorInner = QColor(255, 100, 100, 100)
-        self.colorBorder = QColor(255, 100, 100, 100)
+        self.change_pen_width(0)
+        self.colorInner = QColor(100, 100, 100, 100)
+        self.colorBorder = QColor(100, 100, 100, 100)
         self.setZValue(1)
 
         # Assign color to the node
-        self.setDefaultColor()
+        self.set_default_color()
 
     def get_center_pos(self) -> QPointF:
         """
@@ -111,49 +107,47 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         y = self.rect().y() + self.rect().height() / 2
         return QPointF(x, y)
 
-    def updateRealPos(self) -> None:
+    def update_real_pos(self) -> None:
         """
 
         :return:
         """
         real_position = self.pos()
-        center_point = self.getPos()
+        center_point = self.get_pos()
         self.x = center_point.x() + real_position.x()
         self.y = center_point.y() + real_position.y()
 
-    def updatePosition(self):
+    def update_position(self) -> None:
         """
 
         :return:
         """
 
         if self.enabled:
-            self.updateRealPos()
-            self.needsUpdate = True
+            self.update_real_pos()
+            self.needs_update = True
             self.line_container.update_connectors()
 
-    def updateDiagram(self):
+    def update_position_at_the_diagram(self) -> None:
         """
-
-        :return:
+        This function updates the position of this graphical element in the diagram
         """
         real_position = self.pos()
-        center_point = self.getPos()
+        center_point = self.get_pos()
 
-        lat, long = self.editor.to_lat_lon(x=center_point.x() + real_position.x(),
-                                           y=center_point.y() + real_position.y())
+        self.lat, self.lon = self.editor.to_lat_lon(x=center_point.x() + real_position.x(),
+                                                    y=center_point.y() + real_position.y())
 
-        print(f'Updating node position id:{self.api_object.idtag}, lat:{lat}, lon:{long}')
+        # print(f'Updating node position id:{self.api_object.idtag}, lat:{self.lat}, lon:{self.lon}')
 
         self.editor.update_diagram_element(device=self.api_object,
-                                           latitude=lat,
-                                           longitude=long,
+                                           latitude=self.lat,
+                                           longitude=self.lon,
                                            graphic_object=self)
 
-        self.lat = lat
-        self.lon = long
+        print()
 
-    def mouseMoveEvent(self, event):
+    def mouseMoveEvent(self, event: QtWidgets.QGraphicsSceneMouseEvent) -> None:
         """
         Event handler for mouse move events.
         """
@@ -165,51 +159,39 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
             self.set_callabacks(pos.x(), pos.y())
 
             if self.hovered and self.enabled:
-                self.updatePosition()
+                self.update_position()
 
     def mousePressEvent(self, event: QtWidgets.QGraphicsSceneMouseEvent) -> None:
         """
         Event handler for mouse press events.
         """
         super().mousePressEvent(event)
-        selected_items = self.editor.map.view._scene.selectedItems()
-        if len(selected_items) < 2:
-            self.setSelected(True)
         if self.enabled:
             self.editor.map.view.disable_move = True
-            if event.button() == Qt.RightButton:
+            if event.button() == Qt.MouseButton.RightButton:
                 pass
 
-    def mouseReleaseEvent(self, event):
+    def mouseReleaseEvent(self, event: QtWidgets.QGraphicsSceneMouseEvent) -> None:
         """
         Event handler for mouse release events.
         """
         super().mouseReleaseEvent(event)
         self.editor.disableMove = True
-        self.updateDiagram()
-        self.editor.map.view._scene.update()
-
-        selected_items = self.editor.map.view._scene.selectedItems()
-        if len(selected_items) < 2:
-            self.setSelected(True)
+        self.update_position_at_the_diagram()
 
     def hoverEnterEvent(self, event: QtWidgets.QGraphicsSceneHoverEvent) -> None:
         """
         Event handler for when the mouse enters the item.
         """
-        # self.editor.map.view.in_item = True
         self.hovered = True
-        self.setNodeColor(QColor(Qt.red), QColor(Qt.red))
-        QApplication.instance().setOverrideCursor(Qt.PointingHandCursor)
+        self.setNodeColor(QColor(Qt.GlobalColor.red), QColor(Qt.GlobalColor.red))
 
     def hoverLeaveEvent(self, event: QtWidgets.QGraphicsSceneHoverEvent) -> None:
         """
         Event handler for when the mouse leaves the item.
         """
-        # self.editor.map.view.in_item = False
         self.hovered = False
-        self.setDefaultColor()
-        QApplication.instance().restoreOverrideCursor()
+        self.set_default_color()
 
     def contextMenuEvent(self, event: QGraphicsSceneContextMenuEvent):
         """
@@ -219,20 +201,20 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         """
         menu = QMenu()
 
-        add_menu_entry(menu=menu,
-                       text="Merge",
-                       icon_path="",
-                       function_ptr=self.MergeFunction)
-
-        add_menu_entry(menu=menu,
-                       text="Split",
-                       icon_path=":/Icons/icons/divide.svg",
-                       function_ptr=self.SplitFunction)
+        # add_menu_entry(menu=menu,
+        #                text="Merge",
+        #                icon_path="",
+        #                function_ptr=self.MergeFunction)
+        #
+        # add_menu_entry(menu=menu,
+        #                text="Split",
+        #                icon_path=":/Icons/icons/divide.svg",
+        #                function_ptr=self.SplitFunction)
 
         add_menu_entry(menu=menu,
                        text="Delete",
                        icon_path=":/Icons/icons/delete.svg",
-                       function_ptr=self.RemoveFunction)
+                       function_ptr=self.remove)
 
         menu.exec_(event.screenPos())
 
@@ -254,13 +236,13 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         # Implement the functionality for Action 1 here
         pass
 
-    def RemoveFunction(self):
+    def remove(self):
         """
 
         :return:
         """
         # Implement the functionality for Action 1 here
-        self.editor.removeNode(self)
+        self.editor.remove_line_location_graphic(self)
 
     def MergeFunction(self):
         """
@@ -286,7 +268,7 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
             pen.setColor(border_color)
             self.setPen(pen)
 
-    def setDefaultColor(self) -> None:
+    def set_default_color(self) -> None:
         """
 
         :return:
@@ -294,7 +276,7 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
         # Example: color assignment
         self.setNodeColor(self.colorInner, self.colorBorder)
 
-    def getPos(self) -> QPointF:
+    def get_pos(self) -> QPointF:
         """
 
         :return:
@@ -312,7 +294,7 @@ class NodeGraphicItem(QtWidgets.QGraphicsRectItem, NodeTemplate):
 
         :return:
         """
-        self.updateRealPos()
+        self.update_real_pos()
         return self.x, self.y
 
     def resize(self, new_radius: float):

{GridCal-5.1.52 → GridCal-5.1.53}/GridCal/Gui/Diagrams/MapWidget/Branches/map_line_container.py

@@ -16,24 +16,19 @@
 # Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 from __future__ import annotations
 
-# import uuid
 from typing import TYPE_CHECKING, List, Union
 
-import logging
-
 from PySide6.QtCore import Qt
-from PySide6.QtGui import QColor, QPen
+from PySide6.QtGui import QColor
 from GridCal.Gui.Diagrams.MapWidget.Branches.map_line_segment import MapLineSegment
-from GridCalEngine.Devices import LineLocation
-from GridCalEngine.Devices.Diagrams.base_diagram import PointsGroup
+from GridCalEngine.Devices.Branches.line_locations import LineLocation
 from GridCalEngine.Devices.types import BRANCH_TYPES, FluidPath
-from GridCalEngine.Devices.Branches.line import Line
 from GridCalEngine.enumerations import DeviceType
 from GridCal.Gui.Diagrams.generic_graphics import GenericDiagramWidget
 from GridCal.Gui.messages import error_msg
 
 if TYPE_CHECKING:
-    from GridCal.Gui.Diagrams.MapWidget.Substation.node_graphic_item import NodeGraphicItem
+    from GridCal.Gui.Diagrams.MapWidget.Branches.line_location_graphic_item import LineLocationGraphicItem
     from GridCal.Gui.Diagrams.MapWidget.Substation.substation_graphic_item import SubstationGraphicItem
     from GridCal.Gui.Diagrams.MapWidget.Substation.voltage_level_graphic_item import VoltageLevelGraphicItem
     from GridCal.Gui.Diagrams.MapWidget.grid_map_widget import GridMapWidget
@@ -61,20 +56,22 @@ class MapLineContainer(GenericDiagramWidget):
 
         self.editor: GridMapWidget = editor  # reassign to make clear the editor type
 
-        self.nodes_list: List[NodeGraphicItem] = list()
+        self.nodes_list: List[LineLocationGraphicItem] = list()
         self.segments_list: List[MapLineSegment] = list()
         self.enabled = True
         self.original = True  # TODO: Que es esto?
 
-    def set_width_scale(self, val: float):
+    def set_width_scale(self, branch_scale: float, arrow_scale: float):
         """
         Set the width scale of the line
-        :param val:
+        :param branch_scale:
+        :param arrow_scale:
         """
         for segment in self.segments_list:
             # pen = segment.pen()  # get the current pen
             # pen.setWidthF(val * segment.width)  # Set the fractional thickness of the line
-            segment.set_width(val * segment.width)  # Assign the pen to the line item
+            segment.set_width(branch_scale * segment.width)  # Assign the pen to the line item
+            segment.set_arrow_scale(arrow_scale)
 
     def clean_segments(self) -> None:
         """
@@ -108,7 +105,7 @@ class MapLineContainer(GenericDiagramWidget):
         """
         return len(self.nodes_list)
 
-    def register_new_node(self, node: NodeGraphicItem):
+    def register_new_node(self, node: LineLocationGraphicItem):
         """
         Add node
         :param node: NodeGraphicItem
@@ -126,7 +123,6 @@ class MapLineContainer(GenericDiagramWidget):
         """
         Set color and style
         :param color: QColor instance
-        :param w: width
         :param style: PenStyle instance
         :param tool_tip: tool tip text
         :return:
@@ -159,20 +155,29 @@ class MapLineContainer(GenericDiagramWidget):
         """
         self.clean()
 
+        # get the diagram line locations
+        line_locs_info = self.editor.diagram.query_by_type(device_type=DeviceType.LineLocation)
+
         # draw line locations
         for elm in self.api_object.locations.data:
-            graphic_obj = self.editor.create_node(line_container=self,
-                                                  api_object=elm,
-                                                  lat=elm.lat,  # 42.0 ...
-                                                  lon=elm.long,
-                                                  index=self.number_of_nodes())  # 2.7 ...
+
+            if line_locs_info is not None:
+                loc_data = line_locs_info.locations.get(elm.idtag, None)
+            else:
+                loc_data = None
+
+            graphic_obj = self.editor.create_line_location_graphic(line_container=self,
+                                                                   api_object=elm,
+                                                                   lat=elm.lat if loc_data is None else loc_data.latitude,
+                                                                   lon=elm.long if loc_data is None else loc_data.longitude,
+                                                                   index=self.number_of_nodes())  # 2.7 ...
 
             self.register_new_node(node=graphic_obj)
 
         # second pass: create the segments
         self.redraw_segments()
 
-    def removeNode(self, node: NodeGraphicItem):
+    def removeNode(self, node: LineLocationGraphicItem):
         """
 
         :param node:
@@ -198,7 +203,8 @@ class MapLineContainer(GenericDiagramWidget):
         """
         self.clean_segments()
 
-        connection_elements: List[Union[NodeGraphicItem, SubstationGraphicItem, VoltageLevelGraphicItem]] = list()
+        connection_elements: List[
+            Union[LineLocationGraphicItem, SubstationGraphicItem, VoltageLevelGraphicItem]] = list()
 
         # add the substation from
         substation_from_graphics = self.editor.graphics_manager.query(elm=self.api_object.get_substation_from())
@@ -240,9 +246,17 @@ class MapLineContainer(GenericDiagramWidget):
         self.editor.update_device_sizes()
 
     def substation_to(self):
+        """
+
+        :return:
+        """
         return self.editor.graphics_manager.query(elm=self.api_object.get_substation_to())
 
     def substation_from(self):
+        """
+
+        :return:
+        """
         return self.editor.graphics_manager.query(elm=self.api_object.get_substation_from())
 
     def insert_new_node_at_position(self, index: int):
@@ -276,11 +290,11 @@ class MapLineContainer(GenericDiagramWidget):
 
             # Create a new graphical node item
 
-            graphic_obj = self.editor.create_node(line_container=self,
-                                                  api_object=new_api_object,
-                                                  lat=new_api_object.lat,
-                                                  lon=new_api_object.long,
-                                                  index=index)
+            graphic_obj = self.editor.create_line_location_graphic(line_container=self,
+                                                                   api_object=new_api_object,
+                                                                   lat=new_api_object.lat,
+                                                                   lon=new_api_object.long,
+                                                                   index=index)
 
             idx = 0
 
@@ -294,7 +308,7 @@ class MapLineContainer(GenericDiagramWidget):
             # Add the node to the nodes list
             self.nodes_list.insert(index, graphic_obj)
 
-            graphic_obj.updatePosition()
+            graphic_obj.update_position()
 
             # Update connectors if necessary
             self.redraw_segments()
@@ -325,16 +339,16 @@ class MapLineContainer(GenericDiagramWidget):
 
             # Create a new graphical node item
 
-            graphic_obj = self.editor.create_node(line_container=self,
-                                                  api_object=new_api_object,
-                                                  lat=new_api_object.lat,
-                                                  lon=new_api_object.long,
-                                                  index=0)
+            graphic_obj = self.editor.create_line_location_graphic(line_container=self,
+                                                                   api_object=new_api_object,
+                                                                   lat=new_api_object.lat,
+                                                                   lon=new_api_object.long,
+                                                                   index=0)
 
             # Add the node to the nodes list
             self.nodes_list.insert(0, graphic_obj)
 
-            graphic_obj.updatePosition()
+            graphic_obj.update_position()
 
             # Update connectors if necessary
             self.redraw_segments()
@@ -342,7 +356,7 @@ class MapLineContainer(GenericDiagramWidget):
             # Return the newly created node
             return graphic_obj
 
-        elif (0 == index or index >= len(self.api_object.locations.data) - 1):
+        elif 0 == index or index >= len(self.api_object.locations.data) - 1:
 
             substation_from_graphics = self.editor.graphics_manager.query(elm=self.api_object.get_substation_from())
             substation_to_graphics = self.editor.graphics_manager.query(elm=self.api_object.get_substation_to())
@@ -371,11 +385,11 @@ class MapLineContainer(GenericDiagramWidget):
 
             # Create a new graphical node item
 
-            graphic_obj = self.editor.create_node(line_container=self,
-                                                  api_object=new_api_object,
-                                                  lat=new_api_object.lat,
-                                                  lon=new_api_object.long,
-                                                  index=index)
+            graphic_obj = self.editor.create_line_location_graphic(line_container=self,
+                                                                   api_object=new_api_object,
+                                                                   lat=new_api_object.lat,
+                                                                   lon=new_api_object.long,
+                                                                   index=index)
 
             idx = 0
 
@@ -389,7 +403,7 @@ class MapLineContainer(GenericDiagramWidget):
             # Add the node to the nodes list
             self.nodes_list.insert(index, graphic_obj)
 
-            graphic_obj.updatePosition()
+            graphic_obj.update_position()
 
             # Update connectors if necessary
             self.redraw_segments()
@@ -397,11 +411,9 @@ class MapLineContainer(GenericDiagramWidget):
             # Return the newly created node
             return graphic_obj
 
-        else:
-
-            logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(levelname)s - %(message)s')
-
-            logging.info("Invalid node index")
+        # else:
+        #     logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(levelname)s - %(message)s')
+        #     logging.info("Invalid node index")
 
     def split_Line(self, index):
         """
@@ -440,8 +452,8 @@ class MapLineContainer(GenericDiagramWidget):
             ln1.bus_from = self.api_object.bus_from
             ln2.bus_to = self.api_object.bus_to
 
-            l1 = self.editor.add_api_line(ln1, original=False)
-            l2 = self.editor.add_api_line(ln2, original=False)
+            # l1 = self.editor.add_api_line(ln1, original=False)
+            # l2 = self.editor.add_api_line(ln2, original=False)
 
             self.disable_line()
 

{GridCal-5.1.52 → GridCal-5.1.53}/GridCal/Gui/Diagrams/MapWidget/Branches/map_line_segment.py

@@ -28,10 +28,9 @@ from GridCal.Gui.Diagrams.generic_graphics import ACTIVE, DEACTIVATED, OTHER
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.line_editor import LineEditor
 
 from GridCalEngine.Devices.types import BRANCH_TYPES
-from GridCalEngine.enumerations import DeviceType
 
 if TYPE_CHECKING:
-    from GridCal.Gui.Diagrams.MapWidget.Substation.node_graphic_item import NodeGraphicItem
+    from GridCal.Gui.Diagrams.MapWidget.Branches.line_location_graphic_item import LineLocationGraphicItem
     from GridCal.Gui.Diagrams.MapWidget.Branches.map_line_container import MapLineContainer
     from GridCal.Gui.Diagrams.MapWidget.grid_map_widget import GridMapWidget
 
@@ -41,15 +40,15 @@ class MapLineSegment(QGraphicsLineItem):
     Segment joining two NodeGraphicItem
     """
 
-    def __init__(self, first: NodeGraphicItem, second: NodeGraphicItem, container: MapLineContainer):
+    def __init__(self, first: LineLocationGraphicItem, second: LineLocationGraphicItem, container: MapLineContainer):
         """
         Segment constructor
         :param first: NodeGraphicItem
         :param second: NodeGraphicItem
         """
         QGraphicsLineItem.__init__(self)
-        self.first: NodeGraphicItem = first
-        self.second: NodeGraphicItem = second
+        self.first: LineLocationGraphicItem = first
+        self.second: LineLocationGraphicItem = second
         self.container: MapLineContainer = container
         self.draw_labels = True
 
@@ -110,16 +109,21 @@ class MapLineSegment(QGraphicsLineItem):
         pen.setWidthF(width)
         self.setPen(pen)
 
-        self.arrow_p_from.label.setScale(width)
-        self.arrow_q_from.label.setScale(width)
-        self.arrow_p_to.label.setScale(width)
-        self.arrow_q_to.label.setScale(width)
+    def set_arrow_scale(self, width: float):
+        """
+
+        :param width:
+        :return:
+        """
+        self.arrow_p_from.setScale(width)
+        self.arrow_q_from.setScale(width)
+        self.arrow_p_to.setScale(width)
+        self.arrow_q_to.setScale(width)
 
     def set_colour(self, color: QColor, style: Qt.PenStyle):
         """
         Set color and style
         :param color: QColor instance
-        :param w: width
         :param style: PenStyle instance
         :return:
         """
@@ -229,14 +233,14 @@ class MapLineSegment(QGraphicsLineItem):
                        icon_path=":/Icons/icons/assign_to_profile.svg")
 
         add_menu_entry(menu=menu,
-                       text="Split line",
-                       function_ptr=self.split_line,
-                       icon_path=":/Icons/icons/divide.svg")
+                       text="Add point",
+                       function_ptr=self.add_path_node,
+                       icon_path=":/Icons/icons/cn_icon.svg")
 
-        add_menu_entry(menu=menu,
-                       text="Split line with in/out",
-                       function_ptr=self.split_line_in_out,
-                       icon_path=":/Icons/icons/divide.svg")
+        # add_menu_entry(menu=menu,
+        #                text="Add substation here",
+        #                function_ptr=self.add_substation_here,
+        #                icon_path=":/Icons/icons/substation.svg")
 
         menu.addSeparator()
 
@@ -313,8 +317,7 @@ class MapLineSegment(QGraphicsLineItem):
         current_template = self.api_object.template
         dlg = LineEditor(line=self.api_object, Sbase=Sbase, frequency=self.editor.circuit.fBase,
                          templates=templates, current_template=current_template)
-        if dlg.exec_():
-            pass
+        dlg.exec()
 
     def plot_profiles(self) -> None:
         """
@@ -337,14 +340,14 @@ class MapLineSegment(QGraphicsLineItem):
         """
         self.editor.set_active_status_to_profile(self.api_object)
 
-    def split_line(self):
+    def add_path_node(self):
         """
-
-        :return:
+        Add a path to the container by adding a new graphical segment
         """
 
         if len(self.container.nodes_list) == 0:
             self.container.insert_new_node_at_position(0)
+
         elif len(self.container.nodes_list) == 1:
             if self.second == self.container.substation_to() or self.first == self.container.substation_to():
                 self.container.insert_new_node_at_position(1)
@@ -353,24 +356,26 @@ class MapLineSegment(QGraphicsLineItem):
         else:
             if self.second == self.container.substation_to() or self.first == self.container.substation_to():
                 self.container.insert_new_node_at_position(len(self.container.nodes_list))
+
             elif self.second == self.container.substation_from() or self.first == self.container.substation_from():
                 self.container.insert_new_node_at_position(0)
+
             else:
                 if self.first.index > self.second.index:
                     self.container.insert_new_node_at_position(self.second.index)
+
                 elif self.first.index < self.second.index:
                     self.container.insert_new_node_at_position(self.second.index)
 
-        # TODO implement
-        # self.editor.split_line(line_graphics=self)
-        pass
-
-    def split_line_in_out(self):
+    def add_substation_here(self):
         """
         Split the line
         :return:
         """
-        # TODO implement
+        # TODO implement:
+        # The container of this segment must be split into two new containers
+        # and in the middle, we need to create a substation object
+
         # self.editor.split_line_in_out(line_graphics=self)
         pass