GridCal 5.1.49__tar.gz → 5.1.51__tar.gz

{GridCal-5.1.49 → GridCal-5.1.51}/GridCal/Gui/Diagrams/MapWidget/grid_map_widget.py

@@ -30,6 +30,7 @@ from PySide6.QtCore import (Qt, QSize, QRect, QMimeData, QIODevice, QByteArray,
 from PySide6.QtGui import (QIcon, QPixmap, QImage, QPainter, QStandardItemModel, QStandardItem, QColor,
                            QDropEvent, QWheelEvent)
 
+from GridCal.Gui.SubstationDesigner.substation_designer import SubstationDesigner
 from GridCalEngine.Devices.Diagrams.map_location import MapLocation
 from GridCalEngine.Devices.Substation import Bus
 from GridCalEngine.Devices.Branches.line import Line
@@ -857,15 +858,46 @@ class GridMapWidget(BaseDiagramWidget):
             y0 = point0.y()
             lat, lon = self.to_lat_lon(x=x0, y=y0)
 
-            # print(f"Dropped at x:{x0}, y:{y0}, lat:{lat}, lon:{lon}")
-
             if obj_type == self.library_model.get_substation_mime_data():
-                api_object = Substation(name=f"Substation {self.circuit.get_substation_number()}",
-                                        latitude=lat,
-                                        longitude=lon)
-                self.circuit.add_substation(obj=api_object)
-                substation_graphics = self.add_api_substation(api_object=api_object, lat=lat, lon=lon)
-                substation_graphics.add_voltage_level()
+                self.create_substation_with_dialogue(lat=lat, lon=lon)
+
+    def create_substation_with_dialogue(self, lat, lon):
+        """
+        Create a substation using the dialogue
+        :param lat:
+        :param lon:
+        :return:
+        """
+        kv = self.gui.get_default_voltage()
+        dlg = SubstationDesigner(grid=self.circuit, default_voltage=kv)
+        dlg.exec()
+        if dlg.was_ok():
+
+            # create the SE
+            se_object = Substation(name=dlg.get_name(), latitude=lat, longitude=lon)
+
+            self.circuit.add_substation(obj=se_object)
+            substation_graphics = self.add_api_substation(api_object=se_object, lat=lat, lon=lon)
+
+            for vl_template in dlg.get_voltage_levels():
+
+                # substation_graphics.add_voltage_level()
+                vl = VoltageLevel(name=f"{se_object.name} @{kv}KV VL",
+                                  Vnom=vl_template.voltage,
+                                  substation=se_object)
+                self.circuit.add_voltage_level(vl)
+
+                bus = Bus(name=f"{se_object.name} @{kv}KV bus",
+                          Vnom=vl_template.voltage,
+                          substation=se_object,
+                          voltage_level=vl)
+                self.circuit.add_bus(obj=bus)
+
+                # add the vl graphics
+                self.add_api_voltage_level(substation_graphics=substation_graphics, api_object=vl)
+
+            # sort voltage levels
+            substation_graphics.sort_voltage_levels()
 
     def wheelEvent(self, event: QWheelEvent):
         """
@@ -874,12 +906,12 @@ class GridMapWidget(BaseDiagramWidget):
         :return:
         """
 
-        # SANTIAGO: NO TOCAR ESTO ES EL COMPORTAMIENTO DESEADO
+        # SANTIAGO: DO NOT TOUCH, THIS IS THE DESIRED BEHAVIOUR
         self.update_device_sizes()
 
-    def get_branch_width(self):
+    def get_branch_width(self) -> float:
         """
-
+        Get the desired branch width
         :return:
         """
         max_zoom = self.map.max_level
@@ -888,9 +920,9 @@ class GridMapWidget(BaseDiagramWidget):
         scale = self.diagram.min_branch_width + (zoom - min_zoom) / (max_zoom - min_zoom)
         return scale
 
-    def update_device_sizes(self):
+    def update_device_sizes(self) -> None:
         """
-
+        Updat ethe devices' sizes
         :return:
         """
 

{GridCal-5.1.49 → GridCal-5.1.51}/GridCal/Gui/Diagrams/MapWidget/map_widget.py

@@ -469,12 +469,12 @@ class MapWidget(QWidget):
         self.view_tlat = 0
 
         # some cursors
-        self.standard_cursor = QCursor(Qt.ArrowCursor)
-        self.box_select_cursor = QCursor(Qt.CrossCursor)
-        self.wait_cursor = QCursor(Qt.WaitCursor)
-        self.drag_cursor = QCursor(Qt.OpenHandCursor)
+        self.standard_cursor = QCursor(Qt.CursorShape.ArrowCursor)
+        self.box_select_cursor = QCursor(Qt.CursorShape.CrossCursor)
+        self.wait_cursor = QCursor(Qt.CursorShape.WaitCursor)
+        self.drag_cursor = QCursor(Qt.CursorShape.OpenHandCursor)
 
-        self.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Expanding)
+        self.setSizePolicy(QSizePolicy.Policy.Expanding, QSizePolicy.Policy.Expanding)
         self.setMinimumSize(self.tile_width, self.tile_height)
 
         self.setMouseTracking(True)
@@ -672,9 +672,9 @@ class MapWidget(QWidget):
         self.setCursor(self.default_cursor)
 
         b = event.button()
-        if b == Qt.NoButton:
+        if b == Qt.MouseButton.NoButton:
             pass
-        elif b == Qt.LeftButton:
+        elif b == Qt.MouseButton.LeftButton:
             self.left_mbutton_down = False
 
             if self.start_drag_x is None:
@@ -688,10 +688,10 @@ class MapWidget(QWidget):
             longitude, latitude = self.view_to_geo(x, y)
             self.position_callback(latitude, longitude, x, y)
 
-        elif b == Qt.MidButton:
+        elif b == Qt.MouseButton.MiddleButton:
             self.mid_mbutton_down = False
 
-        elif b == Qt.RightButton:
+        elif b == Qt.MouseButton.RightButton:
             self.right_mbutton_down = False
 
         else:
@@ -705,13 +705,13 @@ class MapWidget(QWidget):
         :return:
         """
         b = event.button()
-        if b == Qt.NoButton:
+        if b == Qt.MouseButton.NoButton:
             pass
-        elif b == Qt.LeftButton:
+        elif b == Qt.MouseButton.LeftButton:
             pass
-        elif b == Qt.MidButton:
+        elif b == Qt.MouseButton.MiddleButton:
             pass
-        elif b == Qt.RightButton:
+        elif b == Qt.MouseButton.RightButton:
             pass
         else:
             pass
@@ -781,7 +781,7 @@ class MapWidget(QWidget):
     def keyPressEvent(self, event: QKeyEvent):
         """Capture a key press."""
 
-        if event.key() == Qt.Key_Shift:
+        if event.key() == Qt.Key.Key_Shift:
             self.shift_down = True
             self.default_cursor = self.box_select_cursor
             self.setCursor(self.default_cursor)
@@ -792,7 +792,7 @@ class MapWidget(QWidget):
         """Capture a key release."""
 
         key = event.key()
-        if event.key() == Qt.Key_Shift:
+        if event.key() == Qt.Key.Key_Shift:
             self.shift_down = False
             self.default_cursor = self.standard_cursor
             self.setCursor(self.default_cursor)

{GridCal-5.1.49 → GridCal-5.1.51}/GridCal/Gui/Diagrams/SchematicWidget/Branches/line_editor.py

@@ -58,7 +58,7 @@ class LineEditor(QDialog):
 
         self.setObjectName("self")
 
-        self.setContextMenuPolicy(Qt.NoContextMenu)
+        self.setContextMenuPolicy(Qt.ContextMenuPolicy.NoContextMenu)
 
         self.layout = QVBoxLayout(self)
 
@@ -84,10 +84,10 @@ class LineEditor(QDialog):
         if length == 0:
             length = 1.0
 
-        R = self.line.R * Zbase / length
-        X = self.line.X * Zbase / length
-        B = self.line.B * Ybase / length
-        I = np.round(self.line.rate / (Vf * 1.73205080757), 6)  # current in KA
+        r_ohm = self.line.R * Zbase / length
+        x_ohm = self.line.X * Zbase / length
+        b_us = self.line.B * Ybase / length * 1e6
+        I_KA = np.round(self.line.rate / (Vf * 1.73205080757), 6)  # current in KA
 
         # ------------------------------------------------------------------------------------------
 
@@ -103,22 +103,22 @@ class LineEditor(QDialog):
                         self.catalogue_combo.setCurrentIndex(idx)
 
                         if isinstance(self.current_template, SequenceLineType):
-                            I = self.current_template.Imax
-                            R = self.current_template.R
-                            X = self.current_template.X
-                            B = self.current_template.B
+                            I_KA = self.current_template.Imax
+                            r_ohm = self.current_template.R
+                            x_ohm = self.current_template.X
+                            b_us = self.current_template.B
 
                         if isinstance(self.current_template, UndergroundLineType):
-                            I = self.current_template.Imax
-                            R = self.current_template.R
-                            X = self.current_template.X
-                            B = self.current_template.B
+                            I_KA = self.current_template.Imax
+                            r_ohm = self.current_template.R
+                            x_ohm = self.current_template.X
+                            b_us = self.current_template.B
 
                         elif isinstance(self.current_template, OverheadLineType):
-                            I = self.current_template.Imax
-                            R = self.current_template.R1
-                            X = self.current_template.X1
-                            B = self.current_template.Bsh1
+                            I_KA = self.current_template.Imax
+                            r_ohm = self.current_template.R1
+                            x_ohm = self.current_template.X1
+                            b_us = self.current_template.Bsh1
 
                     except:
                         pass
@@ -141,7 +141,7 @@ class LineEditor(QDialog):
         self.i_spinner.setMinimum(0)
         self.i_spinner.setMaximum(9999999)
         self.i_spinner.setDecimals(2)
-        self.i_spinner.setValue(I)
+        self.i_spinner.setValue(I_KA)
         self.i_spinner.setSuffix(' KA')
 
         # R
@@ -149,7 +149,7 @@ class LineEditor(QDialog):
         self.r_spinner.setMinimum(0)
         self.r_spinner.setMaximum(9999999)
         self.r_spinner.setDecimals(6)
-        self.r_spinner.setValue(R)
+        self.r_spinner.setValue(r_ohm)
         self.r_spinner.setSuffix(' Ω/Km')
 
         # X
@@ -157,7 +157,7 @@ class LineEditor(QDialog):
         self.x_spinner.setMinimum(0)
         self.x_spinner.setMaximum(9999999)
         self.x_spinner.setDecimals(6)
-        self.x_spinner.setValue(X)
+        self.x_spinner.setValue(x_ohm)
         self.x_spinner.setSuffix(' Ω/Km')
 
         # B
@@ -165,7 +165,7 @@ class LineEditor(QDialog):
         self.b_spinner.setMinimum(0)
         self.b_spinner.setMaximum(9999999)
         self.b_spinner.setDecimals(6)
-        self.b_spinner.setValue(B)
+        self.b_spinner.setValue(b_us)
         self.b_spinner.setSuffix(" uS/Km")
 
         # apply to profile
@@ -209,29 +209,36 @@ class LineEditor(QDialog):
 
         self.setWindowTitle('Line editor')
 
-    def accept_click(self):
+    def accept_click(self) -> None:
         """
         Set the values
         :return:
         """
 
-        if self.selected_template is not None:
-            self.line.length = self.l_spinner.value()
-            self.line.apply_template(self.selected_template, Sbase=self.Sbase)
+        length = self.l_spinner.value()
+
+        if length != 0.0:
+
+            if self.selected_template is not None:
+                self.line.set_length(val=length, update_electrical_values=False)
+                self.line.apply_template(obj=self.selected_template, Sbase=self.Sbase)
+
+            else:
+                wf = 2 * np.pi * self.frequency
+                self.line.fill_design_properties(
+                    r_ohm=self.r_spinner.value(),  # ohm / km
+                    x_ohm=self.x_spinner.value(),  # ohm / km
+                    c_nf=self.b_spinner.value() * 1e3 / wf,  # nF / km
+                    length=length,  # km
+                    Imax=self.i_spinner.value(),  # KA
+                    freq=self.frequency,  # Hz
+                    Sbase=self.Sbase,  # MVA
+                    apply_to_profile=self.apply_to_profile.isChecked()
+                )
+
+            self.accept()
         else:
-            wf = 2 * np.pi * self.frequency
-            self.line.fill_design_properties(
-                r_ohm=self.r_spinner.value(),  # ohm / km
-                x_ohm=self.x_spinner.value(),  # ohm / km
-                c_nf=self.b_spinner.value() * 1e3 / wf,  # nF / km
-                length=self.l_spinner.value(),  # km
-                Imax=self.i_spinner.value(),  # KA
-                freq=self.frequency,  # Hz
-                Sbase=self.Sbase,  # MVA
-                apply_to_profile=self.apply_to_profile.isChecked()
-            )
-
-        self.accept()
+            error_msg(text="The length cannot be 0!", title="Accept line design values")
 
     def load_template(self, template: Union[SequenceLineType, OverheadLineType, UndergroundLineType]):
         """

{GridCal-5.1.49 → GridCal-5.1.51}/GridCal/Gui/Diagrams/SchematicWidget/Branches/transformer2w_graphics.py

@@ -181,7 +181,7 @@ class TransformerGraphicItem(LineGraphicTemplateItem):
                                 modify_on_accept=True,
                                 templates=templates,
                                 current_template=current_template)
-        if dlg.exec_():
+        if dlg.exec():
             pass
 
     def edit_tap_changer(self):
@@ -191,7 +191,7 @@ class TransformerGraphicItem(LineGraphicTemplateItem):
         """
 
         dlg = TransformerTapsEditor(api_object=self.api_object.tap_changer)
-        if dlg.exec_():
+        if dlg.exec():
             pass
 
     def show_transformer_editor(self):

GridCal-5.1.51/GridCal/Gui/Diagrams/SchematicWidget/Branches/transformer3w_editor.py

@@ -0,0 +1,211 @@
+# GridCal
+# Copyright (C) 2015 - 2024 Santiago Peñate Vera
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 3 of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program; if not, write to the Free Software Foundation,
+# Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+from PySide6.QtCore import Qt
+from PySide6.QtWidgets import QPushButton, QVBoxLayout, QHBoxLayout, QDialog, QLabel, QFrame
+from GridCal.Gui.gui_functions import create_spinbox
+from GridCal.ThirdParty.qdarktheme.qtpy.QtWidgets import QApplication
+from GridCalEngine.Devices.Branches.transformer3w import Transformer3W
+from GridCalEngine.Devices.Substation.bus import Bus
+
+
+class WindingWidget(QFrame):
+    """
+    Widget to package the winding editor logic
+    """
+
+    def __init__(self, i: int, V: float, Sn: float, Pcu: float, Vsc: float, bus_to: Bus, Sbase: float):
+        """
+
+        :param i:
+        :param V:
+        :param Sn:
+        :param Pcu:
+        :param Vsc:
+        :param bus_to:
+        :param Sbase:
+        """
+        QFrame.__init__(self)
+
+        self.i = i
+
+        self.Sbase = Sbase
+
+        self.layout = QVBoxLayout(self)
+
+        # Vn
+        self.vn_spinner = create_spinbox(value=V, minimum=0, maximum=999999, decimals=6)
+
+        # Sn
+        self.sn_spinner = create_spinbox(value=Sn, minimum=0, maximum=999999, decimals=6)
+
+        # Pcu
+        self.pcu_spinner = create_spinbox(value=Pcu, minimum=0, maximum=999999, decimals=6)
+
+        # Vsc
+        self.vsc_spinner = create_spinbox(value=Vsc, minimum=0, maximum=999999, decimals=6)
+
+        # add all to the GUI
+        self.layout.addWidget(QLabel(f"Winding {self.i}"))
+
+        v_str = f"{bus_to.Vnom} KV" if bus_to is not None else 'Not connected'
+        self.layout.addWidget(QLabel(f"Bus voltage: {v_str}"))
+
+        if i == 1:
+            wstr = "1-2"
+        elif i == 2:
+            wstr = "2-3"
+        elif i == 3:
+            wstr = "3-1"
+        else:
+            wstr = ""
+
+        # spacer
+        self.layout.addWidget(QLabel(""))
+
+        self.layout.addWidget(QLabel(f"V{i}: Nominal voltage [KV]"))
+        self.layout.addWidget(self.vn_spinner)
+
+        self.layout.addWidget(QLabel(f"Sn{i}: Nominal power [MVA]"))
+        self.layout.addWidget(self.sn_spinner)
+
+        self.layout.addWidget(QLabel(f"Pcu {wstr}: Copper losses [kW]"))
+        self.layout.addWidget(self.pcu_spinner)
+
+        self.layout.addWidget(QLabel(f"Vsc {wstr}: Short circuit voltage [%]"))
+        self.layout.addWidget(self.vsc_spinner)
+
+
+class Transformer3WEditor(QDialog):
+    """
+    TransformerEditor
+    """
+
+    def __init__(self, tr3: Transformer3W, Sbase: float = 100.0, modify_on_accept=True):
+        """
+        Transformer
+        :param tr3:
+        :param Sbase:
+        """
+        super(Transformer3WEditor, self).__init__()
+
+        # keep pointer to the line object
+        self.transformer_obj = tr3
+
+        self.Sbase = Sbase
+
+        self.modify_on_accept = modify_on_accept
+
+        self.selected_template = None
+
+        self.setObjectName("self")
+
+        self.setContextMenuPolicy(Qt.ContextMenuPolicy.NoContextMenu)
+
+        # main vertical layout
+        self.layout = QVBoxLayout(self)
+
+        # windings horizontal layout
+        self.h_layout = QHBoxLayout(self)
+        self.w_frame = QFrame(self)
+        self.w_frame.setLayout(self.h_layout)
+
+        # create the windings frames
+        self.w1 = WindingWidget(1, V=tr3.V1, Sn=tr3.rate1, Pcu=tr3.Pcu12, Vsc=tr3.Vsc12,
+                                bus_to=tr3.bus1, Sbase=self.Sbase)
+
+        self.w2 = WindingWidget(2, V=tr3.V2, Sn=tr3.rate2, Pcu=tr3.Pcu23, Vsc=tr3.Vsc23,
+                                bus_to=tr3.bus2, Sbase=self.Sbase)
+
+        self.w3 = WindingWidget(3, V=tr3.V3, Sn=tr3.rate3, Pcu=tr3.Pcu31, Vsc=tr3.Vsc31,
+                                bus_to=tr3.bus3, Sbase=self.Sbase)
+
+        self.h_layout.addWidget(self.w1)
+        self.h_layout.addWidget(self.w2)
+        self.h_layout.addWidget(self.w3)
+
+        # Pfe
+        self.pfe_spinner = create_spinbox(value=0.0, minimum=0, maximum=999999, decimals=6)
+
+        # I0
+        self.I0_spinner = create_spinbox(value=0.0, minimum=0, maximum=999999, decimals=6)
+
+        # ------------------------------------------------------------------------------------------
+        # Set the object values
+        # ------------------------------------------------------------------------------------------
+
+        # accept button
+        self.accept_btn = QPushButton()
+        self.accept_btn.setText('Accept')
+        self.accept_btn.clicked.connect(self.accept_click)
+
+        self.layout.addWidget(QLabel(f"Name: {tr3.name}"))
+        self.layout.addWidget(QLabel(f""))
+
+        self.layout.addWidget(QLabel("Pfe: Iron losses [kW]"))
+        self.layout.addWidget(self.pfe_spinner)
+
+        self.layout.addWidget(QLabel("I0: No load current [%]"))
+        self.layout.addWidget(self.I0_spinner)
+
+        # compose main layout
+        self.layout.addWidget(self.w_frame)
+
+        self.layout.addWidget(self.accept_btn)
+
+        self.setLayout(self.layout)
+
+        self.setWindowTitle('Transformer editor')
+
+    def accept_click(self):
+        """
+        Create transformer type and get the impedances
+        :return:
+        """
+
+        if self.modify_on_accept:
+            self.transformer_obj.fill_from_design_values(V1=self.w1.vn_spinner.value(),
+                                                         V2=self.w2.vn_spinner.value(),
+                                                         V3=self.w3.vn_spinner.value(),
+                                                         Sn1=self.w1.sn_spinner.value(),
+                                                         Sn2=self.w2.sn_spinner.value(),
+                                                         Sn3=self.w3.sn_spinner.value(),
+                                                         Pcu12=self.w1.pcu_spinner.value(),
+                                                         Pcu23=self.w2.pcu_spinner.value(),
+                                                         Pcu31=self.w3.pcu_spinner.value(),
+                                                         Vsc12=self.w1.vsc_spinner.value(),
+                                                         Vsc23=self.w2.vsc_spinner.value(),
+                                                         Vsc31=self.w3.vsc_spinner.value(),
+                                                         Pfe=self.pfe_spinner.value(),
+                                                         I0=self.I0_spinner.value(),
+                                                         Sbase=self.Sbase)
+
+        self.accept()
+
+
+if __name__ == '__main__':
+    import sys
+    from GridCalEngine.Devices.Substation.bus import Bus
+
+    app = QApplication(sys.argv)
+
+    b1 = Bus()
+    b2 = Bus()
+    b3 = Bus()
+    tr3 = Transformer3W(bus1=b1, bus2=b2, bus3=b3)
+    editor = Transformer3WEditor(tr3, 100.0)
+    editor.exec()

{GridCal-5.1.49 → GridCal-5.1.51}/GridCal/Gui/Diagrams/SchematicWidget/Branches/transformer3w_graphics.py

@@ -21,13 +21,17 @@ from PySide6.QtCore import Qt, QPoint
 from PySide6.QtGui import QPen, QCursor, QColor, QIcon, QPixmap
 from PySide6.QtWidgets import QGraphicsItem, QGraphicsEllipseItem, QGraphicsRectItem, QMenu, QGraphicsSceneMouseEvent
 
-from GridCalEngine.Devices.Branches.transformer3w import Transformer3W
+from GridCal.Gui.Diagrams.SchematicWidget.Branches.transformer3w_editor import Transformer3WEditor
 from GridCal.Gui.Diagrams.generic_graphics import ACTIVE, DEACTIVATED
 from GridCal.Gui.Diagrams.SchematicWidget.terminal_item import RoundTerminalItem
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.winding_graphics import WindingGraphicItem
 from GridCal.Gui.messages import yes_no_question
+from GridCalEngine.Devices.Branches.transformer3w import Transformer3W
+from GridCalEngine.enumerations import DeviceType
+from GridCal.Gui.gui_functions import add_menu_entry
 
-if TYPE_CHECKING:  # Only imports the below statements during type checking
+if TYPE_CHECKING:
+    # Only imports the below statements during type checking
     from GridCal.Gui.Diagrams.SchematicWidget.schematic_widget import SchematicWidget
 
 
@@ -84,11 +88,11 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
             self.color = ACTIVE['color']
             self.style = ACTIVE['style']
 
-        self.setPen(QPen(Qt.transparent, self.pen_width, self.style))
-        self.setBrush(Qt.transparent)
+        self.setPen(QPen(Qt.GlobalColor.transparent, self.pen_width, self.style))
+        self.setBrush(Qt.GlobalColor.transparent)
         self.setFlag(QGraphicsItem.GraphicsItemFlag.ItemIsMovable)
         self.setFlag(QGraphicsItem.GraphicsItemFlag.ItemIsSelectable)
-        self.setCursor(QCursor(Qt.PointingHandCursor))
+        self.setCursor(QCursor(Qt.CursorShape.PointingHandCursor))
 
         # index
         self.index = index
@@ -159,9 +163,11 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
         for i in range(self.n_windings):
             self.winding_circles[i].setPen(pen)
             self.terminals[i].setPen(pen)
-            self.connection_lines[i].recolour_mode()
 
-    def set_winding_tool_tips(self):
+            if self.connection_lines[i] is not None:
+                self.connection_lines[i].recolour_mode()
+
+    def set_winding_tool_tips(self) -> None:
         """
         Set
         :return:
@@ -170,7 +176,6 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
             self.winding_circles[0].setToolTip("Winding 1: {0} KV".format(self.api_object.V1))
             self.winding_circles[1].setToolTip("Winding 2: {0} KV".format(self.api_object.V2))
             self.winding_circles[2].setToolTip("Winding 3: {0} KV".format(self.api_object.V3))
-        pass
 
     def set_label(self, val: str):
         """
@@ -208,6 +213,18 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
         if self.api_object is not None:
             self.editor.set_editor_model(api_object=self.api_object)
 
+    def mouseDoubleClickEvent(self, event):
+        """
+        On double click, edit
+        :param event:
+        :return:
+        """
+
+        if self.api_object is not None:
+            if self.api_object.device_type in [DeviceType.Transformer3WDevice]:
+                # trigger the editor
+                self.edit()
+
     def contextMenuEvent(self, event):
         """
         Show context menu
@@ -220,17 +237,21 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
 
             # menu.addSeparator()
 
-            ra2 = menu.addAction('Delete')
-            del_icon = QIcon()
-            del_icon.addPixmap(QPixmap(":/Icons/icons/delete3.svg"))
-            ra2.setIcon(del_icon)
-            ra2.triggered.connect(self.remove)
+            add_menu_entry(menu=menu,
+                           text="Edit",
+                           function_ptr=self.edit,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            add_menu_entry(menu=menu,
+                           text="Delete",
+                           function_ptr=self.remove,
+                           icon_path=":/Icons/icons/delete3.svg")
 
             menu.exec_(event.screenPos())
         else:
             pass
 
-    def add_big_marker(self, color=Qt.red, tool_tip_text=""):
+    def add_big_marker(self, color=Qt.GlobalColor.red, tool_tip_text=""):
         """
         Add a big marker to the bus
         :param color: Qt Color ot the marker
@@ -350,21 +371,21 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
             self.api_object.bus1 = None
             self.api_object.V1 = 0
             self.connection_lines[0] = None
-            self.api_object.winding1 = None
+            self.api_object.winding1.bus_to = None
             self.terminals[0].setZValue(-1)
 
         elif i == 1:
             self.api_object.bus2 = None
             self.api_object.V2 = 0
             self.connection_lines[1] = None
-            self.api_object.winding2 = None
+            self.api_object.winding2.bus_to = None
             self.terminals[1].setZValue(-1)
 
         elif i == 2:
             self.api_object.bus3 = None
             self.api_object.V3 = 0
             self.connection_lines[2] = None
-            self.api_object.winding3 = None
+            self.api_object.winding3.bus_to = None
             self.terminals[2].setZValue(-1)
         else:
             raise Exception('Unsupported winding index {}'.format(i))
@@ -417,3 +438,13 @@ class Transformer3WGraphicItem(QGraphicsRectItem):
         if ok:
             self.delete_all_connections()
             self.editor.remove_element(device=self.api_object, graphic_object=self)
+
+    def edit(self):
+        """
+        Open the appropriate editor dialogue
+        :return:
+        """
+        Sbase = self.editor.circuit.Sbase
+        dlg = Transformer3WEditor(self.api_object, Sbase, modify_on_accept=True)
+        if dlg.exec():
+            pass